Re: Review Request 60844: Support migration of LDAP users & groups to PAM
> On July 13, 2017, 4:55 p.m., Tuong wrote: > > Juanjo and I combed thru the codes and did not see any red flag. We did > > not know the group creation codes was pushed into trunk a while back and > > got confused a bit ;)). Thanks for the review. Most of the code was taken from the IOP project... I added a few things and tidied up a bit. - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180474 --- On July 13, 2017, 12:03 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60844/ > --- > > (Updated July 13, 2017, 12:03 p.m.) > > > Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, > Di Li, Eugene Chekanskiy, Juanjo Marron, Laszlo Puskas, Sebastian Toader, > and Tuong. > > > Bugs: AMBARI-19038 > https://issues.apache.org/jira/browse/AMBARI-19038 > > > Repository: ambari > > > Description > --- > > After PAM has been declared as the authentication mechanism for Ambari > clients (for example, the Ambari Server web-based UI) where previously the > mechanism was LDAP, a migration process is needed to converts the LDAP users > and groups to PAM users and groups. > > This facility may be invoked using: > > ``` > ambari-server migrate-ldap-pam > ``` > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > c61e71cc33 > ambari-server/pom.xml b1179a4847 > ambari-server/sbin/ambari-server cc1c923a43 > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 83edccc04b > ambari-server/src/main/python/ambari-server.py 71459fb2d3 > ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 > ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc > > > Diff: https://reviews.apache.org/r/60844/diff/1/ > > > Testing > --- > > Manually tested > > > Thanks, > > Robert Levas > >
Re: Review Request 60844: Support migration of LDAP users & groups to PAM
> On July 13, 2017, 4:52 p.m., Juanjo Marron wrote: > > > > Juanjo Marron wrote: > Ship it! > > Juanjo Marron wrote: > Reviewd with Tuong Truong. > This is similar to the logic we were supporting in IOP for LDAP to PAM > migration. > > Thanks for working on it Thanks for the review. Most of the code was taken from the IOP project... I added a few things and tidied up a bit. - Robert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180470 --- On July 13, 2017, 12:03 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60844/ > --- > > (Updated July 13, 2017, 12:03 p.m.) > > > Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, > Di Li, Eugene Chekanskiy, Juanjo Marron, Laszlo Puskas, Sebastian Toader, > and Tuong. > > > Bugs: AMBARI-19038 > https://issues.apache.org/jira/browse/AMBARI-19038 > > > Repository: ambari > > > Description > --- > > After PAM has been declared as the authentication mechanism for Ambari > clients (for example, the Ambari Server web-based UI) where previously the > mechanism was LDAP, a migration process is needed to converts the LDAP users > and groups to PAM users and groups. > > This facility may be invoked using: > > ``` > ambari-server migrate-ldap-pam > ``` > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > c61e71cc33 > ambari-server/pom.xml b1179a4847 > ambari-server/sbin/ambari-server cc1c923a43 > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 83edccc04b > ambari-server/src/main/python/ambari-server.py 71459fb2d3 > ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 > ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc > > > Diff: https://reviews.apache.org/r/60844/diff/1/ > > > Testing > --- > > Manually tested > > > Thanks, > > Robert Levas > >
Re: Review Request 60844: Support migration of LDAP users & groups to PAM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180474 --- Ship it! Juanjo and I combed thru the codes and did not see any red flag. We did not know the group creation codes was pushed into trunk a while back and got confused a bit ;)). - Tuong On July 13, 2017, 4:03 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60844/ > --- > > (Updated July 13, 2017, 4:03 p.m.) > > > Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, > Di Li, Eugene Chekanskiy, Juanjo Marron, Laszlo Puskas, Sebastian Toader, > and Tuong. > > > Bugs: AMBARI-19038 > https://issues.apache.org/jira/browse/AMBARI-19038 > > > Repository: ambari > > > Description > --- > > After PAM has been declared as the authentication mechanism for Ambari > clients (for example, the Ambari Server web-based UI) where previously the > mechanism was LDAP, a migration process is needed to converts the LDAP users > and groups to PAM users and groups. > > This facility may be invoked using: > > ``` > ambari-server migrate-ldap-pam > ``` > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > c61e71cc33 > ambari-server/pom.xml b1179a4847 > ambari-server/sbin/ambari-server cc1c923a43 > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 83edccc04b > ambari-server/src/main/python/ambari-server.py 71459fb2d3 > ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 > ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc > > > Diff: https://reviews.apache.org/r/60844/diff/1/ > > > Testing > --- > > Manually tested > > > Thanks, > > Robert Levas > >
Re: Review Request 60844: Support migration of LDAP users & groups to PAM
> On July 13, 2017, 8:52 p.m., Juanjo Marron wrote: > > > > Juanjo Marron wrote: > Ship it! Reviewd with Tuong Truong. This is similar to the logic we were supporting in IOP for LDAP to PAM migration. Thanks for working on it - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180470 --- On July 13, 2017, 4:03 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60844/ > --- > > (Updated July 13, 2017, 4:03 p.m.) > > > Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, > Di Li, Eugene Chekanskiy, Juanjo Marron, Laszlo Puskas, Sebastian Toader, > and Tuong. > > > Bugs: AMBARI-19038 > https://issues.apache.org/jira/browse/AMBARI-19038 > > > Repository: ambari > > > Description > --- > > After PAM has been declared as the authentication mechanism for Ambari > clients (for example, the Ambari Server web-based UI) where previously the > mechanism was LDAP, a migration process is needed to converts the LDAP users > and groups to PAM users and groups. > > This facility may be invoked using: > > ``` > ambari-server migrate-ldap-pam > ``` > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > c61e71cc33 > ambari-server/pom.xml b1179a4847 > ambari-server/sbin/ambari-server cc1c923a43 > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 83edccc04b > ambari-server/src/main/python/ambari-server.py 71459fb2d3 > ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 > ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc > > > Diff: https://reviews.apache.org/r/60844/diff/1/ > > > Testing > --- > > Manually tested > > > Thanks, > > Robert Levas > >
Re: Review Request 60844: Support migration of LDAP users & groups to PAM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180473 --- Ship it! Ship It! - Juanjo Marron On July 13, 2017, 4:03 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60844/ > --- > > (Updated July 13, 2017, 4:03 p.m.) > > > Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, > Di Li, Eugene Chekanskiy, Juanjo Marron, Laszlo Puskas, Sebastian Toader, > and Tuong. > > > Bugs: AMBARI-19038 > https://issues.apache.org/jira/browse/AMBARI-19038 > > > Repository: ambari > > > Description > --- > > After PAM has been declared as the authentication mechanism for Ambari > clients (for example, the Ambari Server web-based UI) where previously the > mechanism was LDAP, a migration process is needed to converts the LDAP users > and groups to PAM users and groups. > > This facility may be invoked using: > > ``` > ambari-server migrate-ldap-pam > ``` > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > c61e71cc33 > ambari-server/pom.xml b1179a4847 > ambari-server/sbin/ambari-server cc1c923a43 > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 83edccc04b > ambari-server/src/main/python/ambari-server.py 71459fb2d3 > ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 > ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc > > > Diff: https://reviews.apache.org/r/60844/diff/1/ > > > Testing > --- > > Manually tested > > > Thanks, > > Robert Levas > >
Re: Review Request 60844: Support migration of LDAP users & groups to PAM
> On July 13, 2017, 8:52 p.m., Juanjo Marron wrote: > > Ship it! - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180470 --- On July 13, 2017, 4:03 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60844/ > --- > > (Updated July 13, 2017, 4:03 p.m.) > > > Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, > Di Li, Eugene Chekanskiy, Juanjo Marron, Laszlo Puskas, Sebastian Toader, > and Tuong. > > > Bugs: AMBARI-19038 > https://issues.apache.org/jira/browse/AMBARI-19038 > > > Repository: ambari > > > Description > --- > > After PAM has been declared as the authentication mechanism for Ambari > clients (for example, the Ambari Server web-based UI) where previously the > mechanism was LDAP, a migration process is needed to converts the LDAP users > and groups to PAM users and groups. > > This facility may be invoked using: > > ``` > ambari-server migrate-ldap-pam > ``` > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > c61e71cc33 > ambari-server/pom.xml b1179a4847 > ambari-server/sbin/ambari-server cc1c923a43 > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 83edccc04b > ambari-server/src/main/python/ambari-server.py 71459fb2d3 > ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 > ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc > > > Diff: https://reviews.apache.org/r/60844/diff/1/ > > > Testing > --- > > Manually tested > > > Thanks, > > Robert Levas > >
Re: Review Request 60844: Support migration of LDAP users & groups to PAM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/#review180470 --- - Juanjo Marron On July 13, 2017, 4:03 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60844/ > --- > > (Updated July 13, 2017, 4:03 p.m.) > > > Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, > Di Li, Eugene Chekanskiy, Juanjo Marron, Laszlo Puskas, Sebastian Toader, > and Tuong. > > > Bugs: AMBARI-19038 > https://issues.apache.org/jira/browse/AMBARI-19038 > > > Repository: ambari > > > Description > --- > > After PAM has been declared as the authentication mechanism for Ambari > clients (for example, the Ambari Server web-based UI) where previously the > mechanism was LDAP, a migration process is needed to converts the LDAP users > and groups to PAM users and groups. > > This facility may be invoked using: > > ``` > ambari-server migrate-ldap-pam > ``` > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > c61e71cc33 > ambari-server/pom.xml b1179a4847 > ambari-server/sbin/ambari-server cc1c923a43 > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 83edccc04b > ambari-server/src/main/python/ambari-server.py 71459fb2d3 > ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 > ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc > > > Diff: https://reviews.apache.org/r/60844/diff/1/ > > > Testing > --- > > Manually tested > > > Thanks, > > Robert Levas > >
Review Request 60844: Support migration of LDAP users & groups to PAM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60844/ --- Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, Di Li, Eugene Chekanskiy, Juanjo Marron, Laszlo Puskas, Sebastian Toader, and Tuong. Bugs: AMBARI-19038 https://issues.apache.org/jira/browse/AMBARI-19038 Repository: ambari Description --- After PAM has been declared as the authentication mechanism for Ambari clients (for example, the Ambari Server web-based UI) where previously the mechanism was LDAP, a migration process is needed to converts the LDAP users and groups to PAM users and groups. This facility may be invoked using: ``` ambari-server migrate-ldap-pam ``` Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js c61e71cc33 ambari-server/pom.xml b1179a4847 ambari-server/sbin/ambari-server cc1c923a43 ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java 83edccc04b ambari-server/src/main/python/ambari-server.py 71459fb2d3 ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc Diff: https://reviews.apache.org/r/60844/diff/1/ Testing --- Manually tested Thanks, Robert Levas
