Re: Review Request 60992: Service Checks During Upgrades Should Use Desired Stack

2017-07-19 Thread Sid Wagle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60992/#review181013
---


Ship it!




Ship It!

- Sid Wagle


On July 20, 2017, 2:06 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60992/
> ---
> 
> (Updated July 20, 2017, 2:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sid Wagle.
> 
> 
> Bugs: AMBARI-21530
> https://issues.apache.org/jira/browse/AMBARI-21530
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During an upgrade from BI 4.2 to HDP 2.6, some service checks were failing. 
> This is because the service checks were having their hooks/service folders 
> overwritten by some of the scheduler framework. At the time of orchestration, 
> the cluster desired ID was still BI but the effective ID used for the upgrade 
> was HDP (which was being clobbered)
> 
> Exception on running YARN service check:
> 
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/stacks/BigInsights/4.2/services/YARN/package/scripts/service_check.py",
>  line 91, in 
> ServiceCheck().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 329, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/stacks/BigInsights/4.2/services/YARN/package/scripts/service_check.py",
>  line 54, in service_check
> user=params.smokeuser,
>   File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 72, in inner
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  2eca76cd8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  0b47ff1184 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  7405a4e017 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  5f400a3692 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  a36e8ccce1 
>   ambari-server/src/test/python/TestStackFeature.py 230734c9c7 
> 
> 
> Diff: https://reviews.apache.org/r/60992/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>



Review Request 60992: Service Checks During Upgrades Should Use Desired Stack

2017-07-19 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60992/
---

Review request for Ambari, Alejandro Fernandez and Sid Wagle.


Bugs: AMBARI-21530
https://issues.apache.org/jira/browse/AMBARI-21530


Repository: ambari


Description
---

During an upgrade from BI 4.2 to HDP 2.6, some service checks were failing. 
This is because the service checks were having their hooks/service folders 
overwritten by some of the scheduler framework. At the time of orchestration, 
the cluster desired ID was still BI but the effective ID used for the upgrade 
was HDP (which was being clobbered)

Exception on running YARN service check:

```
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/stacks/BigInsights/4.2/services/YARN/package/scripts/service_check.py",
 line 91, in 
ServiceCheck().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 329, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/stacks/BigInsights/4.2/services/YARN/package/scripts/service_check.py",
 line 54, in service_check
user=params.smokeuser,
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
line 72, in inner
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 2eca76cd8d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 0b47ff1184 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
 7405a4e017 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 5f400a3692 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
 a36e8ccce1 
  ambari-server/src/test/python/TestStackFeature.py 230734c9c7 


Diff: https://reviews.apache.org/r/60992/diff/1/


Testing
---

PENDING...


Thanks,

Jonathan Hurley