Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61453/#review185186 --- This has been pushed. Please resolve your JIRA and close this review. Thanks! - Nate Cole On Aug. 7, 2017, 6:45 a.m., Aman Poonia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61453/ > --- > > (Updated Aug. 7, 2017, 6:45 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-21634 > https://issues.apache.org/jira/browse/AMBARI-21634 > > > Repository: ambari > > > Description > --- > > Make sure Ambari also considers NIS users > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c > > > Diff: https://reviews.apache.org/r/61453/diff/1/ > > > Testing > --- > > Changed the TestHostInfo.py to include one valid and one invalid user. Also > tried it with NIS users and it works as expected. > > > Thanks, > > Aman Poonia > >
Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61453/#review182865 --- Ship it! Ship It! - Nate Cole On Aug. 7, 2017, 6:45 a.m., Aman Poonia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61453/ > --- > > (Updated Aug. 7, 2017, 6:45 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-21634 > https://issues.apache.org/jira/browse/AMBARI-21634 > > > Repository: ambari > > > Description > --- > > Make sure Ambari also considers NIS users > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c > > > Diff: https://reviews.apache.org/r/61453/diff/1/ > > > Testing > --- > > Changed the TestHostInfo.py to include one valid and one invalid user. Also > tried it with NIS users and it works as expected. > > > Thanks, > > Aman Poonia > >
Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61453/#review182393 --- Ship it! Ship It! - Jonathan Hurley On Aug. 7, 2017, 6:45 a.m., Aman Poonia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61453/ > --- > > (Updated Aug. 7, 2017, 6:45 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-21634 > https://issues.apache.org/jira/browse/AMBARI-21634 > > > Repository: ambari > > > Description > --- > > Make sure Ambari also considers NIS users > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c > > > Diff: https://reviews.apache.org/r/61453/diff/1/ > > > Testing > --- > > Changed the TestHostInfo.py to include one valid and one invalid user. Also > tried it with NIS users and it works as expected. > > > Thanks, > > Aman Poonia > >
Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users
> On Aug. 7, 2017, 6:28 p.m., Alejandro Fernandez wrote: > > What OS'es was this tested on? Tested it on Centos-6.4. Python documentation says "It is available on all Unix versions". - Aman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61453/#review182306 --- On Aug. 7, 2017, 10:45 a.m., Aman Poonia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61453/ > --- > > (Updated Aug. 7, 2017, 10:45 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-21634 > https://issues.apache.org/jira/browse/AMBARI-21634 > > > Repository: ambari > > > Description > --- > > Make sure Ambari also considers NIS users > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c > > > Diff: https://reviews.apache.org/r/61453/diff/1/ > > > Testing > --- > > Changed the TestHostInfo.py to include one valid and one invalid user. Also > tried it with NIS users and it works as expected. > > > Thanks, > > Aman Poonia > >
Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61453/#review182306 --- What OS'es was this tested on? - Alejandro Fernandez On Aug. 7, 2017, 10:45 a.m., Aman Poonia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61453/ > --- > > (Updated Aug. 7, 2017, 10:45 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-21634 > https://issues.apache.org/jira/browse/AMBARI-21634 > > > Repository: ambari > > > Description > --- > > Make sure Ambari also considers NIS users > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c > > > Diff: https://reviews.apache.org/r/61453/diff/1/ > > > Testing > --- > > Changed the TestHostInfo.py to include one valid and one invalid user. Also > tried it with NIS users and it works as expected. > > > Thanks, > > Aman Poonia > >
Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61453/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole. Bugs: AMBARI-21634 https://issues.apache.org/jira/browse/AMBARI-21634 Repository: ambari Description --- Make sure Ambari also considers NIS users Diffs - ambari-agent/src/main/python/ambari_agent/HostInfo.py 5f96df5b7a ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 027a0a885c Diff: https://reviews.apache.org/r/61453/diff/1/ Testing --- Changed the TestHostInfo.py to include one valid and one invalid user. Also tried it with NIS users and it works as expected. Thanks, Aman Poonia
