Re: Review Request 62015: Ranger should handle external Solr properly

2017-08-31 Thread Miklos Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62015/
---

(Updated Aug. 31, 2017, 8:41 p.m.)


Review request for Ambari, Gautam Borad, Mugdha Varadkar, Oliver Szabo, Robert 
Nettleton, Vishal Suvagia, and Velmurugan Periasamy.


Bugs: AMBARI-21863
https://issues.apache.org/jira/browse/AMBARI-21863


Repository: ambari


Description
---

Ranger tries to create it's configurations using the local ambari-infra Solr 
even if it is specified to use an external one.


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 bd45558 


Diff: https://reviews.apache.org/r/62015/diff/1/


Testing (updated)
---

Tested on two clusters, one running the external solr, the other installed 
Ranger, the config data were created.


Thanks,

Miklos Gergely



Re: Review Request 62015: Ranger should handle external Solr properly

2017-08-31 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62015/#review184305
---


Ship it!




Patch looks fine to me.

Can you also include Velmurugan Periasamy, Mugdha Varadkar, Vishal Suvagia, and 
Gautam Borad to this review? 

Thanks.

- Robert Nettleton


On Aug. 31, 2017, 1:59 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62015/
> ---
> 
> (Updated Aug. 31, 2017, 1:59 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21863
> https://issues.apache.org/jira/browse/AMBARI-21863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger tries to create it's configurations using the local ambari-infra Solr 
> even if it is specified to use an external one.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  bd45558 
> 
> 
> Diff: https://reviews.apache.org/r/62015/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on two clusters, one running the external solr, the other installed 
> Atlas, the config data were created.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Re: Review Request 62015: Ranger should handle external Solr properly

2017-08-31 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62015/#review184272
---


Ship it!




Ship It!

- Oliver Szabo


On Aug. 31, 2017, 1:59 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62015/
> ---
> 
> (Updated Aug. 31, 2017, 1:59 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21863
> https://issues.apache.org/jira/browse/AMBARI-21863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger tries to create it's configurations using the local ambari-infra Solr 
> even if it is specified to use an external one.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  bd45558 
> 
> 
> Diff: https://reviews.apache.org/r/62015/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on two clusters, one running the external solr, the other installed 
> Atlas, the config data were created.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Review Request 62015: Ranger should handle external Solr properly

2017-08-31 Thread Miklos Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62015/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-21863
https://issues.apache.org/jira/browse/AMBARI-21863


Repository: ambari


Description
---

Ranger tries to create it's configurations using the local ambari-infra Solr 
even if it is specified to use an external one.


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 bd45558 


Diff: https://reviews.apache.org/r/62015/diff/1/


Testing
---

Tested on two clusters, one running the external solr, the other installed 
Atlas, the config data were created.


Thanks,

Miklos Gergely