Re: Review Request 62083: Fix Log Search upgrade to 3.0.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62083/#review184569 --- Ship it! Ship It! - Robert Nettleton On Sept. 5, 2017, 3:52 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62083/ > --- > > (Updated Sept. 5, 2017, 3:52 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21881 > https://issues.apache.org/jira/browse/AMBARI-21881 > > > Repository: ambari > > > Description > --- > > There are 3 problems about the Log Search upgrade to 3.0.0 > - *-logsearch-conf attributes were deleted instead of removing the config type > - logsearch-common-properties must be created explicitly, because the empty > config type will not be created by default > - logsearch-output-config was created instead of overwriting > logfeeder-output-config > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 9255163 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > 53518dd > > > Diff: https://reviews.apache.org/r/62083/diff/1/ > > > Testing > --- > > Tested on local cluster. > > > Thanks, > > Miklos Gergely > >
Re: Review Request 62083: Fix Log Search upgrade to 3.0.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62083/#review184568 --- Ship it! Ship It! - Oliver Szabo On Sept. 5, 2017, 3:52 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62083/ > --- > > (Updated Sept. 5, 2017, 3:52 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21881 > https://issues.apache.org/jira/browse/AMBARI-21881 > > > Repository: ambari > > > Description > --- > > There are 3 problems about the Log Search upgrade to 3.0.0 > - *-logsearch-conf attributes were deleted instead of removing the config type > - logsearch-common-properties must be created explicitly, because the empty > config type will not be created by default > - logsearch-output-config was created instead of overwriting > logfeeder-output-config > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 9255163 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > 53518dd > > > Diff: https://reviews.apache.org/r/62083/diff/1/ > > > Testing > --- > > Tested on local cluster. > > > Thanks, > > Miklos Gergely > >
Review Request 62083: Fix Log Search upgrade to 3.0.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62083/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: AMBARI-21881 https://issues.apache.org/jira/browse/AMBARI-21881 Repository: ambari Description --- There are 3 problems about the Log Search upgrade to 3.0.0 - *-logsearch-conf attributes were deleted instead of removing the config type - logsearch-common-properties must be created explicitly, because the empty config type will not be created by default - logsearch-output-config was created instead of overwriting logfeeder-output-config Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 9255163 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 53518dd Diff: https://reviews.apache.org/r/62083/diff/1/ Testing --- Tested on local cluster. Thanks, Miklos Gergely
