Review Request 62526: Infra Solr client cleanup: make infra-solr-client script usable with symlinks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62526/ --- Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Nettleton, and Sandor Magyari. Bugs: AMBARI-22045 https://issues.apache.org/jira/browse/AMBARI-22045 Repository: ambari Description --- Make it possible for infra solr scripts to used by symlinks. Right now if a symlink points to the infra solr scripts -> throws an error as we using the actual directory to calculate the java classpath. The patch fixes that. Also added some small cleanups (e.g.: stderrs are duplicated because of 2 appenders - i changed the default ones) Diffs - ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java 70bc232 ambari-infra/ambari-infra-solr-client/src/main/resources/log4j.properties e8dca12 ambari-infra/ambari-infra-solr-client/src/main/resources/solrCloudCli.sh 7bfa864 ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh 12e6a77 ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/solr-client-log4j.properties.j2 0d0adc3 Diff: https://reviews.apache.org/r/62526/diff/1/ Testing --- tested manually. Thanks, Oliver Szabo
Re: Review Request 62526: Infra Solr client cleanup: make infra-solr-client script usable with symlinks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62526/#review186079 --- Ship it! Ship It! - Attila Magyar On Sept. 23, 2017, 11:20 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62526/ > --- > > (Updated Sept. 23, 2017, 11:20 p.m.) > > > Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Nettleton, > and Sandor Magyari. > > > Bugs: AMBARI-22045 > https://issues.apache.org/jira/browse/AMBARI-22045 > > > Repository: ambari > > > Description > --- > > Make it possible for infra solr scripts to used by symlinks. > > Right now if a symlink points to the infra solr scripts -> throws an error as > we using the actual directory to calculate the java classpath. The patch > fixes that. > > Also added some small cleanups (e.g.: stderrs are duplicated because of 2 > appenders - i changed the default ones) > > > Diffs > - > > > ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java > 70bc232 > ambari-infra/ambari-infra-solr-client/src/main/resources/log4j.properties > e8dca12 > ambari-infra/ambari-infra-solr-client/src/main/resources/solrCloudCli.sh > 7bfa864 > ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh > 12e6a77 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/solr-client-log4j.properties.j2 > 0d0adc3 > > > Diff: https://reviews.apache.org/r/62526/diff/1/ > > > Testing > --- > > tested manually. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 62526: Infra Solr client cleanup: make infra-solr-client script usable with symlinks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62526/#review186087 --- Ship it! Ship It! - Sandor Magyari On Sept. 23, 2017, 11:20 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62526/ > --- > > (Updated Sept. 23, 2017, 11:20 p.m.) > > > Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Nettleton, > and Sandor Magyari. > > > Bugs: AMBARI-22045 > https://issues.apache.org/jira/browse/AMBARI-22045 > > > Repository: ambari > > > Description > --- > > Make it possible for infra solr scripts to used by symlinks. > > Right now if a symlink points to the infra solr scripts -> throws an error as > we using the actual directory to calculate the java classpath. The patch > fixes that. > > Also added some small cleanups (e.g.: stderrs are duplicated because of 2 > appenders - i changed the default ones) > > > Diffs > - > > > ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java > 70bc232 > ambari-infra/ambari-infra-solr-client/src/main/resources/log4j.properties > e8dca12 > ambari-infra/ambari-infra-solr-client/src/main/resources/solrCloudCli.sh > 7bfa864 > ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh > 12e6a77 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/solr-client-log4j.properties.j2 > 0d0adc3 > > > Diff: https://reviews.apache.org/r/62526/diff/1/ > > > Testing > --- > > tested manually. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 62526: Infra Solr client cleanup: make infra-solr-client script usable with symlinks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62526/#review186094 --- Ship it! Ship It! - Miklos Gergely On Sept. 23, 2017, 11:20 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62526/ > --- > > (Updated Sept. 23, 2017, 11:20 p.m.) > > > Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Nettleton, > and Sandor Magyari. > > > Bugs: AMBARI-22045 > https://issues.apache.org/jira/browse/AMBARI-22045 > > > Repository: ambari > > > Description > --- > > Make it possible for infra solr scripts to used by symlinks. > > Right now if a symlink points to the infra solr scripts -> throws an error as > we using the actual directory to calculate the java classpath. The patch > fixes that. > > Also added some small cleanups (e.g.: stderrs are duplicated because of 2 > appenders - i changed the default ones) > > > Diffs > - > > > ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java > 70bc232 > ambari-infra/ambari-infra-solr-client/src/main/resources/log4j.properties > e8dca12 > ambari-infra/ambari-infra-solr-client/src/main/resources/solrCloudCli.sh > 7bfa864 > ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh > 12e6a77 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/solr-client-log4j.properties.j2 > 0d0adc3 > > > Diff: https://reviews.apache.org/r/62526/diff/1/ > > > Testing > --- > > tested manually. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 62526: Infra Solr client cleanup: make infra-solr-client script usable with symlinks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62526/#review186128 --- Ship it! Ship It! - Robert Nettleton On Sept. 23, 2017, 11:20 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62526/ > --- > > (Updated Sept. 23, 2017, 11:20 p.m.) > > > Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Nettleton, > and Sandor Magyari. > > > Bugs: AMBARI-22045 > https://issues.apache.org/jira/browse/AMBARI-22045 > > > Repository: ambari > > > Description > --- > > Make it possible for infra solr scripts to used by symlinks. > > Right now if a symlink points to the infra solr scripts -> throws an error as > we using the actual directory to calculate the java classpath. The patch > fixes that. > > Also added some small cleanups (e.g.: stderrs are duplicated because of 2 > appenders - i changed the default ones) > > > Diffs > - > > > ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java > 70bc232 > ambari-infra/ambari-infra-solr-client/src/main/resources/log4j.properties > e8dca12 > ambari-infra/ambari-infra-solr-client/src/main/resources/solrCloudCli.sh > 7bfa864 > ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh > 12e6a77 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/solr-client-log4j.properties.j2 > 0d0adc3 > > > Diff: https://reviews.apache.org/r/62526/diff/1/ > > > Testing > --- > > tested manually. > > > Thanks, > > Oliver Szabo > >
