Re: Review Request 62542: Solr Data Manager should use --line-delimited option by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62542/#review186122 --- Ship it! Ship It! - Robert Nettleton On Sept. 25, 2017, 12:47 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62542/ > --- > > (Updated Sept. 25, 2017, 12:47 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-22049 > https://issues.apache.org/jira/browse/AMBARI-22049 > > > Repository: ambari > > > Description > --- > > Instead of having an option for creating line delimited json file, that > should be the default, and a json file should be created if a flag is set. > > Also the -j short argument form was assigned to the name parameter instead of > this. > > > Diffs > - > > ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py > d17aec7 > > > Diff: https://reviews.apache.org/r/62542/diff/1/ > > > Testing > --- > > Tested on local cluster. > > > Thanks, > > Miklos Gergely > >
Re: Review Request 62542: Solr Data Manager should use --line-delimited option by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62542/#review186111 --- Ship it! Ship It! - Oliver Szabo On Sept. 25, 2017, 12:47 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62542/ > --- > > (Updated Sept. 25, 2017, 12:47 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-22049 > https://issues.apache.org/jira/browse/AMBARI-22049 > > > Repository: ambari > > > Description > --- > > Instead of having an option for creating line delimited json file, that > should be the default, and a json file should be created if a flag is set. > > Also the -j short argument form was assigned to the name parameter instead of > this. > > > Diffs > - > > ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py > d17aec7 > > > Diff: https://reviews.apache.org/r/62542/diff/1/ > > > Testing > --- > > Tested on local cluster. > > > Thanks, > > Miklos Gergely > >
Review Request 62542: Solr Data Manager should use --line-delimited option by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62542/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: AMBARI-22049 https://issues.apache.org/jira/browse/AMBARI-22049 Repository: ambari Description --- Instead of having an option for creating line delimited json file, that should be the default, and a json file should be created if a flag is set. Also the -j short argument form was assigned to the name parameter instead of this. Diffs - ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py d17aec7 Diff: https://reviews.apache.org/r/62542/diff/1/ Testing --- Tested on local cluster. Thanks, Miklos Gergely
