Re: Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62676/#review187419 --- Ship it! Ship It! - venkat sairam On Oct. 9, 2017, 3:42 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62676/ > --- > > (Updated Oct. 9, 2017, 3:42 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and venkat sairam. > > > Bugs: AMBARI-22089 > https://issues.apache.org/jira/browse/AMBARI-22089 > > > Repository: ambari > > > Description > --- > > - Updating the same worksheet rather creating new one. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java > 3690683 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryService.java > 7139ce8 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 9e8b6db > contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js > 4b4b29e > contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c > > > Diff: https://reviews.apache.org/r/62676/diff/2/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62676/ --- (Updated Oct. 9, 2017, 3:42 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and venkat sairam. Bugs: AMBARI-22089 https://issues.apache.org/jira/browse/AMBARI-22089 Repository: ambari Description --- - Updating the same worksheet rather creating new one. Diffs (updated) - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java 3690683 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryService.java 7139ce8 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 9e8b6db contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 4b4b29e contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c Diff: https://reviews.apache.org/r/62676/diff/2/ Changes: https://reviews.apache.org/r/62676/diff/1-2/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
Re: Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62676/#review186640 --- Ship it! Ship It! - venkat sairam On Sept. 28, 2017, 7:40 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62676/ > --- > > (Updated Sept. 28, 2017, 7:40 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and venkat sairam. > > > Bugs: AMBARI-22089 > https://issues.apache.org/jira/browse/AMBARI-22089 > > > Repository: ambari > > > Description > --- > > - Updating the same worksheet rather creating new one. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java > 3690683 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > f6256898 > contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c > > > Diff: https://reviews.apache.org/r/62676/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62676/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and venkat sairam. Bugs: AMBARI-22089 https://issues.apache.org/jira/browse/AMBARI-22089 Repository: ambari Description --- - Updating the same worksheet rather creating new one. Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java 3690683 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js f6256898 contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c Diff: https://reviews.apache.org/r/62676/diff/1/ Testing --- manually tested. Thanks, Pallav Kulshreshtha
