Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187088 --- Ship it! Ship It! - Nate Cole On Oct. 3, 2017, 5:11 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62754/ > --- > > (Updated Oct. 3, 2017, 5:11 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-22123 > https://issues.apache.org/jira/browse/AMBARI-22123 > > > Repository: ambari > > > Description > --- > > Essentially, the symlinking was doing a quick-exit if the > /etc//conf directory already existed. However, it might have been > created by another RPM and not the component we actually care about. > > The refactor here did two things: > - Invokes conf-select on the necessary packages > - Combined most of the logic between conf_select.select(...) and > conf_select.convert_conf_directories_to_symlinks(...) > - Removed legacy code from back in the pre-HDP 2.3 days > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 86821bf47a > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 3ace3b1570 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 0727970adb > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 0727970adb > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py > 20fd48de15 > ambari-server/src/test/python/TestAmbariServer.py 5db79137ee > ambari-server/src/test/python/TestMpacks.py fd30bf6f88 > > ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py > 92f5011978 > ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py > 2eeec46b4a > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py > 3d9bfd7c3e > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py > b88f3858a7 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py > 31b083bd0d > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py > 2df001cf21 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py > 34687c453b > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py > 4ec6aa788f > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py > 34c683ab2f > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py > 424157b128 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py > b235cad164 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py > 71c7bc17a2 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py > 4d65a404a2 > > > Diff: https://reviews.apache.org/r/62754/diff/3/ > > > Testing > --- > > Total run:1192 > Total errors:0 > Total failures:0 > OK > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 57.162 s > [INFO] Finished at: 2017-10-03T23:04:47-04:00 > [INFO] Final Memory: 19M/491M > [INFO] > > > > Thanks, > > Jonathan Hurley > >
Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187081 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 3, 2017, 9:11 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62754/ > --- > > (Updated Oct. 3, 2017, 9:11 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-22123 > https://issues.apache.org/jira/browse/AMBARI-22123 > > > Repository: ambari > > > Description > --- > > Essentially, the symlinking was doing a quick-exit if the > /etc//conf directory already existed. However, it might have been > created by another RPM and not the component we actually care about. > > The refactor here did two things: > - Invokes conf-select on the necessary packages > - Combined most of the logic between conf_select.select(...) and > conf_select.convert_conf_directories_to_symlinks(...) > - Removed legacy code from back in the pre-HDP 2.3 days > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 86821bf47a > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 3ace3b1570 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 0727970adb > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 0727970adb > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py > 20fd48de15 > ambari-server/src/test/python/TestAmbariServer.py 5db79137ee > ambari-server/src/test/python/TestMpacks.py fd30bf6f88 > > ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py > 92f5011978 > ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py > 2eeec46b4a > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py > 3d9bfd7c3e > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py > b88f3858a7 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py > 31b083bd0d > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py > 2df001cf21 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py > 34687c453b > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py > 4ec6aa788f > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py > 34c683ab2f > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py > 424157b128 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py > b235cad164 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py > 71c7bc17a2 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py > 4d65a404a2 > > > Diff: https://reviews.apache.org/r/62754/diff/3/ > > > Testing > --- > > Total run:1192 > Total errors:0 > Total failures:0 > OK > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 57.162 s > [INFO] Finished at: 2017-10-03T23:04:47-04:00 > [INFO] Final Memory: 19M/491M > [INFO] > > > > Thanks, > > Jonathan Hurley > >
Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187080 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 4, 2017, 12:11 a.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62754/ > --- > > (Updated Oct. 4, 2017, 12:11 a.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-22123 > https://issues.apache.org/jira/browse/AMBARI-22123 > > > Repository: ambari > > > Description > --- > > Essentially, the symlinking was doing a quick-exit if the > /etc//conf directory already existed. However, it might have been > created by another RPM and not the component we actually care about. > > The refactor here did two things: > - Invokes conf-select on the necessary packages > - Combined most of the logic between conf_select.select(...) and > conf_select.convert_conf_directories_to_symlinks(...) > - Removed legacy code from back in the pre-HDP 2.3 days > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 86821bf47a > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 3ace3b1570 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 0727970adb > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 0727970adb > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py > 20fd48de15 > ambari-server/src/test/python/TestAmbariServer.py 5db79137ee > ambari-server/src/test/python/TestMpacks.py fd30bf6f88 > > ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py > 92f5011978 > ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py > 2eeec46b4a > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py > 3d9bfd7c3e > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py > b88f3858a7 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py > 31b083bd0d > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py > 2df001cf21 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py > 34687c453b > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py > 4ec6aa788f > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py > 34c683ab2f > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py > 424157b128 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py > b235cad164 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py > 71c7bc17a2 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py > 4d65a404a2 > > > Diff: https://reviews.apache.org/r/62754/diff/3/ > > > Testing > --- > > Total run:1192 > Total errors:0 > Total failures:0 > OK > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 57.162 s > [INFO] Finished at: 2017-10-03T23:04:47-04:00 > [INFO] Final Memory: 19M/491M > [INFO] > > > > Thanks, > > Jonathan Hurley > >
Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/ --- (Updated Oct. 3, 2017, 5:11 p.m.) Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. Bugs: AMBARI-22123 https://issues.apache.org/jira/browse/AMBARI-22123 Repository: ambari Description --- Essentially, the symlinking was doing a quick-exit if the /etc//conf directory already existed. However, it might have been created by another RPM and not the component we actually care about. The refactor here did two things: - Invokes conf-select on the necessary packages - Combined most of the logic between conf_select.select(...) and conf_select.convert_conf_directories_to_symlinks(...) - Removed legacy code from back in the pre-HDP 2.3 days Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 86821bf47a ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 3ace3b1570 ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py 0727970adb ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py 0727970adb ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 20fd48de15 ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py 92f5011978 ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 2eeec46b4a contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py 3d9bfd7c3e contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py b88f3858a7 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py 31b083bd0d contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py 2df001cf21 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py 34687c453b contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py 4ec6aa788f contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py 34c683ab2f contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py 424157b128 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py b235cad164 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py 71c7bc17a2 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py 4d65a404a2 Diff: https://reviews.apache.org/r/62754/diff/2/ Changes: https://reviews.apache.org/r/62754/diff/1-2/ Testing (updated) --- mvn clean test Thanks, Jonathan Hurley
Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. Bugs: AMBARI-22123 https://issues.apache.org/jira/browse/AMBARI-22123 Repository: ambari Description --- Essentially, the symlinking was doing a quick-exit if the /etc//conf directory already existed. However, it might have been created by another RPM and not the component we actually care about. The refactor here did two things: - Invokes conf-select on the necessary packages - Combined most of the logic between conf_select.select(...) and conf_select.convert_conf_directories_to_symlinks(...) - Removed legacy code from back in the pre-HDP 2.3 days Diffs - ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 86821bf47a ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 3ace3b1570 ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py 0727970adb ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py 0727970adb ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 20fd48de15 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py 3d9bfd7c3e contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py b88f3858a7 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py 31b083bd0d contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py 2df001cf21 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py 34687c453b contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py 4ec6aa788f contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py 34c683ab2f contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py 424157b128 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py b235cad164 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py 71c7bc17a2 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py 4d65a404a2 Diff: https://reviews.apache.org/r/62754/diff/1/ Testing --- PENDING... Thanks, Jonathan Hurley
