Re: Review Request 63080: Smartsense requires HDFS to be always present while installing

2017-10-17 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63080/#review188332
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 17, 2017, 5:15 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63080/
> ---
> 
> (Updated Жов. 17, 2017, 5:15 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22256
> https://issues.apache.org/jira/browse/AMBARI-22256
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Smartsense cannot be installed without HDFS in the cluster.  
> I am getting the below exception
> 
> 
> 
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
>  line 43, in 
> BeforeStartHook().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 367, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
>  line 29, in hook
> import params
>   File 
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py",
>  line 331, in 
> if "core-site" in config['configurations'] and namenode_rpc:
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
>  line 73, in __getattr__
> raise Fail("Configuration parameter '" + self.name + "' was not found 
> in configurations dictionary!")
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'fs.defaultFS' was not found in configurations dictionary!
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  55a609328e 
> 
> 
> Diff: https://reviews.apache.org/r/63080/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Review Request 63080: Smartsense requires HDFS to be always present while installing

2017-10-17 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63080/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-22256
https://issues.apache.org/jira/browse/AMBARI-22256


Repository: ambari


Description
---

Smartsense cannot be installed without HDFS in the cluster.  
I am getting the below exception




Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
 line 43, in 
BeforeStartHook().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 367, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
 line 29, in hook
import params
  File 
"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py",
 line 331, in 
if "core-site" in config['configurations'] and namenode_rpc:
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
 line 73, in __getattr__
raise Fail("Configuration parameter '" + self.name + "' was not found 
in configurations dictionary!")
resource_management.core.exceptions.Fail: Configuration parameter 
'fs.defaultFS' was not found in configurations dictionary!


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 55a609328e 


Diff: https://reviews.apache.org/r/63080/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk