Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-31 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/#review189718
---


Ship it!




Ship It!

- Robert Levas


On Oct. 24, 2017, 2:02 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63180/
> ---
> 
> (Updated Oct. 24, 2017, 2:02 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22278
> https://issues.apache.org/jira/browse/AMBARI-22278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fist step of changin way of handling keytabs.
> In this patch:
> 1. Enable cache for every principal
> 2. Changed database to represent keytab-principal relation
> 3. Created stub (ResolvedKerberosKeytab) to handle keytabs files between 
> stages in kerberos instead of principal records
> 
> Future plans:
> 1. Improve kerberos.json with support for referencing to keytab descriptor 
> and multiple principals descriptors in one identity
> 2. Refactor all *Kerberos*ServerAction.java to use KerberosKeytab instead of 
> IdentityRecord
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008e59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  b8e1be15d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  4f14614000 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
>  bfaf7b4a4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
>  8acc401c83 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
>  93c55c14fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
>  0c17f198f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  bb67131584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
>  600bb8b2aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  7948a60ba2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
>  dae8254799 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
>  4f1ee52739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  fca1b6fd12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  355f515591 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  1c0853b98e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
>  ddf3d1b0fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
>  ea742bd940 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  1b0f4fb2f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  e1f8419b81 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  335451fa03 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  038d1b5d3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  5af7c6b35f 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 1104d199f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  3b8f6dae22 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 015ec0a9e7 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.s

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-25 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/#review189196
---


Ship it!




Ship It!

- Attila Magyar


On Oct. 24, 2017, 6:02 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63180/
> ---
> 
> (Updated Oct. 24, 2017, 6:02 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22278
> https://issues.apache.org/jira/browse/AMBARI-22278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fist step of changin way of handling keytabs.
> In this patch:
> 1. Enable cache for every principal
> 2. Changed database to represent keytab-principal relation
> 3. Created stub (ResolvedKerberosKeytab) to handle keytabs files between 
> stages in kerberos instead of principal records
> 
> Future plans:
> 1. Improve kerberos.json with support for referencing to keytab descriptor 
> and multiple principals descriptors in one identity
> 2. Refactor all *Kerberos*ServerAction.java to use KerberosKeytab instead of 
> IdentityRecord
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008e59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  b8e1be15d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  4f14614000 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
>  bfaf7b4a4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
>  8acc401c83 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
>  93c55c14fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
>  0c17f198f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  bb67131584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
>  600bb8b2aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  7948a60ba2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
>  dae8254799 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
>  4f1ee52739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  fca1b6fd12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  355f515591 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  1c0853b98e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
>  ddf3d1b0fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
>  ea742bd940 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  1b0f4fb2f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  e1f8419b81 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  335451fa03 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  038d1b5d3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  5af7c6b35f 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 1104d199f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  3b8f6dae22 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 015ec0a9e7 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-25 Thread Eugene Chekanskiy 


> On Oct. 25, 2017, 7:28 a.m., Attila Magyar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
> > Lines 469 (patched)
> > 
> >
> > How does regenerate missing keytabs work now? I can't find where it 
> > takes the id_distributed flag into consideration.

It works as before except that cached keytabs used always. This patch is only a 
first patch in series. Next patches will refactor how the data passed between 
stages and id_distributed will be honored when final keytabs specific to host 
are generated and distributed.


> On Oct. 25, 2017, 7:28 a.m., Attila Magyar wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
> > Lines 906 (patched)
> > 
> >
> > is there any migraction code that needs to be created for existing 
> > users?

Nope. It will added last, when refactoring and all features like many-to-many 
relation for principals-keytabs will be implemented.


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/#review189176
---


On Oct. 24, 2017, 6:02 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63180/
> ---
> 
> (Updated Oct. 24, 2017, 6:02 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22278
> https://issues.apache.org/jira/browse/AMBARI-22278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fist step of changin way of handling keytabs.
> In this patch:
> 1. Enable cache for every principal
> 2. Changed database to represent keytab-principal relation
> 3. Created stub (ResolvedKerberosKeytab) to handle keytabs files between 
> stages in kerberos instead of principal records
> 
> Future plans:
> 1. Improve kerberos.json with support for referencing to keytab descriptor 
> and multiple principals descriptors in one identity
> 2. Refactor all *Kerberos*ServerAction.java to use KerberosKeytab instead of 
> IdentityRecord
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008e59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  b8e1be15d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  4f14614000 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
>  bfaf7b4a4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
>  8acc401c83 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
>  93c55c14fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
>  0c17f198f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  bb67131584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
>  600bb8b2aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  7948a60ba2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
>  dae8254799 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
>  4f1ee52739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  fca1b6fd12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  355f515591 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  1c0853b98e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
>  ddf3d1b0fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
>  ea742bd940 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Ker

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-25 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/#review189176
---




ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
Lines 469 (patched)


How does regenerate missing keytabs work now? I can't find where it takes 
the id_distributed flag into consideration.



ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Lines 906 (patched)


is there any migraction code that needs to be created for existing users?


- Attila Magyar


On Oct. 24, 2017, 6:02 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63180/
> ---
> 
> (Updated Oct. 24, 2017, 6:02 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22278
> https://issues.apache.org/jira/browse/AMBARI-22278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fist step of changin way of handling keytabs.
> In this patch:
> 1. Enable cache for every principal
> 2. Changed database to represent keytab-principal relation
> 3. Created stub (ResolvedKerberosKeytab) to handle keytabs files between 
> stages in kerberos instead of principal records
> 
> Future plans:
> 1. Improve kerberos.json with support for referencing to keytab descriptor 
> and multiple principals descriptors in one identity
> 2. Refactor all *Kerberos*ServerAction.java to use KerberosKeytab instead of 
> IdentityRecord
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008e59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  b8e1be15d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  4f14614000 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
>  bfaf7b4a4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
>  8acc401c83 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
>  93c55c14fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
>  0c17f198f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  bb67131584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
>  600bb8b2aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  7948a60ba2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
>  dae8254799 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
>  4f1ee52739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  fca1b6fd12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  355f515591 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  1c0853b98e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
>  ddf3d1b0fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
>  ea742bd940 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  1b0f4fb2f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  e1f8419b81 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  335451fa03 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  038d1b5d3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
>  PRE-CREATION 
>   
>

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-24 Thread Eugene Chekanskiy 


> On Oct. 20, 2017, 3:58 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
> > Lines 393-396 (patched)
> > 
> >
> > This may not be necessary since we aren't actually creating Keberos 
> > identitities here.  We are setting up the configurations for certain 
> > services not yet installed in anticipation for them being installed so that 
> > we can reduce the need to restart the core Hadoop services.

This ensures that DB is in state to work with service actions down in the 
kerberos wizard. Before my patch existance of principal indicated by existance 
of record in database, now it is a flag in database.


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/#review188838
---


On Oct. 24, 2017, 6:02 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63180/
> ---
> 
> (Updated Oct. 24, 2017, 6:02 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22278
> https://issues.apache.org/jira/browse/AMBARI-22278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fist step of changin way of handling keytabs.
> In this patch:
> 1. Enable cache for every principal
> 2. Changed database to represent keytab-principal relation
> 3. Created stub (ResolvedKerberosKeytab) to handle keytabs files between 
> stages in kerberos instead of principal records
> 
> Future plans:
> 1. Improve kerberos.json with support for referencing to keytab descriptor 
> and multiple principals descriptors in one identity
> 2. Refactor all *Kerberos*ServerAction.java to use KerberosKeytab instead of 
> IdentityRecord
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008e59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  b8e1be15d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  4f14614000 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
>  bfaf7b4a4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
>  8acc401c83 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
>  93c55c14fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
>  0c17f198f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  bb67131584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
>  600bb8b2aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  7948a60ba2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
>  dae8254799 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
>  4f1ee52739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  fca1b6fd12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  355f515591 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  1c0853b98e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
>  ddf3d1b0fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
>  ea742bd940 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  1b0f4fb2f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  e1f8419b81 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  335451fa03 
>   
> amb

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-24 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/
---

(Updated Oct. 24, 2017, 6:02 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, 
Robert Levas, and Sebastian Toader.


Bugs: AMBARI-22278
https://issues.apache.org/jira/browse/AMBARI-22278


Repository: ambari


Description
---

Fist step of changin way of handling keytabs.
In this patch:
1. Enable cache for every principal
2. Changed database to represent keytab-principal relation
3. Created stub (ResolvedKerberosKeytab) to handle keytabs files between stages 
in kerberos instead of principal records

Future plans:
1. Improve kerberos.json with support for referencing to keytab descriptor and 
multiple principals descriptors in one identity
2. Refactor all *Kerberos*ServerAction.java to use KerberosKeytab instead of 
IdentityRecord


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 2690008e59 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 29f8e2acbd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 b8e1be15d5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 4f14614000 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
 bfaf7b4a4f 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
 8acc401c83 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
 93c55c14fa 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
 0c17f198f4 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
 bb67131584 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
 600bb8b2aa 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 7948a60ba2 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
 dae8254799 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
 4f1ee52739 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
 fca1b6fd12 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 355f515591 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 1c0853b98e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
 ddf3d1b0fe 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
 ea742bd940 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 1b0f4fb2f9 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
 e1f8419b81 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
 335451fa03 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
 038d1b5d3f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
 5af7c6b35f 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
1104d199f4 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 3b8f6dae22 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 015ec0a9e7 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql eb9ca96465 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql dac3f28501 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c321a38d7c 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8740ed7fdd 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 415589d3a8 
  ambari-server/src/main/resources/META-INF/persistence.xml e4045ef536 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 21accdd925 
  
ambari-server/src/main/resources/common-ser

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-20 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/#review188838
---



The patch looks really good, but I am concerned that it may break the various 
forms of the "Regenerate Keytab" operations that are avaialbe:
- Regenerate all
- Regenerate missing
- Regenerate all for a host
- Regenerate all for a service (or set of components)

The headless identities are most sensitive to the host-based operation. We 
don't want to change the key for them during this operation since it will 
invalidate the keytab files on the other hosts. For this case, we simply want 
to ensure the keytab file for those identities are installed on the host we are 
operating on. If needed the keytab entry should be pulled from the cache to 
build the keytab file to distribute.


ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
Lines 471 (patched)


Is there a reason this commented out line was left in?



ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
Lines 738 (patched)


Missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
Lines 740 (patched)


Missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
Lines 1889 (patched)


Possible NPE?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
Lines 199-201 (original), 199-204 (patched)


It seems like this should be completed else the generated report will also 
indicate that the keytb file have not yet been distributed.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
Lines 393-396 (patched)


This may not be necessary since we aren't actually creating Keberos 
identitities here.  We are setting up the configurations for certain services 
not yet installed in anticipation for them being installed so that we can 
reduce the need to restart the core Hadoop services.


- Robert Levas


On Oct. 20, 2017, 9:25 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63180/
> ---
> 
> (Updated Oct. 20, 2017, 9:25 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22278
> https://issues.apache.org/jira/browse/AMBARI-22278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fist step of changin way of handling keytabs.
> In this patch:
> 1. Enable cache for every principal
> 2. Changed database to represent keytab-principal relation
> 3. Created stub (ResolvedKerberosKeytab) to handle keytabs files between 
> stages in kerberos instead of principal records
> 
> Future plans:
> 1. Improve kerberos.json with support for referencing to keytab descriptor 
> and multiple principals descriptors in one identity
> 2. Refactor all *Kerberos*ServerAction.java to use KerberosKeytab instead of 
> IdentityRecord
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008e59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  b8e1be15d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  4f14614000 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
>  bfaf7b4a4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
>  8acc401c83 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
>  93c55c14fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
>  0c17f198f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  bb67131584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/enti

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-20 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/#review188836
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
Lines 582-588 (patched)


Since ambari 3.0 is java8 you could use here java8 construct like 
Optional.

Also this could be a utility method such as it can be used from other 
classes as well.


- Sebastian Toader


On Oct. 20, 2017, 3:25 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63180/
> ---
> 
> (Updated Oct. 20, 2017, 3:25 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22278
> https://issues.apache.org/jira/browse/AMBARI-22278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fist step of changin way of handling keytabs.
> In this patch:
> 1. Enable cache for every principal
> 2. Changed database to represent keytab-principal relation
> 3. Created stub (ResolvedKerberosKeytab) to handle keytabs files between 
> stages in kerberos instead of principal records
> 
> Future plans:
> 1. Improve kerberos.json with support for referencing to keytab descriptor 
> and multiple principals descriptors in one identity
> 2. Refactor all *Kerberos*ServerAction.java to use KerberosKeytab instead of 
> IdentityRecord
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008e59 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  b8e1be15d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  4f14614000 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
>  bfaf7b4a4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
>  8acc401c83 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
>  93c55c14fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
>  0c17f198f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
>  bb67131584 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
>  600bb8b2aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  7948a60ba2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
>  dae8254799 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
>  4f1ee52739 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  fca1b6fd12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  355f515591 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  1c0853b98e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
>  ddf3d1b0fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
>  ea742bd940 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  1b0f4fb2f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  e1f8419b81 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  335451fa03 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  038d1b5d3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  5af7c6b35f 
>   ambari-serve

Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-20 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, 
Robert Levas, and Sebastian Toader.


Bugs: AMBARI-22278
https://issues.apache.org/jira/browse/AMBARI-22278


Repository: ambari


Description
---

Fist step of changin way of handling keytabs.
In this patch:
1. Enable cache for every principal
2. Changed database to represent keytab-principal relation
3. Created stub (ResolvedKerberosKeytab) to handle keytabs files between stages 
in kerberos instead of principal records

Future plans:
1. Improve kerberos.json with support for referencing to keytab descriptor and 
multiple principals descriptors in one identity
2. Refactor all *Kerberos*ServerAction.java to use KerberosKeytab instead of 
IdentityRecord


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 2690008e59 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 29f8e2acbd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 b8e1be15d5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 4f14614000 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
 bfaf7b4a4f 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
 8acc401c83 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java
 93c55c14fa 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java
 0c17f198f4 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java
 bb67131584 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java
 600bb8b2aa 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 7948a60ba2 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java
 dae8254799 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
 4f1ee52739 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
 fca1b6fd12 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 355f515591 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 1c0853b98e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
 ddf3d1b0fe 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
 ea742bd940 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 1b0f4fb2f9 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
 e1f8419b81 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
 335451fa03 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
 038d1b5d3f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
 5af7c6b35f 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
1104d199f4 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 3b8f6dae22 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 614af1ef15 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 530411a149 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ebe5f120a2 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 634db9566a 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql f64ff80b73 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 7a3feaf92a 
  ambari-server/src/main/resources/META-INF/persistence.xml e4045ef536 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 21accdd925 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/kerber