Re: Review Request 64186: Update server setup to deny GPL as default

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192331
---


Ship it!




Ship It!

- Andrew Onischuk


On Nov. 30, 2017, 6:36 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 6:36 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> File Attachments
> 
> 
> AMBARI-22555-1.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/11/30/3aaac156-4020-4d03-8611-de2790ff9301__AMBARI-22555-1.patch
> AMBARI-22555-1.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/11/30/1276fb76-4340-4d2b-8bb2-ff2edfa49a73__AMBARI-22555-1.patch
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/
---

(Updated Nov. 30, 2017, 6:36 p.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
Papirkovskyy.


Changes
---

Minor change to write out false on silent without accept.


Bugs: AMBARI-22555
https://issues.apache.org/jira/browse/AMBARI-22555


Repository: ambari


Description
---

Presently the default is to accept GPL for LZO download.


Diffs
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
3f8a772 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
e5adb19 


Diff: https://reviews.apache.org/r/64186/diff/3/


Testing
---

mvn clean test


File Attachments (updated)


AMBARI-22555-1.patch
  
https://reviews.apache.org/media/uploaded/files/2017/11/30/3aaac156-4020-4d03-8611-de2790ff9301__AMBARI-22555-1.patch
AMBARI-22555-1.patch
  
https://reviews.apache.org/media/uploaded/files/2017/11/30/1276fb76-4340-4d2b-8bb2-ff2edfa49a73__AMBARI-22555-1.patch


Thanks,

Sid Wagle

Re: Review Request 64186: Update server setup to deny GPL as default

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/
---

(Updated Nov. 30, 2017, 6:26 p.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
Papirkovskyy.


Changes
---

Fix for silent accept.


Bugs: AMBARI-22555
https://issues.apache.org/jira/browse/AMBARI-22555


Repository: ambari


Description
---

Presently the default is to accept GPL for LZO download.


Diffs
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
3f8a772 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
e5adb19 


Diff: https://reviews.apache.org/r/64186/diff/3/


Testing
---

mvn clean test


File Attachments (updated)


AMBARI-22555-1.patch
  
https://reviews.apache.org/media/uploaded/files/2017/11/30/3aaac156-4020-4d03-8611-de2790ff9301__AMBARI-22555-1.patch


Thanks,

Sid Wagle

Re: Review Request 64186: Update server setup to deny GPL as default

[Andrew Onischuk]

> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/python/ambari_server/serverConfiguration.py
> > Line 1162 (original), 1157 (patched)
> > 
> >
> > I think you might have broken silent flag to enable gpl by doing this.
> 
> Andrew Onischuk wrote:
> By doing so you should able to fix it. (should add default_value kwarg to 
> write_gpl_license_accepted.
> 
> -  if not get_silent() or options.accept_gpl:
> -print 'Checking GPL software agreement...'
> -write_gpl_license_accepted()
> +  print 'Checking GPL software agreement...'
> +  write_gpl_license_accepted(default_value=(get_silent() and 
> options.accept_gpl))
> 
> Andrew Onischuk wrote:
> Ah it formats really bad. So I meant was to replace 
>  
> this:
> 
> if not get_silent() or options.accept_gpl:
>print 'Checking GPL software agreement...'
>write_gpl_license_accepted()
> 
> by this:
> 
> print 'Checking GPL software agreement...'
> write_gpl_license_accepted(default_value=(get_silent() and 
> options.accept_gpl))

Or even this is better:
if not get_silent() or options.accept_gpl:
   print 'Checking GPL software agreement...'
   write_gpl_license_accepted()
--> 

print 'Checking GPL software agreement...'
write_gpl_license_accepted(default_value=options.accept_gpl)


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192245
---


On Nov. 30, 2017, 12:20 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Andrew Onischuk]

> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/python/ambari_server/serverConfiguration.py
> > Line 1162 (original), 1157 (patched)
> > 
> >
> > I think you might have broken silent flag to enable gpl by doing this.
> 
> Andrew Onischuk wrote:
> By doing so you should able to fix it. (should add default_value kwarg to 
> write_gpl_license_accepted.
> 
> -  if not get_silent() or options.accept_gpl:
> -print 'Checking GPL software agreement...'
> -write_gpl_license_accepted()
> +  print 'Checking GPL software agreement...'
> +  write_gpl_license_accepted(default_value=(get_silent() and 
> options.accept_gpl))

Ah it formats really bad. So I meant was to replace 
 
this:

if not get_silent() or options.accept_gpl:
   print 'Checking GPL software agreement...'
   write_gpl_license_accepted()

by this:

print 'Checking GPL software agreement...'
write_gpl_license_accepted(default_value=(get_silent() and options.accept_gpl))


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192245
---


On Nov. 30, 2017, 12:20 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Andrew Onischuk]

> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/python/ambari_server/serverConfiguration.py
> > Line 1162 (original), 1157 (patched)
> > 
> >
> > I think you might have broken silent flag to enable gpl by doing this.

By doing so you should able to fix it. (should add default_value kwarg to 
write_gpl_license_accepted.

-  if not get_silent() or options.accept_gpl:
-print 'Checking GPL software agreement...'
-write_gpl_license_accepted()
+  print 'Checking GPL software agreement...'
+  write_gpl_license_accepted(default_value=(get_silent() and 
options.accept_gpl))


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192245
---


On Nov. 30, 2017, 12:20 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192245
---




ambari-server/src/main/python/ambari_server/serverConfiguration.py
Line 1162 (original), 1157 (patched)


I think you might have broken silent flag to enable gpl by doing this.


- Andrew Onischuk


On Nov. 30, 2017, 12:20 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192244
---


Ship it!




Ship It!

- Andrew Onischuk


On Nov. 30, 2017, 12:20 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192237
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 29, 2017, 7:20 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 29, 2017, 7:20 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192203
---


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On Nov. 30, 2017, 12:20 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/
---

(Updated Nov. 30, 2017, 12:20 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
Papirkovskyy.


Changes
---

Fixed typo


Bugs: AMBARI-22555
https://issues.apache.org/jira/browse/AMBARI-22555


Repository: ambari


Description
---

Presently the default is to accept GPL for LZO download.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
3f8a772 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
e5adb19 


Diff: https://reviews.apache.org/r/64186/diff/3/

Changes: https://reviews.apache.org/r/64186/diff/2-3/


Testing
---

mvn clean test


Thanks,

Sid Wagle

Re: Review Request 64186: Update server setup to deny GPL as default

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/#review192200
---




ambari-server/src/main/python/ambari_server/serverUpgrade.py
Line 77 (original), 77 (patched)


Typo: INSTALLED


- Vivek Ratnavel Subramanian


On Nov. 30, 2017, 12:02 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64186/
> ---
> 
> (Updated Nov. 30, 2017, 12:02 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-22555
> https://issues.apache.org/jira/browse/AMBARI-22555
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Presently the default is to accept GPL for LZO download.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f8a772 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> e5adb19 
> 
> 
> Diff: https://reviews.apache.org/r/64186/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 64186: Update server setup to deny GPL as default

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/
---

(Updated Nov. 30, 2017, 12:02 a.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
Papirkovskyy.


Bugs: AMBARI-22555
https://issues.apache.org/jira/browse/AMBARI-22555


Repository: ambari


Description
---

Presently the default is to accept GPL for LZO download.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
3f8a772 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
e5adb19 


Diff: https://reviews.apache.org/r/64186/diff/2/

Changes: https://reviews.apache.org/r/64186/diff/1-2/


Testing (updated)
---

mvn clean test


Thanks,

Sid Wagle

Review Request 64186: Update server setup to deny GPL as default

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64186/
---

Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav 
Papirkovskyy.


Bugs: AMBARI-22555
https://issues.apache.org/jira/browse/AMBARI-22555


Repository: ambari


Description
---

Presently the default is to accept GPL for LZO download.


Diffs
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
3f8a772 


Diff: https://reviews.apache.org/r/64186/diff/1/


Testing
---


Thanks,

Sid Wagle