Review Request 64914: AMBARI-22719. Regenerate Keytabs resets security.inter.broker.protocol to PLAINTEXTSASL

2018-01-03 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64914/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, and 
Yolanda Davis.


Bugs: AMBARI-22719
https://issues.apache.org/jira/browse/AMBARI-22719


Repository: ambari


Description
---

Let stack advisor retain `security.inter.broker.protocol` value if it is a 
secure one.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
125372011984791db4b1c54ef5874740882a2331 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
4f8eaf2ceb985996b7e3d888e615c3bdc91f7c90 


Diff: https://reviews.apache.org/r/64914/diff/1/


Testing
---

Tested according to steps in 
[AMBARI-22719](https://issues.apache.org/jira/browse/AMBARI-22719).

Amended existing unit test case.  Unit tests are OK:

```
Total run:1200
Total errors:0
Total failures:0
OK
```


Thanks,

Attila Doroszlai



Re: Review Request 64914: AMBARI-22719. Regenerate Keytabs resets security.inter.broker.protocol to PLAINTEXTSASL

2018-01-03 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64914/#review194695
---


Ship it!




Ship It!

- Robert Levas


On Jan. 3, 2018, 6:24 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64914/
> ---
> 
> (Updated Jan. 3, 2018, 6:24 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, 
> and Yolanda Davis.
> 
> 
> Bugs: AMBARI-22719
> https://issues.apache.org/jira/browse/AMBARI-22719
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Let stack advisor retain `security.inter.broker.protocol` value if it is a 
> secure one.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 125372011984791db4b1c54ef5874740882a2331 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 4f8eaf2ceb985996b7e3d888e615c3bdc91f7c90 
> 
> 
> Diff: https://reviews.apache.org/r/64914/diff/1/
> 
> 
> Testing
> ---
> 
> Tested according to steps in 
> [AMBARI-22719](https://issues.apache.org/jira/browse/AMBARI-22719).
> 
> Amended existing unit test case.  Unit tests are OK:
> 
> ```
> Total run:1200
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 64914: AMBARI-22719. Regenerate Keytabs resets security.inter.broker.protocol to PLAINTEXTSASL

2018-01-03 Thread Balázs Bence Sári

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64914/#review194696
---


Ship it!




Ship It!

- Balázs Bence Sári


On Jan. 3, 2018, 11:24 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64914/
> ---
> 
> (Updated Jan. 3, 2018, 11:24 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, 
> and Yolanda Davis.
> 
> 
> Bugs: AMBARI-22719
> https://issues.apache.org/jira/browse/AMBARI-22719
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Let stack advisor retain `security.inter.broker.protocol` value if it is a 
> secure one.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 125372011984791db4b1c54ef5874740882a2331 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 4f8eaf2ceb985996b7e3d888e615c3bdc91f7c90 
> 
> 
> Diff: https://reviews.apache.org/r/64914/diff/1/
> 
> 
> Testing
> ---
> 
> Tested according to steps in 
> [AMBARI-22719](https://issues.apache.org/jira/browse/AMBARI-22719).
> 
> Amended existing unit test case.  Unit tests are OK:
> 
> ```
> Total run:1200
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 64914: AMBARI-22719. Regenerate Keytabs resets security.inter.broker.protocol to PLAINTEXTSASL

2018-01-03 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64914/#review194698
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 3, 2018, 11:24 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64914/
> ---
> 
> (Updated Jan. 3, 2018, 11:24 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, 
> and Yolanda Davis.
> 
> 
> Bugs: AMBARI-22719
> https://issues.apache.org/jira/browse/AMBARI-22719
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Let stack advisor retain `security.inter.broker.protocol` value if it is a 
> secure one.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 125372011984791db4b1c54ef5874740882a2331 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 4f8eaf2ceb985996b7e3d888e615c3bdc91f7c90 
> 
> 
> Diff: https://reviews.apache.org/r/64914/diff/1/
> 
> 
> Testing
> ---
> 
> Tested according to steps in 
> [AMBARI-22719](https://issues.apache.org/jira/browse/AMBARI-22719).
> 
> Amended existing unit test case.  Unit tests are OK:
> 
> ```
> Total run:1200
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>