Re: Review Request 33997: Improve GPG key validation for release verification script

[Joe Smith]

> On May 8, 2015, 5:22 p.m., Bill Farner wrote:
> > Ship It!

Mind committing for me?


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/#review83119
---


On May 8, 2015, 5:11 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33997/
> ---
> 
> (Updated May 8, 2015, 5:11 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve GPG key validation for release verification script
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> f96d7c9239895e86d715ecec3c47b9ba828dbc30 
> 
> Diff: https://reviews.apache.org/r/33997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 33997: Improve GPG key validation for release verification script

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/#review83121
---

Ship it!


Master (1c09d58) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 9, 2015, 12:11 a.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33997/
> ---
> 
> (Updated May 9, 2015, 12:11 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve GPG key validation for release verification script
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> f96d7c9239895e86d715ecec3c47b9ba828dbc30 
> 
> Diff: https://reviews.apache.org/r/33997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 33997: Improve GPG key validation for release verification script

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/#review83119
---

Ship it!


Ship It!

- Bill Farner


On May 9, 2015, 12:11 a.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33997/
> ---
> 
> (Updated May 9, 2015, 12:11 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve GPG key validation for release verification script
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> f96d7c9239895e86d715ecec3c47b9ba828dbc30 
> 
> Diff: https://reviews.apache.org/r/33997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 33997: Improve GPG key validation for release verification script

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/#review83118
---

Ship it!


Ship It!

- Joshua Cohen


On May 9, 2015, 12:11 a.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33997/
> ---
> 
> (Updated May 9, 2015, 12:11 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve GPG key validation for release verification script
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> f96d7c9239895e86d715ecec3c47b9ba828dbc30 
> 
> Diff: https://reviews.apache.org/r/33997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 33997: Improve GPG key validation for release verification script

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/
---

(Updated May 8, 2015, 5:11 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

after speaking with jcohen and wfarner in IRC's #aurora


Repository: aurora


Description
---

Improve GPG key validation for release verification script


Diffs (updated)
-

  build-support/release/verify-release-candidate 
f96d7c9239895e86d715ecec3c47b9ba828dbc30 

Diff: https://reviews.apache.org/r/33997/diff/


Testing
---


Thanks,

Joe Smith

Re: Review Request 33999: Add missing binding to ThriftApiBenchmarks.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33999/
---

(Updated May 8, 2015, 10:02 p.m.)


Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
---

Sorry for the whack-a-mole, these tests take a long time to run so i was 
selecting specific ones to run.  I'll make sure the full suite is green before 
i push this one.


Diffs
-

  src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
ed1171d52655fef643330f34913c256f77300fa2 

Diff: https://reviews.apache.org/r/33999/diff/


Testing (updated)
---

`./gradlew jmh` now works


Thanks,

Bill Farner

Re: Review Request 33959: Add update wait and update start --wait flag.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83104
---

Ship it!


Master (288f00b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 9:07 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 9:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33999: Add missing binding to ThriftApiBenchmarks.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33999/#review83102
---

Ship it!


Ship It!

- Joshua Cohen


On May 8, 2015, 8:45 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33999/
> ---
> 
> (Updated May 8, 2015, 8:45 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Sorry for the whack-a-mole, these tests take a long time to run so i was 
> selecting specific ones to run.  I'll make sure the full suite is green 
> before i push this one.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
> ed1171d52655fef643330f34913c256f77300fa2 
> 
> Diff: https://reviews.apache.org/r/33999/diff/
> 
> 
> Testing
> ---
> 
> TODO(wfarner): Report back on result of ./gradlew jmh.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update wait and update start --wait flag.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83094
---


@ReviewBot retry

Last build result is for the previous diff.

- Bill Farner


On May 8, 2015, 9:07 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 9:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update wait and update start --wait flag.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83093
---


Master (288f00b) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.api.updater   
 .   SUCCESS
 src.test.python.apache.aurora.client.api.updater_util  
 .   SUCCESS
 src.test.python.apache.aurora.client.base  
 .   SUCCESS
 src.test.python.apache.aurora.client.binding_helper
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.api   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.client
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.command_hooks 
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.config
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.context   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.cron  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.inspect   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.job   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.plugins   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.quota 
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.sla   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.supdate   
 .   FAILURE
 src.test.python.apache.aurora.client.cli.task  
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.thermos.cli.commands.commands   
 .   SUCCESS
 src.test.python.apache.thermos.cli.common  
 .   SUCCESS
 src.test.python.apache.thermos.cli.main
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE


   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 9:07 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 9:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> 

Re: Review Request 33959: Add update wait and update start --wait flag.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/
---

(Updated May 8, 2015, 9:07 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

Acted too quickly - fixed stdout strings in unit test.


Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239


Repository: aurora


Description
---

Add update watch and update start --watch flag.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
  src/main/python/apache/aurora/client/cli/update.py 
7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
968d456927de8044b8a8c5ca365464a8fedd3711 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
501d111f87dbaff8b6f22ffc67a9720b4dad 

Diff: https://reviews.apache.org/r/33959/diff/


Testing
---

Unit tests + end-to-end tests.


Thanks,

Bill Farner

Re: Review Request 33959: Add update wait and update start --wait flag.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83089
---

Ship it!


Ship It!

- Zameer Manji


On May 8, 2015, 1:57 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 1:57 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33999: Add missing binding to ThriftApiBenchmarks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33999/#review83088
---

Ship it!


Master (288f00b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 8:45 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33999/
> ---
> 
> (Updated May 8, 2015, 8:45 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Sorry for the whack-a-mole, these tests take a long time to run so i was 
> selecting specific ones to run.  I'll make sure the full suite is green 
> before i push this one.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
> ed1171d52655fef643330f34913c256f77300fa2 
> 
> Diff: https://reviews.apache.org/r/33999/diff/
> 
> 
> Testing
> ---
> 
> TODO(wfarner): Report back on result of ./gradlew jmh.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update wait and update start --wait flag.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/
---

(Updated May 8, 2015, 8:57 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Summary (updated)
-

Add update wait and update start --wait flag.


Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239


Repository: aurora


Description
---

Add update watch and update start --watch flag.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
  src/main/python/apache/aurora/client/cli/update.py 
7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
968d456927de8044b8a8c5ca365464a8fedd3711 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
501d111f87dbaff8b6f22ffc67a9720b4dad 

Diff: https://reviews.apache.org/r/33959/diff/


Testing
---

Unit tests + end-to-end tests.


Thanks,

Bill Farner

Re: Review Request 33959: Add update watch and update start --watch flag.

[Bill Farner]

> On May 8, 2015, 2:49 a.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 200
> > 
> >
> > Shouldn't we abort if the response is not OK? Also how does this work 
> > when the scheduler fails over?

Thanks, i meant to cover that.  Added the ceremonial 
`context.log_response_and_raise` call.  With regards to failover, it signals a 
problem if failover is considered this high in the stack.  In this case, it's 
dealt with in the API layer with retries based on the response (or lack thereof)


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82968
---


On May 8, 2015, 1:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 1:04 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33959: Add update watch and update start --watch flag.

[Bill Farner]

> On May 8, 2015, 1:08 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 205
> > 
> >
> > Since this is also used in "update wait" command, suggest reprhasing to 
> > something like "Current state". Otherwise, a command executed at arbitrary 
> > time may create a false assumption the update has _just_ entered that state.

Thanks, i wasn't crazy about the wording either.


> On May 8, 2015, 1:08 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 239
> > 
> >
> > drop pass

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82958
---


On May 8, 2015, 1:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 1:04 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 33999: Add missing binding to ThriftApiBenchmarks.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33999/
---

Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
---

Sorry for the whack-a-mole, these tests take a long time to run so i was 
selecting specific ones to run.  I'll make sure the full suite is green before 
i push this one.


Diffs
-

  src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
ed1171d52655fef643330f34913c256f77300fa2 

Diff: https://reviews.apache.org/r/33999/diff/


Testing
---

TODO(wfarner): Report back on result of ./gradlew jmh.


Thanks,

Bill Farner

Re: Review Request 33997: Improve GPG key validation for release verification script

[Joe Smith]

> On May 8, 2015, 1:23 p.m., Joshua Cohen wrote:
> > build-support/release/verify-release-candidate, line 81
> > 
> >
> > do we need to explicitly set this to /tmp? Won't it use TMPDIR by 
> > default?

It would use TMPDIR if we didn't set it to "" on line 67. Should we change 
TMPDIR to "./" ?


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/#review83068
---


On May 8, 2015, 1:20 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33997/
> ---
> 
> (Updated May 8, 2015, 1:20 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve GPG key validation for release verification script
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> f96d7c9239895e86d715ecec3c47b9ba828dbc30 
> 
> Diff: https://reviews.apache.org/r/33997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 33924: Adding missing API hook support in kill commands.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33924/#review83072
---

Ship it!


Ship It!

- Zameer Manji


On May 6, 2015, 6:28 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33924/
> ---
> 
> (Updated May 6, 2015, 6:28 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1307
> https://issues.apache.org/jira/browse/AURORA-1307
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added missing config options and refactored relevant tests.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> bd40410ccd0b02d0358e46eef015ce5d625c239f 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 6d82a7e7d97f7bf8621669ce76e24c9f4c1a371d 
>   src/main/python/apache/aurora/client/cli/options.py 
> d175e8cc061c305fe95ccfdc00f4b91cfa30ad96 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> f9facb6dfd22b578359a68435d3e72318f5f158c 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 09734a7981b0f41abd0c8667caf2b121a3205853 
>   src/test/python/apache/aurora/client/cli/util.py 
> 1fbf05009c298dfb854cec7b699e557eb1499a43 
> 
> Diff: https://reviews.apache.org/r/33924/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python:all
> Manual testing in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 33997: Improve GPG key validation for release verification script

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/#review83071
---

Ship it!


Master (288f00b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 8:20 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33997/
> ---
> 
> (Updated May 8, 2015, 8:20 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve GPG key validation for release verification script
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> f96d7c9239895e86d715ecec3c47b9ba828dbc30 
> 
> Diff: https://reviews.apache.org/r/33997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 33997: Improve GPG key validation for release verification script

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/#review83068
---



build-support/release/verify-release-candidate


do we need to explicitly set this to /tmp? Won't it use TMPDIR by default?


- Joshua Cohen


On May 8, 2015, 8:20 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33997/
> ---
> 
> (Updated May 8, 2015, 8:20 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve GPG key validation for release verification script
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> f96d7c9239895e86d715ecec3c47b9ba828dbc30 
> 
> Diff: https://reviews.apache.org/r/33997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Review Request 33997: Improve GPG key validation for release verification script

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Improve GPG key validation for release verification script


Diffs
-

  build-support/release/verify-release-candidate 
f96d7c9239895e86d715ecec3c47b9ba828dbc30 

Diff: https://reviews.apache.org/r/33997/diff/


Testing
---


Thanks,

Joe Smith

Re: Review Request 33994: Change RC verification script to use a temp dir.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/
---

(Updated May 8, 2015, 7:33 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

This sidesteps the too-long-shebang problem (see AURORA-1309), which remains 
and is likely to regress.


Diffs (updated)
-

  build-support/release/verify-release-candidate 
a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 

Diff: https://reviews.apache.org/r/33994/diff/


Testing
---

Successfully verified 0.8.0-rc1:
```
./build-support/release/verify-release-candidate 0.8.0-rc1
```


Thanks,

Bill Farner

Re: Review Request 33994: Change RC verification script to use a temp dir.

[Bill Farner]

> On May 8, 2015, 7:24 p.m., Kevin Sweeney wrote:
> > build-support/release/verify-release-candidate, line 59
> > 
> >
> > local dist_name=$1

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/#review83057
---


On May 8, 2015, 7:16 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33994/
> ---
> 
> (Updated May 8, 2015, 7:16 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This sidesteps the too-long-shebang problem (see AURORA-1309), which remains 
> and is likely to regress.
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 
> 
> Diff: https://reviews.apache.org/r/33994/diff/
> 
> 
> Testing
> ---
> 
> Successfully verified 0.8.0-rc1:
> ```
> ./build-support/release/verify-release-candidate 0.8.0-rc1
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33994: Change RC verification script to use a temp dir.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/#review83058
---

Ship it!


Master (8d8d75e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 7:16 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33994/
> ---
> 
> (Updated May 8, 2015, 7:16 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This sidesteps the too-long-shebang problem (see AURORA-1309), which remains 
> and is likely to regress.
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 
> 
> Diff: https://reviews.apache.org/r/33994/diff/
> 
> 
> Testing
> ---
> 
> Successfully verified 0.8.0-rc1:
> ```
> ./build-support/release/verify-release-candidate 0.8.0-rc1
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33994: Change RC verification script to use a temp dir.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/#review83057
---

Ship it!



build-support/release/verify-release-candidate


local dist_name=$1


- Kevin Sweeney


On May 8, 2015, 12:16 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33994/
> ---
> 
> (Updated May 8, 2015, 12:16 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This sidesteps the too-long-shebang problem (see AURORA-1309), which remains 
> and is likely to regress.
> 
> 
> Diffs
> -
> 
>   build-support/release/verify-release-candidate 
> a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 
> 
> Diff: https://reviews.apache.org/r/33994/diff/
> 
> 
> Testing
> ---
> 
> Successfully verified 0.8.0-rc1:
> ```
> ./build-support/release/verify-release-candidate 0.8.0-rc1
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33994: Change RC verification script to use a temp dir.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/
---

(Updated May 8, 2015, 7:16 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

This sidesteps the too-long-shebang problem (see AURORA-1309), which remains 
and is likely to regress.


Diffs
-

  build-support/release/verify-release-candidate 
a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 

Diff: https://reviews.apache.org/r/33994/diff/


Testing (updated)
---

Successfully verified 0.8.0-rc1:
```
./build-support/release/verify-release-candidate 0.8.0-rc1
```


Thanks,

Bill Farner

Review Request 33994: Change RC verification script to use a temp dir.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33994/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

This sidesteps the too-long-shebang problem (see AURORA-1309), which remains 
and is likely to regress.


Diffs
-

  build-support/release/verify-release-candidate 
a0f717957d285c40ada3cd3b8a14f0dc11b6df1d 

Diff: https://reviews.apache.org/r/33994/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33991/#review83040
---

Ship it!


Master (8157181) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 6:10 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33991/
> ---
> 
> (Updated May 8, 2015, 6:10 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1315
> https://issues.apache.org/jira/browse/AURORA-1315
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a StatsProvider binding to UpdateStoreBenchmarks.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
> 4cc53d8bc9a64a8f5d574e53f9ad98f37cdeff21 
> 
> Diff: https://reviews.apache.org/r/33991/diff/
> 
> 
> Testing
> ---
> 
> Successfully ran `./gradlew jmh -Pbenchmarks='UpdateStoreBenchmarks'`.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33991/#review83038
---

Ship it!


Ship It!

- Joshua Cohen


On May 8, 2015, 6:10 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33991/
> ---
> 
> (Updated May 8, 2015, 6:10 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1315
> https://issues.apache.org/jira/browse/AURORA-1315
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a StatsProvider binding to UpdateStoreBenchmarks.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
> 4cc53d8bc9a64a8f5d574e53f9ad98f37cdeff21 
> 
> Diff: https://reviews.apache.org/r/33991/diff/
> 
> 
> Testing
> ---
> 
> Successfully ran `./gradlew jmh -Pbenchmarks='UpdateStoreBenchmarks'`.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33991/
---

(Updated May 8, 2015, 6:10 p.m.)


Review request for Aurora and Joshua Cohen.


Bugs: AURORA-1315
https://issues.apache.org/jira/browse/AURORA-1315


Repository: aurora


Description
---

Add a StatsProvider binding to UpdateStoreBenchmarks.


Diffs
-

  src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
4cc53d8bc9a64a8f5d574e53f9ad98f37cdeff21 

Diff: https://reviews.apache.org/r/33991/diff/


Testing
---

Successfully ran `./gradlew jmh -Pbenchmarks='UpdateStoreBenchmarks'`.


Thanks,

Bill Farner

Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33991/
---

Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
---

Add a StatsProvider binding to UpdateStoreBenchmarks.


Diffs
-

  src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
4cc53d8bc9a64a8f5d574e53f9ad98f37cdeff21 

Diff: https://reviews.apache.org/r/33991/diff/


Testing
---

Successfully ran `./gradlew jmh -Pbenchmarks='UpdateStoreBenchmarks'`.


Thanks,

Bill Farner