Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34300/#review88188
---

Ship it!


Ship It!

- Joe Smith


On June 1, 2015, 11:05 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34300/
> ---
> 
> (Updated June 1, 2015, 11:05 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-739
> https://issues.apache.org/jira/browse/AURORA-739
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> It's possible to define nested refs that can cause the executor to stack 
> trace, e.g.
> {{derp[{{thermos.ports[http]}}]}} is perfectly valid but crashes the executor.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/config/__init__.py 
> dd2f89014a3da730364b14e01c499ac0f2c288c1 
>   src/main/python/apache/aurora/config/schema/base.py 
> a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 
>   src/main/python/apache/aurora/config/thrift.py 
> 810febb637d168b07c4aea77984e1d1451a39af2 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> d110faf08135d94d9af95ad74613950c56248c09 
>   src/main/python/apache/thermos/config/dsl.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/main/python/apache/thermos/config/loader.py 
> d77ab9a52b16e9d65acdb95f01fd251ae8ab2b6e 
>   src/test/python/apache/aurora/client/test_config.py 
> c56779712b91f621261358aa7ebd6c4fc65446a0 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 654c0b5ae82c98db163c7a44301ff6b23e19b211 
>   src/test/python/apache/aurora/executor/common/test_task_info.py 
> 102ba531aa6c28f2d74bd0d7f1668e5861e3a6b8 
> 
> Diff: https://reviews.apache.org/r/34300/diff/
> 
> 
> Testing
> ---
> 
> Added some regression tests.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 35527: Making observer polling interval configurable.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88154
---

Ship it!


Ship It!

- Joshua Cohen


On June 16, 2015, 10:18 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35527/
> ---
> 
> (Updated June 16, 2015, 10:18 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Bugs: AURORA-1351
> https://issues.apache.org/jira/browse/AURORA-1351
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Making observer polling interval configurable.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 
> 4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 
>   src/main/python/apache/thermos/observer/task_observer.py 
> b9a37de0f6260dc8c0a6ba92119c57e16f29d82c 
>   src/test/python/apache/aurora/BUILD 
> 0701440ae47034c580b5baae40e5f6feec4bb4fd 
>   src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
> PRE-CREATION 
>   src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35527/diff/
> 
> 
> Testing
> ---
> 
> ./pants --test.pytest --no-fast src/test/python::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35527: Making observer polling interval configurable.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88153
---

Ship it!


Master (ea2c9ad) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 16, 2015, 10:18 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35527/
> ---
> 
> (Updated June 16, 2015, 10:18 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Bugs: AURORA-1351
> https://issues.apache.org/jira/browse/AURORA-1351
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Making observer polling interval configurable.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 
> 4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 
>   src/main/python/apache/thermos/observer/task_observer.py 
> b9a37de0f6260dc8c0a6ba92119c57e16f29d82c 
>   src/test/python/apache/aurora/BUILD 
> 0701440ae47034c580b5baae40e5f6feec4bb4fd 
>   src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
> PRE-CREATION 
>   src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35527/diff/
> 
> 
> Testing
> ---
> 
> ./pants --test.pytest --no-fast src/test/python::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35527: Making observer polling interval configurable.

[Maxim Khutornenko]

> On June 16, 2015, 10:25 p.m., Brian Wickman wrote:
> > src/test/python/apache/thermos/observer/test_task_observer.py, lines 37-38
> > 
> >
> > while ugly, should probably change pass to time.sleep(0.01) so that 
> > MainThread yields to the observer thread to make forward progress.

The busy wait loop relying on the mock_call count works just fine here 
producing the same 0.29sec run as the one with time.sleep(0.01). Is there a 
particular concern you have in mind?


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88144
---


On June 16, 2015, 10:18 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35527/
> ---
> 
> (Updated June 16, 2015, 10:18 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Bugs: AURORA-1351
> https://issues.apache.org/jira/browse/AURORA-1351
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Making observer polling interval configurable.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 
> 4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 
>   src/main/python/apache/thermos/observer/task_observer.py 
> b9a37de0f6260dc8c0a6ba92119c57e16f29d82c 
>   src/test/python/apache/aurora/BUILD 
> 0701440ae47034c580b5baae40e5f6feec4bb4fd 
>   src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
> PRE-CREATION 
>   src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35527/diff/
> 
> 
> Testing
> ---
> 
> ./pants --test.pytest --no-fast src/test/python::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35527: Making observer polling interval configurable.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88144
---

Ship it!



src/test/python/apache/thermos/observer/test_task_observer.py (lines 37 - 38)


while ugly, should probably change pass to time.sleep(0.01) so that 
MainThread yields to the observer thread to make forward progress.


- Brian Wickman


On June 16, 2015, 10:18 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35527/
> ---
> 
> (Updated June 16, 2015, 10:18 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Bugs: AURORA-1351
> https://issues.apache.org/jira/browse/AURORA-1351
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Making observer polling interval configurable.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 
> 4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 
>   src/main/python/apache/thermos/observer/task_observer.py 
> b9a37de0f6260dc8c0a6ba92119c57e16f29d82c 
>   src/test/python/apache/aurora/BUILD 
> 0701440ae47034c580b5baae40e5f6feec4bb4fd 
>   src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
> PRE-CREATION 
>   src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35527/diff/
> 
> 
> Testing
> ---
> 
> ./pants --test.pytest --no-fast src/test/python::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35527: Making observer polling interval configurable.

[Maxim Khutornenko]

> On June 16, 2015, 9:33 p.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py, 
> > lines 27-30
> > 
> >
> > There's a way to set this up so that only these expected properties are 
> > accessed, right? Is it by doing `Mock(spec_set=['root','mesos_root',...])`?
> > 
> > In any event, we should probably do that?

The option set is really irrelevant here but I don't have a strong opinion. 
Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88130
---


On June 16, 2015, 8:50 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35527/
> ---
> 
> (Updated June 16, 2015, 8:50 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Bugs: AURORA-1351
> https://issues.apache.org/jira/browse/AURORA-1351
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Making observer polling interval configurable.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 
> 4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 
>   src/main/python/apache/thermos/observer/task_observer.py 
> b9a37de0f6260dc8c0a6ba92119c57e16f29d82c 
>   src/test/python/apache/aurora/BUILD 
> 0701440ae47034c580b5baae40e5f6feec4bb4fd 
>   src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
> PRE-CREATION 
>   src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35527/diff/
> 
> 
> Testing
> ---
> 
> ./pants --test.pytest --no-fast src/test/python::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35527: Making observer polling interval configurable.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/
---

(Updated June 16, 2015, 10:18 p.m.)


Review request for Aurora, Joshua Cohen and Brian Wickman.


Changes
---

Joshua's comments.


Bugs: AURORA-1351
https://issues.apache.org/jira/browse/AURORA-1351


Repository: aurora


Description
---

Making observer polling interval configurable.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos_observer.py 
4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 
  src/main/python/apache/thermos/observer/task_observer.py 
b9a37de0f6260dc8c0a6ba92119c57e16f29d82c 
  src/test/python/apache/aurora/BUILD 0701440ae47034c580b5baae40e5f6feec4bb4fd 
  src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
PRE-CREATION 
  src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 

Diff: https://reviews.apache.org/r/35527/diff/


Testing
---

./pants --test.pytest --no-fast src/test/python::


Thanks,

Maxim Khutornenko

Re: Review Request 35535: Use Shiro identity if available in audit logs.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
---

(Updated June 16, 2015, 3:06 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Changes
---

Review feedback.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Use Shiro identity if available in audit logs.


Diffs (updated)
-

  config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
912e465793b42c81040a8cfe507c2e341932c205 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/35535/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 35535: Use Shiro identity if available in audit logs.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/#review88139
---

Ship it!


Ship It!

- Maxim Khutornenko


On June 16, 2015, 9:54 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35535/
> ---
> 
> (Updated June 16, 2015, 9:54 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1352
> https://issues.apache.org/jira/browse/AURORA-1352
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use Shiro identity if available in audit logs.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
>   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
> 912e465793b42c81040a8cfe507c2e341932c205 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35535/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 35535: Use Shiro identity if available in audit logs.

[Maxim Khutornenko]

> On June 16, 2015, 9:54 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java, line 34
> > 
> >
> > Should this move to UnsecureSessionContext?

+1


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/#review88136
---


On June 16, 2015, 9:54 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35535/
> ---
> 
> (Updated June 16, 2015, 9:54 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1352
> https://issues.apache.org/jira/browse/AURORA-1352
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use Shiro identity if available in audit logs.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
>   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
> 912e465793b42c81040a8cfe507c2e341932c205 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35535/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 35535: Use Shiro identity if available in audit logs.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/#review88136
---

Ship it!



src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java (line 34)


Should this move to UnsecureSessionContext?


- Joshua Cohen


On June 16, 2015, 9:54 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35535/
> ---
> 
> (Updated June 16, 2015, 9:54 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1352
> https://issues.apache.org/jira/browse/AURORA-1352
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use Shiro identity if available in audit logs.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
>   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
> 912e465793b42c81040a8cfe507c2e341932c205 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35535/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 35535: Use Shiro identity if available in audit logs.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
---

(Updated June 16, 2015, 2:54 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Changes
---

Use map instead of ofNullable within flatMap.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Use Shiro identity if available in audit logs.


Diffs (updated)
-

  config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
912e465793b42c81040a8cfe507c2e341932c205 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/35535/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Review Request 35535: Use Shiro identity if available in audit logs.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35535/
---

Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-1352
https://issues.apache.org/jira/browse/AURORA-1352


Repository: aurora


Description
---

Use Shiro identity if available in audit logs.


Diffs
-

  config/legacy_untested_classes.txt f50b812459bd6b59d1a03e6814caa2daae133fe9 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
912e465793b42c81040a8cfe507c2e341932c205 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java PRE-CREATION 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/35535/diff/


Testing
---

./gradlew -Pq build


Thanks,

Kevin Sweeney

Re: Review Request 35527: Making observer polling interval configurable.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88130
---



src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py (lines 
27 - 30)


There's a way to set this up so that only these expected properties are 
accessed, right? Is it by doing `Mock(spec_set=['root','mesos_root',...])`?

In any event, we should probably do that?


- Joshua Cohen


On June 16, 2015, 8:50 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35527/
> ---
> 
> (Updated June 16, 2015, 8:50 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Bugs: AURORA-1351
> https://issues.apache.org/jira/browse/AURORA-1351
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Making observer polling interval configurable.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 
> 4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 
>   src/main/python/apache/thermos/observer/task_observer.py 
> b9a37de0f6260dc8c0a6ba92119c57e16f29d82c 
>   src/test/python/apache/aurora/BUILD 
> 0701440ae47034c580b5baae40e5f6feec4bb4fd 
>   src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
> PRE-CREATION 
>   src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35527/diff/
> 
> 
> Testing
> ---
> 
> ./pants --test.pytest --no-fast src/test/python::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 35527: Making observer polling interval configurable.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88127
---

Ship it!


Master (b09adc6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 16, 2015, 8:50 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35527/
> ---
> 
> (Updated June 16, 2015, 8:50 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Brian Wickman.
> 
> 
> Bugs: AURORA-1351
> https://issues.apache.org/jira/browse/AURORA-1351
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Making observer polling interval configurable.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 
> 4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 
>   src/main/python/apache/thermos/observer/task_observer.py 
> b9a37de0f6260dc8c0a6ba92119c57e16f29d82c 
>   src/test/python/apache/aurora/BUILD 
> 0701440ae47034c580b5baae40e5f6feec4bb4fd 
>   src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
> PRE-CREATION 
>   src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35527/diff/
> 
> 
> Testing
> ---
> 
> ./pants --test.pytest --no-fast src/test/python::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 35527: Making observer polling interval configurable.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/
---

Review request for Aurora, Joshua Cohen and Brian Wickman.


Bugs: AURORA-1351
https://issues.apache.org/jira/browse/AURORA-1351


Repository: aurora


Description
---

Making observer polling interval configurable.


Diffs
-

  src/main/python/apache/aurora/tools/__init__.py PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos_observer.py 
4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 
  src/main/python/apache/thermos/observer/task_observer.py 
b9a37de0f6260dc8c0a6ba92119c57e16f29d82c 
  src/test/python/apache/aurora/BUILD 0701440ae47034c580b5baae40e5f6feec4bb4fd 
  src/test/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py 
PRE-CREATION 
  src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION 

Diff: https://reviews.apache.org/r/35527/diff/


Testing
---

./pants --test.pytest --no-fast src/test/python::


Thanks,

Maxim Khutornenko

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/#review88053
---

Ship it!


Master (b09adc6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 16, 2015, 9:12 a.m., Brian Brazil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32973/
> ---
> 
> (Updated June 16, 2015, 9:12 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1257
> https://issues.apache.org/jira/browse/AURORA-1257
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix name of test for sigterm being ignored.
> 
> Based on 
> https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
>   src/main/python/apache/aurora/common/http_signaler.py 
> 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 837ad5c55b4a02215a8d509c211e80529536f705 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/test/python/apache/aurora/common/test_http_signaler.py 
> c6a21708eb997f213f4cca038891a84f6c5218d4 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf 
> 
> Diff: https://reviews.apache.org/r/32973/diff/
> 
> 
> Testing
> ---
> 
> Unittests and manually in vagrant cluster. Also verified that the flaky tests 
> pass.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>

Re: Review Request 35498: Compute SLA stats for non-prod jobs

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/#review88044
---

Ship it!


Master (b09adc6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 16, 2015, 9:07 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35498/
> ---
> 
> (Updated June 16, 2015, 9:07 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1350
> https://issues.apache.org/jira/browse/AURORA-1350
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Compute SLA stats for non-prod jobs
> 
> This is a first iteration closely following the design proposal of Maxim as 
> posted on the mailinglist. Feedback welcome.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 82f36d5ca15df18bdc8ebbbd868d3394db38e603 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 64e986fb2e0f955dd4a9c7824eac9494728bf24e 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> cb98834e925793fc116814371548a30470830164 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 
> 
> Diff: https://reviews.apache.org/r/35498/diff/
> 
> 
> Testing
> ---
> 
> `./gradlew -Pq build` and a manual verification in Vagrant.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

[Brian Brazil]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/
---

(Updated June 16, 2015, 9:12 a.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
---

Fix grammar in docs.


Bugs: AURORA-1257
https://issues.apache.org/jira/browse/AURORA-1257


Repository: aurora


Description
---

Fix name of test for sigterm being ignored.

Based on 
https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34


Diffs (updated)
-

  docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
  src/main/python/apache/aurora/common/http_signaler.py 
531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
837ad5c55b4a02215a8d509c211e80529536f705 
  src/main/python/apache/thermos/config/schema_base.py 
f9143cc1b83143d6147f59d90c79435d055d0518 
  src/test/python/apache/aurora/common/test_http_signaler.py 
c6a21708eb997f213f4cca038891a84f6c5218d4 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf 

Diff: https://reviews.apache.org/r/32973/diff/


Testing
---

Unittests and manually in vagrant cluster. Also verified that the flaky tests 
pass.


Thanks,

Brian Brazil

Re: Review Request 35498: Compute SLA stats for non-prod jobs

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/
---

(Updated June 16, 2015, 11:07 a.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-1350
https://issues.apache.org/jira/browse/AURORA-1350


Repository: aurora


Description
---

Compute SLA stats for non-prod jobs

This is a first iteration closely following the design proposal of Maxim as 
posted on the mailinglist. Feedback welcome.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
82f36d5ca15df18bdc8ebbbd868d3394db38e603 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
  src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
64e986fb2e0f955dd4a9c7824eac9494728bf24e 
  src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
cb98834e925793fc116814371548a30470830164 
  src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 

Diff: https://reviews.apache.org/r/35498/diff/


Testing
---

`./gradlew -Pq build` and a manual verification in Vagrant.


Thanks,

Stephan Erb

Re: Review Request 35498: Compute SLA stats for non-prod jobs

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/#review88042
---



src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java (line 57)


I could change the command line to take a list of  SLA statistic enums to 
enable. This should help to greatly reduce the overall boilerplate. What do you 
think?



src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java (line 
65)


Using a list of enums instead of serveral bools will also help to simplify 
this code.


- Stephan Erb


On June 16, 2015, 11 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35498/
> ---
> 
> (Updated June 16, 2015, 11 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Compute SLA stats for non-prod jobs
> 
> This is a first iteration closely following the design proposal of Maxim as 
> posted on the mailinglist. Feedback welcome.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 82f36d5ca15df18bdc8ebbbd868d3394db38e603 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 64e986fb2e0f955dd4a9c7824eac9494728bf24e 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> cb98834e925793fc116814371548a30470830164 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 
> 
> Diff: https://reviews.apache.org/r/35498/diff/
> 
> 
> Testing
> ---
> 
> `./gradlew -Pq build` and a manual verification in Vagrant.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 35498: Compute SLA stats for non-prod jobs

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/
---

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Repository: aurora


Description
---

Compute SLA stats for non-prod jobs

This is a first iteration closely following the design proposal of Maxim as 
posted on the mailinglist. Feedback welcome.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
82f36d5ca15df18bdc8ebbbd868d3394db38e603 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
  src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
64e986fb2e0f955dd4a9c7824eac9494728bf24e 
  src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
cb98834e925793fc116814371548a30470830164 
  src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 

Diff: https://reviews.apache.org/r/35498/diff/


Testing
---

`./gradlew -Pq build` and a manual verification in Vagrant.


Thanks,

Stephan Erb