Re: Review Request 36700: Remove references to binary build targets that are not currently for general consumption.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/#review93624 --- I'm abandoning this review. The time spent trying to achieve consensus has exceeded the value. I suggest users look to forthcoming binary packages to insulate from build refactors in the future. - Bill Farner On July 28, 2015, 12:58 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/ --- (Updated July 28, 2015, 12:58 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: AURORA-1381 https://issues.apache.org/jira/browse/AURORA-1381 Repository: aurora Description --- The meaning of the targets under `src/main/python/apache/thermos/cli/bin/BUILD` and `src/main/python/apache/thermos/observer/bin/BUILD` changed recently, which bit several people (including our own packaging). This removes targets that Aurora users should not be consuming. Diffs - README.md f3b23247cf3f7e550c1714b4fb8227a2baab3b41 build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 build-support/packaging/debian/rules 23828c02b73f007393d2ed4ce69c010cebf07e57 build-support/packaging/rpm/aurora.spec 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 build-support/release/make-python-sdists 9608f68e16243da01434ce2fc7d61bb7c7efd712 Diff: https://reviews.apache.org/r/36700/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (as far as it currently gets on master, anyhow, due to AURORA-1409) Thanks, Bill Farner
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
On July 30, 2015, 5:22 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243 https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243 Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. Aha, gotcha- no worries, I'll update the ticket and discard this. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93682 --- On July 30, 2015, 5:14 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 5:14 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93665 --- Ship it! src/main/java/org/apache/aurora/scheduler/TaskVars.java (line 255) https://reviews.apache.org/r/34020/#comment148076 This is not generally the right thing to do, as jdk logging allows you to configure this externally with configuration. However, i don't see a great alternative that allows us to pick a sane default for other users of the software. Please at least leave a TODO here and in the other file indicating why you're doing this. - Bill Farner On July 30, 2015, 10:02 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:02 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 5:14 p.m.) Review request for Aurora and Bill Farner. Changes --- Updated with a TODO to remove, happy to update if that doesn't seem clear Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 3:02 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing (updated) --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 3:02 p.m.) Review request for Aurora and Bill Farner. Changes --- Moved the stats change to the inner class (not sure if this is ~good or not, feedback welcome). Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93682 --- src/main/java/org/apache/aurora/scheduler/TaskVars.java (line 243) https://reviews.apache.org/r/34020/#comment148097 Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. - Bill Farner On July 31, 2015, 12:14 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 31, 2015, 12:14 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Review Request 36972: One python_library per exported setup.py project
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-1381 https://issues.apache.org/jira/browse/AURORA-1381 Repository: aurora Description --- Publishing this review now for early feedback, don't intend to ship until most of the TODOs are addressed. This is a mostly red code diff and makes the pants build work similar to how it already works in an IDE environment while minimizing duplicated information. This change also removes the confusing versions of `thermos` and `thermos_observer` in favor of new ones. Because of the way covering dependencies were required it was easier to do this refactor than more tactically create a working `setup_py` target for `apache.aurora.tools` without cycles and without duplicated files. * Remove the `apache.thermos` package. * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`. * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`. * Introduce a new `apache.aurora.tools` package. * Create apache.thermos.runner package, rename `thermos/bin` to `thermos/runner`. * Remove all `*-packaged` and virtual dependency trees, as well as the phrase covering dependencies. * Use `_`-prefix naming convention for private target names. * Replace manual list of targets in `make-python-sdists` with automatically-generated one (using new convention). * Remove `kaurora` and `kaurora_admin` binaries. * Remove all `BUILD` files in `src/main` that don't contain an exported `setup.py` library (except one mentioned in TODO). * Use dictionary syntax in `with_binaries` (TODO: replace the underscores in binary names with dashes?). * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`). * Create blank `__init__.py` files in directories that pants warns aren't packages. * TODO: Write NEWS entry Diffs - api/src/main/thrift/org/apache/aurora/gen/BUILD d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 api/src/main/thrift/org/apache/thermos/BUILD d0d789a6ee3971e3070f9397d53929563a77f7ea build-support/release/make-python-sdists 9608f68e16243da01434ce2fc7d61bb7c7efd712 src/main/python/apache/aurora/admin/BUILD 22bf3f9943ea11258ba681bdb80feb00206bb926 src/main/python/apache/aurora/client/BUILD e73cd52289209bb9658b16bb77dc0b0a9c811a1a src/main/python/apache/aurora/client/api/BUILD a030a67b78fc4bc4682d0df169e27efc6810dce3 src/main/python/apache/aurora/client/cli/BUILD 973d05971bd940c7e38c48ce6bfbf5c8e1654c5a src/main/python/apache/aurora/client/hooks/BUILD ddf813b5d2e7d63507a8e08745ebf6cb3dbac8e1 src/main/python/apache/aurora/common/BUILD abc122b0775bb17b1df67bdb946c472010219b9b src/main/python/apache/aurora/common/auth/BUILD 0abac94eeeb71e6af43ed191ea690e5f96a6be23 src/main/python/apache/aurora/config/BUILD 0a3a93fa6bb785903f71bc067aecc79c0e45a0b5 src/main/python/apache/aurora/config/schema/BUILD 171f42a24ec7ddc2846eb68b6a60e7d8dec4383b src/main/python/apache/aurora/executor/BUILD 891cbe63d23ea59a68ca99f62d29be5713c9b91d src/main/python/apache/aurora/executor/bin/BUILD b23429ab9d1d3db1af2bb1b77f5bce30de19f34b src/main/python/apache/aurora/executor/common/BUILD 3d94792b9e3c2d0f7bb7ce42616f08947f5119ee src/main/python/apache/aurora/tools/BUILD 9dfeb6c7e5a3796c76250aa9ff6fd4230d00cfb0 src/main/python/apache/thermos/BUILD 8221aa0bd4efe5f519550cba716d6a564ba9ae44 src/main/python/apache/thermos/bin/BUILD 4f0cb9b67b1c3c52ec3278ce92ff0d765257796c src/main/python/apache/thermos/bin/__init__.py src/main/python/apache/thermos/bin/thermos_ckpt.py 8ed69e0440b6aec85c5fa9e138215b592e9adcb1 src/main/python/apache/thermos/bin/thermos_runner.py src/main/python/apache/thermos/cli/BUILD 2b9bc6245718397e4cb1ba104194b167434a3112 src/main/python/apache/thermos/cli/bin/BUILD f33c7f838a6a0932abc737d0ecf7ca3a59580e2e src/main/python/apache/thermos/cli/bin/thermos.py fcef38d33e7ca2005f35c3bdb90ffee6aeade3af src/main/python/apache/thermos/cli/commands/BUILD 552eeb4f61693033d8828e789bd22e680b957d1d src/main/python/apache/thermos/common/BUILD 942fc15f5a5d6a5ff58385b10f3783ac476a4f82 src/main/python/apache/thermos/config/BUILD d9099c5806eadb1190d2028142a7ec711023d39f src/main/python/apache/thermos/config/bin/config_load.py d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e src/main/python/apache/thermos/config/bin/config_repl.py ae9ca3b2812f719b0a6185081434d557492ac825 src/main/python/apache/thermos/core/BUILD d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea src/main/python/apache/thermos/monitoring/BUILD e8851026cb7ff59f0fd719837fdb0110be356c31 src/main/python/apache/thermos/observer/BUILD 41db2cc2e11234c434f58f55abec0b9f308096be src/main/python/apache/thermos/observer/bin/BUILD 0abe2ccfe9c5ccb509ad731125385900114ba352
Re: Review Request 36972: One python_library per exported setup.py project
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93695 --- Master (d327773) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 31, 2015, 2:32 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- (Updated July 31, 2015, 2:32 a.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-1381 https://issues.apache.org/jira/browse/AURORA-1381 Repository: aurora Description --- Publishing this review now for early feedback, don't intend to ship until most of the TODOs are addressed. This is a mostly red code diff and makes the pants build work similar to how it already works in an IDE environment while minimizing duplicated information. This change also removes the confusing versions of `thermos` and `thermos_observer` in favor of new ones. Because of the way covering dependencies were required it was easier to do this refactor than more tactically create a working `setup_py` target for `apache.aurora.tools` without cycles and without duplicated files. * Remove the `apache.thermos` package. * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`. * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`. * Introduce a new `apache.aurora.tools` package. * Create apache.thermos.runner package, rename `thermos/bin` to `thermos/runner`. * Remove all `*-packaged` and virtual dependency trees, as well as the phrase covering dependencies. * Use `_`-prefix naming convention for private target names. * Replace manual list of targets in `make-python-sdists` with automatically-generated one (using new convention). * Remove `kaurora` and `kaurora_admin` binaries. * Remove all `BUILD` files in `src/main` that don't contain an exported `setup.py` library (except one mentioned in TODO). * Use dictionary syntax in `with_binaries` (TODO: replace the underscores in binary names with dashes?). * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`). * Create blank `__init__.py` files in directories that pants warns aren't packages. * TODO: Write NEWS entry Diffs - api/src/main/thrift/org/apache/aurora/gen/BUILD d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 api/src/main/thrift/org/apache/thermos/BUILD d0d789a6ee3971e3070f9397d53929563a77f7ea build-support/release/make-python-sdists 9608f68e16243da01434ce2fc7d61bb7c7efd712 src/main/python/apache/aurora/admin/BUILD 22bf3f9943ea11258ba681bdb80feb00206bb926 src/main/python/apache/aurora/client/BUILD e73cd52289209bb9658b16bb77dc0b0a9c811a1a src/main/python/apache/aurora/client/api/BUILD a030a67b78fc4bc4682d0df169e27efc6810dce3 src/main/python/apache/aurora/client/cli/BUILD 973d05971bd940c7e38c48ce6bfbf5c8e1654c5a src/main/python/apache/aurora/client/hooks/BUILD ddf813b5d2e7d63507a8e08745ebf6cb3dbac8e1 src/main/python/apache/aurora/common/BUILD abc122b0775bb17b1df67bdb946c472010219b9b src/main/python/apache/aurora/common/auth/BUILD 0abac94eeeb71e6af43ed191ea690e5f96a6be23 src/main/python/apache/aurora/config/BUILD 0a3a93fa6bb785903f71bc067aecc79c0e45a0b5 src/main/python/apache/aurora/config/schema/BUILD 171f42a24ec7ddc2846eb68b6a60e7d8dec4383b src/main/python/apache/aurora/executor/BUILD 891cbe63d23ea59a68ca99f62d29be5713c9b91d src/main/python/apache/aurora/executor/bin/BUILD b23429ab9d1d3db1af2bb1b77f5bce30de19f34b src/main/python/apache/aurora/executor/common/BUILD 3d94792b9e3c2d0f7bb7ce42616f08947f5119ee src/main/python/apache/aurora/tools/BUILD 9dfeb6c7e5a3796c76250aa9ff6fd4230d00cfb0 src/main/python/apache/thermos/BUILD 8221aa0bd4efe5f519550cba716d6a564ba9ae44 src/main/python/apache/thermos/bin/BUILD 4f0cb9b67b1c3c52ec3278ce92ff0d765257796c src/main/python/apache/thermos/bin/__init__.py src/main/python/apache/thermos/bin/thermos_ckpt.py 8ed69e0440b6aec85c5fa9e138215b592e9adcb1 src/main/python/apache/thermos/bin/thermos_runner.py src/main/python/apache/thermos/cli/BUILD 2b9bc6245718397e4cb1ba104194b167434a3112 src/main/python/apache/thermos/cli/bin/BUILD f33c7f838a6a0932abc737d0ecf7ca3a59580e2e src/main/python/apache/thermos/cli/bin/thermos.py fcef38d33e7ca2005f35c3bdb90ffee6aeade3af src/main/python/apache/thermos/cli/commands/BUILD 552eeb4f61693033d8828e789bd22e680b957d1d src/main/python/apache/thermos/common/BUILD
Re: Review Request 36972: One python_library per exported setup.py project
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- (Updated July 30, 2015, 8:37 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- RPMs, DEBs, and e2e test Bugs: AURORA-1381 https://issues.apache.org/jira/browse/AURORA-1381 Repository: aurora Description (updated) --- Publishing this review now for early feedback, don't intend to ship until most of the TODOs are addressed. This is a mostly red code diff and makes the pants build work similar to how it already works in an IDE environment while minimizing duplicated information. This change also removes the confusing versions of `thermos` and `thermos_observer` in favor of new ones. Because of the way covering dependencies were required it was easier to do this refactor than more tactically create a working `setup_py` target for `apache.aurora.tools` without cycles and without duplicated files. * Remove the `apache.thermos` package. * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`. * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`. * Introduce a new `apache.aurora.tools` package. * Create apache.thermos.runner package, rename `thermos/bin` to `thermos/runner`. * Remove all `*-packaged` and virtual dependency trees, as well as the phrase covering dependencies. * Use `_`-prefix naming convention for private target names. * Replace manual list of targets in `make-python-sdists` with automatically-generated one (using new convention). * Remove `kaurora` and `kaurora_admin` binaries. * Remove all `BUILD` files in `src/main` that don't contain an exported `setup.py` library (except one mentioned in TODO). * Use dictionary syntax in `with_binaries` (TODO: replace the underscores in binary names with dashes?). * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`). * Create blank `__init__.py` files in directories that pants warns aren't packages. * Added `krb5-devel` to rpm spec `BuildRequires` * Added `thermos` command to vagrant image. * TODO: Write NEWS entry Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/BUILD d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 api/src/main/thrift/org/apache/thermos/BUILD d0d789a6ee3971e3070f9397d53929563a77f7ea build-support/packaging/debian/rules 17e00c02a3cb3294d5107516d795a73587ca4f70 build-support/packaging/rpm/aurora.spec 7cf8de6f7b99788ca461a90fc4aefba7dccd7b63 build-support/release/make-python-sdists 9608f68e16243da01434ce2fc7d61bb7c7efd712 examples/vagrant/aurorabuild.sh fbaa6ae9ef7ff2910af8c9c0d6b8ef90ea3e152a src/main/python/apache/aurora/admin/BUILD 22bf3f9943ea11258ba681bdb80feb00206bb926 src/main/python/apache/aurora/client/BUILD e73cd52289209bb9658b16bb77dc0b0a9c811a1a src/main/python/apache/aurora/client/api/BUILD a030a67b78fc4bc4682d0df169e27efc6810dce3 src/main/python/apache/aurora/client/cli/BUILD 973d05971bd940c7e38c48ce6bfbf5c8e1654c5a src/main/python/apache/aurora/client/hooks/BUILD ddf813b5d2e7d63507a8e08745ebf6cb3dbac8e1 src/main/python/apache/aurora/common/BUILD abc122b0775bb17b1df67bdb946c472010219b9b src/main/python/apache/aurora/common/auth/BUILD 0abac94eeeb71e6af43ed191ea690e5f96a6be23 src/main/python/apache/aurora/config/BUILD 0a3a93fa6bb785903f71bc067aecc79c0e45a0b5 src/main/python/apache/aurora/config/schema/BUILD 171f42a24ec7ddc2846eb68b6a60e7d8dec4383b src/main/python/apache/aurora/executor/BUILD 891cbe63d23ea59a68ca99f62d29be5713c9b91d src/main/python/apache/aurora/executor/bin/BUILD b23429ab9d1d3db1af2bb1b77f5bce30de19f34b src/main/python/apache/aurora/executor/common/BUILD 3d94792b9e3c2d0f7bb7ce42616f08947f5119ee src/main/python/apache/aurora/tools/BUILD 9dfeb6c7e5a3796c76250aa9ff6fd4230d00cfb0 src/main/python/apache/thermos/BUILD 8221aa0bd4efe5f519550cba716d6a564ba9ae44 src/main/python/apache/thermos/bin/BUILD 4f0cb9b67b1c3c52ec3278ce92ff0d765257796c src/main/python/apache/thermos/bin/__init__.py src/main/python/apache/thermos/bin/thermos_ckpt.py 8ed69e0440b6aec85c5fa9e138215b592e9adcb1 src/main/python/apache/thermos/bin/thermos_runner.py src/main/python/apache/thermos/cli/BUILD 2b9bc6245718397e4cb1ba104194b167434a3112 src/main/python/apache/thermos/cli/bin/BUILD f33c7f838a6a0932abc737d0ecf7ca3a59580e2e src/main/python/apache/thermos/cli/bin/thermos.py fcef38d33e7ca2005f35c3bdb90ffee6aeade3af src/main/python/apache/thermos/cli/commands/BUILD 552eeb4f61693033d8828e789bd22e680b957d1d src/main/python/apache/thermos/common/BUILD 942fc15f5a5d6a5ff58385b10f3783ac476a4f82 src/main/python/apache/thermos/config/BUILD d9099c5806eadb1190d2028142a7ec711023d39f src/main/python/apache/thermos/config/bin/config_load.py d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e
Review Request 36945: Use the correct (aurora-specific) python build targets in RPM and deb scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36945/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Pulled this out of https://reviews.apache.org/r/36700/ to address separately, as it is the more pressing issue. Diffs - build-support/packaging/debian/rules 23828c02b73f007393d2ed4ce69c010cebf07e57 build-support/packaging/rpm/aurora.spec 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 Diff: https://reviews.apache.org/r/36945/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 36945: Use the correct (aurora-specific) python build targets in RPM and deb scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36945/#review93594 --- Ship it! Master (d9c911a) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 30, 2015, 4:13 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36945/ --- (Updated July 30, 2015, 4:13 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Pulled this out of https://reviews.apache.org/r/36700/ to address separately, as it is the more pressing issue. Diffs - build-support/packaging/debian/rules 23828c02b73f007393d2ed4ce69c010cebf07e57 build-support/packaging/rpm/aurora.spec 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 Diff: https://reviews.apache.org/r/36945/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
On July 30, 2015, 5:22 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243 https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243 Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. Joe Smith wrote: Aha, gotcha- no worries, I'll update the ticket and discard this. Well- to make sure I learn to fish- this is because we're then modifying Stats, which typically doesn't happen from another class? (And its normally done [via configuration](http://docs.oracle.com/javase/8/docs/api/java/util/logging/LogManager.html) instead?) - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93682 --- On July 30, 2015, 5:14 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 5:14 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93686 --- Master (d327773) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 31, 2015, 12:14 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 31, 2015, 12:14 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 36945: Use the correct (aurora-specific) python build targets in RPM and deb scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36945/#review93615 --- Ship it! Ship It! - Kevin Sweeney On July 30, 2015, 9:13 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36945/ --- (Updated July 30, 2015, 9:13 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Pulled this out of https://reviews.apache.org/r/36700/ to address separately, as it is the more pressing issue. Diffs - build-support/packaging/debian/rules 23828c02b73f007393d2ed4ce69c010cebf07e57 build-support/packaging/rpm/aurora.spec 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 Diff: https://reviews.apache.org/r/36945/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:36 a.m.) Review request for Aurora and Bill Farner. Changes --- Stephan Erb's additional catch Summary (updated) - Squelch extraneous Stats logging to prevent spamming scheduler startup log. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description (updated) --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93617 --- Master (d9c911a) is red with this patch. ./build-support/jenkins/build.sh :api:checkPython :api:generateThriftEntitiesJava :api:classesThriftEntities :api:compileJava UP-TO-DATE :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :startScripts :distTar :distZip :assemble :compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java:20: Wrong order for 'java.util.Map.Entry' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 46.946 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 30, 2015, 5:36 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 5:36 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
On July 5, 2015, 12:49 p.m., Stephan Erb wrote: The same thing should also be applied to https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/src/main/java/org/apache/aurora/scheduler/TaskVars.java#L110 Bill Farner wrote: Good call - are you planning to roll that into this patch? Yep, good idea, pulled that in as well. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review90412 --- On July 30, 2015, 10:32 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
On July 8, 2015, 10:49 a.m., Stephan Erb wrote: Joe, have you tested this change in vagrant? I decided to change direction here, so we won't be changing stats names. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review90933 --- On July 30, 2015, 10:32 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
On July 30, 2015, 5:22 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243 https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243 Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. Joe Smith wrote: Aha, gotcha- no worries, I'll update the ticket and discard this. Joe Smith wrote: Well- to make sure I learn to fish- this is because we're then modifying Stats, which typically doesn't happen from another class? (And its normally done [via configuration](http://docs.oracle.com/javase/8/docs/api/java/util/logging/LogManager.html) instead?) Bill Farner wrote: Yeah, it's just kind of sneaky. Even if the operator tries to configure the logging system, or we try to adjust the log level on the fly, this code undermines that. That might be okay for the logging done today, but who knows about tomorrow. Yep, gotcha- thanks! - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93682 --- On July 30, 2015, 5:14 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 5:14 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
