Review Request 38210: [aurora-packaging] Adds Monit supervisor support for EL6

2015-09-09 Thread Steve Salevan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38210/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-1480
https://issues.apache.org/jira/browse/AURORA-1480


Repository: aurora-packaging


Description
---

As requested by AURORA-1480, this RB adds Monit as a runtime requirement for 
the aurora and aurora-thermos packages alongside some basic Monit scripts to 
properly supervise these processes.

Let me know what you think and thanks!


Diffs
-

  specs/rpm/SOURCES/aurora.monit PRE-CREATION 
  specs/rpm/SOURCES/thermos-observer.monit PRE-CREATION 
  specs/rpm/aurora.spec cf9c2715106a27fcb71447b5453ad3b847d2235a 

Diff: https://reviews.apache.org/r/38210/diff/


Testing
---

Tested Monit scripts against a local machine


Thanks,

Steve Salevan

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-09 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38200/#review98175
---

Ship it!


Master (2773826) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 1:36 p.m., Jeffrey Schroeder wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38200/
> ---
> 
> (Updated Sept. 9, 2015, 1:36 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1484
> https://issues.apache.org/jira/browse/AURORA-1484
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding notes on changing the scheduler quorum size
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 8a1e68e 
> 
> Diff: https://reviews.apache.org/r/38200/diff/
> 
> 
> Testing
> ---
> 
> Manually built the documentation using mkdocs and verified the links were 
> correct and the TOC rendered.
> 
> 
> Thanks,
> 
> Jeffrey Schroeder
> 
>

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-09 Thread Jeffrey Schroeder 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38200/
---

(Updated Sept. 9, 2015, 1:36 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

`s/follows/followed/` based on review feedback


Bugs: AURORA-1484
https://issues.apache.org/jira/browse/AURORA-1484


Repository: aurora


Description
---

Adding notes on changing the scheduler quorum size


Diffs (updated)
-

  docs/deploying-aurora-scheduler.md 8a1e68e 

Diff: https://reviews.apache.org/r/38200/diff/


Testing
---

Manually built the documentation using mkdocs and verified the links were 
correct and the TOC rendered.


Thanks,

Jeffrey Schroeder

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-09 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38200/#review98189
---

Ship it!


I'll go ahead and commit this once the cleanups are addressed.


docs/deploying-aurora-scheduler.md (line 294)


remove one newline


- Bill Farner


On Sept. 9, 2015, 6:36 a.m., Jeffrey Schroeder wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38200/
> ---
> 
> (Updated Sept. 9, 2015, 6:36 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1484
> https://issues.apache.org/jira/browse/AURORA-1484
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding notes on changing the scheduler quorum size
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 8a1e68e 
> 
> Diff: https://reviews.apache.org/r/38200/diff/
> 
> 
> Testing
> ---
> 
> Manually built the documentation using mkdocs and verified the links were 
> correct and the TOC rendered.
> 
> 
> Thanks,
> 
> Jeffrey Schroeder
> 
>

Re: Review Request 38200: Adding notes on changing the scheduler quorum size

2015-09-09 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38200/#review98201
---

Ship it!


Master (2773826) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 2:52 p.m., Jeffrey Schroeder wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38200/
> ---
> 
> (Updated Sept. 9, 2015, 2:52 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1484
> https://issues.apache.org/jira/browse/AURORA-1484
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding notes on changing the scheduler quorum size
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 8a1e68e 
> 
> Diff: https://reviews.apache.org/r/38200/diff/
> 
> 
> Testing
> ---
> 
> Manually built the documentation using mkdocs and verified the links were 
> correct and the TOC rendered.
> 
> 
> Thanks,
> 
> Jeffrey Schroeder
> 
>

Re: Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

2015-09-09 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38202/#review98286
---

Ship it!


Ship It!

- Bill Farner


On Sept. 8, 2015, 8:33 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38202/
> ---
> 
> (Updated Sept. 8, 2015, 8:33 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replace BoundedQueue with Guava's EvictingQueue.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/collections/BoundedQueue.java 
> 3e2d5fa7dd66db4a3c798334c68a92b707660618 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   
> commons/src/test/java/org/apache/aurora/common/collections/BoundedQueueTest.java
>  d6e3c211542e14406785ff200076f77ac1dc4823 
> 
> Diff: https://reviews.apache.org/r/38202/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98297
---

Ship it!


Master (a5ac5b9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 10:24 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 9, 2015, 10:24 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Bill Farner 


> On Sept. 9, 2015, 2:39 p.m., Kevin Sweeney wrote:
> > commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java,
> >  line 63
> > 
> >
> > Looks like Modules.combine is redundant here.

Thanks, removed.


> On Sept. 9, 2015, 2:39 p.m., Kevin Sweeney wrote:
> > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java,
> >  line 111
> > 
> >
> > Consider subclassing AbstractScheduledService instead

Good call!  That was a remarkably simple switch :-)


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98274
---


On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 8, 2015, 4:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38086: Add test environments for RPMs and debs.

2015-09-09 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/
---

(Updated Sept. 9, 2015, 3:19 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora-packaging


Description
---

Add test environments for RPMs and debs.


Diffs (updated)
-

  .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
  test/deb/ubuntu-trusty/README.md PRE-CREATION 
  test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
  test/rpm/centos-7/README.md PRE-CREATION 
  test/rpm/centos-7/Vagrantfile PRE-CREATION 
  test/rpm/centos-7/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/38086/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 38086: Add test environments for RPMs and debs.

2015-09-09 Thread Bill Farner 


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/deb/ubuntu-trusty/Vagrantfile, lines 6-12
> > 
> >
> > mutli-vm boilerplate isn't needed
> > 
> > Can replace this block with
> > 
> > ```ruby
> > config.vm.provider :virtualbox do |vb|
> >   vb.customize [...]
> > end
> > config.vm.provision "shell", path: "provision.sh"
> > ```

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/deb/ubuntu-trusty/provision.sh, line 9
> > 
> >
> > https

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/README.md, line 8
> > 
> >
> > https

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/Vagrantfile, lines 6-11
> > 
> >
> > Drop multi-vm boilerplate

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/provision.sh, line 7
> > 
> >
> > https

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/provision.sh, line 12
> > 
> >
> > https

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/provision.sh, lines 3-5
> > 
> >
> > yum should include these packages when we install the others, can this 
> > line be omitted?

Thanks, done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/#review98233
---


On Sept. 2, 2015, 7:59 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38086/
> ---
> 
> (Updated Sept. 2, 2015, 7:59 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Add test environments for RPMs and debs.
> 
> 
> Diffs
> -
> 
>   .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
>   test/deb/ubuntu-trusty/README.md PRE-CREATION 
>   test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
>   test/rpm/centos-7/README.md PRE-CREATION 
>   test/rpm/centos-7/Vagrantfile PRE-CREATION 
>   test/rpm/centos-7/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38086/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38202: Replace BoundedQueue with Guava's EvictingQueue.

2015-09-09 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38202/#review98302
---

Ship it!


Master (a5ac5b9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 3:33 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38202/
> ---
> 
> (Updated Sept. 9, 2015, 3:33 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Replace BoundedQueue with Guava's EvictingQueue.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/collections/BoundedQueue.java 
> 3e2d5fa7dd66db4a3c798334c68a92b707660618 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   
> commons/src/test/java/org/apache/aurora/common/collections/BoundedQueueTest.java
>  d6e3c211542e14406785ff200076f77ac1dc4823 
> 
> Diff: https://reviews.apache.org/r/38202/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-09 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review98345
---


Maxim - ping.

- Bill Farner


On Sept. 8, 2015, 4:26 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38112/
> ---
> 
> (Updated Sept. 8, 2015, 4:26 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1476
> https://issues.apache.org/jira/browse/AURORA-1476
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Alter thrift wrapper generator to use default primitive values and empty 
> collections.
> 
> Reviewers - please see my self-review commentary in specific parts of the 
> patch.  The biggest shift with this change is that an impedance mismatch that 
> existed when inserting/fetching a record from the database is now lifted to 
> the thrift wrapper layer.
> 
> This means the following test is not guaranteed to pass:
> ```java
> TaskConfig original = new TaskConfig(...);
> assertEquals(original, ITaskConfig.build(original).newBuilder());  // won't 
> always pass
> ```
> 
> Most specifically, the wrapped/upwrapped `TaskConfig` will have null 
> collections replaced with empty ones, and will not honor set/unset flags for 
> primitives.  The best practice, therefore, should be to treat our wrapper 
> classes as the canonical form, and only deal with the underlying thrift types 
> when absolutely necessary.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  a952797315a3421695748f09b9a6abb552cbb668 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e12ad3e3868472ba84e379986bd1aa97bca42ffe 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  5d8bd1b72927786df95c972df64d68c78f25dad0 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
>  9213b88ab4ce5063ca0fb055851ae5632616155e 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 295974a9f97e020dce11474d500a1bcd40d9f5d5 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 7ccc273204d20c84bbb576958e832b6f4a29f607 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  4685aa157be77502ad0e4e648ad333ee286f3de5 
> 
> Diff: https://reviews.apache.org/r/38112/diff/
> 
> 
> Testing
> ---
> 
> End-to-end tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-09 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/
---

(Updated Sept. 9, 2015, 6:35 p.m.)


Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.


Changes
---

Bill's comment.


Bugs: AURORA-1460
https://issues.apache.org/jira/browse/AURORA-1460


Repository: aurora


Description
---

This change drops quota enforcement for dedicated jobs and adds dedicated 
resource consumption into the thrift API. There is now a shared/dedicated 
consumption split for both prod and non-prod tasks.

NOTE: the GetQuotaResult will have to be deprecated and/or replaced with a 
tier-based mapping when AURORA-1443 is addressed.


Diffs (updated)
-

  NEWS 83a1213e2ea4ab6b3706cd70c015ba9f16735520 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
  src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java 
df796fcc91265c588872051f16bd2f10f73dc718 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
3d89e43659750de63d7588f8574e7a350caea04b 
  src/main/python/apache/aurora/client/api/quota_check.py 
75406ac1d3ec9ba655daf7c6125f208f74290cfb 
  src/main/python/apache/aurora/client/cli/quota.py 
e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
  src/main/resources/scheduler/assets/js/controllers.js 
4acab107e1a4ecf310192c9bb3ad2a3f90f524f1 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
db60cd21d06d636505202bac7277a13dc24d46e6 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 a8df44612b605dff512d1ca686f0789b84ef9012 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
e0110e7ebe631b7b66b2341cedc10490da00a2ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
4d4e752088f7dca99675cc66782ae046bbd516d6 
  src/test/python/apache/aurora/admin/test_admin.py 
d793293acc7f77c0081968334c38b984d865fbc8 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
  src/test/python/apache/aurora/client/cli/test_quota.py 
3573e4c4575577e2232d2b99ca781b06a03d48d7 

Diff: https://reviews.apache.org/r/38081/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-09 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review98238
---

Ship it!


Master (4577de4) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 6:35 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 9, 2015, 6:35 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. There is now a shared/dedicated 
> consumption split for both prod and non-prod tasks.
> 
> NOTE: the GetQuotaResult will have to be deprecated and/or replaced with a 
> tier-based mapping when AURORA-1443 is addressed.
> 
> 
> Diffs
> -
> 
>   NEWS 83a1213e2ea4ab6b3706cd70c015ba9f16735520 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java 
> df796fcc91265c588872051f16bd2f10f73dc718 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 4acab107e1a4ecf310192c9bb3ad2a3f90f524f1 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  a8df44612b605dff512d1ca686f0789b84ef9012 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-09 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38169/#review98260
---


Master (01e611a) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 7:10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38169/
> ---
> 
> (Updated Sept. 9, 2015, 7:10 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1461
> https://issues.apache.org/jira/browse/AURORA-1461
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Making Resources table dynamic to display only non-zero resource vectors (see 
> pics attached). Table width is now dependent on the number of visible columns.
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 9436e9b21347db572f235b81687baea3252074f5 
>   src/main/resources/scheduler/assets/role.html 
> 2572c4b4497aa78d3fa31457a5dc7c57e6565027 
> 
> Diff: https://reviews.apache.org/r/38169/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> resources_full.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/08/ada720ce-bb97-4321-99bb-0574bf14b653__resources_full.png
> resources_partial.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/08/a6e4aa7e-ca7e-4ca4-900e-fda6cfdcaff3__resources_partial.png
> resources_min.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/08/c44964f2-d8d7-41b0-8a4f-995a1e3538f1__resources_min.png
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38169: Refactoring resources table to show dedicated.

2015-09-09 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38169/#review98268
---

Ship it!


Ship It!

- David McLaughlin


On Sept. 9, 2015, 7:10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38169/
> ---
> 
> (Updated Sept. 9, 2015, 7:10 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1461
> https://issues.apache.org/jira/browse/AURORA-1461
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Making Resources table dynamic to display only non-zero resource vectors (see 
> pics attached). Table width is now dependent on the number of visible columns.
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 9436e9b21347db572f235b81687baea3252074f5 
>   src/main/resources/scheduler/assets/role.html 
> 2572c4b4497aa78d3fa31457a5dc7c57e6565027 
> 
> Diff: https://reviews.apache.org/r/38169/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> resources_full.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/08/ada720ce-bb97-4321-99bb-0574bf14b653__resources_full.png
> resources_partial.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/08/a6e4aa7e-ca7e-4ca4-900e-fda6cfdcaff3__resources_partial.png
> resources_min.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/08/c44964f2-d8d7-41b0-8a4f-995a1e3538f1__resources_min.png
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38086: Add test environments for RPMs and debs.

2015-09-09 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/#review98272
---

Ship it!


LGTM once comments are addressed

- Kevin Sweeney


On Sept. 2, 2015, 7:59 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38086/
> ---
> 
> (Updated Sept. 2, 2015, 7:59 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Add test environments for RPMs and debs.
> 
> 
> Diffs
> -
> 
>   .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
>   test/deb/ubuntu-trusty/README.md PRE-CREATION 
>   test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
>   test/rpm/centos-7/README.md PRE-CREATION 
>   test/rpm/centos-7/Vagrantfile PRE-CREATION 
>   test/rpm/centos-7/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38086/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98274
---

Ship it!



commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
(line 51)


Looks like Modules.combine is redundant here.



commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
 (line 108)


Consider subclassing AbstractScheduledService instead


- Kevin Sweeney


On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> ---
> 
> (Updated Sept. 8, 2015, 4:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> ---
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>