Re: Review Request 65477: Fix UI table layout issue on Config Summaries

2018-02-02 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196693
---



Master (21a371c) is red with this patch.
  ./build-support/jenkins/build.sh

  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
 --- Captured log call 
 health_checker.py  167 INFO  INFO] Reached 
consecutive success limit.
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-2
 health_checker.py  184 WARNING   WARN] Ignoring 
failure of attempt: 2
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-3
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
  1 failed, 799 passed, 6 skipped in 260.33 seconds 
 
FAILURE


   Waiting for background workers to finish.
08:06:46 04:55   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2018, 3:52 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> ---
> 
> (Updated Feb. 2, 2018, 3:52 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix UI table layout issue when configuration metadata (or any other cell) is 
> longer than the max width of the table.
> 
> 
> Diffs
> -
> 
>   ui/src/main/sass/components/_job-page.scss 
> 2ae4e73c5d8d4e653cd1c550e699888b42554aec 
> 
> 
> Diff: https://reviews.apache.org/r/65477/diff/1/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> before
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65476: Add PartitionPolicy to config summary when defined

2018-02-02 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196695
---



Master (21a371c) is red with this patch.
  ./build-support/jenkins/build.sh

  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
 --- Captured log call 
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure
 health_checker.py  184 WARNING   WARN] Ignoring 
failure of attempt: 1
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure
 health_checker.py  184 WARNING   WARN] Ignoring 
failure of attempt: 2
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
  1 failed, 799 passed, 6 skipped in 258.85 seconds 
 
FAILURE


   Waiting for background workers to finish.
08:18:41 04:50   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2018, 7:46 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> ---
> 
> (Updated Feb. 2, 2018, 7:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskConfigSummary.js 
> 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> ---
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> 
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65477: Fix UI table layout issue on Config Summaries

2018-02-02 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196698
---


Ship it!




Ship It!

- Stephan Erb


On Feb. 2, 2018, 8:52 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> ---
> 
> (Updated Feb. 2, 2018, 8:52 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix UI table layout issue when configuration metadata (or any other cell) is 
> longer than the max width of the table.
> 
> 
> Diffs
> -
> 
>   ui/src/main/sass/components/_job-page.scss 
> 2ae4e73c5d8d4e653cd1c550e699888b42554aec 
> 
> 
> Diff: https://reviews.apache.org/r/65477/diff/1/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> before
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65476: Add PartitionPolicy to config summary when defined

2018-02-02 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196699
---


Ship it!




Ship It!

- Stephan Erb


On Feb. 2, 2018, 8:46 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> ---
> 
> (Updated Feb. 2, 2018, 8:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskConfigSummary.js 
> 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> ---
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> 
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65477: Fix UI table layout issue on Config Summaries

2018-02-02 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196701
---



@ReviewBot retry

- Stephan Erb


On Feb. 2, 2018, 8:52 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> ---
> 
> (Updated Feb. 2, 2018, 8:52 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix UI table layout issue when configuration metadata (or any other cell) is 
> longer than the max width of the table.
> 
> 
> Diffs
> -
> 
>   ui/src/main/sass/components/_job-page.scss 
> 2ae4e73c5d8d4e653cd1c550e699888b42554aec 
> 
> 
> Diff: https://reviews.apache.org/r/65477/diff/1/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> before
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65476: Add PartitionPolicy to config summary when defined

2018-02-02 Thread Stephan Erb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196700
---



@ReviewBot retry

- Stephan Erb


On Feb. 2, 2018, 8:46 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> ---
> 
> (Updated Feb. 2, 2018, 8:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskConfigSummary.js 
> 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> ---
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> 
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65476: Add PartitionPolicy to config summary when defined

2018-02-02 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196702
---



Master (21a371c) is red with this patch.
  ./build-support/jenkins/build.sh

  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
 --- Captured log call 
 health_checker.py  167 INFO  INFO] Reached 
consecutive success limit.
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-2
 health_checker.py  184 WARNING   WARN] Ignoring 
failure of attempt: 2
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-3
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
  5 failed, 795 passed, 6 skipped in 368.28 seconds 
 
FAILURE


   Waiting for background workers to finish.
10:06:03 06:47   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2018, 7:46 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> ---
> 
> (Updated Feb. 2, 2018, 7:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskConfigSummary.js 
> 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> ---
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> 
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65477: Fix UI table layout issue on Config Summaries

2018-02-02 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196704
---



Master (21a371c) is red with this patch.
  ./build-support/jenkins/build.sh

  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
 --- Captured log call 
 health_checker.py  167 INFO  INFO] Reached 
consecutive success limit.
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-2
 health_checker.py  184 WARNING   WARN] Ignoring 
failure of attempt: 2
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-3
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
  5 failed, 795 passed, 6 skipped in 492.44 seconds 
 
FAILURE


   Waiting for background workers to finish.
10:22:57 08:50   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2018, 3:52 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> ---
> 
> (Updated Feb. 2, 2018, 3:52 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix UI table layout issue when configuration metadata (or any other cell) is 
> longer than the max width of the table.
> 
> 
> Diffs
> -
> 
>   ui/src/main/sass/components/_job-page.scss 
> 2ae4e73c5d8d4e653cd1c550e699888b42554aec 
> 
> 
> Diff: https://reviews.apache.org/r/65477/diff/1/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> before
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65477: Fix UI table layout issue on Config Summaries

2018-02-02 Thread Santhosh Kumar Shanmugham

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196712
---


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On Feb. 1, 2018, 11:52 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> ---
> 
> (Updated Feb. 1, 2018, 11:52 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix UI table layout issue when configuration metadata (or any other cell) is 
> longer than the max width of the table.
> 
> 
> Diffs
> -
> 
>   ui/src/main/sass/components/_job-page.scss 
> 2ae4e73c5d8d4e653cd1c550e699888b42554aec 
> 
> 
> Diff: https://reviews.apache.org/r/65477/diff/1/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> before
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65476: Add PartitionPolicy to config summary when defined

2018-02-02 Thread Santhosh Kumar Shanmugham

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196713
---


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On Feb. 1, 2018, 11:46 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> ---
> 
> (Updated Feb. 1, 2018, 11:46 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskConfigSummary.js 
> 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> ---
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> 
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65477: Fix UI table layout issue on Config Summaries

2018-02-02 Thread Reza Motamedi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196715
---


Ship it!




Ship It!

- Reza Motamedi


On Feb. 2, 2018, 7:52 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65477/
> ---
> 
> (Updated Feb. 2, 2018, 7:52 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix UI table layout issue when configuration metadata (or any other cell) is 
> longer than the max width of the table.
> 
> 
> Diffs
> -
> 
>   ui/src/main/sass/components/_job-page.scss 
> 2ae4e73c5d8d4e653cd1c550e699888b42554aec 
> 
> 
> Diff: https://reviews.apache.org/r/65477/diff/1/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> before
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/dcfa3542-10cb-42d2-9a3f-7fd8e5d54ddf__Screen_Shot_2018-02-01_at_11.50.04_PM.png
> after
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/ff3cf950-e26f-4593-9169-aa8b489d7d49__Screen_Shot_2018-02-01_at_11.49.51_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65476: Add PartitionPolicy to config summary when defined

2018-02-02 Thread David McLaughlin


> On Feb. 2, 2018, 10:06 a.m., Aurora ReviewBot wrote:
> > Master (21a371c) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >   WARN] Reached consecutive failure limit.
> >  --- Captured log call 
> >  health_checker.py  167 INFO  INFO] Reached 
> > consecutive success limit.
> >  health_checker.py  143 WARNING   WARN] Health 
> > check failure: failure-2
> >  health_checker.py  184 WARNING   WARN] 
> > Ignoring failure of attempt: 2
> >  health_checker.py  143 WARNING   WARN] Health 
> > check failure: failure-3
> >  health_checker.py  159 WARNING   WARN] Reached 
> > consecutive failure limit.
> >   5 failed, 795 passed, 6 skipped in 368.28 seconds 
> >  
> > FAILURE
> > 
> > 
> >Waiting for background workers to finish.
> > 10:06:03 06:47   [complete]
> >FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

I'm randomly getting this failure locally too. Does anyone have an idea what 
change was introduced that caused this? Should we mark the test as skippable 
until it's triaged?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196702
---


On Feb. 2, 2018, 7:46 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65476/
> ---
> 
> (Updated Feb. 2, 2018, 7:46 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add PartitionPolicy to config summary when defined
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/TaskConfigSummary.js 
> 01902cdd90192113b93cdf5872cd560c431f2bf0 
> 
> 
> Diff: https://reviews.apache.org/r/65476/diff/1/
> 
> 
> Testing
> ---
> 
> Testing in vagrant (see screenshot).
> 
> 
> File Attachments
> 
> 
> Screen Shot 2018-02-01 at 11.46.17 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/02/1353e8ee-bb7b-4546-adf6-9f1ececb36b4__Screen_Shot_2018-02-01_at_11.46.17_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Review Request 65488: Adding gpg key for re...@apache.org

2018-02-02 Thread Renan DelValle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65488/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Adding gpg key for re...@apache.org


Diffs
-

  KEYS f5e5764a2ef017e8326414e5ce5ae7327f7bed3a 


Diff: https://reviews.apache.org/r/65488/diff/1/


Testing
---


Thanks,

Renan DelValle



Re: Review Request 65488: Adding gpg key for re...@apache.org

2018-02-02 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65488/#review196765
---



Master (f088032) is red with this patch.
  ./build-support/jenkins/build.sh

  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
 --- Captured log call 
 health_checker.py  167 INFO  INFO] Reached 
consecutive success limit.
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-2
 health_checker.py  184 WARNING   WARN] Ignoring 
failure of attempt: 2
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-3
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
  3 failed, 797 passed, 6 skipped in 375.61 seconds 
 
FAILURE


   Waiting for background workers to finish.
00:11:06 06:54   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 2, 2018, 8:31 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65488/
> ---
> 
> (Updated Feb. 2, 2018, 8:31 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding gpg key for re...@apache.org
> 
> 
> Diffs
> -
> 
>   KEYS f5e5764a2ef017e8326414e5ce5ae7327f7bed3a 
> 
> 
> Diff: https://reviews.apache.org/r/65488/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>



Review Request 65494: Add task page to Scheduler UI

2018-02-02 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65494/
---

Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar 
Shanmugham.


Repository: aurora


Description
---

Add task page to Scheduler UI. I haven't created any inbound links to this yet 
because there isn't any really useful information, but we have a need to 
permalink to tasks from outside the Scheduler so right now this scratches that 
itch. 

If anyone has ideas about where we can add permalinks or inbound clicks.. let 
me know! In the future we could maybe bring some of the Observer stuff into 
this page and make it really useful.


Diffs
-

  ui/src/main/js/components/Breadcrumb.js 
76c62709cf3ebf76e74e08573bc8b245a45d5fe9 
  ui/src/main/js/components/TaskStatus.js 
2e5a2b46121d6cc7c80c6d7589803a10973b5c1b 
  ui/src/main/js/components/__tests__/Breadcrumb-test.js 
47f7afb29b9192e214040097dbfee2ff7f7e29ed 
  ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93 
  ui/src/main/js/pages/Task.js PRE-CREATION 
  ui/src/main/js/pages/__tests__/Task-test.js PRE-CREATION 
  ui/src/main/sass/components/_instance-page.scss 
1da87dcb0f66c258179295b23bda5c895bf5308f 


Diff: https://reviews.apache.org/r/65494/diff/1/


Testing
---

./gradlew ui:test

See screenshot for Vagrant test.


File Attachments


Screen Shot 2018-02-02 at 4.22.16 PM.png
  
https://reviews.apache.org/media/uploaded/files/2018/02/03/588521b3-6014-4e63-aa4c-8389d4ed44e3__Screen_Shot_2018-02-02_at_4.22.16_PM.png


Thanks,

David McLaughlin



Re: Review Request 65494: Add task page to Scheduler UI

2018-02-02 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65494/#review196773
---



Master (f088032) is red with this patch.
  ./build-support/jenkins/build.sh

  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
 --- Captured log call 
 health_checker.py  167 INFO  INFO] Reached 
consecutive success limit.
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-4
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-5
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
  2 failed, 798 passed, 6 skipped in 346.91 seconds 
 
FAILURE


   Waiting for background workers to finish.
01:08:34 06:26   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 3, 2018, 12:27 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65494/
> ---
> 
> (Updated Feb. 3, 2018, 12:27 a.m.)
> 
> 
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar 
> Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add task page to Scheduler UI. I haven't created any inbound links to this 
> yet because there isn't any really useful information, but we have a need to 
> permalink to tasks from outside the Scheduler so right now this scratches 
> that itch. 
> 
> If anyone has ideas about where we can add permalinks or inbound clicks.. let 
> me know! In the future we could maybe bring some of the Observer stuff into 
> this page and make it really useful.
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/Breadcrumb.js 
> 76c62709cf3ebf76e74e08573bc8b245a45d5fe9 
>   ui/src/main/js/components/TaskStatus.js 
> 2e5a2b46121d6cc7c80c6d7589803a10973b5c1b 
>   ui/src/main/js/components/__tests__/Breadcrumb-test.js 
> 47f7afb29b9192e214040097dbfee2ff7f7e29ed 
>   ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93 
>   ui/src/main/js/pages/Task.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Task-test.js PRE-CREATION 
>   ui/src/main/sass/components/_instance-page.scss 
> 1da87dcb0f66c258179295b23bda5c895bf5308f 
> 
> 
> Diff: https://reviews.apache.org/r/65494/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew ui:test
> 
> See screenshot for Vagrant test.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2018-02-02 at 4.22.16 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/03/588521b3-6014-4e63-aa4c-8389d4ed44e3__Screen_Shot_2018-02-02_at_4.22.16_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 65494: Add task page to Scheduler UI

2018-02-02 Thread Kai Huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65494/#review196780
---


Ship it!




Ship It!

- Kai Huang


On Feb. 3, 2018, 12:27 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65494/
> ---
> 
> (Updated Feb. 3, 2018, 12:27 a.m.)
> 
> 
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar 
> Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add task page to Scheduler UI. I haven't created any inbound links to this 
> yet because there isn't any really useful information, but we have a need to 
> permalink to tasks from outside the Scheduler so right now this scratches 
> that itch. 
> 
> If anyone has ideas about where we can add permalinks or inbound clicks.. let 
> me know! In the future we could maybe bring some of the Observer stuff into 
> this page and make it really useful.
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/Breadcrumb.js 
> 76c62709cf3ebf76e74e08573bc8b245a45d5fe9 
>   ui/src/main/js/components/TaskStatus.js 
> 2e5a2b46121d6cc7c80c6d7589803a10973b5c1b 
>   ui/src/main/js/components/__tests__/Breadcrumb-test.js 
> 47f7afb29b9192e214040097dbfee2ff7f7e29ed 
>   ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93 
>   ui/src/main/js/pages/Task.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Task-test.js PRE-CREATION 
>   ui/src/main/sass/components/_instance-page.scss 
> 1da87dcb0f66c258179295b23bda5c895bf5308f 
> 
> 
> Diff: https://reviews.apache.org/r/65494/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew ui:test
> 
> See screenshot for Vagrant test.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2018-02-02 at 4.22.16 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/03/588521b3-6014-4e63-aa4c-8389d4ed44e3__Screen_Shot_2018-02-02_at_4.22.16_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Review Request 65501: Show cron job preview when no active tasks.

2018-02-02 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65501/
---

Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.


Repository: aurora


Description
---

Show cron job preview when no active tasks.


Diffs
-

  ui/src/main/js/components/CronJobPreview.js PRE-CREATION 
  ui/src/main/js/components/JobStatus.js 
14f3538c3716e39dfc4ec6953f640343af161417 
  ui/src/main/js/components/__tests__/JobStatus-test.js 
78eaab48faf7fd2cabf6ced9d4fd84537216ae1b 
  ui/src/main/sass/components/_job-page.scss 
41e9518d2d2bd5ad3bf07194e0de4d52ed5eca0b 


Diff: https://reviews.apache.org/r/65501/diff/1/


Testing
---

./gradlew ui:test

See screenshot.


File Attachments


Screen Shot 2018-02-02 at 10.37.53 PM.png
  
https://reviews.apache.org/media/uploaded/files/2018/02/03/e44008fd-ef17-4f6a-9d4b-2524ee9ba934__Screen_Shot_2018-02-02_at_10.37.53_PM.png


Thanks,

David McLaughlin



Re: Review Request 65501: Show cron job preview when no active tasks.

2018-02-02 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65501/#review196783
---



Master (f088032) is red with this patch.
  ./build-support/jenkins/build.sh

  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
 --- Captured log call 
 health_checker.py  167 INFO  INFO] Reached 
consecutive success limit.
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-4
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-5
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
  3 failed, 797 passed, 6 skipped in 373.78 seconds 
 
FAILURE


   Waiting for background workers to finish.
06:58:01 06:53   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 3, 2018, 6:39 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65501/
> ---
> 
> (Updated Feb. 3, 2018, 6:39 a.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show cron job preview when no active tasks.
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/CronJobPreview.js PRE-CREATION 
>   ui/src/main/js/components/JobStatus.js 
> 14f3538c3716e39dfc4ec6953f640343af161417 
>   ui/src/main/js/components/__tests__/JobStatus-test.js 
> 78eaab48faf7fd2cabf6ced9d4fd84537216ae1b 
>   ui/src/main/sass/components/_job-page.scss 
> 41e9518d2d2bd5ad3bf07194e0de4d52ed5eca0b 
> 
> 
> Diff: https://reviews.apache.org/r/65501/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew ui:test
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2018-02-02 at 10.37.53 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2018/02/03/e44008fd-ef17-4f6a-9d4b-2524ee9ba934__Screen_Shot_2018-02-02_at_10.37.53_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>