Re: Review Request 65648: Do not reschedule a PARTITIONED task if it was in KILLING state

2018-02-14 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65648/#review197574
---


Ship it!




Ship It!

- Jordan Ly


On Feb. 14, 2018, 5:27 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65648/
> ---
> 
> (Updated Feb. 14, 2018, 5:27 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> In previous behavior KILLING -> LOST never resulted in a reschedule. In the 
> new code, KILLING -> PARTITIONED -> LOST would. This adds a check to 
> PARTITIONED -> LOST to only reschedule when KILLING isn't one of the previous 
> states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> f325bf46350bda49c3aaca151b76aad9649cb91a 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 050a46ad8f06bbeeb88079a2583296348b6f8359 
> 
> 
> Diff: https://reviews.apache.org/r/65648/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew test
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

2018-02-14 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197571
---




build-support/jenkins/build.sh
Lines 30 (patched)


Do we still need --junit-xml-dir="$PWD/dist/test-results" to make the logs 
go to the right place?


- Renan DelValle


On Feb. 12, 2018, 12:36 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65598/
> ---
> 
> (Updated Feb. 12, 2018, 12:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Renan DelValle.
> 
> 
> Bugs: AURORA-1972
> https://issues.apache.org/jira/browse/AURORA-1972
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable pytest-fast mode as a workaround for failing health checker tests
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 4c25a3fa315ab965df8908fe7c28be48ceb002bc 
> 
> 
> Diff: https://reviews.apache.org/r/65598/diff/1/
> 
> 
> Testing
> ---
> 
> repeated git clean -xfd && ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 65650: Add GPG key for jorda...@apache.org

2018-02-14 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65650/#review197546
---


Ship it!




Ship It!

- Stephan Erb


On Feb. 14, 2018, 9:36 a.m., Jordan Ly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65650/
> ---
> 
> (Updated Feb. 14, 2018, 9:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Renan DelValle.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add GPG key for jorda...@apache.org
> 
> 
> Diffs
> -
> 
>   KEYS 843e955e8f69e4d36b61df66aa20a1c914cb77c9 
> 
> 
> Diff: https://reviews.apache.org/r/65650/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jordan Ly
> 
>

Re: Review Request 65650: Add GPG key for jorda...@apache.org

2018-02-14 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65650/#review197537
---


Ship it!




Ship It!

- Renan DelValle


On Feb. 14, 2018, 12:36 a.m., Jordan Ly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65650/
> ---
> 
> (Updated Feb. 14, 2018, 12:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Renan DelValle.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add GPG key for jorda...@apache.org
> 
> 
> Diffs
> -
> 
>   KEYS 843e955e8f69e4d36b61df66aa20a1c914cb77c9 
> 
> 
> Diff: https://reviews.apache.org/r/65650/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jordan Ly
> 
>

Re: Review Request 65649: Adding support for a Thrift JSON request which defines UTF-8 as the charset for the Content-Type in the Request Headers

2018-02-14 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65649/#review197520
---


Ship it!




Ship It!

- Stephan Erb


On Feb. 14, 2018, 6:05 a.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65649/
> ---
> 
> (Updated Feb. 14, 2018, 6:05 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding support in the scheduler to receive a JSON request which defines a 
> UTF-8 charset in the Content-Type inside of the HTTP Request Headers.
> 
> This fixes the current UI brakage as Thrift is incorrectly rejected by the 
> scheduler servlet as an unsupported media type.
> 
> Adding a test to prevent regressions.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> 91ff8d32be1dacd35c7ba74b666479a61aede296 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 
> 10da43bdc113791d0644dcc480476323f86cc66e 
> 
> 
> Diff: https://reviews.apache.org/r/65649/diff/1/
> 
> 
> Testing
> ---
> 
> End to end testing
> Loading up UI in different browsers in order to make sure thrift.js was not 
> cached.
> vagrant destroy && vagrant up
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 65650: Add GPG key for jorda...@apache.org

2018-02-14 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65650/#review197492
---



Master (cb0faf8) is red with this patch.
  ./build-support/jenkins/build.sh

  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
  WARN] Reached consecutive failure limit.
 --- Captured log call 
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-1
 health_checker.py  184 WARNING   WARN] Ignoring 
failure of attempt: 1
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-2
 health_checker.py  184 WARNING   WARN] Ignoring 
failure of attempt: 2
 health_checker.py  143 WARNING   WARN] Health 
check failure: failure-3
 health_checker.py  159 WARNING   WARN] Reached 
consecutive failure limit.
  2 failed, 798 passed, 6 skipped in 419.66 seconds 
 
FAILURE


   Waiting for background workers to finish.
09:27:35 07:35   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 14, 2018, 8:36 a.m., Jordan Ly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65650/
> ---
> 
> (Updated Feb. 14, 2018, 8:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Renan DelValle.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add GPG key for jorda...@apache.org
> 
> 
> Diffs
> -
> 
>   KEYS 843e955e8f69e4d36b61df66aa20a1c914cb77c9 
> 
> 
> Diff: https://reviews.apache.org/r/65650/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jordan Ly
> 
>

Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

2018-02-14 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197488
---


Ship it!




Ship It!

- Jordan Ly


On Feb. 12, 2018, 8:36 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65598/
> ---
> 
> (Updated Feb. 12, 2018, 8:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Renan DelValle.
> 
> 
> Bugs: AURORA-1972
> https://issues.apache.org/jira/browse/AURORA-1972
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable pytest-fast mode as a workaround for failing health checker tests
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 4c25a3fa315ab965df8908fe7c28be48ceb002bc 
> 
> 
> Diff: https://reviews.apache.org/r/65598/diff/1/
> 
> 
> Testing
> ---
> 
> repeated git clean -xfd && ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 65650: Add GPG key for jorda...@apache.org

2018-02-14 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65650/
---

Review request for Aurora, David McLaughlin and Renan DelValle.


Repository: aurora


Description
---

Add GPG key for jorda...@apache.org


Diffs
-

  KEYS 843e955e8f69e4d36b61df66aa20a1c914cb77c9 


Diff: https://reviews.apache.org/r/65650/diff/1/


Testing
---


Thanks,

Jordan Ly

Re: Review Request 65649: Adding support for a Thrift JSON request which defines UTF-8 as the charset for the Content-Type in the Request Headers

2018-02-14 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65649/#review197487
---


Ship it!




Ship It!

- Jordan Ly


On Feb. 14, 2018, 5:05 a.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65649/
> ---
> 
> (Updated Feb. 14, 2018, 5:05 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding support in the scheduler to receive a JSON request which defines a 
> UTF-8 charset in the Content-Type inside of the HTTP Request Headers.
> 
> This fixes the current UI brakage as Thrift is incorrectly rejected by the 
> scheduler servlet as an unsupported media type.
> 
> Adding a test to prevent regressions.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> 91ff8d32be1dacd35c7ba74b666479a61aede296 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 
> 10da43bdc113791d0644dcc480476323f86cc66e 
> 
> 
> Diff: https://reviews.apache.org/r/65649/diff/1/
> 
> 
> Testing
> ---
> 
> End to end testing
> Loading up UI in different browsers in order to make sure thrift.js was not 
> cached.
> vagrant destroy && vagrant up
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>