Re: Review Request 66490: Implement Mesos docker/volume isolator support for aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66490/#review200694 --- Ship it! Master (70d043e) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 7, 2018, 12:04 a.m., Justin Venus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66490/ > --- > > (Updated April 7, 2018, 12:04 a.m.) > > > Review request for Aurora, Renan DelValle and Stephan Erb. > > > Bugs: AURORA-1983 > https://issues.apache.org/jira/browse/AURORA-1983 > > > Repository: aurora > > > Description > --- > > This change implements the docker/volume isolator as described at > http://mesos.apache.org/documentation/latest/isolators/docker-volume/. > > * update config thrift tests to check for docker/volume isolator support > * update mesos task factory to support docker/volume isolator > * update documentation for docker/volume isolator support > > > Diffs > - > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > ef754e32172e7490a47a13e7b526f243ffa3efeb > docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > bcb2bbf882f43d813dd26c746d806e78bae6bcf3 > src/main/python/apache/aurora/config/schema/base.py > a629bcd1261e5959da0a8458a55545d4e2c2a7a5 > src/main/python/apache/aurora/config/thrift.py > 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 > src/test/python/apache/aurora/config/test_thrift.py > 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 > > > Diff: https://reviews.apache.org/r/66490/diff/4/ > > > Testing > --- > > Tests pass locally > ```sh > ./gradlew test > ./pants test src/test/python:: > ``` > > I've deployed this code to a test cluster with rexray, dvdcli, and the agents > have `docker/volume` isolation enabled. I am able to exercise mounting an > EBS volume as I would expect into a container. > > > Thanks, > > Justin Venus > >
Re: Review Request 66490: Implement Mesos docker/volume isolator support for aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66490/#review200692 --- Master (70d043e) is red with this patch. ./build-support/jenkins/build.sh 00:44:35 00:00 [setup] 00:44:36 00:01 [parse] Executing tasks in goals: lint 00:44:36 00:01 [lint] 00:44:36 00:01 [python-eval] 00:44:36 00:01 [pythonstyle] 00:44:36 00:01 [cache] No cached artifacts for 48 targets. Invalidated 48 targets. T302:ERROR src/test/python/apache/aurora/config/test_thrift.py:218 Expected 2 blank lines, found 1 |def test_config_with_host_volumes(): T302:ERROR src/test/python/apache/aurora/config/test_thrift.py:240 Expected 2 blank lines, found 1 |def test_config_with_docker_volumes(): T302:ERROR src/test/python/apache/aurora/config/test_thrift.py:265 Expected 2 blank lines, found 1 |def test_docker_with_parameters(): E302:ERROR PythonFile(src/test/python/apache/aurora/config/test_thrift.py):218 expected 2 blank lines, found 1 |def test_config_with_host_volumes(): E302:ERROR PythonFile(src/test/python/apache/aurora/config/test_thrift.py):240 expected 2 blank lines, found 1 |def test_config_with_docker_volumes(): E302:ERROR PythonFile(src/test/python/apache/aurora/config/test_thrift.py):265 expected 2 blank lines, found 1 |def test_docker_with_parameters(): T302:ERROR src/main/python/apache/aurora/config/thrift.py:209 Expected 2 blank lines, found 1 |def volumes_to_thrift(volumes): E302:ERROR PythonFile(src/main/python/apache/aurora/config/thrift.py):209 expected 2 blank lines, found 1 |def volumes_to_thrift(volumes): FAILURE: 8 Python Style issues found. You may try `./pants fmt ` 00:44:55 00:20 [complete] FAILURE I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 7, 2018, 12:04 a.m., Justin Venus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66490/ > --- > > (Updated April 7, 2018, 12:04 a.m.) > > > Review request for Aurora, Renan DelValle and Stephan Erb. > > > Bugs: AURORA-1983 > https://issues.apache.org/jira/browse/AURORA-1983 > > > Repository: aurora > > > Description > --- > > This change implements the docker/volume isolator as described at > http://mesos.apache.org/documentation/latest/isolators/docker-volume/. > > * update config thrift tests to check for docker/volume isolator support > * update mesos task factory to support docker/volume isolator > * update documentation for docker/volume isolator support > > > Diffs > - > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > ef754e32172e7490a47a13e7b526f243ffa3efeb > docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > bcb2bbf882f43d813dd26c746d806e78bae6bcf3 > src/main/python/apache/aurora/config/schema/base.py > a629bcd1261e5959da0a8458a55545d4e2c2a7a5 > src/main/python/apache/aurora/config/thrift.py > 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 > src/test/python/apache/aurora/config/test_thrift.py > 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 > > > Diff: https://reviews.apache.org/r/66490/diff/3/ > > > Testing > --- > > Tests pass locally > ```sh > ./gradlew test > ./pants test src/test/python:: > ``` > > I've deployed this code to a test cluster with rexray, dvdcli, and the agents > have `docker/volume` isolation enabled. I am able to exercise mounting an > EBS volume as I would expect into a container. > > > Thanks, > > Justin Venus > >
Re: Review Request 66491: Chaning default reviewers as well as reflecting the new address of gorealis.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66491/#review200691 --- Ship it! Master (70d043e) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 7, 2018, 12:18 a.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66491/ > --- > > (Updated April 7, 2018, 12:18 a.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > Chaning default reviewers as well as reflecting the new address of gorealis. > > > Diffs > - > > CONTRIBUTING.md bdd27822e265bbd43d0d8378559b6b3080210fd9 > docs/additional-resources/tools.md 678e5504d00c657e563437032e7210ac1e8cd227 > > > Diff: https://reviews.apache.org/r/66491/diff/1/ > > > Testing > --- > > Doc change only. > > > Thanks, > > Renan DelValle > >
Review Request 66491: Chaning default reviewers as well as reflecting the new address of gorealis.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66491/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description --- Chaning default reviewers as well as reflecting the new address of gorealis. Diffs - CONTRIBUTING.md bdd27822e265bbd43d0d8378559b6b3080210fd9 docs/additional-resources/tools.md 678e5504d00c657e563437032e7210ac1e8cd227 Diff: https://reviews.apache.org/r/66491/diff/1/ Testing --- Doc change only. Thanks, Renan DelValle
Re: Review Request 66490: Implement Mesos docker/volume isolator support for aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66490/#review200689
---
Master (70d043e) is red with this patch.
./build-support/jenkins/build.sh
[191] ./src/main/resources/source-sans-pro.css 1.05 kB {0} [built]
[223] ./src/main/js/index.js 3.43 kB {0} [built]
+ 268 hidden modules
:processResources
:classes
:jar
:moreStartScripts
:startScripts
:distTar
:distZip
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processTestResources
:testClasses
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:286:
'lambda arguments' have incorrect indentation level 16, expected level should
be one of the following: 10, 12. [Indentation]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 3m 57s
32 actionable tasks: 26 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On April 7, 2018, 12:04 a.m., Justin Venus wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66490/
> ---
>
> (Updated April 7, 2018, 12:04 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Renan DelValle, and Zameer Manji.
>
>
> Bugs: AURORA-1983
> https://issues.apache.org/jira/browse/AURORA-1983
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This change implements the docker/volume isolator as described at
> http://mesos.apache.org/documentation/latest/isolators/docker-volume/.
>
> * update config thrift tests to check for docker/volume isolator support
> * update mesos task factory to support docker/volume isolator
> * update documentation for docker/volume isolator support
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> ef754e32172e7490a47a13e7b526f243ffa3efeb
> docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
> bcb2bbf882f43d813dd26c746d806e78bae6bcf3
> src/main/python/apache/aurora/config/schema/base.py
> a629bcd1261e5959da0a8458a55545d4e2c2a7a5
> src/main/python/apache/aurora/config/thrift.py
> 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431
> src/test/python/apache/aurora/config/test_thrift.py
> 8e1d0e177959af12b97bdd1cd47845b72bc12fe1
>
>
> Diff: https://reviews.apache.org/r/66490/diff/2/
>
>
> Testing
> ---
>
> Tests pass locally
> ```sh
> ./gradlew test
> ./pants test src/test/python::
> ```
>
> I've deployed this code to a test cluster with rexray, dvdcli, and the agents
> have `docker/volume` isolation enabled. I am able to exercise mounting an
> EBS volume as I would expect into a container.
>
>
> Thanks,
>
> Justin Venus
>
>
Re: Review Request 66490: Implement Mesos docker/volume isolator support for aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66490/ --- (Updated April 7, 2018, 12:04 a.m.) Review request for Aurora, Joshua Cohen, Renan DelValle, and Zameer Manji. Changes --- fixing style issues "@ReviewBot retry" Bugs: AURORA-1983 https://issues.apache.org/jira/browse/AURORA-1983 Repository: aurora Description --- This change implements the docker/volume isolator as described at http://mesos.apache.org/documentation/latest/isolators/docker-volume/. * update config thrift tests to check for docker/volume isolator support * update mesos task factory to support docker/volume isolator * update documentation for docker/volume isolator support Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/api.thrift ef754e32172e7490a47a13e7b526f243ffa3efeb docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java bcb2bbf882f43d813dd26c746d806e78bae6bcf3 src/main/python/apache/aurora/config/schema/base.py a629bcd1261e5959da0a8458a55545d4e2c2a7a5 src/main/python/apache/aurora/config/thrift.py 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 src/test/python/apache/aurora/config/test_thrift.py 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 Diff: https://reviews.apache.org/r/66490/diff/2/ Changes: https://reviews.apache.org/r/66490/diff/1-2/ Testing --- Tests pass locally ```sh ./gradlew test ./pants test src/test/python:: ``` I've deployed this code to a test cluster with rexray, dvdcli, and the agents have `docker/volume` isolation enabled. I am able to exercise mounting an EBS volume as I would expect into a container. Thanks, Justin Venus
Re: Review Request 66490: Implement Mesos docker/volume isolator support for aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66490/#review200687
---
Master (70d043e) is red with this patch.
./build-support/jenkins/build.sh
[223] ./src/main/js/index.js 3.43 kB {0} [built]
+ 268 hidden modules
:processResources
:classes
:jar
:moreStartScripts
:startScripts
:distTar
:distZip
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processTestResources
:testClasses
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:66:15:
Unused import - org.apache.aurora.gen.apiConstants.DEPRECATED_PATH_SENTINEL.
[UnusedImports]
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java:285:
Line is longer than 100 characters (found 115). [LineLength]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 4m 15s
32 actionable tasks: 26 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On April 6, 2018, 11:49 p.m., Justin Venus wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66490/
> ---
>
> (Updated April 6, 2018, 11:49 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Renan DelValle, and Zameer Manji.
>
>
> Bugs: AURORA-1983
> https://issues.apache.org/jira/browse/AURORA-1983
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This change implements the docker/volume isolator as described at
> http://mesos.apache.org/documentation/latest/isolators/docker-volume/.
>
> * update config thrift tests to check for docker/volume isolator support
> * update mesos task factory to support docker/volume isolator
> * update documentation for docker/volume isolator support
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> ef754e32172e7490a47a13e7b526f243ffa3efeb
> docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
> bcb2bbf882f43d813dd26c746d806e78bae6bcf3
> src/main/python/apache/aurora/config/schema/base.py
> a629bcd1261e5959da0a8458a55545d4e2c2a7a5
> src/main/python/apache/aurora/config/thrift.py
> 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431
> src/test/python/apache/aurora/config/test_thrift.py
> 8e1d0e177959af12b97bdd1cd47845b72bc12fe1
>
>
> Diff: https://reviews.apache.org/r/66490/diff/1/
>
>
> Testing
> ---
>
> Tests pass locally
> ```sh
> ./gradlew test
> ./pants test src/test/python::
> ```
>
> I've deployed this code to a test cluster with rexray, dvdcli, and the agents
> have `docker/volume` isolation enabled. I am able to exercise mounting an
> EBS volume as I would expect into a container.
>
>
> Thanks,
>
> Justin Venus
>
>
Review Request 66490: Implement Mesos docker/volume isolator support for aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66490/ --- Review request for Aurora, Joshua Cohen, Renan DelValle, and Zameer Manji. Bugs: AURORA-1983 https://issues.apache.org/jira/browse/AURORA-1983 Repository: aurora Description --- This change implements the docker/volume isolator as described at http://mesos.apache.org/documentation/latest/isolators/docker-volume/. * update config thrift tests to check for docker/volume isolator support * update mesos task factory to support docker/volume isolator * update documentation for docker/volume isolator support Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift ef754e32172e7490a47a13e7b526f243ffa3efeb docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java bcb2bbf882f43d813dd26c746d806e78bae6bcf3 src/main/python/apache/aurora/config/schema/base.py a629bcd1261e5959da0a8458a55545d4e2c2a7a5 src/main/python/apache/aurora/config/thrift.py 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 src/test/python/apache/aurora/config/test_thrift.py 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 Diff: https://reviews.apache.org/r/66490/diff/1/ Testing --- Tests pass locally ```sh ./gradlew test ./pants test src/test/python:: ``` I've deployed this code to a test cluster with rexray, dvdcli, and the agents have `docker/volume` isolation enabled. I am able to exercise mounting an EBS volume as I would expect into a container. Thanks, Justin Venus
Re: Review Request 66482: Fixing issue where OpenJDK PPA would not install in Ubuntu Trusty in packaging tests.
> On April 6, 2018, 7:12 a.m., Stephan Erb wrote: > > Ship it! > > > > Btw, what is our plan for trusty? The end-of-live is near > > https://www.ubuntu.com/info/release-end-of-life, so we could ask on the > > mailinglist who is using it and stop building packages for it after 0.20. Woah, I didn't realize how close we were to that point, good catch. It looks like the end of life will come in April 2019. Since that's about a year out, my vote is to propose sunsetting official Trusty packages after 0.21.0. Mind kicking off the discussion for this? - Renan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66482/#review200649 --- On April 5, 2018, 4:58 p.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66482/ > --- > > (Updated April 5, 2018, 4:58 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora-packaging > > > Description > --- > > * Reinstalled certificates in Ubuntu trusty upon provisioning in order to fix > an issue where the OpenJDK PPA could not be installed. > * Updated RBT to lastest version 0.7.11 > > > Diffs > - > > rbt 5b94e53357e8934df040e603efc9ad2378ff6575 > test/deb/ubuntu-trusty/provision.sh > 2d886bf3e3e1e46870e87df8eec7c2018f5bd4e2 > > > Diff: https://reviews.apache.org/r/66482/diff/1/ > > > Testing > --- > > Tested Trusty packages using the modified provisioning script. > > > Thanks, > > Renan DelValle > >
Re: Review Request 66482: Fixing issue where OpenJDK PPA would not install in Ubuntu Trusty in packaging tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66482/#review200649 --- Ship it! Ship it! Btw, what is our plan for trusty? The end-of-live is near https://www.ubuntu.com/info/release-end-of-life, so we could ask on the mailinglist who is using it and stop building packages for it after 0.20. - Stephan Erb On April 6, 2018, 1:58 a.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66482/ > --- > > (Updated April 6, 2018, 1:58 a.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora-packaging > > > Description > --- > > * Reinstalled certificates in Ubuntu trusty upon provisioning in order to fix > an issue where the OpenJDK PPA could not be installed. > * Updated RBT to lastest version 0.7.11 > > > Diffs > - > > rbt 5b94e53357e8934df040e603efc9ad2378ff6575 > test/deb/ubuntu-trusty/provision.sh > 2d886bf3e3e1e46870e87df8eec7c2018f5bd4e2 > > > Diff: https://reviews.apache.org/r/66482/diff/1/ > > > Testing > --- > > Tested Trusty packages using the modified provisioning script. > > > Thanks, > > Renan DelValle > >
