Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-03 Thread Reza Motamedi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66716/#review202386
---




api/src/main/thrift/org/apache/aurora/gen/api.thrift
Lines 248 (patched)


Should the comment be updated to match the struct in resolution?

Ms is milli secs, right?



api/src/main/thrift/org/apache/aurora/gen/api.thrift
Lines 1241 (patched)


s/of the host/of the hosts


- Reza Motamedi


On May 1, 2018, 9:19 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66716/
> ---
> 
> (Updated May 1, 2018, 9:19 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> `Tasks` can specify custom SLA requirements as part of
> their `TaskConfig`. One of the new features is the ability
> to specify an external coordinator that can ACK/NACK
> maintenance requests for tasks. This will be hugely
> beneficial for onboarding services that cannot satisfactorily
> specify SLA in terms of running instances.
> 
> Maintenance requests are driven from the Scheduler to
> improve management of nodes in the cluster.
> 
> 
> Note to reviewers:
> - Test coverage is minimal at this point. Expect more coverage soon in the 
> next diff.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
> b79e2045ccda05d5058565f81988dfe33feea8f1 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> f58c66aaebe8d31913d67a05add0f3d6054e88d1 
>   src/main/java/org/apache/aurora/scheduler/state/SlaManager.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
> 0e0f90b670bbbcd6cb3aa302ce4a9abfe70ea979 
>   src/main/java/org/apache/aurora/scheduler/storage/HostMaintenanceStore.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> da5534f886e032ca5a182f3704aa335ff680b258 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/DurableStorage.java
>  f1fdc275d3958a36bbe79110d70dfeba640a948a 
>   src/main/java/org/apache/aurora/scheduler/storage/durability/Loader.java 
> 10864f122eff5027c88d835baae6de483d960218 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java
>  8d70cae35289a9e36142bab288cf0c9398ebd2d4 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotService.java 
> b30de881eafa3226fdc32383b4e9bfd33ca912a5 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotterImpl.java 
> 4b52be02001e704f4b1a5f447226ac8c2386e3fd 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemHostMaintenanceStore.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 9f324b010db7e351e98b257d8fc8fecfeac81268 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
> edcea09b4d206cfddb642074237b031ad71cff13 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  9fc0416086dd3eb2e2f4e8f659da59fcdea2b22b 
>   src/main/python/apache/aurora/config/schema/base.py 
> a629bcd1261e5959da0a8458a55545d4e2c2a7a5 
>   src/main/python/apache/aurora/config/thrift.py 
> 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 561f9452aedda4cc695c84a2a850bdd7e1d65dec 
>   src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 778148a7c033cba9004954cabc33a2b1d003dccf 
>   src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 
> e66ec116112df164106598d9ff0bc9e8f465e44f 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  770846e84e9980ea3dbf9e1c46b0d45c5488c5b3 
>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 
> ba03ff94bb5fee2b09a6660a9ad759cece7449f1 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/WriteRecorderTest.java
>  27c8c829cd1e417dd5e60a8e9415331ca4a7c918 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotterImplIT.java 
> be07361a27afefa21cc2ba76ce82531a418d9814 
>   
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
>  d59118be13342da9003b0bcb97e12e477d9edf8f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 
>

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-03 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66537/#review202384
---


Ship it!




Ship It!

- Renan DelValle


On May 2, 2018, 6:06 p.m., Steve Salevan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66537/
> ---
> 
> (Updated May 2, 2018, 6:06 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Hey there!
> 
> Over here at Spine we've added a few enhancements to Aurora's Docker 
> functionality to support several of our use cases. We'd like to submit these 
> back up to the upstream to support the great work y'all are doing in this 
> space.
> 
> Here's what's included in this RB:
> 
> * Support for the force_pull flag to help ensure container freshness
> * Overrides for a Docker --entrypoint which can be specified on the job
> * Support for alternative Docker networks (defaults to HOST)
> * Support for user Docker networks
> 
> We currently use Aurora to schedule Docker containers without the use of 
> Thermos, so we've added support for server-side templating of common Thermos 
> variables into Docker executor's parameters for this purpose.
> 
> This change modifies Aurora's api.thrift with several new optional fields, 
> and all added code handles their absence gracefully, so no backfills have 
> been added. We've threaded these schema changes through to the Python Aurora 
> client alongside support for the Mesos Fetcher URIs already supported 
> server-side.
> 
> Let me know what you think and thanks!
> 
> 
> Diffs
> -
> 
>   .gitignore 9ce74ebbbc57b77d912eaa573a8fb18ed4aa3c15 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  4073229b74d0e0e7fd31552bd96894ceb8a0971a 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bcb2bbf882f43d813dd26c746d806e78bae6bcf3 
>   src/main/python/apache/aurora/config/schema/base.py 
> a629bcd1261e5959da0a8458a55545d4e2c2a7a5 
>   src/main/python/apache/aurora/config/thrift.py 
> 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 
>   src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 778148a7c033cba9004954cabc33a2b1d003dccf 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  749ffeac6cb851f32bba7606390203d7a046a0e6 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 686087ef858b8a5a8e956d82a7bd692f7be28b12 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 40851c419e4d62e6545959eebc0ce144fdecc697 
>   src/test/python/apache/aurora/client/cli/test_inspect.py 
> e4f43d0573c7862adc9bc679f4cea40cc76eac38 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob
>  88e1c36a1aa2d192b95963f7aa36e243a447e4af 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate
>  32fdcdacde58345cdd6c4b449b82c0c90c2b2aae 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks
>  4323031ec6bd128576c2a43ebc11f04a9f046e2f 
> 
> 
> Diff: https://reviews.apache.org/r/66537/diff/4/
> 
> 
> Testing
> ---
> 
> Unit tests for all new functionality have been added and run cleanly 
> alongside checkstyle/static analysis tooling.
> 
> Operational/functional testing completed within Spine infrastructure.
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66537/#review202372
---


Ship it!




Master (a3d596e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 2, 2018, 6:06 p.m., Steve Salevan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66537/
> ---
> 
> (Updated May 2, 2018, 6:06 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Hey there!
> 
> Over here at Spine we've added a few enhancements to Aurora's Docker 
> functionality to support several of our use cases. We'd like to submit these 
> back up to the upstream to support the great work y'all are doing in this 
> space.
> 
> Here's what's included in this RB:
> 
> * Support for the force_pull flag to help ensure container freshness
> * Overrides for a Docker --entrypoint which can be specified on the job
> * Support for alternative Docker networks (defaults to HOST)
> * Support for user Docker networks
> 
> We currently use Aurora to schedule Docker containers without the use of 
> Thermos, so we've added support for server-side templating of common Thermos 
> variables into Docker executor's parameters for this purpose.
> 
> This change modifies Aurora's api.thrift with several new optional fields, 
> and all added code handles their absence gracefully, so no backfills have 
> been added. We've threaded these schema changes through to the Python Aurora 
> client alongside support for the Mesos Fetcher URIs already supported 
> server-side.
> 
> Let me know what you think and thanks!
> 
> 
> Diffs
> -
> 
>   .gitignore 9ce74ebbbc57b77d912eaa573a8fb18ed4aa3c15 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  4073229b74d0e0e7fd31552bd96894ceb8a0971a 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bcb2bbf882f43d813dd26c746d806e78bae6bcf3 
>   src/main/python/apache/aurora/config/schema/base.py 
> a629bcd1261e5959da0a8458a55545d4e2c2a7a5 
>   src/main/python/apache/aurora/config/thrift.py 
> 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 
>   src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 778148a7c033cba9004954cabc33a2b1d003dccf 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  749ffeac6cb851f32bba7606390203d7a046a0e6 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 686087ef858b8a5a8e956d82a7bd692f7be28b12 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 40851c419e4d62e6545959eebc0ce144fdecc697 
>   src/test/python/apache/aurora/client/cli/test_inspect.py 
> e4f43d0573c7862adc9bc679f4cea40cc76eac38 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob
>  88e1c36a1aa2d192b95963f7aa36e243a447e4af 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate
>  32fdcdacde58345cdd6c4b449b82c0c90c2b2aae 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks
>  4323031ec6bd128576c2a43ebc11f04a9f046e2f 
> 
> 
> Diff: https://reviews.apache.org/r/66537/diff/4/
> 
> 
> Testing
> ---
> 
> Unit tests for all new functionality have been added and run cleanly 
> alongside checkstyle/static analysis tooling.
> 
> Operational/functional testing completed within Spine infrastructure.
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-03 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66537/#review202370
---



@ReviewBot retry

- Renan DelValle


On May 2, 2018, 6:06 p.m., Steve Salevan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66537/
> ---
> 
> (Updated May 2, 2018, 6:06 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Hey there!
> 
> Over here at Spine we've added a few enhancements to Aurora's Docker 
> functionality to support several of our use cases. We'd like to submit these 
> back up to the upstream to support the great work y'all are doing in this 
> space.
> 
> Here's what's included in this RB:
> 
> * Support for the force_pull flag to help ensure container freshness
> * Overrides for a Docker --entrypoint which can be specified on the job
> * Support for alternative Docker networks (defaults to HOST)
> * Support for user Docker networks
> 
> We currently use Aurora to schedule Docker containers without the use of 
> Thermos, so we've added support for server-side templating of common Thermos 
> variables into Docker executor's parameters for this purpose.
> 
> This change modifies Aurora's api.thrift with several new optional fields, 
> and all added code handles their absence gracefully, so no backfills have 
> been added. We've threaded these schema changes through to the Python Aurora 
> client alongside support for the Mesos Fetcher URIs already supported 
> server-side.
> 
> Let me know what you think and thanks!
> 
> 
> Diffs
> -
> 
>   .gitignore 9ce74ebbbc57b77d912eaa573a8fb18ed4aa3c15 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  4073229b74d0e0e7fd31552bd96894ceb8a0971a 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bcb2bbf882f43d813dd26c746d806e78bae6bcf3 
>   src/main/python/apache/aurora/config/schema/base.py 
> a629bcd1261e5959da0a8458a55545d4e2c2a7a5 
>   src/main/python/apache/aurora/config/thrift.py 
> 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 
>   src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 778148a7c033cba9004954cabc33a2b1d003dccf 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  749ffeac6cb851f32bba7606390203d7a046a0e6 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 686087ef858b8a5a8e956d82a7bd692f7be28b12 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 40851c419e4d62e6545959eebc0ce144fdecc697 
>   src/test/python/apache/aurora/client/cli/test_inspect.py 
> e4f43d0573c7862adc9bc679f4cea40cc76eac38 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob
>  88e1c36a1aa2d192b95963f7aa36e243a447e4af 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate
>  32fdcdacde58345cdd6c4b449b82c0c90c2b2aae 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks
>  4323031ec6bd128576c2a43ebc11f04a9f046e2f 
> 
> 
> Diff: https://reviews.apache.org/r/66537/diff/4/
> 
> 
> Testing
> ---
> 
> Unit tests for all new functionality have been added and run cleanly 
> alongside checkstyle/static analysis tooling.
> 
> Operational/functional testing completed within Spine infrastructure.
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-03 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66716/#review202363
---



The interface for SlaManager looks good to me! Thanks for the refactors :)


src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java
Lines 144-150 (patched)


If bound in a private module, you don't need to have a `@Named` annotation 
(I don't think it is used anywhere else).

Additionally, maybe use `@Qualifier` instead (e.g. 
https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java#L60-L62).
 Not entirely sure what the difference is myself but this is used more 
throughout the project.



src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java
Line 157 (original), 203 (patched)


This name confused me a bit. For me, it implies there will be a 
long-running method continually doing something but this is a one-time thing.

Maybe rename to `checkForDrainingTasks` or something?



src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java
Lines 259 (patched)


nit: newline after



src/main/java/org/apache/aurora/scheduler/state/SlaManager.java
Lines 60-65 (patched)


Maybe use a private binding for this, or a `@Qualifier` (see my comments on 
`StateModule` for more context.



src/main/java/org/apache/aurora/scheduler/state/SlaManager.java
Lines 152 (patched)


nit: newline after



src/main/java/org/apache/aurora/scheduler/state/SlaManager.java
Lines 153-155 (patched)


Do we need to immediately return after this?

If I am going to force the work to be done, do I need to even call this 
method?



src/main/java/org/apache/aurora/scheduler/state/SlaManager.java
Lines 186 (patched)


nit: newline after



src/main/java/org/apache/aurora/scheduler/state/StateModule.java
Lines 97-107 (patched)


We may want this as a private binding since `WebhookModule` also uses this 
class.



src/main/java/org/apache/aurora/scheduler/state/StateModule.java
Lines 115-116 (patched)


I think this (+ its dependencies and options) may be better suited for the 
`SlaModule`.



src/main/java/org/apache/aurora/scheduler/state/StateModule.java
Lines 131-140 (patched)


I would create a `MaintenanceModule` and move this.


- Jordan Ly


On May 1, 2018, 9:19 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66716/
> ---
> 
> (Updated May 1, 2018, 9:19 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> `Tasks` can specify custom SLA requirements as part of
> their `TaskConfig`. One of the new features is the ability
> to specify an external coordinator that can ACK/NACK
> maintenance requests for tasks. This will be hugely
> beneficial for onboarding services that cannot satisfactorily
> specify SLA in terms of running instances.
> 
> Maintenance requests are driven from the Scheduler to
> improve management of nodes in the cluster.
> 
> 
> Note to reviewers:
> - Test coverage is minimal at this point. Expect more coverage soon in the 
> next diff.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
> b79e2045ccda05d5058565f81988dfe33feea8f1 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> f58c66aaebe8d31913d67a05add0f3d6054e88d1 
>   src/main/java/org/apache/aurora/scheduler/state/SlaManager.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
> 0e0f90b670bbbcd6cb3aa302ce4a9abfe70ea979 
>   src/main/java/org/apache/aurora/scheduler/storage/HostMaintenanceStore.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> da5534f886e032ca5a182f3704aa335ff680b258 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/DurableStorage.java
>  f1fdc275d3958a36bbe79110d70dfeba640a948a 
>   src/main/java/org/apache/aurora/scheduler/storage/durability/Loader.java 
>

Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-03 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/#review202343
---


Ship it!




LGTM.

I think the Webhook test is being flaky again :/


Vagrantfile
Lines 20-21 (original), 20-21 (patched)


Should we need to update (or remove) this comment?


- Jordan Ly


On May 2, 2018, 10:08 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66922/
> ---
> 
> (Updated May 2, 2018, 10:08 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Changing Vagrant requirements to latest version for launching our local dev 
> box.
> 
> Needed since we depend on the Vagrant Cloud instead of Atlas now.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 
> 
> 
> Diff: https://reviews.apache.org/r/66922/diff/1/
> 
> 
> Testing
> ---
> 
> Ran vagrant box with latest Vagrant version (2.0.4).
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>