Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review86104 --- @ReviewBot retry - Bhuvan Arumugam On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/ --- (Updated May 21, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1237 https://issues.apache.org/jira/browse/AURORA-1237 Repository: aurora Description --- The tasks inside container should run as user that match aurora-role, if --nosetuid option is not passed for executor. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1237 Diffs - src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 Diff: https://reviews.apache.org/r/34568/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/ --- (Updated May 21, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1237 https://issues.apache.org/jira/browse/AURORA-1237 Repository: aurora Description --- The tasks inside container should run as user that match aurora-role, if --nosetuid option is not passed for executor. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1237 Diffs (updated) - src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 Diff: https://reviews.apache.org/r/34568/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 21, 2015, 6:53 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- - incorporate review comments from @zmanji in irc. - fix tests Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs (updated) - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 21, 2015, 7:53 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- handle review comments from zmanji Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs (updated) - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 9 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs (updated) - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 8:15 p.m.) Review request for Aurora. Summary (updated) - Fix the path to download stdout/stderr Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description (updated) --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs (updated) - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: download url for stdout/stderr broken
On April 20, 2015, 6:14 p.m., Aurora ReviewBot wrote: Master (b18dc44) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry @ReviewBot retry - Bhuvan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review80771 --- On April 20, 2015, 5:57 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 5:57 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Fix the path to download stdout/stderr. Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Review Request 33366: download url for stdout/stderr broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Fix the path to download stdout/stderr. Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: download url for stdout/stderr broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review80777 --- @wfarner, thank you for the review comment. I did ReviewBot retry before I saw your 1st comment. I will revise the patch with unittests. - Bhuvan Arumugam On April 20, 2015, 5:57 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 5:57 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Fix the path to download stdout/stderr. Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
