Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs
> On April 17, 2018, 10:11 p.m., Renan DelValle wrote: > > Overall looks great! Few fixes here and there and we should be able to land > > this in master quickly. > > > > It would be nice if a check were added for rejecting requests from the > > scheduler side that were misconfigured. > > > > For example, if a job specifies using HOST network, but doesn't provide the > > name. > > > > You can do this from here: > > https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java#L300 You bet. With this patch, the only newly invalid configuration is when a client sets the network field to USER and does not specify a userNetworkName. I've added a check and a unit test for this particular case. > On April 17, 2018, 10:11 p.m., Renan DelValle wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 243 (patched) > > <https://reviews.apache.org/r/66537/diff/3/?file=1995347#file1995347line243> > > > > This looks like it could benefit from some refactoring (or maybe just a > > simple name change). It's a bit confusing from the standpoint of a user to > > have this exist even when using a non-user defined network interface. > > > > Maybe it would be more intuitive to have DockerNetwork become > > DockerNetworkType. > > > > And Docker Network to be a Union of the different Docker network types > > like we do for Result. Agreed, I think the best approach here may be to rename userNetwork to userNetworkName; this would be immediately familiar to anyone coming from Docker itself. > On April 17, 2018, 10:11 p.m., Renan DelValle wrote: > > src/main/python/apache/aurora/config/schema/base.py > > Line 18 (original), 18 (patched) > > <https://reviews.apache.org/r/66537/diff/3/?file=1995349#file1995349line18> > > > > Can we get away without importing Enum from pystaachio? (I only ask > > because I don't see it being used in this file). Definitely, eliminated. - Steve ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review201350 --- On May 3, 2018, 1:06 a.m., Steve Salevan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66537/ > --- > > (Updated May 3, 2018, 1:06 a.m.) > > > Review request for Aurora, Renan DelValle and Stephan Erb. > > > Repository: aurora > > > Description > --- > > Hey there! > > Over here at Spine we've added a few enhancements to Aurora's Docker > functionality to support several of our use cases. We'd like to submit these > back up to the upstream to support the great work y'all are doing in this > space. > > Here's what's included in this RB: > > * Support for the force_pull flag to help ensure container freshness > * Overrides for a Docker --entrypoint which can be specified on the job > * Support for alternative Docker networks (defaults to HOST) > * Support for user Docker networks > > We currently use Aurora to schedule Docker containers without the use of > Thermos, so we've added support for server-side templating of common Thermos > variables into Docker executor's parameters for this purpose. > > This change modifies Aurora's api.thrift with several new optional fields, > and all added code handles their absence gracefully, so no backfills have > been added. We've threaded these schema changes through to the Python Aurora > client alongside support for the Mesos Fetcher URIs already supported > server-side. > > Let me know what you think and thanks! > > > Diffs > - > > .gitignore 9ce74ebbbc57b77d912eaa573a8fb18ed4aa3c15 > api/src/main/thrift/org/apache/aurora/gen/api.thrift > ef754e32172e7490a47a13e7b526f243ffa3efeb > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 4073229b74d0e0e7fd31552bd96894ceb8a0971a > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > bcb2bbf882f43d813dd26c746d806e78bae6bcf3 > src/main/python/apache/aurora/config/schema/base.py > a629bcd1261e5959da0a8458a55545d4e2c2a7a5 > src/main/python/apache/aurora/config/thrift.py > 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 > src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 778148a7c
Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/ --- (Updated May 3, 2018, 1:06 a.m.) Review request for Aurora, Renan DelValle and Stephan Erb. Changes --- Addressing RB comments Repository: aurora Description --- Hey there! Over here at Spine we've added a few enhancements to Aurora's Docker functionality to support several of our use cases. We'd like to submit these back up to the upstream to support the great work y'all are doing in this space. Here's what's included in this RB: * Support for the force_pull flag to help ensure container freshness * Overrides for a Docker --entrypoint which can be specified on the job * Support for alternative Docker networks (defaults to HOST) * Support for user Docker networks We currently use Aurora to schedule Docker containers without the use of Thermos, so we've added support for server-side templating of common Thermos variables into Docker executor's parameters for this purpose. This change modifies Aurora's api.thrift with several new optional fields, and all added code handles their absence gracefully, so no backfills have been added. We've threaded these schema changes through to the Python Aurora client alongside support for the Mesos Fetcher URIs already supported server-side. Let me know what you think and thanks! Diffs (updated) - .gitignore 9ce74ebbbc57b77d912eaa573a8fb18ed4aa3c15 api/src/main/thrift/org/apache/aurora/gen/api.thrift ef754e32172e7490a47a13e7b526f243ffa3efeb src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 4073229b74d0e0e7fd31552bd96894ceb8a0971a src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java bcb2bbf882f43d813dd26c746d806e78bae6bcf3 src/main/python/apache/aurora/config/schema/base.py a629bcd1261e5959da0a8458a55545d4e2c2a7a5 src/main/python/apache/aurora/config/thrift.py 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 778148a7c033cba9004954cabc33a2b1d003dccf src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 749ffeac6cb851f32bba7606390203d7a046a0e6 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 686087ef858b8a5a8e956d82a7bd692f7be28b12 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40851c419e4d62e6545959eebc0ce144fdecc697 src/test/python/apache/aurora/client/cli/test_inspect.py e4f43d0573c7862adc9bc679f4cea40cc76eac38 src/test/python/apache/aurora/config/test_thrift.py 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob 88e1c36a1aa2d192b95963f7aa36e243a447e4af src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 32fdcdacde58345cdd6c4b449b82c0c90c2b2aae src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks 4323031ec6bd128576c2a43ebc11f04a9f046e2f Diff: https://reviews.apache.org/r/66537/diff/4/ Changes: https://reviews.apache.org/r/66537/diff/3-4/ Testing --- Unit tests for all new functionality have been added and run cleanly alongside checkstyle/static analysis tooling. Operational/functional testing completed within Spine infrastructure. Thanks, Steve Salevan
Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/ --- (Updated April 11, 2018, 2:17 a.m.) Review request for Aurora, Renan DelValle and Stephan Erb. Changes --- Corrects failing unit test @ReviewBot retry Repository: aurora Description --- Hey there! Over here at Spine we've added a few enhancements to Aurora's Docker functionality to support several of our use cases. We'd like to submit these back up to the upstream to support the great work y'all are doing in this space. Here's what's included in this RB: * Support for the force_pull flag to help ensure container freshness * Overrides for a Docker --entrypoint which can be specified on the job * Support for alternative Docker networks (defaults to HOST) * Support for user Docker networks We currently use Aurora to schedule Docker containers without the use of Thermos, so we've added support for server-side templating of common Thermos variables into Docker executor's parameters for this purpose. This change modifies Aurora's api.thrift with several new optional fields, and all added code handles their absence gracefully, so no backfills have been added. We've threaded these schema changes through to the Python Aurora client alongside support for the Mesos Fetcher URIs already supported server-side. Let me know what you think and thanks! Diffs (updated) - .gitignore 9ce74ebbbc57b77d912eaa573a8fb18ed4aa3c15 api/src/main/thrift/org/apache/aurora/gen/api.thrift ef754e32172e7490a47a13e7b526f243ffa3efeb src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java bcb2bbf882f43d813dd26c746d806e78bae6bcf3 src/main/python/apache/aurora/config/schema/base.py a629bcd1261e5959da0a8458a55545d4e2c2a7a5 src/main/python/apache/aurora/config/thrift.py 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 778148a7c033cba9004954cabc33a2b1d003dccf src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 686087ef858b8a5a8e956d82a7bd692f7be28b12 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40851c419e4d62e6545959eebc0ce144fdecc697 src/test/python/apache/aurora/client/cli/test_inspect.py e4f43d0573c7862adc9bc679f4cea40cc76eac38 src/test/python/apache/aurora/config/test_thrift.py 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob 88e1c36a1aa2d192b95963f7aa36e243a447e4af src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 32fdcdacde58345cdd6c4b449b82c0c90c2b2aae src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks 4323031ec6bd128576c2a43ebc11f04a9f046e2f Diff: https://reviews.apache.org/r/66537/diff/3/ Changes: https://reviews.apache.org/r/66537/diff/2-3/ Testing --- Unit tests for all new functionality have been added and run cleanly alongside checkstyle/static analysis tooling. Operational/functional testing completed within Spine infrastructure. Thanks, Steve Salevan
Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/ --- (Updated April 11, 2018, 1:45 a.m.) Review request for Aurora, Renan DelValle and Stephan Erb. Changes --- Corrects ReviewBot's Python checkstyle issues @ReviewBot retry Repository: aurora Description --- Hey there! Over here at Spine we've added a few enhancements to Aurora's Docker functionality to support several of our use cases. We'd like to submit these back up to the upstream to support the great work y'all are doing in this space. Here's what's included in this RB: * Support for the force_pull flag to help ensure container freshness * Overrides for a Docker --entrypoint which can be specified on the job * Support for alternative Docker networks (defaults to HOST) * Support for user Docker networks We currently use Aurora to schedule Docker containers without the use of Thermos, so we've added support for server-side templating of common Thermos variables into Docker executor's parameters for this purpose. This change modifies Aurora's api.thrift with several new optional fields, and all added code handles their absence gracefully, so no backfills have been added. We've threaded these schema changes through to the Python Aurora client alongside support for the Mesos Fetcher URIs already supported server-side. Let me know what you think and thanks! Diffs (updated) - .gitignore 9ce74ebbbc57b77d912eaa573a8fb18ed4aa3c15 api/src/main/thrift/org/apache/aurora/gen/api.thrift ef754e32172e7490a47a13e7b526f243ffa3efeb src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java bcb2bbf882f43d813dd26c746d806e78bae6bcf3 src/main/python/apache/aurora/config/schema/base.py a629bcd1261e5959da0a8458a55545d4e2c2a7a5 src/main/python/apache/aurora/config/thrift.py 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 778148a7c033cba9004954cabc33a2b1d003dccf src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 686087ef858b8a5a8e956d82a7bd692f7be28b12 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40851c419e4d62e6545959eebc0ce144fdecc697 src/test/python/apache/aurora/config/test_thrift.py 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob 88e1c36a1aa2d192b95963f7aa36e243a447e4af src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 32fdcdacde58345cdd6c4b449b82c0c90c2b2aae src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks 4323031ec6bd128576c2a43ebc11f04a9f046e2f Diff: https://reviews.apache.org/r/66537/diff/2/ Changes: https://reviews.apache.org/r/66537/diff/1-2/ Testing --- Unit tests for all new functionality have been added and run cleanly alongside checkstyle/static analysis tooling. Operational/functional testing completed within Spine infrastructure. Thanks, Steve Salevan
Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/ --- Review request for Aurora. Repository: aurora Description --- Hey there! Over here at Spine we've added a few enhancements to Aurora's Docker functionality to support several of our use cases. We'd like to submit these back up to the upstream to support the great work y'all are doing in this space. Here's what's included in this RB: * Support for the force_pull flag to help ensure container freshness * Overrides for a Docker --entrypoint which can be specified on the job * Support for alternative Docker networks (defaults to HOST) * Support for user Docker networks We currently use Aurora to schedule Docker containers without the use of Thermos, so we've added support for server-side templating of common Thermos variables into Docker executor's parameters for this purpose. This change modifies Aurora's api.thrift with several new optional fields, and all added code handles their absence gracefully, so no backfills have been added. We've threaded these schema changes through to the Python Aurora client alongside support for the Mesos Fetcher URIs already supported server-side. Let me know what you think and thanks! Diffs - .gitignore 9ce74ebbbc57b77d912eaa573a8fb18ed4aa3c15 api/src/main/thrift/org/apache/aurora/gen/api.thrift ef754e32172e7490a47a13e7b526f243ffa3efeb src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java bcb2bbf882f43d813dd26c746d806e78bae6bcf3 src/main/python/apache/aurora/config/schema/base.py a629bcd1261e5959da0a8458a55545d4e2c2a7a5 src/main/python/apache/aurora/config/thrift.py 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 778148a7c033cba9004954cabc33a2b1d003dccf src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 686087ef858b8a5a8e956d82a7bd692f7be28b12 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40851c419e4d62e6545959eebc0ce144fdecc697 src/test/python/apache/aurora/config/test_thrift.py 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob 88e1c36a1aa2d192b95963f7aa36e243a447e4af src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 32fdcdacde58345cdd6c4b449b82c0c90c2b2aae src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks 4323031ec6bd128576c2a43ebc11f04a9f046e2f Diff: https://reviews.apache.org/r/66537/diff/1/ Testing --- Unit tests for all new functionality have been added and run cleanly alongside checkstyle/static analysis tooling. Operational/functional testing completed within Spine infrastructure. Thanks, Steve Salevan
Review Request 38210: [aurora-packaging] Adds Monit supervisor support for EL6
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38210/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-1480 https://issues.apache.org/jira/browse/AURORA-1480 Repository: aurora-packaging Description --- As requested by AURORA-1480, this RB adds Monit as a runtime requirement for the aurora and aurora-thermos packages alongside some basic Monit scripts to properly supervise these processes. Let me know what you think and thanks! Diffs - specs/rpm/SOURCES/aurora.monit PRE-CREATION specs/rpm/SOURCES/thermos-observer.monit PRE-CREATION specs/rpm/aurora.spec cf9c2715106a27fcb71447b5453ad3b847d2235a Diff: https://reviews.apache.org/r/38210/diff/ Testing --- Tested Monit scripts against a local machine Thanks, Steve Salevan
Re: Review Request 38080: Remove openjdk runtime requirement.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38080/#review97594 --- Ship it! Ship It! - Steve Salevan On Sept. 2, 2015, 11:36 p.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38080/ > --- > > (Updated Sept. 2, 2015, 11:36 p.m.) > > > Review request for Aurora, Steve Salevan and Bill Farner. > > > Repository: aurora-packaging > > > Description > --- > > Remove openjdk runtime requirement. > > This addresses one of my +0s. > > > Diffs > - > > specs/rpm/aurora.spec a559b42d73a4211891d8c7569ea7ab2a3a6993ae > > Diff: https://reviews.apache.org/r/38080/diff/ > > > Testing > --- > > Using a clean vagrant environment installed aurora, then installed the oracle > jdk, then uninstalled java-1.8.0-openjdk-headless (that aurora brought in > transitively). RPM didn't complain and when I restarted the scheduler it was > running under the new JVM. > > ``` > [vagrant@localhost ~]$ curl -s http://localhost:8081/vars | grep > 'jvm_prop_java_vendor ' > jvm_prop_java_vendor Oracle Corporation > [vagrant@localhost ~]$ > ``` > > > Thanks, > > Kevin Sweeney > >
Re: Review Request 37959: Reset RPM changelog.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37959/#review97087 --- Ship it! Ship It! - Steve Salevan On Aug. 31, 2015, 5:11 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37959/ > --- > > (Updated Aug. 31, 2015, 5:11 p.m.) > > > Review request for Aurora and Steve Salevan. > > > Repository: aurora-packaging > > > Description > --- > > Reset RPM changelog. > > > Diffs > - > > specs/rpm/aurora.spec 0f3d0a735cc8c864f217b5e5de90243243738044 > > Diff: https://reviews.apache.org/r/37959/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Review Request 36370: Tidying RPM packaging README and specfile
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36370/ --- Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and Zameer Manji. Bugs: AURORA-1391 https://issues.apache.org/jira/browse/AURORA-1391 Repository: aurora Description --- This RB removes the hard dependency on daemonize for all non-EL6 builds and tidies the README.md for better readability. Let me know what you think and thanks! Diffs - build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION Diff: https://reviews.apache.org/r/36370/diff/ Testing --- Rebuilt packages Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 7:25 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 8:40 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Changes --- Preferencing Java 8 in startup script Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:09 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Changes --- Bugfixing init script breakout when no args are specified Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:05 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
> On July 6, 2015, 9:20 p.m., Kevin Sweeney wrote: > > build-support/packaging/rpm/aurora.service, line 20 > > <https://reviews.apache.org/r/33778/diff/12/?file=1000455#file1000455line20> > > > > This is unnecessary according to [1]? > > > > Alternatively you should consider doing `curl -X POST > > http://localhost:8081/quitquitquit`, which will invoke the scheduler > > graceful shutdown logic. > > > > ``` > > If this option is not specified, the process is terminated by sending > > the signal specified in KillSignal= when service stop is requested. > > ``` > > > > [1] > > http://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecStop= Good catch! I opted for removing this altogether, as systemd will by default send SIGTERM, wait for a timeout, and then send a SIGKILL, which seems like the cleanest way to rock this. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90566 --- On July 6, 2015, 9:41 p.m., Steve Salevan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33778/ > --- > > (Updated July 6, 2015, 9:41 p.m.) > > > Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-1116 > https://issues.apache.org/jira/browse/AURORA-1116 > > > Repository: aurora > > > Description > --- > > This review board adds support for building Red Hat-flavored packages for the > Aurora scheduler alongside its client and Thermos-related binaries: > > aurora - Aurora Scheduler > aurora-client - Aurora client and admin tool > aurora-thermos - Thermos executor, runner, and observer > aurora-debuginfo - Debugging symbols for Python/libmesos integration > > If you'd like to give it a whirl, the following Make targets will spin up new > RPMs: > > make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped > versioning, suitable for producing nightly updates > make (release_srpm|release_rpm) - builds without timestamped versioning > > Let me know what you think, and thanks! > > > Diffs > - > > build-support/packaging/rpm/Makefile PRE-CREATION > build-support/packaging/rpm/README.md PRE-CREATION > build-support/packaging/rpm/aurora.init.sh PRE-CREATION > build-support/packaging/rpm/aurora.logrotate PRE-CREATION > build-support/packaging/rpm/aurora.service PRE-CREATION > build-support/packaging/rpm/aurora.spec PRE-CREATION > build-support/packaging/rpm/aurora.startup.sh PRE-CREATION > build-support/packaging/rpm/aurora.sysconfig PRE-CREATION > build-support/packaging/rpm/clusters.json PRE-CREATION > build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION > build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION > build-support/packaging/rpm/thermos-observer.service PRE-CREATION > build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION > build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION > > Diff: https://reviews.apache.org/r/33778/diff/ > > > Testing > --- > > Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 > and F19 > > > Thanks, > > Steve Salevan > >
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:01 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Changes --- Documentation tweaks Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:41 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Changes --- Addressing RB concerns Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 6:30 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 6:28 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Changes --- Nuking gc_executor Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 6:11 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Changes --- Adding doc tweaks and JDK 1.8 PATH preferencing Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 12:44 a.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 12:32 a.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - build-support/packaging/rpm/Makefile PRE-CREATION build-support/packaging/rpm/README.md PRE-CREATION build-support/packaging/rpm/aurora.init.sh PRE-CREATION build-support/packaging/rpm/aurora.logrotate PRE-CREATION build-support/packaging/rpm/aurora.service PRE-CREATION build-support/packaging/rpm/aurora.spec PRE-CREATION build-support/packaging/rpm/aurora.startup.sh PRE-CREATION build-support/packaging/rpm/aurora.sysconfig PRE-CREATION build-support/packaging/rpm/clusters.json PRE-CREATION build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION build-support/packaging/rpm/thermos-observer.service PRE-CREATION build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
> On June 23, 2015, 2:55 p.m., Jake Farrell wrote: > > Are you able to update this Steve? would love to get this in for 0.9.0 The latest patch incorporates the above changes; let me know what you think. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review88987 --- On May 19, 2015, 4:19 p.m., Steve Salevan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33778/ > --- > > (Updated May 19, 2015, 4:19 p.m.) > > > Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-1116 > https://issues.apache.org/jira/browse/AURORA-1116 > > > Repository: aurora > > > Description > --- > > This review board adds support for building Red Hat-flavored packages for the > Aurora scheduler alongside its client and Thermos-related binaries: > > aurora - Aurora Scheduler > aurora-client - Aurora client and admin tool > aurora-thermos - Thermos executor, runner, and observer > aurora-debuginfo - Debugging symbols for Python/libmesos integration > > If you'd like to give it a whirl, the following Make targets will spin up new > RPMs: > > make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped > versioning, suitable for producing nightly updates > make (release_srpm|release_rpm) - builds without timestamped versioning > > Let me know what you think, and thanks! > > > Diffs > - > > packaging/rpm/Makefile PRE-CREATION > packaging/rpm/aurora.init.sh PRE-CREATION > packaging/rpm/aurora.logrotate PRE-CREATION > packaging/rpm/aurora.service PRE-CREATION > packaging/rpm/aurora.spec PRE-CREATION > packaging/rpm/aurora.startup.sh PRE-CREATION > packaging/rpm/aurora.sysconfig PRE-CREATION > packaging/rpm/clusters.json PRE-CREATION > packaging/rpm/thermos-observer.init.sh PRE-CREATION > packaging/rpm/thermos-observer.logrotate PRE-CREATION > packaging/rpm/thermos-observer.service PRE-CREATION > packaging/rpm/thermos-observer.startup.sh PRE-CREATION > packaging/rpm/thermos-observer.sysconfig PRE-CREATION > > Diff: https://reviews.apache.org/r/33778/diff/ > > > Testing > --- > > Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 > and F19 > > > Thanks, > > Steve Salevan > >
Re: Review Request 33778: Adds RPM specfile and support scripting
> On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote: > > packaging/rpm/aurora.service, line 21 > > <https://reviews.apache.org/r/33778/diff/2/?file=947994#file947994line21> > > > > The scheduler should not run as root Added support for the creation of an aurora user/group as well as logic to support running the scheduler under this user. > On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote: > > packaging/rpm/aurora.spec, line 32 > > <https://reviews.apache.org/r/33778/diff/2/?file=947995#file947995line32> > > > > support for 1.7 will be dropped in 0.9.0, I'd prefer we not get new > > users stuck here and remove this branch. Dropped. > On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote: > > packaging/rpm/aurora.spec, lines 28-34 > > <https://reviews.apache.org/r/33778/diff/5/?file=963972#file963972line28> > > > > Java 8 is required in 0.9.0 - remove this branching entirely. Dropped. > On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote: > > packaging/rpm/aurora.spec, lines 166-171 > > <https://reviews.apache.org/r/33778/diff/5/?file=963972#file963972line166> > > > > Drop this entirely now that the project is on JDK8? Dropped. > On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote: > > packaging/rpm/aurora.startup.sh, line 21 > > <https://reviews.apache.org/r/33778/diff/5/?file=963973#file963973line21> > > > > the RHS is redundant here if you change GLOG_V to GLOG_v in the > > sysconfig file. Fixed. > On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote: > > packaging/rpm/aurora.startup.sh, lines 22-23 > > <https://reviews.apache.org/r/33778/diff/5/?file=963973#file963973line22> > > > > RHS is redundant - you can just do > > > > ``` > > export GLOG_v LIBPROCESS_PORT LIBPROCES_IP > > ``` Fixed. > On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote: > > packaging/rpm/aurora.sysconfig, line 28 > > <https://reviews.apache.org/r/33778/diff/5/?file=963974#file963974line28> > > > > Is this needed? This is the default right? Alas, the Mesosphere RPM drops the necessary libmesos bits in /usr/lib instead of /usr/lib64, which is the default on an EL system, so this forces the JVM libloader to look into /usr/lib instead. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review82436 --- On May 19, 2015, 4:19 p.m., Steve Salevan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33778/ > --- > > (Updated May 19, 2015, 4:19 p.m.) > > > Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-1116 > https://issues.apache.org/jira/browse/AURORA-1116 > > > Repository: aurora > > > Description > --- > > This review board adds support for building Red Hat-flavored packages for the > Aurora scheduler alongside its client and Thermos-related binaries: > > aurora - Aurora Scheduler > aurora-client - Aurora client and admin tool > aurora-thermos - Thermos executor, runner, and observer > aurora-debuginfo - Debugging symbols for Python/libmesos integration > > If you'd like to give it a whirl, the following Make targets will spin up new > RPMs: > > make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped > versioning, suitable for producing nightly updates > make (release_srpm|release_rpm) - builds without timestamped versioning > > Let me know what you think, and thanks! > > > Diffs > - > > packaging/rpm/Makefile PRE-CREATION > packaging/rpm/aurora.init.sh PRE-CREATION > packaging/rpm/aurora.logrotate PRE-CREATION > packaging/rpm/aurora.service PRE-CREATION > packaging/rpm/aurora.spec PRE-CREATION > packaging/rpm/aurora.startup.sh PRE-CREATION > packaging/rpm/aurora.sysconfig PRE-CREATION > packaging/rpm/clusters.json PRE-CREATION > packaging/rpm/thermos-observer.init.sh PRE-CREATION > packaging/rpm/thermos-observer.logrotate PRE-CREATION > packaging/rpm/thermos-observer.service PRE-CREATION > packaging/rpm/thermos-observer.startup.sh PRE-CREATION > packaging/rpm/thermos-observer.sysconfig PRE-CREATION > > Diff: https://reviews.apache.org/r/33778/diff/ > > > Testing > --- > > Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 > and F19 > > > Thanks, > > Steve Salevan > >
Re: Review Request 33778: Adds RPM specfile and support scripting
> On June 9, 2015, 3:49 p.m., Jake Farrell wrote: > > Patch looks good. Would like to see this move from top level /packaging to > > build-support/packaging and have docs/packaging.md or > > build-support/packaging/README.md added with some details for anyone that > > may not be familiar with dependencies needed to create the packages. With > > these updates will happily commit this patch, nice work > > > > (ultimately would like to see a gradle task for deb/rpm and maybe docker > > containers used to create the packages, but that is independant of this > > patch.) Added documentation and adjusted toplevel directory. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review87208 ------- On May 19, 2015, 4:19 p.m., Steve Salevan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33778/ > --- > > (Updated May 19, 2015, 4:19 p.m.) > > > Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-1116 > https://issues.apache.org/jira/browse/AURORA-1116 > > > Repository: aurora > > > Description > --- > > This review board adds support for building Red Hat-flavored packages for the > Aurora scheduler alongside its client and Thermos-related binaries: > > aurora - Aurora Scheduler > aurora-client - Aurora client and admin tool > aurora-thermos - Thermos executor, runner, and observer > aurora-debuginfo - Debugging symbols for Python/libmesos integration > > If you'd like to give it a whirl, the following Make targets will spin up new > RPMs: > > make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped > versioning, suitable for producing nightly updates > make (release_srpm|release_rpm) - builds without timestamped versioning > > Let me know what you think, and thanks! > > > Diffs > - > > packaging/rpm/Makefile PRE-CREATION > packaging/rpm/aurora.init.sh PRE-CREATION > packaging/rpm/aurora.logrotate PRE-CREATION > packaging/rpm/aurora.service PRE-CREATION > packaging/rpm/aurora.spec PRE-CREATION > packaging/rpm/aurora.startup.sh PRE-CREATION > packaging/rpm/aurora.sysconfig PRE-CREATION > packaging/rpm/clusters.json PRE-CREATION > packaging/rpm/thermos-observer.init.sh PRE-CREATION > packaging/rpm/thermos-observer.logrotate PRE-CREATION > packaging/rpm/thermos-observer.service PRE-CREATION > packaging/rpm/thermos-observer.startup.sh PRE-CREATION > packaging/rpm/thermos-observer.sysconfig PRE-CREATION > > Diff: https://reviews.apache.org/r/33778/diff/ > > > Testing > --- > > Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 > and F19 > > > Thanks, > > Steve Salevan > >
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated May 19, 2015, 4:19 p.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Changes --- Style fixes Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - packaging/rpm/Makefile PRE-CREATION packaging/rpm/aurora.init.sh PRE-CREATION packaging/rpm/aurora.logrotate PRE-CREATION packaging/rpm/aurora.service PRE-CREATION packaging/rpm/aurora.spec PRE-CREATION packaging/rpm/aurora.startup.sh PRE-CREATION packaging/rpm/aurora.sysconfig PRE-CREATION packaging/rpm/clusters.json PRE-CREATION packaging/rpm/thermos-observer.init.sh PRE-CREATION packaging/rpm/thermos-observer.logrotate PRE-CREATION packaging/rpm/thermos-observer.service PRE-CREATION packaging/rpm/thermos-observer.startup.sh PRE-CREATION packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated May 19, 2015, 6 a.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Changes --- Addressing RB comments Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - packaging/rpm/Makefile PRE-CREATION packaging/rpm/aurora.init.sh PRE-CREATION packaging/rpm/aurora.logrotate PRE-CREATION packaging/rpm/aurora.service PRE-CREATION packaging/rpm/aurora.spec PRE-CREATION packaging/rpm/aurora.startup.sh PRE-CREATION packaging/rpm/aurora.sysconfig PRE-CREATION packaging/rpm/clusters.json PRE-CREATION packaging/rpm/thermos-observer.init.sh PRE-CREATION packaging/rpm/thermos-observer.logrotate PRE-CREATION packaging/rpm/thermos-observer.service PRE-CREATION packaging/rpm/thermos-observer.startup.sh PRE-CREATION packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
> On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/Makefile, line 15 > > <https://reviews.apache.org/r/33778/diff/3/?file=952806#file952806line15> > > > > My hunch is we should grab this from either the requirements.txt or the > > java dep, vs. specifying it here > > Zameer Manji wrote: > +1. We don't need more places to specify the mesos version. Switched to a method which obtains this via parsing requirements.txt. > On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/Makefile, line 17 > > <https://reviews.apache.org/r/33778/diff/3/?file=952806#file952806line17> > > > > If someone grabs this from the downloads page (aka, downloads a > > tarballed Release) then this won't be in a git repo. Not sure if we're > > worried about it for the people that get confused and try to build a > > "nightly" Release, but just wanted to bring it up in case this was a > > concern for others. Switched to a method which does not require usage of git. > On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/Makefile, line 18 > > <https://reviews.apache.org/r/33778/diff/3/?file=952806#file952806line18> > > > > Aha, but this will definitely cause issues if not in a git repo, which > > we don't want. If not git, just ../.. ? Switched to a method which does not require usage of git. > On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/aurora.init.sh, line 6 > > <https://reviews.apache.org/r/33778/diff/3/?file=952807#file952807line6> > > > > s/task/service Fixed. > On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/aurora.init.sh, line 7 > > <https://reviews.apache.org/r/33778/diff/3/?file=952807#file952807line7> > > > > s/services/tasks Fixed. > On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/aurora.init.sh, line 89 > > <https://reviews.apache.org/r/33778/diff/3/?file=952807#file952807line89> > > > > sweet! Thanks! > On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/aurora.spec, line 111 > > <https://reviews.apache.org/r/33778/diff/3/?file=952810#file952810line111> > > > > maybe s/executes/runs and monitors ? (just to avoid the double execut*) I dig; fixed. > On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/aurora.spec, line 184 > > <https://reviews.apache.org/r/33778/diff/3/?file=952810#file952810line184> > > > > There's also a Thermos CLI tool at > > `src/main/apache/thermos/cli/bin:thermos` This is awesome; it's now included in the current RPM. > On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/aurora.spec, line 117 > > <https://reviews.apache.org/r/33778/diff/3/?file=952810#file952810line117> > > > > Since docker support is still beta, perhaps put this behind a flag and > > only install if desired? I originally thought that we'd go this route, but I ultimately opted to include Docker as a hard requirement for the following reasons: 1. Docker is present within the current EPEL repos for EL (already required to install Thermos as libmesos requires cyrus-sasl) and is a dependency of the upstream Fedora RPMs 2. Docker support is currently enabled within the Vagrant automation 3. Docker is popular amongst the potential OSS users of Aurora As such, I think that including Docker as a hard requirement for Thermos could help drive the open source adoption of Aurora as well as being lightweight, as packaging for it already exists across all our supported platforms. > On May 11, 2015, 2:53 a.m., Joe Smith wrote: > > packaging/rpm/aurora.spec, line 152 > > <https://reviews.apache.org/r/33778/diff/3/?file=952810#file952810line152> > > > > I looked around for a gradle RPM but couldn't find it, so I'll +1 this I feel similarly about this situation; alas, official Gradle RPMs won't land upstream until F22: https://fedoraproject.org/wiki/Changes/Gradle - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review83195 --- On May 8, 2015, 5:08 a.m., Steve Salevan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33778/ > --- > > (Updated May 8, 2015, 5:08 a.m.) > > > Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Fa
Re: Review Request 33778: Adds RPM specfile and support scripting
> On May 4, 2015, 7:31 p.m., Bill Farner wrote:
> > We've had success with using vagrant to serve as test beds and build
> > environments for things like this [1]. Docker might be a boon here, as we
> > can use that in ASF's jenkins.
> >
> > Don't hesitate to punt on this for now, as it's not a ship-blocker for
> > me...but i'm curious if you have any thoughts on this.
> >
> >
> > [1]
> > https://github.com/apache/aurora/blob/master/build-support/python/make-mesos-native-egg
>
> Jake Farrell wrote:
> Though your bash-foo in make-mesos-native-egg is nice I would be a big +1
> to using docker for that as well as the packaging (rpm/deb), would love to
> see both of the packages built that way using something like
> build-support/docker/${os}/
I agree that Docker might be our best bet, as our next logical step is in
figuring out a way to stand up nightly builds and a Yum repo to contain them.
To do so we'll want to establish a base Docker image with the necessary
BuildRequires for each supported platform (EL 6/7, F19/20/21) and then write a
script that'll run through the RPM build procedure and copy the resulting RPMs
to some persistent storage, where we can then regenerate the Yum metadata.
- Steve
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33778/#review82421
---
On May 8, 2015, 5:08 a.m., Steve Salevan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33778/
> ---
>
> (Updated May 8, 2015, 5:08 a.m.)
>
>
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-1116
> https://issues.apache.org/jira/browse/AURORA-1116
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This review board adds support for building Red Hat-flavored packages for the
> Aurora scheduler alongside its client and Thermos-related binaries:
>
> aurora - Aurora Scheduler
> aurora-client - Aurora client and admin tool
> aurora-thermos - Thermos executor, runner, and observer
> aurora-debuginfo - Debugging symbols for Python/libmesos integration
>
> If you'd like to give it a whirl, the following Make targets will spin up new
> RPMs:
>
> make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped
> versioning, suitable for producing nightly updates
> make (release_srpm|release_rpm) - builds without timestamped versioning
>
> Let me know what you think, and thanks!
>
>
> Diffs
> -
>
> packaging/rpm/Makefile PRE-CREATION
> packaging/rpm/aurora.init.sh PRE-CREATION
> packaging/rpm/aurora.logrotate PRE-CREATION
> packaging/rpm/aurora.service PRE-CREATION
> packaging/rpm/aurora.spec PRE-CREATION
> packaging/rpm/aurora.startup.sh PRE-CREATION
> packaging/rpm/aurora.sysconfig PRE-CREATION
> packaging/rpm/clusters.json PRE-CREATION
> packaging/rpm/thermos-observer.init.sh PRE-CREATION
> packaging/rpm/thermos-observer.logrotate PRE-CREATION
> packaging/rpm/thermos-observer.service PRE-CREATION
> packaging/rpm/thermos-observer.startup.sh PRE-CREATION
> packaging/rpm/thermos-observer.sysconfig PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33778/diff/
>
>
> Testing
> ---
>
> Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6
> and F19
>
>
> Thanks,
>
> Steve Salevan
>
>
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated May 8, 2015, 5:08 a.m.) Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. Changes --- Adding in a few changes to better support newer Fedora iterations Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - packaging/rpm/Makefile PRE-CREATION packaging/rpm/aurora.init.sh PRE-CREATION packaging/rpm/aurora.logrotate PRE-CREATION packaging/rpm/aurora.service PRE-CREATION packaging/rpm/aurora.spec PRE-CREATION packaging/rpm/aurora.startup.sh PRE-CREATION packaging/rpm/aurora.sysconfig PRE-CREATION packaging/rpm/clusters.json PRE-CREATION packaging/rpm/thermos-observer.init.sh PRE-CREATION packaging/rpm/thermos-observer.logrotate PRE-CREATION packaging/rpm/thermos-observer.service PRE-CREATION packaging/rpm/thermos-observer.startup.sh PRE-CREATION packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Re: Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated May 2, 2015, 5:20 a.m.) Review request for Aurora. Changes --- Allows for specifiable MESOS_VERSION via Makefile env variable Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs (updated) - packaging/rpm/Makefile PRE-CREATION packaging/rpm/aurora.init.sh PRE-CREATION packaging/rpm/aurora.logrotate PRE-CREATION packaging/rpm/aurora.service PRE-CREATION packaging/rpm/aurora.spec PRE-CREATION packaging/rpm/aurora.startup.sh PRE-CREATION packaging/rpm/aurora.sysconfig PRE-CREATION packaging/rpm/clusters.json PRE-CREATION packaging/rpm/thermos-observer.init.sh PRE-CREATION packaging/rpm/thermos-observer.logrotate PRE-CREATION packaging/rpm/thermos-observer.service PRE-CREATION packaging/rpm/thermos-observer.startup.sh PRE-CREATION packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
Review Request 33778: Adds RPM specfile and support scripting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- Review request for Aurora. Bugs: AURORA-1116 https://issues.apache.org/jira/browse/AURORA-1116 Repository: aurora Description --- This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries: aurora - Aurora Scheduler aurora-client - Aurora client and admin tool aurora-thermos - Thermos executor, runner, and observer aurora-debuginfo - Debugging symbols for Python/libmesos integration If you'd like to give it a whirl, the following Make targets will spin up new RPMs: make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates make (release_srpm|release_rpm) - builds without timestamped versioning Let me know what you think, and thanks! Diffs - packaging/rpm/Makefile PRE-CREATION packaging/rpm/aurora.init.sh PRE-CREATION packaging/rpm/aurora.logrotate PRE-CREATION packaging/rpm/aurora.service PRE-CREATION packaging/rpm/aurora.spec PRE-CREATION packaging/rpm/aurora.startup.sh PRE-CREATION packaging/rpm/aurora.sysconfig PRE-CREATION packaging/rpm/clusters.json PRE-CREATION packaging/rpm/thermos-observer.init.sh PRE-CREATION packaging/rpm/thermos-observer.logrotate PRE-CREATION packaging/rpm/thermos-observer.service PRE-CREATION packaging/rpm/thermos-observer.startup.sh PRE-CREATION packaging/rpm/thermos-observer.sysconfig PRE-CREATION Diff: https://reviews.apache.org/r/33778/diff/ Testing --- Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19 Thanks, Steve Salevan
