Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-25 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/#review89453
---

Ship it!


Ship It!

- Maxim Khutornenko


On June 26, 2015, 12:07 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35812/
> ---
> 
> (Updated June 26, 2015, 12:07 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1074
> https://issues.apache.org/jira/browse/AURORA-1074
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the "enable_legacy_constraints" flag and associated behaviour.
> 
> 
> Diffs
> -
> 
>   NEWS 1a0fb48c3bed1761937e98fa528fac39f2bdc05b 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  abbd23dd3ee4382565ce846eb035e2aa502badae 
>   src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 
> 83eec5d3c8e493fcefbcb5b9cf67dae4e741b095 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  71b09b1fddc5faa7960ade43929cb57eec3243dd 
> 
> Diff: https://reviews.apache.org/r/35812/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-25 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/#review89452
---

Ship it!


Master (56bb1e6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 26, 2015, 12:07 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35812/
> ---
> 
> (Updated June 26, 2015, 12:07 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1074
> https://issues.apache.org/jira/browse/AURORA-1074
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the "enable_legacy_constraints" flag and associated behaviour.
> 
> 
> Diffs
> -
> 
>   NEWS 1a0fb48c3bed1761937e98fa528fac39f2bdc05b 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  abbd23dd3ee4382565ce846eb035e2aa502badae 
>   src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 
> 83eec5d3c8e493fcefbcb5b9cf67dae4e741b095 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  71b09b1fddc5faa7960ade43929cb57eec3243dd 
> 
> Diff: https://reviews.apache.org/r/35812/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-25 Thread Zameer Manji 


> On June 25, 2015, 9:38 a.m., Bill Farner wrote:
> > NEWS, line 5
> > 
> >
> > ```
> > The scheduler command line argument enable_legacy_constraints has been 
> > removed, and the scheduler no longer automatically injects 'host' and 
> > 'rack' constraints for production services.
> > ```

Done.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/#review89373
---


On June 25, 2015, 5:07 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35812/
> ---
> 
> (Updated June 25, 2015, 5:07 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1074
> https://issues.apache.org/jira/browse/AURORA-1074
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the "enable_legacy_constraints" flag and associated behaviour.
> 
> 
> Diffs
> -
> 
>   NEWS 1a0fb48c3bed1761937e98fa528fac39f2bdc05b 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  abbd23dd3ee4382565ce846eb035e2aa502badae 
>   src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 
> 83eec5d3c8e493fcefbcb5b9cf67dae4e741b095 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  71b09b1fddc5faa7960ade43929cb57eec3243dd 
> 
> Diff: https://reviews.apache.org/r/35812/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-25 Thread Zameer Manji 


> On June 25, 2015, 10:40 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java,
> >  lines 75-76
> > 
> >
> > AFAICT, these are now only referenced in test now. Remove?

Good catch. I removed them.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/#review89391
---


On June 25, 2015, 5:07 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35812/
> ---
> 
> (Updated June 25, 2015, 5:07 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1074
> https://issues.apache.org/jira/browse/AURORA-1074
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the "enable_legacy_constraints" flag and associated behaviour.
> 
> 
> Diffs
> -
> 
>   NEWS 1a0fb48c3bed1761937e98fa528fac39f2bdc05b 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  abbd23dd3ee4382565ce846eb035e2aa502badae 
>   src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 
> 83eec5d3c8e493fcefbcb5b9cf67dae4e741b095 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  71b09b1fddc5faa7960ade43929cb57eec3243dd 
> 
> Diff: https://reviews.apache.org/r/35812/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-25 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/
---

(Updated June 25, 2015, 5:07 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Feedback.


Bugs: AURORA-1074
https://issues.apache.org/jira/browse/AURORA-1074


Repository: aurora


Description
---

Remove the "enable_legacy_constraints" flag and associated behaviour.


Diffs (updated)
-

  NEWS 1a0fb48c3bed1761937e98fa528fac39f2bdc05b 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 b77b0ebbf303778e528b16ff3db1aa4e76f1 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
 9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 abbd23dd3ee4382565ce846eb035e2aa502badae 
  src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 
83eec5d3c8e493fcefbcb5b9cf67dae4e741b095 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 71b09b1fddc5faa7960ade43929cb57eec3243dd 

Diff: https://reviews.apache.org/r/35812/diff/


Testing
---

./gradlew build -Pq


Thanks,

Zameer Manji

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-25 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/#review89391
---



src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 (lines 69 - 70)


AFAICT, these are now only referenced in test now. Remove?


- Maxim Khutornenko


On June 23, 2015, 11:58 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35812/
> ---
> 
> (Updated June 23, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1074
> https://issues.apache.org/jira/browse/AURORA-1074
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the "enable_legacy_constraints" flag and associated behaviour.
> 
> 
> Diffs
> -
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  abbd23dd3ee4382565ce846eb035e2aa502badae 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  38ef412a6d29dfef7b305e00cf44522818303965 
> 
> Diff: https://reviews.apache.org/r/35812/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-25 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/#review89373
---

Ship it!



NEWS (line 5)


```
The scheduler command line argument enable_legacy_constraints has been 
removed, and the scheduler no longer automatically injects 'host' and 'rack' 
constraints for production services.
```


- Bill Farner


On June 23, 2015, 11:58 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35812/
> ---
> 
> (Updated June 23, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1074
> https://issues.apache.org/jira/browse/AURORA-1074
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the "enable_legacy_constraints" flag and associated behaviour.
> 
> 
> Diffs
> -
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  abbd23dd3ee4382565ce846eb035e2aa502badae 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  38ef412a6d29dfef7b305e00cf44522818303965 
> 
> Diff: https://reviews.apache.org/r/35812/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 35812: Remove "enable_legacy_constraints" flag.

2015-06-23 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35812/#review89102
---

Ship it!


Master (4b8c34c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 23, 2015, 11:58 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35812/
> ---
> 
> (Updated June 23, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1074
> https://issues.apache.org/jira/browse/AURORA-1074
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove the "enable_legacy_constraints" flag and associated behaviour.
> 
> 
> Diffs
> -
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  abbd23dd3ee4382565ce846eb035e2aa502badae 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  38ef412a6d29dfef7b305e00cf44522818303965 
> 
> Diff: https://reviews.apache.org/r/35812/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>