Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96710 --- Should this be a part of an epic to rename all internal occurences? Quick check shows up plenty of mentiones in docs and public (e.g. thrift) APIs. I think consistency is important and we should not lose track of other work in this area. - Maxim Khutornenko On Aug. 27, 2015, 5:37 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 5:37 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55 src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484 src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
On Aug. 27, 2015, 10:46 a.m., Maxim Khutornenko wrote: Should this be a part of an epic to rename all internal occurences? Quick check shows up plenty of mentiones in docs and public (e.g. thrift) APIs. I think consistency is important and we should not lose track of other work in this area. This change was the result of a grep for the lowest-hanging fruit, but I restricted it to the `src/main` folder and didn't include `docs`. I can definitely include `docs` in a follow-up patch. Good call on the Epic - filed https://issues.apache.org/jira/browse/AURORA-1448 - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96710 --- On Aug. 27, 2015, 10:37 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 10:37 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55 src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484 src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 11:01 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes --- Add bug IDs Bugs: AURORA-1449 and AURORA-1450 https://issues.apache.org/jira/browse/AURORA-1449 https://issues.apache.org/jira/browse/AURORA-1450 Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55 src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484 src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96725 --- Ship it! Ship It! - Joshua Cohen On Aug. 27, 2015, 6:01 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 6:01 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1449 and AURORA-1450 https://issues.apache.org/jira/browse/AURORA-1449 https://issues.apache.org/jira/browse/AURORA-1450 Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55 src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484 src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96774 --- Master (06ddaad) is red with this patch. ./build-support/jenkins/build.sh :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJava :processTestResources :testClasses :checkstyleTest :findbugsJmh :findbugsMain :findbugsTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage of 0.8962987319920261 exceeds minimum coverage of 0.89. Branch coverage is 0.823905109489051, but must be greater than 0.835 :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Test coverage missing for org/apache/aurora/scheduler/http/Agents Test coverage missing for org/apache/aurora/scheduler/http/Agents$1 Test coverage missing for org/apache/aurora/scheduler/http/Agents$Agent * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 4 mins 12.543 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Aug. 27, 2015, 6:55 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/ --- (Updated Aug. 27, 2015, 6:55 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1449 and AURORA-1450 https://issues.apache.org/jira/browse/AURORA-1449 https://issues.apache.org/jira/browse/AURORA-1450 Repository: aurora Description --- Change the UI to refer to Mesos Agents instead of Mesos Slaves. This change also moves the /slaves endpoint to /agents and adds a compatibility redirect. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 05af127a91b6c0e8db089cb828c38e556b07d45f src/main/java/org/apache/aurora/scheduler/http/Slaves.java a9fef25595d616f0fbbb7c5ad6de39184a60002a src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65 src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney
