Re: Review Request 51307: Catch IOError.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/#review147179 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 23, 2016, 9:12 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51307/ > --- > > (Updated Aug. 23, 2016, 9:12 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1752 > https://issues.apache.org/jira/browse/AURORA-1752 > > > Repository: aurora > > > Description > --- > > Catch IOError. > > > Diffs > - > > src/main/python/apache/thermos/monitoring/process_collector_psutil.py > bb7c90206791309772c4bb8e2ccf6e62a3991403 > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/51307/diff/ > > > Testing > --- > > $ ./pants test src/test/python/apache/thermos/monitoring > > 13:59:36 00:00 [main] >(To run a reporting server: ./pants server) > 13:59:36 00:00 [setup] > 13:59:36 00:00 [parse] >Executing tasks in goals: test > 13:59:36 00:00 [test] > 13:59:36 00:00 [test-prep-command] > 13:59:36 00:00 [test] > 13:59:36 00:00 [pytest] > 13:59:36 00:00 [run] > == test session starts === > platform linux2 -- Python 2.7.11 -- py-1.4.31 -- > pytest-2.6.4 > plugins: cov, timeout > collected 12 items > > src/test/python/apache/thermos/monitoring/test_disk.py . > > src/test/python/apache/thermos/monitoring/test_detector.py . > > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py . > > src/test/python/apache/thermos/monitoring/test_resource.py . > > === 12 passed in 0.17 seconds > > 13:59:37 00:01 [complete] >SUCCESS > > > Thanks, > > David Robinson > >
Re: Review Request 51307: Catch IOError.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/#review147178 --- Ship it! Master (56906a7) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 23, 2016, 9:12 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51307/ > --- > > (Updated Aug. 23, 2016, 9:12 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1752 > https://issues.apache.org/jira/browse/AURORA-1752 > > > Repository: aurora > > > Description > --- > > Catch IOError. > > > Diffs > - > > src/main/python/apache/thermos/monitoring/process_collector_psutil.py > bb7c90206791309772c4bb8e2ccf6e62a3991403 > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/51307/diff/ > > > Testing > --- > > $ ./pants test src/test/python/apache/thermos/monitoring > > 13:59:36 00:00 [main] >(To run a reporting server: ./pants server) > 13:59:36 00:00 [setup] > 13:59:36 00:00 [parse] >Executing tasks in goals: test > 13:59:36 00:00 [test] > 13:59:36 00:00 [test-prep-command] > 13:59:36 00:00 [test] > 13:59:36 00:00 [pytest] > 13:59:36 00:00 [run] > == test session starts === > platform linux2 -- Python 2.7.11 -- py-1.4.31 -- > pytest-2.6.4 > plugins: cov, timeout > collected 12 items > > src/test/python/apache/thermos/monitoring/test_disk.py . > > src/test/python/apache/thermos/monitoring/test_detector.py . > > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py . > > src/test/python/apache/thermos/monitoring/test_resource.py . > > === 12 passed in 0.17 seconds > > 13:59:37 00:01 [complete] >SUCCESS > > > Thanks, > > David Robinson > >
Re: Review Request 51307: Catch IOError.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/#review147172 --- @ReviewBot retry - Stephan Erb On Aug. 23, 2016, 11:12 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51307/ > --- > > (Updated Aug. 23, 2016, 11:12 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1752 > https://issues.apache.org/jira/browse/AURORA-1752 > > > Repository: aurora > > > Description > --- > > Catch IOError. > > > Diffs > - > > src/main/python/apache/thermos/monitoring/process_collector_psutil.py > bb7c90206791309772c4bb8e2ccf6e62a3991403 > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/51307/diff/ > > > Testing > --- > > $ ./pants test src/test/python/apache/thermos/monitoring > > 13:59:36 00:00 [main] >(To run a reporting server: ./pants server) > 13:59:36 00:00 [setup] > 13:59:36 00:00 [parse] >Executing tasks in goals: test > 13:59:36 00:00 [test] > 13:59:36 00:00 [test-prep-command] > 13:59:36 00:00 [test] > 13:59:36 00:00 [pytest] > 13:59:36 00:00 [run] > == test session starts === > platform linux2 -- Python 2.7.11 -- py-1.4.31 -- > pytest-2.6.4 > plugins: cov, timeout > collected 12 items > > src/test/python/apache/thermos/monitoring/test_disk.py . > > src/test/python/apache/thermos/monitoring/test_detector.py . > > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py . > > src/test/python/apache/thermos/monitoring/test_resource.py . > > === 12 passed in 0.17 seconds > > 13:59:37 00:01 [complete] >SUCCESS > > > Thanks, > > David Robinson > >
Re: Review Request 51307: Catch IOError.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/#review146579 --- Master (c115ac6) is red with this patch. ./build-support/jenkins/build.sh [1m proxy_driver = ProxyDriver()[0m [1m with temporary_dir() as checkpoint_root:[0m [1mte = AuroraExecutor([0m [1m> runner_provider=make_provider(checkpoint_root),[0m [1m sandbox_provider=DefaultTestSandboxProvider())[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:580: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider [1mpex_location=thermos_runner_path(),[0m _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ build = True [1mdef thermos_runner_path(build=True):[0m [1m if not build:[0m [1mreturn getattr(thermos_runner_path, 'value', None)[0m [1m[0m [1m if not hasattr(thermos_runner_path, 'value'):[0m [1mpex_dir = safe_mkdtemp()[0m [1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m [1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m [1m[31mE assert 1 == 0[0m [1m[31mE+ where 1 = (['./pants', '--pants-distdir=/tmp/tmpX8bFqO', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m [1m[31mE+where = subprocess.call[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError -- Captured stderr call -- Traceback (most recent call last): File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/bin/pants", line 7, in from pants.bin.pants_exe import main ImportError: No module named pants.bin.pants_exe generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml [1m[31m 16 failed, 670 passed, 6 skipped, 1 warnings, 8 error in 188.31 seconds [0m FAILURE 21:37:40 03:35 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 23, 2016, 9:12 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51307/ > --- > > (Updated Aug. 23, 2016, 9:12 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1752 > https://issues.apache.org/jira/browse/AURORA-1752 > > > Repository: aurora > > > Description > --- > > Catch IOError. > > > Diffs > - > > src/main/python/apache/thermos/monitoring/process_collector_psutil.py > bb7c90206791309772c4bb8e2ccf6e62a3991403 > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/51307/diff/ > > > Testing > --- > > $ ./pants test src/test/python/apache/thermos/monitoring > > 13:59:36 00:00 [main] >(To run a reporting server: ./pants server) > 13:59:36 00:00 [setup] > 13:59:36 00:00 [parse] >Executing tasks in goals: test > 13:59:36 00:00 [test] > 13:59:36 00:00 [test-prep-command] > 13:59:36 00:00 [test] > 13:59:36 00:00 [pytest] > 13:59:36 00:00 [run] > == test session starts === > platform linux2 -- Python 2.7.11 -- py-1.4.31 -- > pytest-2.6.4 > plugins: cov, timeout > collected 12 items > > src/test/python/apache/thermos/monitoring/test_disk.py . > > src/test/python/apache/thermos/monitoring/test_detector.py . > > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py . > >
Re: Review Request 51307: Catch IOError.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/#review146573 --- Ship it! Ship It! - Joshua Cohen On Aug. 23, 2016, 9:12 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51307/ > --- > > (Updated Aug. 23, 2016, 9:12 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1752 > https://issues.apache.org/jira/browse/AURORA-1752 > > > Repository: aurora > > > Description > --- > > Catch IOError. > > > Diffs > - > > src/main/python/apache/thermos/monitoring/process_collector_psutil.py > bb7c90206791309772c4bb8e2ccf6e62a3991403 > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/51307/diff/ > > > Testing > --- > > $ ./pants test src/test/python/apache/thermos/monitoring > > 13:59:36 00:00 [main] >(To run a reporting server: ./pants server) > 13:59:36 00:00 [setup] > 13:59:36 00:00 [parse] >Executing tasks in goals: test > 13:59:36 00:00 [test] > 13:59:36 00:00 [test-prep-command] > 13:59:36 00:00 [test] > 13:59:36 00:00 [pytest] > 13:59:36 00:00 [run] > == test session starts === > platform linux2 -- Python 2.7.11 -- py-1.4.31 -- > pytest-2.6.4 > plugins: cov, timeout > collected 12 items > > src/test/python/apache/thermos/monitoring/test_disk.py . > > src/test/python/apache/thermos/monitoring/test_detector.py . > > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py . > > src/test/python/apache/thermos/monitoring/test_resource.py . > > === 12 passed in 0.17 seconds > > 13:59:37 00:01 [complete] >SUCCESS > > > Thanks, > > David Robinson > >
Re: Review Request 51307: Catch IOError.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/ --- (Updated Aug. 23, 2016, 9:12 p.m.) Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Changes --- Fixed style. Bugs: AURORA-1752 https://issues.apache.org/jira/browse/AURORA-1752 Repository: aurora Description --- Catch IOError. Diffs (updated) - src/main/python/apache/thermos/monitoring/process_collector_psutil.py bb7c90206791309772c4bb8e2ccf6e62a3991403 src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py PRE-CREATION Diff: https://reviews.apache.org/r/51307/diff/ Testing --- $ ./pants test src/test/python/apache/thermos/monitoring 13:59:36 00:00 [main] (To run a reporting server: ./pants server) 13:59:36 00:00 [setup] 13:59:36 00:00 [parse] Executing tasks in goals: test 13:59:36 00:00 [test] 13:59:36 00:00 [test-prep-command] 13:59:36 00:00 [test] 13:59:36 00:00 [pytest] 13:59:36 00:00 [run] == test session starts === platform linux2 -- Python 2.7.11 -- py-1.4.31 -- pytest-2.6.4 plugins: cov, timeout collected 12 items src/test/python/apache/thermos/monitoring/test_disk.py . src/test/python/apache/thermos/monitoring/test_detector.py . src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py . src/test/python/apache/thermos/monitoring/test_resource.py . === 12 passed in 0.17 seconds 13:59:37 00:01 [complete] SUCCESS Thanks, David Robinson
Re: Review Request 51307: Catch IOError.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/ --- (Updated Aug. 23, 2016, 9:03 p.m.) Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs: AURORA-1752 https://issues.apache.org/jira/browse/AURORA-1752 Repository: aurora Description --- Catch IOError. Diffs (updated) - src/main/python/apache/thermos/monitoring/process_collector_psutil.py bb7c90206791309772c4bb8e2ccf6e62a3991403 src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py PRE-CREATION Diff: https://reviews.apache.org/r/51307/diff/ Testing (updated) --- $ ./pants test src/test/python/apache/thermos/monitoring 13:59:36 00:00 [main] (To run a reporting server: ./pants server) 13:59:36 00:00 [setup] 13:59:36 00:00 [parse] Executing tasks in goals: test 13:59:36 00:00 [test] 13:59:36 00:00 [test-prep-command] 13:59:36 00:00 [test] 13:59:36 00:00 [pytest] 13:59:36 00:00 [run] == test session starts === platform linux2 -- Python 2.7.11 -- py-1.4.31 -- pytest-2.6.4 plugins: cov, timeout collected 12 items src/test/python/apache/thermos/monitoring/test_disk.py . src/test/python/apache/thermos/monitoring/test_detector.py . src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py . src/test/python/apache/thermos/monitoring/test_resource.py . === 12 passed in 0.17 seconds 13:59:37 00:01 [complete] SUCCESS Thanks, David Robinson
Re: Review Request 51307: Catch IOError.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/#review146461 --- Master (9b34a40) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 23, 2016, 12:04 a.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51307/ > --- > > (Updated Aug. 23, 2016, 12:04 a.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1752 > https://issues.apache.org/jira/browse/AURORA-1752 > > > Repository: aurora > > > Description > --- > > Catch IOError. > > > Diffs > - > > src/main/python/apache/thermos/monitoring/process_collector_psutil.py > bb7c90206791309772c4bb8e2ccf6e62a3991403 > > Diff: https://reviews.apache.org/r/51307/diff/ > > > Testing > --- > > > Thanks, > > David Robinson > >
