Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/#review156375 --- Renan, this review is closed, can you open another one for your future changes? - Zameer Manji On Nov. 18, 2016, 6:45 p.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53831/ > --- > > (Updated Nov. 18, 2016, 6:45 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Placed filter when creating resource bags from Mesos resources in to avoid > trying to conver unsupported resources which leads to the scheduler crashing. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java > 589288dc877d74eea1de65715fc498523be43d7f > > Diff: https://reviews.apache.org/r/53831/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > End to end testing finally passed after trying it 2 times, failures seem to > be unrelated to this patch. > > > Thanks, > > Renan DelValle > >
Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/#review156227 --- Ship it! Ship It! - Zameer Manji On Nov. 17, 2016, 8:43 a.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53831/ > --- > > (Updated Nov. 17, 2016, 8:43 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Placed filter when creating resource bags from Mesos resources in to avoid > trying to conver unsupported resources which leads to the scheduler crashing. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java > caacc583b552d0638ad59b9d69f7eee668b53723 > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java > 915c83d00c974bef36b42b7dd211dc16744f6c08 > > src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java > 14ac54713acf69fc40807b8cf7345b7a043e1ad9 > > Diff: https://reviews.apache.org/r/53831/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > End to end testing finally passed after trying it 2 times, failures seem to > be unrelated to this patch. > > > Thanks, > > Renan DelValle > >
Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/#review156213 --- Ship it! Master (85e2493) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 17, 2016, 4:43 p.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53831/ > --- > > (Updated Nov. 17, 2016, 4:43 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Placed filter when creating resource bags from Mesos resources in to avoid > trying to conver unsupported resources which leads to the scheduler crashing. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java > caacc583b552d0638ad59b9d69f7eee668b53723 > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java > 915c83d00c974bef36b42b7dd211dc16744f6c08 > > src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java > 14ac54713acf69fc40807b8cf7345b7a043e1ad9 > > Diff: https://reviews.apache.org/r/53831/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > End to end testing finally passed after trying it 2 times, failures seem to > be unrelated to this patch. > > > Thanks, > > Renan DelValle > >
Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/ --- (Updated Nov. 17, 2016, 8:43 a.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji. Changes --- Style fixes Repository: aurora Description --- Placed filter when creating resource bags from Mesos resources in to avoid trying to conver unsupported resources which leads to the scheduler crashing. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java caacc583b552d0638ad59b9d69f7eee668b53723 src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 915c83d00c974bef36b42b7dd211dc16744f6c08 src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 14ac54713acf69fc40807b8cf7345b7a043e1ad9 Diff: https://reviews.apache.org/r/53831/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh End to end testing finally passed after trying it 2 times, failures seem to be unrelated to this patch. Thanks, Renan DelValle
Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/#review156172 --- Ship it! Master (85e2493) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 17, 2016, 4:05 a.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53831/ > --- > > (Updated Nov. 17, 2016, 4:05 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Placed filter when creating resource bags from Mesos resources in to avoid > trying to conver unsupported resources which leads to the scheduler crashing. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java > caacc583b552d0638ad59b9d69f7eee668b53723 > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java > 915c83d00c974bef36b42b7dd211dc16744f6c08 > > src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java > 14ac54713acf69fc40807b8cf7345b7a043e1ad9 > > Diff: https://reviews.apache.org/r/53831/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > End to end testing finally passed after trying it 2 times, failures seem to > be unrelated to this patch. > > > Thanks, > > Renan DelValle > >
Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/#review156168 --- Ship it! Ship It! - David McLaughlin On Nov. 17, 2016, 12:31 a.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53831/ > --- > > (Updated Nov. 17, 2016, 12:31 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > Placed filter when creating resource bags from Mesos resources in to avoid > trying to conver unsupported resources which leads to the scheduler crashing. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java > caacc583b552d0638ad59b9d69f7eee668b53723 > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java > 915c83d00c974bef36b42b7dd211dc16744f6c08 > > src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java > 14ac54713acf69fc40807b8cf7345b7a043e1ad9 > > Diff: https://reviews.apache.org/r/53831/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > End to end testing finally passed after trying it 2 times, failures seem to > be unrelated to this patch. > > > Thanks, > > Renan DelValle > >
Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/#review156160 --- Ship it! Master (85e2493) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 17, 2016, 12:31 a.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53831/ > --- > > (Updated Nov. 17, 2016, 12:31 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > Placed filter when creating resource bags from Mesos resources in to avoid > trying to conver unsupported resources which leads to the scheduler crashing. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java > caacc583b552d0638ad59b9d69f7eee668b53723 > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java > 915c83d00c974bef36b42b7dd211dc16744f6c08 > > src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java > 14ac54713acf69fc40807b8cf7345b7a043e1ad9 > > Diff: https://reviews.apache.org/r/53831/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > End to end testing finally passed after trying it 2 times, failures seem to > be unrelated to this patch. > > > Thanks, > > Renan DelValle > >
