Re: Review Request 60133: Update h2 to 1.4.196
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60133/#review178060 --- Ship it! Master (0001f90) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 15, 2017, 10:13 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60133/ > --- > > (Updated June 15, 2017, 10:13 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This update picks up my H2 patch improving SLF4j logging performance > (https://github.com/h2database/h2database/commit/e907049a2b4a18ef3ab47bb0779e60005722bcb7). > > Additional changes in this release: > http://www.h2database.com/html/changelog.html > > The UpdateStore performance seems to have improved by roughly a factor of > three. The snapshot benchmarks are currently broken (and I failed to fix > them). I assume they might show an improvement as well. > > Before: > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 1000 N/A thrpt5 119.038 ± 54.139 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 5000 N/A thrpt5 37.694 ± 3.426 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A >1 N/A thrpt5 18.649 ± 3.810 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1 > N/A N/A thrpt5 37.918 ± 6.921 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 10 > N/A N/A thrpt5 37.762 ± 5.814 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run100 > N/A N/A thrpt5 30.227 ± 18.007 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1000 > N/A N/A thrpt5 15.769 ± 14.883 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 10 thrpt5 33.075 ± 17.729 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 100 thrpt5 35.692 ± 11.266 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A1000 thrpt5 26.050 ± 12.683 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 1 thrpt59.561 ± 13.355 ops/s > > After: > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 1000 N/A thrpt5 414.317 ± 232.301 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 5000 N/A thrpt5 112.781 ± 41.688 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A >1 N/A thrpt5 57.149 ± 30.002 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1 > N/A N/A thrpt5 114.242 ± 54.799 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 10 > N/A N/A thrpt5 118.942 ± 17.132 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run100 > N/A N/A thrpt5 103.792 ± 17.981 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1000 > N/A N/A thrpt5 46.515 ± 7.201 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 10 thrpt5 114.828 ± 35.298 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 100 thrpt5 112.394 ± 42.421 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A1000 thrpt5 83.514 ± 52.970 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 1 thrpt5 32.203 ± 15.586 ops/s > > > Diffs > - > > build.gradle 4802d5e552b978338b037326eae85e193a7eb2d1 > > > Diff: https://reviews.apache.org/r/60133/diff/1/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
Re: Review Request 60133: Update h2 to 1.4.196
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60133/#review178058 --- Ship it! Ship It! - David McLaughlin On June 15, 2017, 10:13 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60133/ > --- > > (Updated June 15, 2017, 10:13 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This update picks up my H2 patch improving SLF4j logging performance > (https://github.com/h2database/h2database/commit/e907049a2b4a18ef3ab47bb0779e60005722bcb7). > > Additional changes in this release: > http://www.h2database.com/html/changelog.html > > The UpdateStore performance seems to have improved by roughly a factor of > three. The snapshot benchmarks are currently broken (and I failed to fix > them). I assume they might show an improvement as well. > > Before: > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 1000 N/A thrpt5 119.038 ± 54.139 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 5000 N/A thrpt5 37.694 ± 3.426 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A >1 N/A thrpt5 18.649 ± 3.810 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1 > N/A N/A thrpt5 37.918 ± 6.921 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 10 > N/A N/A thrpt5 37.762 ± 5.814 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run100 > N/A N/A thrpt5 30.227 ± 18.007 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1000 > N/A N/A thrpt5 15.769 ± 14.883 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 10 thrpt5 33.075 ± 17.729 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 100 thrpt5 35.692 ± 11.266 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A1000 thrpt5 26.050 ± 12.683 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 1 thrpt59.561 ± 13.355 ops/s > > After: > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 1000 N/A thrpt5 414.317 ± 232.301 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 5000 N/A thrpt5 112.781 ± 41.688 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A >1 N/A thrpt5 57.149 ± 30.002 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1 > N/A N/A thrpt5 114.242 ± 54.799 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 10 > N/A N/A thrpt5 118.942 ± 17.132 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run100 > N/A N/A thrpt5 103.792 ± 17.981 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1000 > N/A N/A thrpt5 46.515 ± 7.201 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 10 thrpt5 114.828 ± 35.298 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 100 thrpt5 112.394 ± 42.421 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A1000 thrpt5 83.514 ± 52.970 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 1 thrpt5 32.203 ± 15.586 ops/s > > > Diffs > - > > build.gradle 4802d5e552b978338b037326eae85e193a7eb2d1 > > > Diff: https://reviews.apache.org/r/60133/diff/1/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
Re: Review Request 60133: Update h2 to 1.4.196
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60133/#review178057 --- Ship it! Ship It! - Zameer Manji On June 15, 2017, 3:13 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60133/ > --- > > (Updated June 15, 2017, 3:13 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This update picks up my H2 patch improving SLF4j logging performance > (https://github.com/h2database/h2database/commit/e907049a2b4a18ef3ab47bb0779e60005722bcb7). > > Additional changes in this release: > http://www.h2database.com/html/changelog.html > > The UpdateStore performance seems to have improved by roughly a factor of > three. The snapshot benchmarks are currently broken (and I failed to fix > them). I assume they might show an improvement as well. > > Before: > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 1000 N/A thrpt5 119.038 ± 54.139 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 5000 N/A thrpt5 37.694 ± 3.426 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A >1 N/A thrpt5 18.649 ± 3.810 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1 > N/A N/A thrpt5 37.918 ± 6.921 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 10 > N/A N/A thrpt5 37.762 ± 5.814 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run100 > N/A N/A thrpt5 30.227 ± 18.007 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1000 > N/A N/A thrpt5 15.769 ± 14.883 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 10 thrpt5 33.075 ± 17.729 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 100 thrpt5 35.692 ± 11.266 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A1000 thrpt5 26.050 ± 12.683 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 1 thrpt59.561 ± 13.355 ops/s > > After: > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 1000 N/A thrpt5 414.317 ± 232.301 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A > 5000 N/A thrpt5 112.781 ± 41.688 ops/s > UpdateStoreBenchmarks.JobDetailsBenchmark.run N/A >1 N/A thrpt5 57.149 ± 30.002 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1 > N/A N/A thrpt5 114.242 ± 54.799 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 10 > N/A N/A thrpt5 118.942 ± 17.132 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run100 > N/A N/A thrpt5 103.792 ± 17.981 ops/s > UpdateStoreBenchmarks.JobInstructionsBenchmark.run 1000 > N/A N/A thrpt5 46.515 ± 7.201 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 10 thrpt5 114.828 ± 35.298 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 100 thrpt5 112.394 ± 42.421 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A1000 thrpt5 83.514 ± 52.970 ops/s > UpdateStoreBenchmarks.JobUpdateMetadataBenchmark.run N/A > N/A 1 thrpt5 32.203 ± 15.586 ops/s > > > Diffs > - > > build.gradle 4802d5e552b978338b037326eae85e193a7eb2d1 > > > Diff: https://reviews.apache.org/r/60133/diff/1/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
