Re: Review Request 60264: Add instructions to generate website for a release.

2017-06-21 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60264/#review178511
---


Ship it!




Master (e80002a) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 21, 2017, 4:31 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60264/
> ---
> 
> (Updated June 21, 2017, 4:31 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add instructions to generate website for a release.
> 
> 
> Diffs
> -
> 
>   docs/development/committers-guide.md 
> eb17efe8e53b7ea40d712d297765082cc29f31ab 
> 
> 
> Diff: https://reviews.apache.org/r/60264/diff/2/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>



Re: Review Request 60264: Add instructions to generate website for a release.

2017-06-21 Thread Santhosh Kumar Shanmugham


> On June 21, 2017, 8:54 a.m., Joshua Cohen wrote:
> > docs/development/committers-guide.md
> > Lines 103-104 (patched)
> > 
> >
> > maybe just make `instructions` the link, rather than `instructions 
> > README`, which reads somewhat awkwardly.

Done.


- Santhosh Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60264/#review178501
---


On June 21, 2017, 9:31 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60264/
> ---
> 
> (Updated June 21, 2017, 9:31 a.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add instructions to generate website for a release.
> 
> 
> Diffs
> -
> 
>   docs/development/committers-guide.md 
> eb17efe8e53b7ea40d712d297765082cc29f31ab 
> 
> 
> Diff: https://reviews.apache.org/r/60264/diff/2/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>



Re: Review Request 60264: Add instructions to generate website for a release.

2017-06-21 Thread Santhosh Kumar Shanmugham

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60264/
---

(Updated June 21, 2017, 9:31 a.m.)


Review request for Aurora, Stephan Erb and Zameer Manji.


Changes
---

feddback.


Repository: aurora


Description
---

Add instructions to generate website for a release.


Diffs (updated)
-

  docs/development/committers-guide.md eb17efe8e53b7ea40d712d297765082cc29f31ab 


Diff: https://reviews.apache.org/r/60264/diff/2/

Changes: https://reviews.apache.org/r/60264/diff/1-2/


Testing
---

NA.


Thanks,

Santhosh Kumar Shanmugham



Re: Review Request 60264: Add instructions to generate website for a release.

2017-06-21 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60264/#review178501
---




docs/development/committers-guide.md
Lines 103-104 (patched)


maybe just make `instructions` the link, rather than `instructions README`, 
which reads somewhat awkwardly.


- Joshua Cohen


On June 21, 2017, 6:46 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60264/
> ---
> 
> (Updated June 21, 2017, 6:46 a.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add instructions to generate website for a release.
> 
> 
> Diffs
> -
> 
>   docs/development/committers-guide.md 
> eb17efe8e53b7ea40d712d297765082cc29f31ab 
> 
> 
> Diff: https://reviews.apache.org/r/60264/diff/1/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>



Re: Review Request 60264: Add instructions to generate website for a release.

2017-06-21 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60264/#review178498
---


Ship it!




Ship It!

- Zameer Manji


On June 20, 2017, 11:46 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60264/
> ---
> 
> (Updated June 20, 2017, 11:46 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add instructions to generate website for a release.
> 
> 
> Diffs
> -
> 
>   docs/development/committers-guide.md 
> eb17efe8e53b7ea40d712d297765082cc29f31ab 
> 
> 
> Diff: https://reviews.apache.org/r/60264/diff/1/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>



Re: Review Request 60264: Add instructions to generate website for a release.

2017-06-21 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60264/#review178457
---


Ship it!




Master (e80002a) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 21, 2017, 6:46 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60264/
> ---
> 
> (Updated June 21, 2017, 6:46 a.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add instructions to generate website for a release.
> 
> 
> Diffs
> -
> 
>   docs/development/committers-guide.md 
> eb17efe8e53b7ea40d712d297765082cc29f31ab 
> 
> 
> Diff: https://reviews.apache.org/r/60264/diff/1/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>