Re: Review Request 32830: Fix header levels in monitoring.md
> On April 3, 2015, 9:40 p.m., Stephan Erb wrote: > > Thinking about it, we might as well drop all headers 'Description', > > 'Alerting' and 'Triage'. By just keeping their content around, the > > resulting document should be much simpler to read. > > > > Example of the current state: > > https://github.com/apache/aurora/blob/master/docs/monitoring.md > > Bill Farner wrote: > Thanks for the touch-up! I'm fine with the additional proposed change. > If you add that to the diff i'll commit. Great! Done - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32830/#review78822 --- On April 4, 2015, 10:35 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32830/ > --- > > (Updated April 4, 2015, 10:35 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Fix header levels in monitoring.md > > > Diffs > - > > docs/monitoring.md 8aee66915f40d39368b57acd2b9e328e52b8cdbe > > Diff: https://reviews.apache.org/r/32830/diff/ > > > Testing > --- > > > Thanks, > > Stephan Erb > >
Re: Review Request 32830: Fix header levels in monitoring.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32830/#review78887 --- Ship it! Master (27a602d) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 4, 2015, 8:35 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32830/ > --- > > (Updated April 4, 2015, 8:35 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > Fix header levels in monitoring.md > > > Diffs > - > > docs/monitoring.md 8aee66915f40d39368b57acd2b9e328e52b8cdbe > > Diff: https://reviews.apache.org/r/32830/diff/ > > > Testing > --- > > > Thanks, > > Stephan Erb > >
Re: Review Request 32830: Fix header levels in monitoring.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32830/ --- (Updated April 4, 2015, 10:35 a.m.) Review request for Aurora and Bill Farner. Changes --- Dropping subsection headers as discussed. Repository: aurora Description --- Fix header levels in monitoring.md Diffs (updated) - docs/monitoring.md 8aee66915f40d39368b57acd2b9e328e52b8cdbe Diff: https://reviews.apache.org/r/32830/diff/ Testing --- Thanks, Stephan Erb
Re: Review Request 32830: Fix header levels in monitoring.md
> On April 3, 2015, 7:40 p.m., Stephan Erb wrote: > > Thinking about it, we might as well drop all headers 'Description', > > 'Alerting' and 'Triage'. By just keeping their content around, the > > resulting document should be much simpler to read. > > > > Example of the current state: > > https://github.com/apache/aurora/blob/master/docs/monitoring.md Thanks for the touch-up! I'm fine with the additional proposed change. If you add that to the diff i'll commit. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32830/#review78822 --- On April 3, 2015, 7:09 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32830/ > --- > > (Updated April 3, 2015, 7:09 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > Fix header levels in monitoring.md > > > Diffs > - > > docs/monitoring.md 8aee66915f40d39368b57acd2b9e328e52b8cdbe > > Diff: https://reviews.apache.org/r/32830/diff/ > > > Testing > --- > > > Thanks, > > Stephan Erb > >
Re: Review Request 32830: Fix header levels in monitoring.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32830/#review78822 --- Thinking about it, we might as well drop all headers 'Description', 'Alerting' and 'Triage'. By just keeping their content around, the resulting document should be much simpler to read. Example of the current state: https://github.com/apache/aurora/blob/master/docs/monitoring.md - Stephan Erb On April 3, 2015, 9:09 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32830/ > --- > > (Updated April 3, 2015, 9:09 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > Fix header levels in monitoring.md > > > Diffs > - > > docs/monitoring.md 8aee66915f40d39368b57acd2b9e328e52b8cdbe > > Diff: https://reviews.apache.org/r/32830/diff/ > > > Testing > --- > > > Thanks, > > Stephan Erb > >
Re: Review Request 32830: Fix header levels in monitoring.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32830/#review78819 --- Ship it! Master (9e46dd8) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 3, 2015, 7:09 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32830/ > --- > > (Updated April 3, 2015, 7:09 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > Fix header levels in monitoring.md > > > Diffs > - > > docs/monitoring.md 8aee66915f40d39368b57acd2b9e328e52b8cdbe > > Diff: https://reviews.apache.org/r/32830/diff/ > > > Testing > --- > > > Thanks, > > Stephan Erb > >
Review Request 32830: Fix header levels in monitoring.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32830/ --- Review request for Aurora. Repository: aurora Description --- Fix header levels in monitoring.md Diffs - docs/monitoring.md 8aee66915f40d39368b57acd2b9e328e52b8cdbe Diff: https://reviews.apache.org/r/32830/diff/ Testing --- Thanks, Stephan Erb
