Re: Review Request 33677: Remove dead code related to Java executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/#review82035 --- Master (e34bf7c) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 29, 2015, 3:25 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33677/ > --- > > (Updated April 29, 2015, 3:25 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Bugs: AURORA-195 > https://issues.apache.org/jira/browse/AURORA-195 > > > Repository: aurora > > > Description > --- > > Remove dead code related to Java executor. > > > Diffs > - > > src/main/python/apache/aurora/client/api/command_runner.py > 2d181fa5fa9ce378518acd83871b02cdbc198201 > > Diff: https://reviews.apache.org/r/33677/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 33677: Remove dead code related to Java executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/#review82029 --- @ReviewBot retry I could not repro the failed announcer test, i suspect it might be flaky. - Bill Farner On April 29, 2015, 3:25 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33677/ > --- > > (Updated April 29, 2015, 3:25 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Bugs: AURORA-195 > https://issues.apache.org/jira/browse/AURORA-195 > > > Repository: aurora > > > Description > --- > > Remove dead code related to Java executor. > > > Diffs > - > > src/main/python/apache/aurora/client/api/command_runner.py > 2d181fa5fa9ce378518acd83871b02cdbc198201 > > Diff: https://reviews.apache.org/r/33677/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 33677: Remove dead code related to Java executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/#review82001 --- Ship it! wow - Brian Wickman On April 29, 2015, 3:25 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33677/ > --- > > (Updated April 29, 2015, 3:25 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Bugs: AURORA-195 > https://issues.apache.org/jira/browse/AURORA-195 > > > Repository: aurora > > > Description > --- > > Remove dead code related to Java executor. > > > Diffs > - > > src/main/python/apache/aurora/client/api/command_runner.py > 2d181fa5fa9ce378518acd83871b02cdbc198201 > > Diff: https://reviews.apache.org/r/33677/diff/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 33677: Remove dead code related to Java executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/#review81968 --- Master (e311dbe) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.announcer . FAILURE src.test.python.apache.aurora.executor.common.path_detector . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.cli.commands.commands . SUCCESS src.test.python.apache.thermos.cli.common . SUCCESS src.test.python.apache.thermos.cli.main . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 29, 2015, 3:25 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33677/ > --- > > (Updated April 29, 2015, 3:25 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Bugs: A
Review Request 33677: Remove dead code related to Java executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-195 https://issues.apache.org/jira/browse/AURORA-195 Repository: aurora Description --- Remove dead code related to Java executor. Diffs - src/main/python/apache/aurora/client/api/command_runner.py 2d181fa5fa9ce378518acd83871b02cdbc198201 Diff: https://reviews.apache.org/r/33677/diff/ Testing --- Thanks, Bill Farner
