Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83104
---

Ship it!


Master (288f00b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 9:07 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 9:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83094
---


@ReviewBot retry

Last build result is for the previous diff.

- Bill Farner


On May 8, 2015, 9:07 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 9:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83093
---


Master (288f00b) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.api.updater   
 .   SUCCESS
 src.test.python.apache.aurora.client.api.updater_util  
 .   SUCCESS
 src.test.python.apache.aurora.client.base  
 .   SUCCESS
 src.test.python.apache.aurora.client.binding_helper
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.api   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.client
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.command_hooks 
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.config
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.context   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.cron  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.inspect   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.job   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.plugins   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.quota 
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.sla   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.supdate   
 .   FAILURE
 src.test.python.apache.aurora.client.cli.task  
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.thermos.cli.commands.commands   
 .   SUCCESS
 src.test.python.apache.thermos.cli.common  
 .   SUCCESS
 src.test.python.apache.thermos.cli.main
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE


   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 8, 2015, 9:07 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 9:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> 

Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/
---

(Updated May 8, 2015, 9:07 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

Acted too quickly - fixed stdout strings in unit test.


Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239


Repository: aurora


Description
---

Add update watch and update start --watch flag.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
  src/main/python/apache/aurora/client/cli/update.py 
7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
968d456927de8044b8a8c5ca365464a8fedd3711 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
501d111f87dbaff8b6f22ffc67a9720b4dad 

Diff: https://reviews.apache.org/r/33959/diff/


Testing
---

Unit tests + end-to-end tests.


Thanks,

Bill Farner



Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review83089
---

Ship it!


Ship It!

- Zameer Manji


On May 8, 2015, 1:57 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> ---
> 
> (Updated May 8, 2015, 1:57 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
> https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f87dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> ---
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/
---

(Updated May 8, 2015, 8:57 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Summary (updated)
-

Add update wait and update start --wait flag.


Bugs: AURORA-1239
https://issues.apache.org/jira/browse/AURORA-1239


Repository: aurora


Description
---

Add update watch and update start --watch flag.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
  src/main/python/apache/aurora/client/cli/update.py 
7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
968d456927de8044b8a8c5ca365464a8fedd3711 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
501d111f87dbaff8b6f22ffc67a9720b4dad 

Diff: https://reviews.apache.org/r/33959/diff/


Testing
---

Unit tests + end-to-end tests.


Thanks,

Bill Farner