Re: Review Request 34501: Enabling TemporaryStorage to use flagged task store.

2015-05-27 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34501/#review85449
---

Ship it!


Ship It!

- Kevin Sweeney


On May 22, 2015, 5:31 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34501/
> ---
> 
> (Updated May 22, 2015, 5:31 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1322
> https://issues.apache.org/jira/browse/AURORA-1322
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allowing TemporaryStorage to use command line controlled task store.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java 
> 03dd5d99b269a1add709504b21fc197fdef9e18c 
>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
> f361caa6f4e3b28f4a1e4d57f1989a6aa6fe258e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  23c0c1e73a183be748199610ddf03e5d654fef74 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 436d3841b9361df4db98a2217e61abb95e6e6bab 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 
> fe8e3f8f164732769fa0ae50a62e89c8aa77e9a5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  177d720b59ba601d59aada9650aba799babb9a73 
>   
> src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 
> 999d5e893897dc24659ca4a240ad3d4615cac0e5 
> 
> Diff: https://reviews.apache.org/r/34501/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Manual restore from backup in Vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 34501: Enabling TemporaryStorage to use flagged task store.

2015-05-22 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34501/#review85040
---

Ship it!


Master (6db13ba) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 23, 2015, 12:31 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34501/
> ---
> 
> (Updated May 23, 2015, 12:31 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1322
> https://issues.apache.org/jira/browse/AURORA-1322
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allowing TemporaryStorage to use command line controlled task store.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java 
> 03dd5d99b269a1add709504b21fc197fdef9e18c 
>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
> f361caa6f4e3b28f4a1e4d57f1989a6aa6fe258e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  23c0c1e73a183be748199610ddf03e5d654fef74 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 436d3841b9361df4db98a2217e61abb95e6e6bab 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 
> fe8e3f8f164732769fa0ae50a62e89c8aa77e9a5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  177d720b59ba601d59aada9650aba799babb9a73 
>   
> src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 
> 999d5e893897dc24659ca4a240ad3d4615cac0e5 
> 
> Diff: https://reviews.apache.org/r/34501/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Manual restore from backup in Vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 34501: Enabling TemporaryStorage to use flagged task store.

2015-05-22 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34501/
---

(Updated May 23, 2015, 12:31 a.m.)


Review request for Aurora and Kevin Sweeney.


Changes
---

Kevin's comments.


Summary (updated)
-

Enabling TemporaryStorage to use flagged task store.


Bugs: AURORA-1322
https://issues.apache.org/jira/browse/AURORA-1322


Repository: aurora


Description (updated)
---

Allowing TemporaryStorage to use command line controlled task store.


Diffs (updated)
-

  src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java 
03dd5d99b269a1add709504b21fc197fdef9e18c 
  src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
f361caa6f4e3b28f4a1e4d57f1989a6aa6fe258e 
  
src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 
23c0c1e73a183be748199610ddf03e5d654fef74 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
436d3841b9361df4db98a2217e61abb95e6e6bab 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 
fe8e3f8f164732769fa0ae50a62e89c8aa77e9a5 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 
177d720b59ba601d59aada9650aba799babb9a73 
  src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 
999d5e893897dc24659ca4a240ad3d4615cac0e5 

Diff: https://reviews.apache.org/r/34501/diff/


Testing
---

./gradlew -Pq build
Manual restore from backup in Vagrant.


Thanks,

Maxim Khutornenko