Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review98515
---


This patch does not apply cleanly on master (98f692d), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 11, 2015, 12:28 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38112/
> ---
> 
> (Updated Sept. 11, 2015, 12:28 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1476
> https://issues.apache.org/jira/browse/AURORA-1476
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Alter thrift wrapper generator to use default primitive values and empty 
> collections.
> 
> Reviewers - please see my self-review commentary in specific parts of the 
> patch.  The biggest shift with this change is that an impedance mismatch that 
> existed when inserting/fetching a record from the database is now lifted to 
> the thrift wrapper layer.
> 
> This means the following test is not guaranteed to pass:
> ```java
> TaskConfig original = new TaskConfig(...);
> assertEquals(original, ITaskConfig.build(original).newBuilder());  // won't 
> always pass
> ```
> 
> Most specifically, the wrapped/upwrapped `TaskConfig` will have null 
> collections replaced with empty ones, and will not honor set/unset flags for 
> primitives.  The best practice, therefore, should be to treat our wrapper 
> classes as the canonical form, and only deal with the underlying thrift types 
> when absolutely necessary.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  a952797315a3421695748f09b9a6abb552cbb668 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e12ad3e3868472ba84e379986bd1aa97bca42ffe 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  5d8bd1b72927786df95c972df64d68c78f25dad0 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
>  9213b88ab4ce5063ca0fb055851ae5632616155e 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 295974a9f97e020dce11474d500a1bcd40d9f5d5 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 7ccc273204d20c84bbb576958e832b6f4a29f607 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  4685aa157be77502ad0e4e648ad333ee286f3de5 
> 
> Diff: https://reviews.apache.org/r/38112/diff/
> 
> 
> Testing
> ---
> 
> End-to-end tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review98503
---

Ship it!


Any plans to get rid of mutable thrift objects in mybatis mappers?


src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
 (line 201)


typo


- Maxim Khutornenko


On Sept. 8, 2015, 11:26 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38112/
> ---
> 
> (Updated Sept. 8, 2015, 11:26 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1476
> https://issues.apache.org/jira/browse/AURORA-1476
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Alter thrift wrapper generator to use default primitive values and empty 
> collections.
> 
> Reviewers - please see my self-review commentary in specific parts of the 
> patch.  The biggest shift with this change is that an impedance mismatch that 
> existed when inserting/fetching a record from the database is now lifted to 
> the thrift wrapper layer.
> 
> This means the following test is not guaranteed to pass:
> ```java
> TaskConfig original = new TaskConfig(...);
> assertEquals(original, ITaskConfig.build(original).newBuilder());  // won't 
> always pass
> ```
> 
> Most specifically, the wrapped/upwrapped `TaskConfig` will have null 
> collections replaced with empty ones, and will not honor set/unset flags for 
> primitives.  The best practice, therefore, should be to treat our wrapper 
> classes as the canonical form, and only deal with the underlying thrift types 
> when absolutely necessary.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  a952797315a3421695748f09b9a6abb552cbb668 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e12ad3e3868472ba84e379986bd1aa97bca42ffe 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  5d8bd1b72927786df95c972df64d68c78f25dad0 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
>  9213b88ab4ce5063ca0fb055851ae5632616155e 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 295974a9f97e020dce11474d500a1bcd40d9f5d5 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 7ccc273204d20c84bbb576958e832b6f4a29f607 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  4685aa157be77502ad0e4e648ad333ee286f3de5 
> 
> Diff: https://reviews.apache.org/r/38112/diff/
> 
> 
> Testing
> ---
> 
> End-to-end tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/
---

(Updated Sept. 10, 2015, 5:36 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
---

rebase


Bugs: AURORA-1476
https://issues.apache.org/jira/browse/AURORA-1476


Repository: aurora


Description
---

Alter thrift wrapper generator to use default primitive values and empty 
collections.

Reviewers - please see my self-review commentary in specific parts of the 
patch.  The biggest shift with this change is that an impedance mismatch that 
existed when inserting/fetching a record from the database is now lifted to the 
thrift wrapper layer.

This means the following test is not guaranteed to pass:
```java
TaskConfig original = new TaskConfig(...);
assertEquals(original, ITaskConfig.build(original).newBuilder());  // won't 
always pass
```

Most specifically, the wrapped/upwrapped `TaskConfig` will have null 
collections replaced with empty ones, and will not honor set/unset flags for 
primitives.  The best practice, therefore, should be to treat our wrapper 
classes as the canonical form, and only deal with the underlying thrift types 
when absolutely necessary.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 a952797315a3421695748f09b9a6abb552cbb668 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
49bf3c9f140210b1153e1bdba74fe9a993686e9f 
  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
e12ad3e3868472ba84e379986bd1aa97bca42ffe 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 f3b62cc957186bc9673060830572bc1cc073ac49 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
5d8bd1b72927786df95c972df64d68c78f25dad0 
  src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
  
src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
 9213b88ab4ce5063ca0fb055851ae5632616155e 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
83a8abed6e5fb8f3ed32745e31a9635bb4802c39 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
295974a9f97e020dce11474d500a1bcd40d9f5d5 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
7ccc273204d20c84bbb576958e832b6f4a29f607 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 
0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 
3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
b0587191779f2d19279ed23a07340c44f3e80c5d 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
37c81291ac43ac9e53211c2e6571e2ac90e1c23b 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 4685aa157be77502ad0e4e648ad333ee286f3de5 

Diff: https://reviews.apache.org/r/38112/diff/


Testing
---

End-to-end tests pass


Thanks,

Bill Farner

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/
---

(Updated Sept. 10, 2015, 5:28 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-1476
https://issues.apache.org/jira/browse/AURORA-1476


Repository: aurora


Description
---

Alter thrift wrapper generator to use default primitive values and empty 
collections.

Reviewers - please see my self-review commentary in specific parts of the 
patch.  The biggest shift with this change is that an impedance mismatch that 
existed when inserting/fetching a record from the database is now lifted to the 
thrift wrapper layer.

This means the following test is not guaranteed to pass:
```java
TaskConfig original = new TaskConfig(...);
assertEquals(original, ITaskConfig.build(original).newBuilder());  // won't 
always pass
```

Most specifically, the wrapped/upwrapped `TaskConfig` will have null 
collections replaced with empty ones, and will not honor set/unset flags for 
primitives.  The best practice, therefore, should be to treat our wrapper 
classes as the canonical form, and only deal with the underlying thrift types 
when absolutely necessary.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 a952797315a3421695748f09b9a6abb552cbb668 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
e12ad3e3868472ba84e379986bd1aa97bca42ffe 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 f3b62cc957186bc9673060830572bc1cc073ac49 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
5d8bd1b72927786df95c972df64d68c78f25dad0 
  src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
  
src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
 9213b88ab4ce5063ca0fb055851ae5632616155e 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
db60cd21d06d636505202bac7277a13dc24d46e6 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
295974a9f97e020dce11474d500a1bcd40d9f5d5 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
7ccc273204d20c84bbb576958e832b6f4a29f607 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 
0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 
3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
e0110e7ebe631b7b66b2341cedc10490da00a2ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
4d4e752088f7dca99675cc66782ae046bbd516d6 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 4685aa157be77502ad0e4e648ad333ee286f3de5 

Diff: https://reviews.apache.org/r/38112/diff/


Testing
---

End-to-end tests pass


Thanks,

Bill Farner

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/
---

(Updated Sept. 10, 2015, 7:10 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
---

fixed bad merge during rebase


Bugs: AURORA-1476
https://issues.apache.org/jira/browse/AURORA-1476


Repository: aurora


Description
---

Alter thrift wrapper generator to use default primitive values and empty 
collections.

Reviewers - please see my self-review commentary in specific parts of the 
patch.  The biggest shift with this change is that an impedance mismatch that 
existed when inserting/fetching a record from the database is now lifted to the 
thrift wrapper layer.

This means the following test is not guaranteed to pass:
```java
TaskConfig original = new TaskConfig(...);
assertEquals(original, ITaskConfig.build(original).newBuilder());  // won't 
always pass
```

Most specifically, the wrapped/upwrapped `TaskConfig` will have null 
collections replaced with empty ones, and will not honor set/unset flags for 
primitives.  The best practice, therefore, should be to treat our wrapper 
classes as the canonical form, and only deal with the underlying thrift types 
when absolutely necessary.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 a952797315a3421695748f09b9a6abb552cbb668 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
49bf3c9f140210b1153e1bdba74fe9a993686e9f 
  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
e12ad3e3868472ba84e379986bd1aa97bca42ffe 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 f3b62cc957186bc9673060830572bc1cc073ac49 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
5d8bd1b72927786df95c972df64d68c78f25dad0 
  src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
  
src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
 9213b88ab4ce5063ca0fb055851ae5632616155e 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
83a8abed6e5fb8f3ed32745e31a9635bb4802c39 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
295974a9f97e020dce11474d500a1bcd40d9f5d5 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
7ccc273204d20c84bbb576958e832b6f4a29f607 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 
0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 
3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
b0587191779f2d19279ed23a07340c44f3e80c5d 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
37c81291ac43ac9e53211c2e6571e2ac90e1c23b 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 4685aa157be77502ad0e4e648ad333ee286f3de5 

Diff: https://reviews.apache.org/r/38112/diff/


Testing
---

End-to-end tests pass


Thanks,

Bill Farner

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review98543
---

Ship it!


Master (e57993b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 11, 2015, 2:10 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38112/
> ---
> 
> (Updated Sept. 11, 2015, 2:10 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1476
> https://issues.apache.org/jira/browse/AURORA-1476
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Alter thrift wrapper generator to use default primitive values and empty 
> collections.
> 
> Reviewers - please see my self-review commentary in specific parts of the 
> patch.  The biggest shift with this change is that an impedance mismatch that 
> existed when inserting/fetching a record from the database is now lifted to 
> the thrift wrapper layer.
> 
> This means the following test is not guaranteed to pass:
> ```java
> TaskConfig original = new TaskConfig(...);
> assertEquals(original, ITaskConfig.build(original).newBuilder());  // won't 
> always pass
> ```
> 
> Most specifically, the wrapped/upwrapped `TaskConfig` will have null 
> collections replaced with empty ones, and will not honor set/unset flags for 
> primitives.  The best practice, therefore, should be to treat our wrapper 
> classes as the canonical form, and only deal with the underlying thrift types 
> when absolutely necessary.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  a952797315a3421695748f09b9a6abb552cbb668 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 49bf3c9f140210b1153e1bdba74fe9a993686e9f 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e12ad3e3868472ba84e379986bd1aa97bca42ffe 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  5d8bd1b72927786df95c972df64d68c78f25dad0 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
>  9213b88ab4ce5063ca0fb055851ae5632616155e 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> 83a8abed6e5fb8f3ed32745e31a9635bb4802c39 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 295974a9f97e020dce11474d500a1bcd40d9f5d5 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 7ccc273204d20c84bbb576958e832b6f4a29f607 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> b0587191779f2d19279ed23a07340c44f3e80c5d 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  37c81291ac43ac9e53211c2e6571e2ac90e1c23b 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  4685aa157be77502ad0e4e648ad333ee286f3de5 
> 
> Diff: https://reviews.apache.org/r/38112/diff/
> 
> 
> Testing
> ---
> 
> End-to-end tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-09 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review98345
---


Maxim - ping.

- Bill Farner


On Sept. 8, 2015, 4:26 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38112/
> ---
> 
> (Updated Sept. 8, 2015, 4:26 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1476
> https://issues.apache.org/jira/browse/AURORA-1476
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Alter thrift wrapper generator to use default primitive values and empty 
> collections.
> 
> Reviewers - please see my self-review commentary in specific parts of the 
> patch.  The biggest shift with this change is that an impedance mismatch that 
> existed when inserting/fetching a record from the database is now lifted to 
> the thrift wrapper layer.
> 
> This means the following test is not guaranteed to pass:
> ```java
> TaskConfig original = new TaskConfig(...);
> assertEquals(original, ITaskConfig.build(original).newBuilder());  // won't 
> always pass
> ```
> 
> Most specifically, the wrapped/upwrapped `TaskConfig` will have null 
> collections replaced with empty ones, and will not honor set/unset flags for 
> primitives.  The best practice, therefore, should be to treat our wrapper 
> classes as the canonical form, and only deal with the underlying thrift types 
> when absolutely necessary.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  a952797315a3421695748f09b9a6abb552cbb668 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e12ad3e3868472ba84e379986bd1aa97bca42ffe 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  5d8bd1b72927786df95c972df64d68c78f25dad0 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
>  9213b88ab4ce5063ca0fb055851ae5632616155e 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 295974a9f97e020dce11474d500a1bcd40d9f5d5 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 7ccc273204d20c84bbb576958e832b6f4a29f607 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  4685aa157be77502ad0e4e648ad333ee286f3de5 
> 
> Diff: https://reviews.apache.org/r/38112/diff/
> 
> 
> Testing
> ---
> 
> End-to-end tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-08 Thread Maxim Khutornenko 


> On Sept. 8, 2015, 10:04 p.m., Maxim Khutornenko wrote:
> > Waiting for the aforementioned rationale write up and related risk analysis 
> > (e.g.: non-stable mutable->immutable->mutable loop).
> 
> Bill Farner wrote:
> Working on that now, but i'm not sure exactly what you're looking for 
> w.r.t. risk analysis other than to make a statement about it.

Not looking for anything fancy. Just calling out the downsides explicitly and 
why you think they are acceptable tradeoffs.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review98079
---


On Sept. 3, 2015, 11:38 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38112/
> ---
> 
> (Updated Sept. 3, 2015, 11:38 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1476
> https://issues.apache.org/jira/browse/AURORA-1476
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Alter thrift wrapper generator to use default primitive values and empty 
> collections.
> 
> Reviewers - i will go through and add notes explaining rationale for changes 
> in different areas.  Feel free to wait for me to do that before you review, 
> if you wish.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  a952797315a3421695748f09b9a6abb552cbb668 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e12ad3e3868472ba84e379986bd1aa97bca42ffe 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  5d8bd1b72927786df95c972df64d68c78f25dad0 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
>  9213b88ab4ce5063ca0fb055851ae5632616155e 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 295974a9f97e020dce11474d500a1bcd40d9f5d5 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 7ccc273204d20c84bbb576958e832b6f4a29f607 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  4685aa157be77502ad0e4e648ad333ee286f3de5 
> 
> Diff: https://reviews.apache.org/r/38112/diff/
> 
> 
> Testing
> ---
> 
> End-to-end tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-08 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review98111
---

Ship it!


Ship It!

- Kevin Sweeney


On Sept. 8, 2015, 3:47 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38112/
> ---
> 
> (Updated Sept. 8, 2015, 3:47 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1476
> https://issues.apache.org/jira/browse/AURORA-1476
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Alter thrift wrapper generator to use default primitive values and empty 
> collections.
> 
> Reviewers - please see my self-review commentary in specific parts of the 
> patch.  The biggest shift with this change is that an impedance mismatch that 
> existed when inserting/fetching a record from the database is now lifted to 
> the thrift wrapper layer.
> 
> This means the following test is not guaranteed to pass:
> ```java
> TaskConfig original = new TaskConfig(...);
> assertEquals(original, ITaskConfig.build(original).newBuilder());  // won't 
> always pass
> ```
> 
> Most specifically, the wrapped/upwrapped `TaskConfig` will have null 
> collections replaced with empty ones, and will not honor set/unset flags for 
> primitives.  The best practice, therefore, should be to treat our wrapper 
> classes as the canonical form, and only prefer with the underlying thrift 
> types when absolutely necessary.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  a952797315a3421695748f09b9a6abb552cbb668 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e12ad3e3868472ba84e379986bd1aa97bca42ffe 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  5d8bd1b72927786df95c972df64d68c78f25dad0 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
>  9213b88ab4ce5063ca0fb055851ae5632616155e 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 295974a9f97e020dce11474d500a1bcd40d9f5d5 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 7ccc273204d20c84bbb576958e832b6f4a29f607 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  4685aa157be77502ad0e4e648ad333ee286f3de5 
> 
> Diff: https://reviews.apache.org/r/38112/diff/
> 
> 
> Testing
> ---
> 
> End-to-end tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-03 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/
---

(Updated Sept. 3, 2015, 4:38 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-1476
https://issues.apache.org/jira/browse/AURORA-1476


Repository: aurora


Description
---

Alter thrift wrapper generator to use default primitive values and empty 
collections.

Reviewers - i will go through and add notes explaining rationale for changes in 
different areas.  Feel free to wait for me to do that before you review, if you 
wish.


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 a952797315a3421695748f09b9a6abb552cbb668 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
e12ad3e3868472ba84e379986bd1aa97bca42ffe 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 f3b62cc957186bc9673060830572bc1cc073ac49 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
5d8bd1b72927786df95c972df64d68c78f25dad0 
  src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
  
src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
 9213b88ab4ce5063ca0fb055851ae5632616155e 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
db60cd21d06d636505202bac7277a13dc24d46e6 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
295974a9f97e020dce11474d500a1bcd40d9f5d5 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
7ccc273204d20c84bbb576958e832b6f4a29f607 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 
0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 
3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
e0110e7ebe631b7b66b2341cedc10490da00a2ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
4d4e752088f7dca99675cc66782ae046bbd516d6 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 4685aa157be77502ad0e4e648ad333ee286f3de5 

Diff: https://reviews.apache.org/r/38112/diff/


Testing (updated)
---

End-to-end tests pass


Thanks,

Bill Farner

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review97695
---

Ship it!


Master (9c0b1b2) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 3, 2015, 11:38 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38112/
> ---
> 
> (Updated Sept. 3, 2015, 11:38 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1476
> https://issues.apache.org/jira/browse/AURORA-1476
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Alter thrift wrapper generator to use default primitive values and empty 
> collections.
> 
> Reviewers - i will go through and add notes explaining rationale for changes 
> in different areas.  Feel free to wait for me to do that before you review, 
> if you wish.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  a952797315a3421695748f09b9a6abb552cbb668 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> f1b167bacbfce4f753fc0bbb2b860e3024b9843f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e12ad3e3868472ba84e379986bd1aa97bca42ffe 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> b5f2bc9e54b525a6a782d8873c9112f6496cd3f2 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  5d8bd1b72927786df95c972df64d68c78f25dad0 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
> 08e1284ac1ef08b7649ed83df0a55be04cfeb88f 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
>  9213b88ab4ce5063ca0fb055851ae5632616155e 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 295974a9f97e020dce11474d500a1bcd40d9f5d5 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 7ccc273204d20c84bbb576958e832b6f4a29f607 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
>  0e0a847f46c4d1d833a3c610e8a5f752f368c0d5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  4685aa157be77502ad0e4e648ad333ee286f3de5 
> 
> Diff: https://reviews.apache.org/r/38112/diff/
> 
> 
> Testing
> ---
> 
> End-to-end tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>