Re: Review Request 43622: Updating scheduler backup restore instructions.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review122038
---


Ship it!




Ship It!

- Stephan Erb


On March 4, 2016, 2:52 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated March 4, 2016, 2:52 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md fe3ee567d085cdfde67dc3efb7c4161f7d5f1999 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review121997
---


Ship it!




Master (98a2bc1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 4, 2016, 1:52 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated March 4, 2016, 1:52 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md fe3ee567d085cdfde67dc3efb7c4161f7d5f1999 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/
---

(Updated March 4, 2016, 1:52 a.m.)


Review request for Aurora, John Sirois and Stephan Erb.


Changes
---

Stephan's comments.


Bugs: AURORA-1605
https://issues.apache.org/jira/browse/AURORA-1605


Repository: aurora


Description
---

Updating scheduler backup restore instructions.


Diffs (updated)
-

  docs/client-commands.md fe3ee567d085cdfde67dc3efb7c4161f7d5f1999 
  docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
  docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 

Diff: https://reviews.apache.org/r/43622/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup


Thanks,

Maxim Khutornenko

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Maxim Khutornenko]

> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 99
> > 
> >
> > I'd propose to move this section after the point "Identify the leading 
> > scheduler". Only at that point it is clear what what scheduler URL to put 
> > there.
> > 
> > Slight nitpick: the sentence is difficult to read due to the duplicate 
> > `aurora_admin`. One of those can be dropped.

I'd rather keep it here as preparation steps may require scheduler restart, 
which will likely change the leader. I've added a sentence suggesting changes 
on all replicas though. This way all preparation steps could easily get 
automated (this is in fact how we do things internally).


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 101
> > 
> >
> > There is a small bug in the referenced documentation snippet. The 
> > `scheduler_url` must contain the schema (`http://`) otherwise `aurora_admin 
> > scheduler_stage_recovery` won't work.

Thanks for pointing out. Fixed.


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 103
> > 
> >
> > Addition regarding my first statement: This sub-section probably does 
> > not need to be moved. In can be kept in the preperation section.

I'd rather keep preparation steps together to logically distiguish potentially 
automatable prep steps from manual restore actions.


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 121
> > 
> >
> > I think we might leave thos one out. Does not seem necessary.

This was supposed to be start not restart. Fixed.


> On Feb. 23, 2016, 4:44 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 143
> > 
> >
> > Two important points are missing here:
> > 
> > * has to be copied into the db backup folder
> > * the `scheduler-backup...` is the file name and not a path

> has to be copied into the db backup folder

Thanks, clarified.

> the scheduler-backup... is the file name and not a path

I thought that's obvious from the command example listed below, no?


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review120329
---


On Feb. 16, 2016, 11:10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated Feb. 16, 2016, 11:10 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review120329
---


Fix it, then Ship it!




We've tested this on a cluster with three masters. Worked great! Couple of 
minor additions and corrections below.


docs/storage-config.md (line 93)


I'd propose to move this section after the point "Identify the leading 
scheduler". Only at that point it is clear what what scheduler URL to put there.

Slight nitpick: the sentence is difficult to read due to the duplicate 
`aurora_admin`. One of those can be dropped.



docs/storage-config.md (line 95)


There is a small bug in the referenced documentation snippet. The 
`scheduler_url` must contain the schema (`http://`) otherwise `aurora_admin 
scheduler_stage_recovery` won't work.



docs/storage-config.md (line 97)


Addition regarding my first statement: This sub-section probably does not 
need to be moved. In can be kept in the preperation section.



docs/storage-config.md (line 115)


I think we might leave thos one out. Does not seem necessary.



docs/storage-config.md (line 137)


Two important points are missing here:

* has to be copied into the db backup folder
* the `scheduler-backup...` is the file name and not a path


- Stephan Erb


On Feb. 17, 2016, 12:10 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated Feb. 17, 2016, 12:10 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review119459
---



I'd likewise like to run through the updated doc to confirm.  I'll have time to 
get that done before next Monday.

- John Sirois


On Feb. 16, 2016, 4:10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated Feb. 16, 2016, 4:10 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review119384
---


Ship it!




Master (9d642dc) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 16, 2016, 11:10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated Feb. 16, 2016, 11:10 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/
---

(Updated Feb. 16, 2016, 11:10 p.m.)


Review request for Aurora, John Sirois and Stephan Erb.


Changes
---

Stephan's comment.


Bugs: AURORA-1605
https://issues.apache.org/jira/browse/AURORA-1605


Repository: aurora


Description
---

Updating scheduler backup restore instructions.


Diffs (updated)
-

  docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
  docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 

Diff: https://reviews.apache.org/r/43622/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup


Thanks,

Maxim Khutornenko

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Maxim Khutornenko]

> On Feb. 16, 2016, 10:38 p.m., Stephan Erb wrote:
> > docs/storage-config.md, line 137
> > 
> >
> > What are the expected values for leader and non-leaders?

This is a binary flag, so only the leader will have it as `1`, all others will 
stay `0`. I all add a note into the doc.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review119368
---


On Feb. 16, 2016, 9:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated Feb. 16, 2016, 9:13 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review119368
---



LGTM overall. Still, I want to test this on a real cluster. Might take me a day 
or two until I have time to look into that.


docs/storage-config.md (line 131)


What are the expected values for leader and non-leaders?


- Stephan Erb


On Feb. 16, 2016, 10:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated Feb. 16, 2016, 10:13 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review119359
---


Ship it!




Master (9d642dc) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 16, 2016, 9:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43622/
> ---
> 
> (Updated Feb. 16, 2016, 9:13 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Stephan Erb.
> 
> 
> Bugs: AURORA-1605
> https://issues.apache.org/jira/browse/AURORA-1605
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating scheduler backup restore instructions.
> 
> 
> Diffs
> -
> 
>   docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
>   docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 
> 
> Diff: https://reviews.apache.org/r/43622/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 43622: Updating scheduler backup restore instructions.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/
---

(Updated Feb. 16, 2016, 9:13 p.m.)


Review request for Aurora, John Sirois and Stephan Erb.


Changes
---

Updating admin setup instructions to always run from a leader.


Bugs: AURORA-1605
https://issues.apache.org/jira/browse/AURORA-1605


Repository: aurora


Description
---

Updating scheduler backup restore instructions.


Diffs (updated)
-

  docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
  docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 

Diff: https://reviews.apache.org/r/43622/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup


Thanks,

Maxim Khutornenko

Review Request 43622: Updating scheduler backup restore instructions.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/
---

Review request for Aurora, John Sirois and Stephan Erb.


Bugs: AURORA-1605
https://issues.apache.org/jira/browse/AURORA-1605


Repository: aurora


Description
---

Updating scheduler backup restore instructions.


Diffs
-

  docs/storage-config.md c838ea3291bf21428d8dcb0be53651ca4ceb5dda 
  docs/thrift-deprecation.md e1f1fbcfb119efa6b015d548266386a1486d932b 

Diff: https://reviews.apache.org/r/43622/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/backup_restore_instructions/docs/storage-config.md#recovering-from-a-scheduler-backup


Thanks,

Maxim Khutornenko