Re: Review Request 50931: Remove unnecessary guice container parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50931/#review145300 --- Ship it! Ship It! - Joshua Cohen On Aug. 9, 2016, 7:53 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50931/ > --- > > (Updated Aug. 9, 2016, 7:53 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > I noticed these configuration parameters have no effect. Both the API and > JAX-RS endpoints like /vars return gipped content. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 12185ec233ac8c9c6b974b60b7e102f48df61c55 > > Diff: https://reviews.apache.org/r/50931/diff/ > > > Testing > --- > > $ curl -I -X GET http://192.168.33.7:8081/vars -H 'Accept-Encoding: gzip, > deflate' > HTTP/1.1 200 OK > Date: Mon, 08 Aug 2016 15:18:12 GMT > Content-Type: text/plain > Vary: Accept-Encoding, User-Agent > Content-Encoding: gzip > Transfer-Encoding: chunked > Server: Jetty(9.3.6.v20151106) > > > Thanks, > > Zameer Manji > >
Re: Review Request 50931: Remove unnecessary guice container parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50931/#review145261 --- Master (581262c) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 9, 2016, 7:53 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50931/ > --- > > (Updated Aug. 9, 2016, 7:53 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > I noticed these configuration parameters have no effect. Both the API and > JAX-RS endpoints like /vars return gipped content. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 12185ec233ac8c9c6b974b60b7e102f48df61c55 > > Diff: https://reviews.apache.org/r/50931/diff/ > > > Testing > --- > > $ curl -I -X GET http://192.168.33.7:8081/vars -H 'Accept-Encoding: gzip, > deflate' > HTTP/1.1 200 OK > Date: Mon, 08 Aug 2016 15:18:12 GMT > Content-Type: text/plain > Vary: Accept-Encoding, User-Agent > Content-Encoding: gzip > Transfer-Encoding: chunked > Server: Jetty(9.3.6.v20151106) > > > Thanks, > > Zameer Manji > >
Re: Review Request 50931: Remove unnecessary guice container parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50931/#review145258 --- @ReviewBot retry - Zameer Manji On Aug. 9, 2016, 12:53 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50931/ > --- > > (Updated Aug. 9, 2016, 12:53 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > I noticed these configuration parameters have no effect. Both the API and > JAX-RS endpoints like /vars return gipped content. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 12185ec233ac8c9c6b974b60b7e102f48df61c55 > > Diff: https://reviews.apache.org/r/50931/diff/ > > > Testing > --- > > $ curl -I -X GET http://192.168.33.7:8081/vars -H 'Accept-Encoding: gzip, > deflate' > HTTP/1.1 200 OK > Date: Mon, 08 Aug 2016 15:18:12 GMT > Content-Type: text/plain > Vary: Accept-Encoding, User-Agent > Content-Encoding: gzip > Transfer-Encoding: chunked > Server: Jetty(9.3.6.v20151106) > > > Thanks, > > Zameer Manji > >
Re: Review Request 50931: Remove unnecessary guice container parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50931/#review145256 --- Master (581262c) is red with this patch. ./build-support/jenkins/build.sh [1m proxy_driver = ProxyDriver()[0m [1m with temporary_dir() as checkpoint_root:[0m [1mte = AuroraExecutor([0m [1m> runner_provider=make_provider(checkpoint_root),[0m [1m sandbox_provider=DefaultTestSandboxProvider())[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:580: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider [1mpex_location=thermos_runner_path(),[0m _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ build = True [1mdef thermos_runner_path(build=True):[0m [1m if not build:[0m [1mreturn getattr(thermos_runner_path, 'value', None)[0m [1m[0m [1m if not hasattr(thermos_runner_path, 'value'):[0m [1mpex_dir = safe_mkdtemp()[0m [1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m [1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m [1m[31mE assert 1 == 0[0m [1m[31mE+ where 1 = (['./pants', '--pants-distdir=/tmp/tmpegMEOQ', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m [1m[31mE+where = subprocess.call[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError -- Captured stderr call -- Traceback (most recent call last): File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/bin/pants", line 7, in from pants.bin.pants_exe import main ImportError: No module named pants.bin.pants_exe generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml [1m[31m 16 failed, 661 passed, 6 skipped, 1 warnings, 8 error in 149.39 seconds [0m FAILURE 20:19:17 02:53 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 9, 2016, 7:53 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50931/ > --- > > (Updated Aug. 9, 2016, 7:53 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > I noticed these configuration parameters have no effect. Both the API and > JAX-RS endpoints like /vars return gipped content. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 12185ec233ac8c9c6b974b60b7e102f48df61c55 > > Diff: https://reviews.apache.org/r/50931/diff/ > > > Testing > --- > > $ curl -I -X GET http://192.168.33.7:8081/vars -H 'Accept-Encoding: gzip, > deflate' > HTTP/1.1 200 OK > Date: Mon, 08 Aug 2016 15:18:12 GMT > Content-Type: text/plain > Vary: Accept-Encoding, User-Agent > Content-Encoding: gzip > Transfer-Encoding: chunked > Server: Jetty(9.3.6.v20151106) > > > Thanks, > > Zameer Manji > >
Review Request 50931: Remove unnecessary guice container parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50931/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --- I noticed these configuration parameters have no effect. Both the API and JAX-RS endpoints like /vars return gipped content. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 12185ec233ac8c9c6b974b60b7e102f48df61c55 Diff: https://reviews.apache.org/r/50931/diff/ Testing --- $ curl -I -X GET http://192.168.33.7:8081/vars -H 'Accept-Encoding: gzip, deflate' HTTP/1.1 200 OK Date: Mon, 08 Aug 2016 15:18:12 GMT Content-Type: text/plain Vary: Accept-Encoding, User-Agent Content-Encoding: gzip Transfer-Encoding: chunked Server: Jetty(9.3.6.v20151106) Thanks, Zameer Manji
