Re: Review Request 54520: Revert BUILD changes in 0c177058.

2016-12-07 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/
---

(Updated Dec. 7, 2016, 9:51 p.m.)


Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.


Bugs: AURORA-1853
https://issues.apache.org/jira/browse/AURORA-1853


Repository: aurora


Description
---

The changes caused `python_tests` target to lose their sources which in
turn caused tests not to run.

 src/main/python/apache/aurora/admin/BUILD   | 1 +
 src/main/python/apache/aurora/client/BUILD  | 1 +
 src/main/python/apache/aurora/common/BUILD  | 1 +
 src/main/python/apache/aurora/config/BUILD  | 1 +
 src/main/python/apache/aurora/executor/BUILD| 1 +
 src/main/python/apache/aurora/kerberos/BUILD| 1 +
 src/main/python/apache/aurora/tools/BUILD   | 1 +
 src/main/python/apache/thermos/cli/BUILD| 1 +
 src/main/python/apache/thermos/common/BUILD | 1 +
 src/main/python/apache/thermos/config/BUILD | 1 +
 src/main/python/apache/thermos/core/BUILD   | 1 +
 src/main/python/apache/thermos/monitoring/BUILD | 1 +
 src/main/python/apache/thermos/observer/BUILD   | 1 +
 src/main/python/apache/thermos/runner/BUILD | 1 +
 src/main/python/apache/thermos/testing/BUILD| 1 +
 src/test/python/apache/aurora/BUILD | 1 +
 src/test/python/apache/aurora/admin/BUILD   | 2 ++
 src/test/python/apache/aurora/client/BUILD  | 2 ++
 src/test/python/apache/aurora/client/api/BUILD  | 2 ++
 src/test/python/apache/aurora/client/cli/BUILD  | 2 ++
 src/test/python/apache/aurora/client/docker/BUILD   | 2 ++
 src/test/python/apache/aurora/client/hooks/BUILD| 3 ++-
 src/test/python/apache/aurora/common/BUILD  | 2 ++
 src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
 src/test/python/apache/aurora/config/BUILD  | 2 ++
 src/test/python/apache/aurora/executor/BUILD| 2 ++
 src/test/python/apache/aurora/executor/bin/BUILD| 2 ++
 src/test/python/apache/aurora/executor/common/BUILD | 2 ++
 src/test/python/apache/aurora/tools/BUILD   | 2 ++
 src/test/python/apache/thermos/cli/BUILD| 2 ++
 src/test/python/apache/thermos/cli/commands/BUILD   | 2 ++
 src/test/python/apache/thermos/common/BUILD | 2 ++
 src/test/python/apache/thermos/config/BUILD | 2 ++
 src/test/python/apache/thermos/core/BUILD   | 2 ++
 src/test/python/apache/thermos/monitoring/BUILD | 2 ++
 src/test/python/apache/thermos/observer/BUILD   | 2 ++
 src/test/python/apache/thermos/observer/http/BUILD  | 2 ++
 37 files changed, 58 insertions(+), 1 deletion(-)


Diffs
-

  src/main/python/apache/aurora/admin/BUILD 
60bfbeda8369db71099a2056c509ea1f34eadaa6 
  src/main/python/apache/aurora/client/BUILD 
452efd45beeb61042b24cf116690221eb95d02ca 
  src/main/python/apache/aurora/common/BUILD 
85b5b45a099556a21d090e180645f0c680d62db3 
  src/main/python/apache/aurora/config/BUILD 
14364ef77eeaa9fe5cd8df731c7047ba18beb361 
  src/main/python/apache/aurora/executor/BUILD 
bb6d4a3e21075ee4d56615e083059d7cae2e3e99 
  src/main/python/apache/aurora/kerberos/BUILD 
d1e6ded02ad8f71e56659fa4455dbbe14b965249 
  src/main/python/apache/aurora/tools/BUILD 
c970bec2c64226b22b624f39d21b2cedcaf4d60d 
  src/main/python/apache/thermos/cli/BUILD 
784b05c6811a86589a5a1a64bc3d15302bb22479 
  src/main/python/apache/thermos/common/BUILD 
023b87ff4ac28c58914a1a8d3943fb0554b1a259 
  src/main/python/apache/thermos/config/BUILD 
729c6533d3e059c0e65bb69da3af464f1dd9d49f 
  src/main/python/apache/thermos/core/BUILD 
e800ccabfb780e8962686434f18caba522f6516b 
  src/main/python/apache/thermos/monitoring/BUILD 
a1c16ac782da3df78b325f5273f76c47a6a1febf 
  src/main/python/apache/thermos/observer/BUILD 
714955d91e97fefc30841a2dd975f63962a444df 
  src/main/python/apache/thermos/runner/BUILD 
d51587842deeadfc316072b6c7fe4a584412db0a 
  src/main/python/apache/thermos/testing/BUILD 
0964a7ddcb6558b6e685b3fa710f25b5862c72f1 
  src/test/python/apache/aurora/BUILD 48ea328c51fb41e1de65673d95e0416ecd1af9c8 
  src/test/python/apache/aurora/admin/BUILD 
8dd8b6d71a5b9e2ddd44d93843853e4271402573 
  src/test/python/apache/aurora/client/BUILD 
2347d226c8f22009d9a2170ea554d7512a47e2ff 
  src/test/python/apache/aurora/client/api/BUILD 
8394d4e717c6ecb6ddb19dc4f67d039347d4ba8f 
  src/test/python/apache/aurora/client/cli/BUILD 
bd74d64f9b19c77f623d7054b5253f1032f02230 
  src/test/python/apache/aurora/client/docker/BUILD 
f0cf97157c9d8b145297d164c610bf020b3e9cd1 
  src/test/python/apache/aurora/client/hooks/BUILD 
bbbeb2fb2277e0c28d67b461a5c589e6c68d9779 
  src/test/python/apache/aurora/common/BUILD 

Re: Review Request 54520: Revert BUILD changes in 0c177058.

2016-12-07 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/#review158499
---


Ship it!




Master (d05ea2b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 8, 2016, 4:51 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54520/
> ---
> 
> (Updated Dec. 8, 2016, 4:51 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1853
> https://issues.apache.org/jira/browse/AURORA-1853
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The changes caused `python_tests` target to lose their sources which in
> turn caused tests not to run.
> 
>  src/main/python/apache/aurora/admin/BUILD   | 1 +
>  src/main/python/apache/aurora/client/BUILD  | 1 +
>  src/main/python/apache/aurora/common/BUILD  | 1 +
>  src/main/python/apache/aurora/config/BUILD  | 1 +
>  src/main/python/apache/aurora/executor/BUILD| 1 +
>  src/main/python/apache/aurora/kerberos/BUILD| 1 +
>  src/main/python/apache/aurora/tools/BUILD   | 1 +
>  src/main/python/apache/thermos/cli/BUILD| 1 +
>  src/main/python/apache/thermos/common/BUILD | 1 +
>  src/main/python/apache/thermos/config/BUILD | 1 +
>  src/main/python/apache/thermos/core/BUILD   | 1 +
>  src/main/python/apache/thermos/monitoring/BUILD | 1 +
>  src/main/python/apache/thermos/observer/BUILD   | 1 +
>  src/main/python/apache/thermos/runner/BUILD | 1 +
>  src/main/python/apache/thermos/testing/BUILD| 1 +
>  src/test/python/apache/aurora/BUILD | 1 +
>  src/test/python/apache/aurora/admin/BUILD   | 2 ++
>  src/test/python/apache/aurora/client/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/api/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/cli/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/docker/BUILD   | 2 ++
>  src/test/python/apache/aurora/client/hooks/BUILD| 3 ++-
>  src/test/python/apache/aurora/common/BUILD  | 2 ++
>  src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
>  src/test/python/apache/aurora/config/BUILD  | 2 ++
>  src/test/python/apache/aurora/executor/BUILD| 2 ++
>  src/test/python/apache/aurora/executor/bin/BUILD| 2 ++
>  src/test/python/apache/aurora/executor/common/BUILD | 2 ++
>  src/test/python/apache/aurora/tools/BUILD   | 2 ++
>  src/test/python/apache/thermos/cli/BUILD| 2 ++
>  src/test/python/apache/thermos/cli/commands/BUILD   | 2 ++
>  src/test/python/apache/thermos/common/BUILD | 2 ++
>  src/test/python/apache/thermos/config/BUILD | 2 ++
>  src/test/python/apache/thermos/core/BUILD   | 2 ++
>  src/test/python/apache/thermos/monitoring/BUILD | 2 ++
>  src/test/python/apache/thermos/observer/BUILD   | 2 ++
>  src/test/python/apache/thermos/observer/http/BUILD  | 2 ++
>  37 files changed, 58 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/BUILD 
> 60bfbeda8369db71099a2056c509ea1f34eadaa6 
>   src/main/python/apache/aurora/client/BUILD 
> 452efd45beeb61042b24cf116690221eb95d02ca 
>   src/main/python/apache/aurora/common/BUILD 
> 85b5b45a099556a21d090e180645f0c680d62db3 
>   src/main/python/apache/aurora/config/BUILD 
> 14364ef77eeaa9fe5cd8df731c7047ba18beb361 
>   src/main/python/apache/aurora/executor/BUILD 
> bb6d4a3e21075ee4d56615e083059d7cae2e3e99 
>   src/main/python/apache/aurora/kerberos/BUILD 
> d1e6ded02ad8f71e56659fa4455dbbe14b965249 
>   src/main/python/apache/aurora/tools/BUILD 
> c970bec2c64226b22b624f39d21b2cedcaf4d60d 
>   src/main/python/apache/thermos/cli/BUILD 
> 784b05c6811a86589a5a1a64bc3d15302bb22479 
>   src/main/python/apache/thermos/common/BUILD 
> 023b87ff4ac28c58914a1a8d3943fb0554b1a259 
>   src/main/python/apache/thermos/config/BUILD 
> 729c6533d3e059c0e65bb69da3af464f1dd9d49f 
>   src/main/python/apache/thermos/core/BUILD 
> e800ccabfb780e8962686434f18caba522f6516b 
>   src/main/python/apache/thermos/monitoring/BUILD 
> a1c16ac782da3df78b325f5273f76c47a6a1febf 
>   src/main/python/apache/thermos/observer/BUILD 
> 714955d91e97fefc30841a2dd975f63962a444df 
>   src/main/python/apache/thermos/runner/BUILD 
> d51587842deeadfc316072b6c7fe4a584412db0a 
>   src/main/python/apache/thermos/testing/BUILD 
> 0964a7ddcb6558b6e685b3fa710f25b5862c72f1 
>   

Re: Review Request 54520: Revert BUILD changes in 0c177058.

2016-12-07 Thread John Sirois


> On Dec. 7, 2016, 9:41 p.m., John Sirois wrote:
> > NB: When AuroraBot goes green I'll submit this TBR and file a follow-up 
> > issue in Aurora and a corresponding one in pants if needed, to restore the 
> > BUILD file changes for default targets and default globs.

Also note this was a mechanical change achieved with:
```
$ git co 0c1770581317d693f3b388c067d2ddd1dcc2b867^ -- src/{main,test}/python/
$ git reset HEAD \
  src/main/python/apache/aurora/executor/aurora_executor.py \
  src/main/python/apache/aurora/executor/common/health_checker.py \
  src/test/python/apache/aurora/executor/common/test_health_checker.py
$ git co -- \
  src/main/python/apache/aurora/executor/aurora_executor.py \
  src/main/python/apache/aurora/executor/common/health_checker.py \
  src/test/python/apache/aurora/executor/common/test_health_checker.py
```

The `git reset HEAD ... && git co -- ...` preserved Santhosh's changes in 
[d05ea2bc](https://github.com/apache/aurora/commit/d05ea2bcc4af20af0b5e0a7f3995d02ff25a1626)


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/#review158496
---


On Dec. 7, 2016, 9:39 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54520/
> ---
> 
> (Updated Dec. 7, 2016, 9:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The changes caused `python_tests` target to lose their sources which in
> turn caused tests not to run.
> 
>  src/main/python/apache/aurora/admin/BUILD   | 1 +
>  src/main/python/apache/aurora/client/BUILD  | 1 +
>  src/main/python/apache/aurora/common/BUILD  | 1 +
>  src/main/python/apache/aurora/config/BUILD  | 1 +
>  src/main/python/apache/aurora/executor/BUILD| 1 +
>  src/main/python/apache/aurora/kerberos/BUILD| 1 +
>  src/main/python/apache/aurora/tools/BUILD   | 1 +
>  src/main/python/apache/thermos/cli/BUILD| 1 +
>  src/main/python/apache/thermos/common/BUILD | 1 +
>  src/main/python/apache/thermos/config/BUILD | 1 +
>  src/main/python/apache/thermos/core/BUILD   | 1 +
>  src/main/python/apache/thermos/monitoring/BUILD | 1 +
>  src/main/python/apache/thermos/observer/BUILD   | 1 +
>  src/main/python/apache/thermos/runner/BUILD | 1 +
>  src/main/python/apache/thermos/testing/BUILD| 1 +
>  src/test/python/apache/aurora/BUILD | 1 +
>  src/test/python/apache/aurora/admin/BUILD   | 2 ++
>  src/test/python/apache/aurora/client/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/api/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/cli/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/docker/BUILD   | 2 ++
>  src/test/python/apache/aurora/client/hooks/BUILD| 3 ++-
>  src/test/python/apache/aurora/common/BUILD  | 2 ++
>  src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
>  src/test/python/apache/aurora/config/BUILD  | 2 ++
>  src/test/python/apache/aurora/executor/BUILD| 2 ++
>  src/test/python/apache/aurora/executor/bin/BUILD| 2 ++
>  src/test/python/apache/aurora/executor/common/BUILD | 2 ++
>  src/test/python/apache/aurora/tools/BUILD   | 2 ++
>  src/test/python/apache/thermos/cli/BUILD| 2 ++
>  src/test/python/apache/thermos/cli/commands/BUILD   | 2 ++
>  src/test/python/apache/thermos/common/BUILD | 2 ++
>  src/test/python/apache/thermos/config/BUILD | 2 ++
>  src/test/python/apache/thermos/core/BUILD   | 2 ++
>  src/test/python/apache/thermos/monitoring/BUILD | 2 ++
>  src/test/python/apache/thermos/observer/BUILD   | 2 ++
>  src/test/python/apache/thermos/observer/http/BUILD  | 2 ++
>  37 files changed, 58 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/BUILD 
> 60bfbeda8369db71099a2056c509ea1f34eadaa6 
>   src/main/python/apache/aurora/client/BUILD 
> 452efd45beeb61042b24cf116690221eb95d02ca 
>   src/main/python/apache/aurora/common/BUILD 
> 85b5b45a099556a21d090e180645f0c680d62db3 
>   src/main/python/apache/aurora/config/BUILD 
> 14364ef77eeaa9fe5cd8df731c7047ba18beb361 
>   src/main/python/apache/aurora/executor/BUILD 
> bb6d4a3e21075ee4d56615e083059d7cae2e3e99 
>   src/main/python/apache/aurora/kerberos/BUILD 
> d1e6ded02ad8f71e56659fa4455dbbe14b965249 
>   src/main/python/apache/aurora/tools/BUILD 
> c970bec2c64226b22b624f39d21b2cedcaf4d60d 
>   

Re: Review Request 54520: Revert BUILD changes in 0c177058.

2016-12-07 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/#review158497
---


Ship it!




Ship It!

- Joshua Cohen


On Dec. 8, 2016, 4:39 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54520/
> ---
> 
> (Updated Dec. 8, 2016, 4:39 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The changes caused `python_tests` target to lose their sources which in
> turn caused tests not to run.
> 
>  src/main/python/apache/aurora/admin/BUILD   | 1 +
>  src/main/python/apache/aurora/client/BUILD  | 1 +
>  src/main/python/apache/aurora/common/BUILD  | 1 +
>  src/main/python/apache/aurora/config/BUILD  | 1 +
>  src/main/python/apache/aurora/executor/BUILD| 1 +
>  src/main/python/apache/aurora/kerberos/BUILD| 1 +
>  src/main/python/apache/aurora/tools/BUILD   | 1 +
>  src/main/python/apache/thermos/cli/BUILD| 1 +
>  src/main/python/apache/thermos/common/BUILD | 1 +
>  src/main/python/apache/thermos/config/BUILD | 1 +
>  src/main/python/apache/thermos/core/BUILD   | 1 +
>  src/main/python/apache/thermos/monitoring/BUILD | 1 +
>  src/main/python/apache/thermos/observer/BUILD   | 1 +
>  src/main/python/apache/thermos/runner/BUILD | 1 +
>  src/main/python/apache/thermos/testing/BUILD| 1 +
>  src/test/python/apache/aurora/BUILD | 1 +
>  src/test/python/apache/aurora/admin/BUILD   | 2 ++
>  src/test/python/apache/aurora/client/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/api/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/cli/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/docker/BUILD   | 2 ++
>  src/test/python/apache/aurora/client/hooks/BUILD| 3 ++-
>  src/test/python/apache/aurora/common/BUILD  | 2 ++
>  src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
>  src/test/python/apache/aurora/config/BUILD  | 2 ++
>  src/test/python/apache/aurora/executor/BUILD| 2 ++
>  src/test/python/apache/aurora/executor/bin/BUILD| 2 ++
>  src/test/python/apache/aurora/executor/common/BUILD | 2 ++
>  src/test/python/apache/aurora/tools/BUILD   | 2 ++
>  src/test/python/apache/thermos/cli/BUILD| 2 ++
>  src/test/python/apache/thermos/cli/commands/BUILD   | 2 ++
>  src/test/python/apache/thermos/common/BUILD | 2 ++
>  src/test/python/apache/thermos/config/BUILD | 2 ++
>  src/test/python/apache/thermos/core/BUILD   | 2 ++
>  src/test/python/apache/thermos/monitoring/BUILD | 2 ++
>  src/test/python/apache/thermos/observer/BUILD   | 2 ++
>  src/test/python/apache/thermos/observer/http/BUILD  | 2 ++
>  37 files changed, 58 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/BUILD 
> 60bfbeda8369db71099a2056c509ea1f34eadaa6 
>   src/main/python/apache/aurora/client/BUILD 
> 452efd45beeb61042b24cf116690221eb95d02ca 
>   src/main/python/apache/aurora/common/BUILD 
> 85b5b45a099556a21d090e180645f0c680d62db3 
>   src/main/python/apache/aurora/config/BUILD 
> 14364ef77eeaa9fe5cd8df731c7047ba18beb361 
>   src/main/python/apache/aurora/executor/BUILD 
> bb6d4a3e21075ee4d56615e083059d7cae2e3e99 
>   src/main/python/apache/aurora/kerberos/BUILD 
> d1e6ded02ad8f71e56659fa4455dbbe14b965249 
>   src/main/python/apache/aurora/tools/BUILD 
> c970bec2c64226b22b624f39d21b2cedcaf4d60d 
>   src/main/python/apache/thermos/cli/BUILD 
> 784b05c6811a86589a5a1a64bc3d15302bb22479 
>   src/main/python/apache/thermos/common/BUILD 
> 023b87ff4ac28c58914a1a8d3943fb0554b1a259 
>   src/main/python/apache/thermos/config/BUILD 
> 729c6533d3e059c0e65bb69da3af464f1dd9d49f 
>   src/main/python/apache/thermos/core/BUILD 
> e800ccabfb780e8962686434f18caba522f6516b 
>   src/main/python/apache/thermos/monitoring/BUILD 
> a1c16ac782da3df78b325f5273f76c47a6a1febf 
>   src/main/python/apache/thermos/observer/BUILD 
> 714955d91e97fefc30841a2dd975f63962a444df 
>   src/main/python/apache/thermos/runner/BUILD 
> d51587842deeadfc316072b6c7fe4a584412db0a 
>   src/main/python/apache/thermos/testing/BUILD 
> 0964a7ddcb6558b6e685b3fa710f25b5862c72f1 
>   src/test/python/apache/aurora/BUILD 
> 48ea328c51fb41e1de65673d95e0416ecd1af9c8 
>   src/test/python/apache/aurora/admin/BUILD 
> 8dd8b6d71a5b9e2ddd44d93843853e4271402573 
>   src/test/python/apache/aurora/client/BUILD 
> 2347d226c8f22009d9a2170ea554d7512a47e2ff 

Re: Review Request 54520: Revert BUILD changes in 0c177058.

2016-12-07 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/#review158496
---



NB: When AuroraBot goes green I'll submit this TBR and file a follow-up issue 
in Aurora and a corresponding one in pants if needed, to restore the BUILD file 
changes for default targets and default globs.

- John Sirois


On Dec. 7, 2016, 9:39 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54520/
> ---
> 
> (Updated Dec. 7, 2016, 9:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The changes caused `python_tests` target to lose their sources which in
> turn caused tests not to run.
> 
>  src/main/python/apache/aurora/admin/BUILD   | 1 +
>  src/main/python/apache/aurora/client/BUILD  | 1 +
>  src/main/python/apache/aurora/common/BUILD  | 1 +
>  src/main/python/apache/aurora/config/BUILD  | 1 +
>  src/main/python/apache/aurora/executor/BUILD| 1 +
>  src/main/python/apache/aurora/kerberos/BUILD| 1 +
>  src/main/python/apache/aurora/tools/BUILD   | 1 +
>  src/main/python/apache/thermos/cli/BUILD| 1 +
>  src/main/python/apache/thermos/common/BUILD | 1 +
>  src/main/python/apache/thermos/config/BUILD | 1 +
>  src/main/python/apache/thermos/core/BUILD   | 1 +
>  src/main/python/apache/thermos/monitoring/BUILD | 1 +
>  src/main/python/apache/thermos/observer/BUILD   | 1 +
>  src/main/python/apache/thermos/runner/BUILD | 1 +
>  src/main/python/apache/thermos/testing/BUILD| 1 +
>  src/test/python/apache/aurora/BUILD | 1 +
>  src/test/python/apache/aurora/admin/BUILD   | 2 ++
>  src/test/python/apache/aurora/client/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/api/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/cli/BUILD  | 2 ++
>  src/test/python/apache/aurora/client/docker/BUILD   | 2 ++
>  src/test/python/apache/aurora/client/hooks/BUILD| 3 ++-
>  src/test/python/apache/aurora/common/BUILD  | 2 ++
>  src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
>  src/test/python/apache/aurora/config/BUILD  | 2 ++
>  src/test/python/apache/aurora/executor/BUILD| 2 ++
>  src/test/python/apache/aurora/executor/bin/BUILD| 2 ++
>  src/test/python/apache/aurora/executor/common/BUILD | 2 ++
>  src/test/python/apache/aurora/tools/BUILD   | 2 ++
>  src/test/python/apache/thermos/cli/BUILD| 2 ++
>  src/test/python/apache/thermos/cli/commands/BUILD   | 2 ++
>  src/test/python/apache/thermos/common/BUILD | 2 ++
>  src/test/python/apache/thermos/config/BUILD | 2 ++
>  src/test/python/apache/thermos/core/BUILD   | 2 ++
>  src/test/python/apache/thermos/monitoring/BUILD | 2 ++
>  src/test/python/apache/thermos/observer/BUILD   | 2 ++
>  src/test/python/apache/thermos/observer/http/BUILD  | 2 ++
>  37 files changed, 58 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/BUILD 
> 60bfbeda8369db71099a2056c509ea1f34eadaa6 
>   src/main/python/apache/aurora/client/BUILD 
> 452efd45beeb61042b24cf116690221eb95d02ca 
>   src/main/python/apache/aurora/common/BUILD 
> 85b5b45a099556a21d090e180645f0c680d62db3 
>   src/main/python/apache/aurora/config/BUILD 
> 14364ef77eeaa9fe5cd8df731c7047ba18beb361 
>   src/main/python/apache/aurora/executor/BUILD 
> bb6d4a3e21075ee4d56615e083059d7cae2e3e99 
>   src/main/python/apache/aurora/kerberos/BUILD 
> d1e6ded02ad8f71e56659fa4455dbbe14b965249 
>   src/main/python/apache/aurora/tools/BUILD 
> c970bec2c64226b22b624f39d21b2cedcaf4d60d 
>   src/main/python/apache/thermos/cli/BUILD 
> 784b05c6811a86589a5a1a64bc3d15302bb22479 
>   src/main/python/apache/thermos/common/BUILD 
> 023b87ff4ac28c58914a1a8d3943fb0554b1a259 
>   src/main/python/apache/thermos/config/BUILD 
> 729c6533d3e059c0e65bb69da3af464f1dd9d49f 
>   src/main/python/apache/thermos/core/BUILD 
> e800ccabfb780e8962686434f18caba522f6516b 
>   src/main/python/apache/thermos/monitoring/BUILD 
> a1c16ac782da3df78b325f5273f76c47a6a1febf 
>   src/main/python/apache/thermos/observer/BUILD 
> 714955d91e97fefc30841a2dd975f63962a444df 
>   src/main/python/apache/thermos/runner/BUILD 
> d51587842deeadfc316072b6c7fe4a584412db0a 
>   src/main/python/apache/thermos/testing/BUILD 
> 0964a7ddcb6558b6e685b3fa710f25b5862c72f1 
>   src/test/python/apache/aurora/BUILD 
> 

Review Request 54520: Revert BUILD changes in 0c177058.

2016-12-07 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/
---

Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.


Repository: aurora


Description
---

The changes caused `python_tests` target to lose their sources which in
turn caused tests not to run.

 src/main/python/apache/aurora/admin/BUILD   | 1 +
 src/main/python/apache/aurora/client/BUILD  | 1 +
 src/main/python/apache/aurora/common/BUILD  | 1 +
 src/main/python/apache/aurora/config/BUILD  | 1 +
 src/main/python/apache/aurora/executor/BUILD| 1 +
 src/main/python/apache/aurora/kerberos/BUILD| 1 +
 src/main/python/apache/aurora/tools/BUILD   | 1 +
 src/main/python/apache/thermos/cli/BUILD| 1 +
 src/main/python/apache/thermos/common/BUILD | 1 +
 src/main/python/apache/thermos/config/BUILD | 1 +
 src/main/python/apache/thermos/core/BUILD   | 1 +
 src/main/python/apache/thermos/monitoring/BUILD | 1 +
 src/main/python/apache/thermos/observer/BUILD   | 1 +
 src/main/python/apache/thermos/runner/BUILD | 1 +
 src/main/python/apache/thermos/testing/BUILD| 1 +
 src/test/python/apache/aurora/BUILD | 1 +
 src/test/python/apache/aurora/admin/BUILD   | 2 ++
 src/test/python/apache/aurora/client/BUILD  | 2 ++
 src/test/python/apache/aurora/client/api/BUILD  | 2 ++
 src/test/python/apache/aurora/client/cli/BUILD  | 2 ++
 src/test/python/apache/aurora/client/docker/BUILD   | 2 ++
 src/test/python/apache/aurora/client/hooks/BUILD| 3 ++-
 src/test/python/apache/aurora/common/BUILD  | 2 ++
 src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
 src/test/python/apache/aurora/config/BUILD  | 2 ++
 src/test/python/apache/aurora/executor/BUILD| 2 ++
 src/test/python/apache/aurora/executor/bin/BUILD| 2 ++
 src/test/python/apache/aurora/executor/common/BUILD | 2 ++
 src/test/python/apache/aurora/tools/BUILD   | 2 ++
 src/test/python/apache/thermos/cli/BUILD| 2 ++
 src/test/python/apache/thermos/cli/commands/BUILD   | 2 ++
 src/test/python/apache/thermos/common/BUILD | 2 ++
 src/test/python/apache/thermos/config/BUILD | 2 ++
 src/test/python/apache/thermos/core/BUILD   | 2 ++
 src/test/python/apache/thermos/monitoring/BUILD | 2 ++
 src/test/python/apache/thermos/observer/BUILD   | 2 ++
 src/test/python/apache/thermos/observer/http/BUILD  | 2 ++
 37 files changed, 58 insertions(+), 1 deletion(-)


Diffs
-

  src/main/python/apache/aurora/admin/BUILD 
60bfbeda8369db71099a2056c509ea1f34eadaa6 
  src/main/python/apache/aurora/client/BUILD 
452efd45beeb61042b24cf116690221eb95d02ca 
  src/main/python/apache/aurora/common/BUILD 
85b5b45a099556a21d090e180645f0c680d62db3 
  src/main/python/apache/aurora/config/BUILD 
14364ef77eeaa9fe5cd8df731c7047ba18beb361 
  src/main/python/apache/aurora/executor/BUILD 
bb6d4a3e21075ee4d56615e083059d7cae2e3e99 
  src/main/python/apache/aurora/kerberos/BUILD 
d1e6ded02ad8f71e56659fa4455dbbe14b965249 
  src/main/python/apache/aurora/tools/BUILD 
c970bec2c64226b22b624f39d21b2cedcaf4d60d 
  src/main/python/apache/thermos/cli/BUILD 
784b05c6811a86589a5a1a64bc3d15302bb22479 
  src/main/python/apache/thermos/common/BUILD 
023b87ff4ac28c58914a1a8d3943fb0554b1a259 
  src/main/python/apache/thermos/config/BUILD 
729c6533d3e059c0e65bb69da3af464f1dd9d49f 
  src/main/python/apache/thermos/core/BUILD 
e800ccabfb780e8962686434f18caba522f6516b 
  src/main/python/apache/thermos/monitoring/BUILD 
a1c16ac782da3df78b325f5273f76c47a6a1febf 
  src/main/python/apache/thermos/observer/BUILD 
714955d91e97fefc30841a2dd975f63962a444df 
  src/main/python/apache/thermos/runner/BUILD 
d51587842deeadfc316072b6c7fe4a584412db0a 
  src/main/python/apache/thermos/testing/BUILD 
0964a7ddcb6558b6e685b3fa710f25b5862c72f1 
  src/test/python/apache/aurora/BUILD 48ea328c51fb41e1de65673d95e0416ecd1af9c8 
  src/test/python/apache/aurora/admin/BUILD 
8dd8b6d71a5b9e2ddd44d93843853e4271402573 
  src/test/python/apache/aurora/client/BUILD 
2347d226c8f22009d9a2170ea554d7512a47e2ff 
  src/test/python/apache/aurora/client/api/BUILD 
8394d4e717c6ecb6ddb19dc4f67d039347d4ba8f 
  src/test/python/apache/aurora/client/cli/BUILD 
bd74d64f9b19c77f623d7054b5253f1032f02230 
  src/test/python/apache/aurora/client/docker/BUILD 
f0cf97157c9d8b145297d164c610bf020b3e9cd1 
  src/test/python/apache/aurora/client/hooks/BUILD 
bbbeb2fb2277e0c28d67b461a5c589e6c68d9779 
  src/test/python/apache/aurora/common/BUILD 
a65a959c0c472a8af2c9c7a0daf59fc85cb0cbc8 
  src/test/python/apache/aurora/common/health_check/BUILD