Re: Review Request 60437: Add timing metrics in MesosCallbackHandler for backward compatibility.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60437/#review182215 --- Ship it! Ship It! - Stephan Erb On June 26, 2017, 7:37 p.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60437/ > --- > > (Updated June 26, 2017, 7:37 p.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Add timing metrics in MesosCallbackHandler for backward compatibility. > > We have an internal performance dashboard that reads the following timing > metrics: > ``` > scheduler_resource_offers, > scheduler_framework_message, > scheduler_status_update > ``` > Currently, these timing metrics merely reside in MesosSchedulerImpl class. If > we were to enable the Mesos HTTP API in aurora(switch from > __MesosSchedulerImpl__ to __VersionedMesosSchedulerImpl__), we will lose the > timing metrics in MesosSchedulerImpl. This CR migrates the missing timing > metrics from MesosSchedulerImpl to MesosCallbackHandler, so that the above > timing metrics will be visible after enabling Mesos HTTP API. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > 772a04cbad99eb088105822f41b0758f47f7915a > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > c3a34d2ae51a02247a7e6176dec0f04bddc0270d > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java > b955d61bbed2a6f4cb7f2581ebec398d637f0895 > > > Diff: https://reviews.apache.org/r/60437/diff/1/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > > Thanks, > > Kai Huang > >
Re: Review Request 60437: Add timing metrics in MesosCallbackHandler for backward compatibility.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60437/#review178912 --- Ship it! Ship It! - David McLaughlin On June 26, 2017, 5:37 p.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60437/ > --- > > (Updated June 26, 2017, 5:37 p.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Add timing metrics in MesosCallbackHandler for backward compatibility. > > We have an internal performance dashboard that reads the following timing > metrics: > ``` > scheduler_resource_offers, > scheduler_framework_message, > scheduler_status_update > ``` > Currently, these timing metrics merely reside in MesosSchedulerImpl class. If > we were to enable the Mesos HTTP API in aurora(switch from > __MesosSchedulerImpl__ to __VersionedMesosSchedulerImpl__), we will lose the > timing metrics in MesosSchedulerImpl. This CR migrates the missing timing > metrics from MesosSchedulerImpl to MesosCallbackHandler, so that the above > timing metrics will be visible after enabling Mesos HTTP API. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > 772a04cbad99eb088105822f41b0758f47f7915a > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > c3a34d2ae51a02247a7e6176dec0f04bddc0270d > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java > b955d61bbed2a6f4cb7f2581ebec398d637f0895 > > > Diff: https://reviews.apache.org/r/60437/diff/1/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > > Thanks, > > Kai Huang > >
Re: Review Request 60437: Add timing metrics in MesosCallbackHandler for backward compatibility.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60437/#review178911 --- Ship it! Master (a922b05) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 26, 2017, 10:37 a.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60437/ > --- > > (Updated June 26, 2017, 10:37 a.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Add timing metrics in MesosCallbackHandler for backward compatibility. > > We have an internal performance dashboard that reads the following timing > metrics: > ``` > scheduler_resource_offers, > scheduler_framework_message, > scheduler_status_update > ``` > Currently, these timing metrics merely reside in MesosSchedulerImpl class. If > we were to enable the Mesos HTTP API in aurora(switch from > __MesosSchedulerImpl__ to __VersionedMesosSchedulerImpl__), we will lose the > timing metrics in MesosSchedulerImpl. This CR migrates the missing timing > metrics from MesosSchedulerImpl to MesosCallbackHandler, so that the above > timing metrics will be visible after enabling Mesos HTTP API. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > 772a04cbad99eb088105822f41b0758f47f7915a > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > c3a34d2ae51a02247a7e6176dec0f04bddc0270d > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java > b955d61bbed2a6f4cb7f2581ebec398d637f0895 > > > Diff: https://reviews.apache.org/r/60437/diff/1/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > > Thanks, > > Kai Huang > >
Re: Review Request 60437: Add timing metrics in MesosCallbackHandler for backward compatibility.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60437/#review178910 --- Ship it! Ship It! - Zameer Manji On June 26, 2017, 10:37 a.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60437/ > --- > > (Updated June 26, 2017, 10:37 a.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Add timing metrics in MesosCallbackHandler for backward compatibility. > > We have an internal performance dashboard that reads the following timing > metrics: > ``` > scheduler_resource_offers, > scheduler_framework_message, > scheduler_status_update > ``` > Currently, these timing metrics merely reside in MesosSchedulerImpl class. If > we were to enable the Mesos HTTP API in aurora(switch from > __MesosSchedulerImpl__ to __VersionedMesosSchedulerImpl__), we will lose the > timing metrics in MesosSchedulerImpl. This CR migrates the missing timing > metrics from MesosSchedulerImpl to MesosCallbackHandler, so that the above > timing metrics will be visible after enabling Mesos HTTP API. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > 772a04cbad99eb088105822f41b0758f47f7915a > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > c3a34d2ae51a02247a7e6176dec0f04bddc0270d > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java > b955d61bbed2a6f4cb7f2581ebec398d637f0895 > > > Diff: https://reviews.apache.org/r/60437/diff/1/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > > Thanks, > > Kai Huang > >
Review Request 60437: Add timing metrics in MesosCallbackHandler for backward compatibility.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60437/ --- Review request for Aurora, David McLaughlin, Santhosh Kumar, and Zameer Manji. Repository: aurora Description --- Add timing metrics in MesosCallbackHandler for backward compatibility. We have an internal performance dashboard that reads the following timing metrics: ``` scheduler_resource_offers, scheduler_framework_message, scheduler_status_update ``` Currently, these timing metrics merely reside in MesosSchedulerImpl class. If we were to enable the Mesos HTTP API in aurora(switch from __MesosSchedulerImpl__ to __VersionedMesosSchedulerImpl__), we will lose the timing metrics in MesosSchedulerImpl. This CR migrates the missing timing metrics from MesosSchedulerImpl to MesosCallbackHandler, so that the above timing metrics will be visible after enabling Mesos HTTP API. Diffs - src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 772a04cbad99eb088105822f41b0758f47f7915a src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java c3a34d2ae51a02247a7e6176dec0f04bddc0270d src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java b955d61bbed2a6f4cb7f2581ebec398d637f0895 Diff: https://reviews.apache.org/r/60437/diff/1/ Testing --- ./build-support/jenkins/build.sh Thanks, Kai Huang
