Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review194377 --- The version of pants used seems to have a native dependency to GLIBC-2.18 which is not available in most Centos-7 machines. I have opened an issue with pants to release a compatible version - https://github.com/pantsbuild/pants/issues/5240. @jsirois looks like the pants release 1.4.0-dev23 was built by you :) Can you take a look? Thanks. - Santhosh Kumar Shanmugham On Dec. 9, 2017, 8:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 8:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
> On Dec. 12, 2017, 4:11 p.m., Aurora ReviewBot wrote: > > Master (65c2288) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" > > Stephan Erb wrote: > Finally :) Excellent! Thanks for your help with this! - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193623 --- On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
> On Dec. 13, 2017, 12:11 a.m., Aurora ReviewBot wrote: > > Master (65c2288) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" Finally :) - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193623 --- On Dec. 9, 2017, 5:32 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 5:32 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193623 --- Ship it! Master (65c2288) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 9, 2017, 8:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 8:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193617 --- @ReviewBot retry - Stephan Erb On Dec. 9, 2017, 5:32 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 5:32 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193508
---
Master (ef24c2c) is red with this patch.
./build-support/jenkins/build.sh
SUCCESS
08:47:34 00:00 [main]
(To run a reporting server: ./pants server)
08:47:34 00:00 [setup]
08:47:35 00:01 [parse]
Executing tasks in goals: gen -> pyprep -> setup-py
08:47:35 00:01 [gen]
08:47:35 00:01 [thrift-py]
08:47:35 00:01 [pyprep]
08:47:35 00:01 [interpreter]
08:47:35 00:01 [requirements]
08:47:35 00:01 [cache]
No cached artifacts for 1 target.
Invalidated 1 target. Failed to install
pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
'--dist-dir=/tmp/tmpvHOMIQ']` while trying to execute `[u'/usr/bin/python2.7',
'-', 'bdist_wheel', '--dist-dir=/tmp/tmpvHOMIQ']`",)
):
stdout:
running bdist_wheel
running build
running build_ext
building 'kerberos' extension
creating build
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
-fstack-protector-strong -Wformat -Werror=format-security -fPIC
-I/usr/include/python2.7 -c src/kerberos.c -o
build/temp.linux-x86_64-2.7/src/kerberos.o
stderr:
In file included from src/kerberos.c:19:0:
src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
directory
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
08:47:37 00:03 [complete]
FAILURE
Exception caught: ()
Exception message: Package
SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
SourceTranslator)
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 9, 2017, 8:32 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 8:32 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
>
> Diffs
> -
>
> .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde
> 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555
> api/src/main/thrift/org/apache/thermos/BUILD
> b58338e76bdee3481071d8f27235a9dbb6bf07b5
> build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/python/checkstyle-check
> 0c8800232e20347b2be9a538ffed1d47a7815241
> build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20
> build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78
> build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae
> build-support/release/make-python-sdists
> 51e11dbc1929609374031c9b23a96f035eba902b
> build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> 77c966caa3d1f644241bcc2b1968bc9306c56689
>
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
> 42300b43a8f72e45c96b975e5d3a6a7bd0283529
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch
> 11c7b13341e156f3686511cb40ab13c1256203a6
> build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
> build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
> build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy
> fc2bc9082dae2c63aa578c05dc89feb346260a67
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
> src/main/python/apache/aurora/client/cli/BUILD
> 80a6dec9acf5b64cff64143929916676b79be686
> src/main/python/apache/thermos/observer/BUILD
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193499 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
> On Dec. 11, 2017, 12:38 p.m., Stephan Erb wrote: > > I have filed https://issues.apache.org/jira/browse/AURORA-1961 to address > > the flaky build. Thanks Stephan. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193430 --- On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193420 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193430 --- I have filed https://issues.apache.org/jira/browse/AURORA-1961 to address the flaky build. - Stephan Erb On Dec. 9, 2017, 5:32 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 5:32 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
> On Dec. 11, 2017, 12:19 a.m., Aurora ReviewBot wrote:
> > Master (ef24c2c) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> >SUCCESS
> >
> > 07:19:08 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 07:19:08 00:00 [setup]
> > 07:19:08 00:00 [parse]
> >Executing tasks in goals: gen -> pyprep -> setup-py
> > 07:19:08 00:00 [gen]
> > 07:19:09 00:01 [thrift-py]
> > 07:19:09 00:01 [pyprep]
> > 07:19:09 00:01 [interpreter]
> > 07:19:09 00:01 [requirements]
> > 07:19:09 00:01 [cache]
> >No cached artifacts for 1 target.
> >Invalidated 1 target. Failed to install
> > pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
> > execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
> > '--dist-dir=/tmp/tmpoky0pr']` while trying to execute
> > `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
> > '--dist-dir=/tmp/tmpoky0pr']`",)
> > ):
> > stdout:
> > running bdist_wheel
> > running build
> > running build_ext
> > building 'kerberos' extension
> > creating build
> > creating build/temp.linux-x86_64-2.7
> > creating build/temp.linux-x86_64-2.7/src
> > x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall
> > -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
> > -fstack-protector-strong -Wformat -Werror=format-security -fPIC
> > -I/usr/include/python2.7 -c src/kerberos.c -o
> > build/temp.linux-x86_64-2.7/src/kerberos.o
> >
> > stderr:
> > In file included from src/kerberos.c:19:0:
> > src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
> > directory
> > compilation terminated.
> > error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
> >
> >
> >
> > 07:19:10 00:02 [complete]
> >FAILURE
> > Exception caught: ()
> >
> > Exception message: Package
> > SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
> > is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
> > SourceTranslator)
> >
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
@ReviewBot retry
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193376
---
On Dec. 9, 2017, 9:32 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 9:32 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
>
> Diffs
> -
>
> .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde
> 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555
> api/src/main/thrift/org/apache/thermos/BUILD
> b58338e76bdee3481071d8f27235a9dbb6bf07b5
> build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/python/checkstyle-check
> 0c8800232e20347b2be9a538ffed1d47a7815241
> build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20
> build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78
> build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae
> build-support/release/make-python-sdists
> 51e11dbc1929609374031c9b23a96f035eba902b
> build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> 77c966caa3d1f644241bcc2b1968bc9306c56689
>
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
> 42300b43a8f72e45c96b975e5d3a6a7bd0283529
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch
> 11c7b13341e156f3686511cb40ab13c1256203a6
> build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
> build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
> build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793
> buildSrc/src
Re: Review Request 64290: Update to Thrift 0.10.0
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193376
---
Master (ef24c2c) is red with this patch.
./build-support/jenkins/build.sh
SUCCESS
07:19:08 00:00 [main]
(To run a reporting server: ./pants server)
07:19:08 00:00 [setup]
07:19:08 00:00 [parse]
Executing tasks in goals: gen -> pyprep -> setup-py
07:19:08 00:00 [gen]
07:19:09 00:01 [thrift-py]
07:19:09 00:01 [pyprep]
07:19:09 00:01 [interpreter]
07:19:09 00:01 [requirements]
07:19:09 00:01 [cache]
No cached artifacts for 1 target.
Invalidated 1 target. Failed to install
pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
'--dist-dir=/tmp/tmpoky0pr']` while trying to execute `[u'/usr/bin/python2.7',
'-', 'bdist_wheel', '--dist-dir=/tmp/tmpoky0pr']`",)
):
stdout:
running bdist_wheel
running build
running build_ext
building 'kerberos' extension
creating build
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
-fstack-protector-strong -Wformat -Werror=format-security -fPIC
-I/usr/include/python2.7 -c src/kerberos.c -o
build/temp.linux-x86_64-2.7/src/kerberos.o
stderr:
In file included from src/kerberos.c:19:0:
src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
directory
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
07:19:10 00:02 [complete]
FAILURE
Exception caught: ()
Exception message: Package
SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
SourceTranslator)
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 9, 2017, 4:32 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 4:32 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
>
> Diffs
> -
>
> .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde
> 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555
> api/src/main/thrift/org/apache/thermos/BUILD
> b58338e76bdee3481071d8f27235a9dbb6bf07b5
> build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/python/checkstyle-check
> 0c8800232e20347b2be9a538ffed1d47a7815241
> build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20
> build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78
> build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae
> build-support/release/make-python-sdists
> 51e11dbc1929609374031c9b23a96f035eba902b
> build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> 77c966caa3d1f644241bcc2b1968bc9306c56689
>
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
> 42300b43a8f72e45c96b975e5d3a6a7bd0283529
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch
> 11c7b13341e156f3686511cb40ab13c1256203a6
> build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
> build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
> build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy
> fc2bc9082dae2c63aa578c05dc89feb346260a67
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
> src/main/python/apache/aurora/client/cli/BUILD
> 80a6dec9acf5b64cff64143929916676b79be686
> src/main/python/apache/thermos/observer/BUILD
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193374 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193358
---
Master (ef24c2c) is red with this patch.
./build-support/jenkins/build.sh
SUCCESS
16:58:13 00:00 [main]
(To run a reporting server: ./pants server)
16:58:13 00:00 [setup]
16:58:14 00:01 [parse]
Executing tasks in goals: gen -> pyprep -> setup-py
16:58:14 00:01 [gen]
16:58:14 00:01 [thrift-py]
16:58:14 00:01 [pyprep]
16:58:14 00:01 [interpreter]
16:58:14 00:01 [requirements]
16:58:14 00:01 [cache]
No cached artifacts for 1 target.
Invalidated 1 target. Failed to install
pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
'--dist-dir=/tmp/tmpA1v87D']` while trying to execute `[u'/usr/bin/python2.7',
'-', 'bdist_wheel', '--dist-dir=/tmp/tmpA1v87D']`",)
):
stdout:
running bdist_wheel
running build
running build_ext
building 'kerberos' extension
creating build
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
-fstack-protector-strong -Wformat -Werror=format-security -fPIC
-I/usr/include/python2.7 -c src/kerberos.c -o
build/temp.linux-x86_64-2.7/src/kerberos.o
stderr:
In file included from src/kerberos.c:19:0:
src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
directory
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
16:58:17 00:04 [complete]
FAILURE
Exception caught: ()
Exception message: Package
SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
SourceTranslator)
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 9, 2017, 4:32 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 4:32 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
>
> Diffs
> -
>
> .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde
> 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555
> api/src/main/thrift/org/apache/thermos/BUILD
> b58338e76bdee3481071d8f27235a9dbb6bf07b5
> build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/python/checkstyle-check
> 0c8800232e20347b2be9a538ffed1d47a7815241
> build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20
> build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78
> build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae
> build-support/release/make-python-sdists
> 51e11dbc1929609374031c9b23a96f035eba902b
> build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> 77c966caa3d1f644241bcc2b1968bc9306c56689
>
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
> 42300b43a8f72e45c96b975e5d3a6a7bd0283529
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch
> 11c7b13341e156f3686511cb40ab13c1256203a6
> build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
> build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
> build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy
> fc2bc9082dae2c63aa578c05dc89feb346260a67
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
> src/main/python/apache/aurora/client/cli/BUILD
> 80a6dec9acf5b64cff64143929916676b79be686
> src/main/python/apache/thermos/observer/BUILD
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193356 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193355
---
Master (ef24c2c) is red with this patch.
./build-support/jenkins/build.sh
SUCCESS
16:19:05 00:00 [main]
(To run a reporting server: ./pants server)
16:19:05 00:00 [setup]
16:19:05 00:00 [parse]
Executing tasks in goals: gen -> pyprep -> setup-py
16:19:05 00:00 [gen]
16:19:05 00:00 [thrift-py]
16:19:05 00:00 [pyprep]
16:19:05 00:00 [interpreter]
16:19:05 00:00 [requirements]
16:19:05 00:00 [cache]
No cached artifacts for 1 target.
Invalidated 1 target. Failed to install
pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
'--dist-dir=/tmp/tmpU80FrW']` while trying to execute `[u'/usr/bin/python2.7',
'-', 'bdist_wheel', '--dist-dir=/tmp/tmpU80FrW']`",)
):
stdout:
running bdist_wheel
running build
running build_ext
building 'kerberos' extension
creating build
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
-fstack-protector-strong -Wformat -Werror=format-security -fPIC
-I/usr/include/python2.7 -c src/kerberos.c -o
build/temp.linux-x86_64-2.7/src/kerberos.o
stderr:
In file included from src/kerberos.c:19:0:
src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
directory
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
16:19:07 00:02 [complete]
FAILURE
Exception caught: ()
Exception message: Package
SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
SourceTranslator)
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 9, 2017, 4:32 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 4:32 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
>
> Diffs
> -
>
> .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde
> 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555
> api/src/main/thrift/org/apache/thermos/BUILD
> b58338e76bdee3481071d8f27235a9dbb6bf07b5
> build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/python/checkstyle-check
> 0c8800232e20347b2be9a538ffed1d47a7815241
> build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20
> build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78
> build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae
> build-support/release/make-python-sdists
> 51e11dbc1929609374031c9b23a96f035eba902b
> build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> 77c966caa3d1f644241bcc2b1968bc9306c56689
>
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
> 42300b43a8f72e45c96b975e5d3a6a7bd0283529
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch
> 11c7b13341e156f3686511cb40ab13c1256203a6
> build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
> build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
> build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy
> fc2bc9082dae2c63aa578c05dc89feb346260a67
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
> src/main/python/apache/aurora/client/cli/BUILD
> 80a6dec9acf5b64cff64143929916676b79be686
> src/main/python/apache/thermos/observer/BUILD
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193354 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193352
---
Master (ef24c2c) is red with this patch.
./build-support/jenkins/build.sh
SUCCESS
15:38:40 00:00 [main]
(To run a reporting server: ./pants server)
15:38:40 00:00 [setup]
15:38:40 00:00 [parse]
Executing tasks in goals: gen -> pyprep -> setup-py
15:38:40 00:00 [gen]
15:38:40 00:00 [thrift-py]
15:38:41 00:01 [pyprep]
15:38:41 00:01 [interpreter]
15:38:41 00:01 [requirements]
15:38:41 00:01 [cache]
No cached artifacts for 1 target.
Invalidated 1 target. Failed to install
pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
'--dist-dir=/tmp/tmppFOGGS']` while trying to execute `[u'/usr/bin/python2.7',
'-', 'bdist_wheel', '--dist-dir=/tmp/tmppFOGGS']`",)
):
stdout:
running bdist_wheel
running build
running build_ext
building 'kerberos' extension
creating build
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
-fstack-protector-strong -Wformat -Werror=format-security -fPIC
-I/usr/include/python2.7 -c src/kerberos.c -o
build/temp.linux-x86_64-2.7/src/kerberos.o
stderr:
In file included from src/kerberos.c:19:0:
src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
directory
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
15:38:42 00:02 [complete]
FAILURE
Exception caught: ()
Exception message: Package
SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
SourceTranslator)
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 9, 2017, 4:32 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 4:32 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
>
> Diffs
> -
>
> .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde
> 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555
> api/src/main/thrift/org/apache/thermos/BUILD
> b58338e76bdee3481071d8f27235a9dbb6bf07b5
> build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/python/checkstyle-check
> 0c8800232e20347b2be9a538ffed1d47a7815241
> build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20
> build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78
> build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae
> build-support/release/make-python-sdists
> 51e11dbc1929609374031c9b23a96f035eba902b
> build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> 77c966caa3d1f644241bcc2b1968bc9306c56689
>
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
> 42300b43a8f72e45c96b975e5d3a6a7bd0283529
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch
> 11c7b13341e156f3686511cb40ab13c1256203a6
> build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
> build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
> build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy
> fc2bc9082dae2c63aa578c05dc89feb346260a67
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
> src/main/python/apache/aurora/client/cli/BUILD
> 80a6dec9acf5b64cff64143929916676b79be686
> src/main/python/apache/thermos/observer/BUILD
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193351 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193348 --- @ReviewBot retry - Stephan Erb On Dec. 9, 2017, 5:32 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 5:32 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193344 --- - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193343 --- - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193342
---
Master (47c6899) is red with this patch.
./build-support/jenkins/build.sh
SUCCESS
02:38:40 00:00 [main]
(To run a reporting server: ./pants server)
02:38:40 00:00 [setup]
02:38:40 00:00 [parse]
Executing tasks in goals: gen -> pyprep -> setup-py
02:38:40 00:00 [gen]
02:38:40 00:00 [thrift-py]
02:38:41 00:01 [pyprep]
02:38:41 00:01 [interpreter]
02:38:41 00:01 [requirements]
02:38:41 00:01 [cache]
No cached artifacts for 1 target.
Invalidated 1 target. Failed to install
pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
'--dist-dir=/tmp/tmpr4j1bh']` while trying to execute `[u'/usr/bin/python2.7',
'-', 'bdist_wheel', '--dist-dir=/tmp/tmpr4j1bh']`",)
):
stdout:
running bdist_wheel
running build
running build_ext
building 'kerberos' extension
creating build
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
-fstack-protector-strong -Wformat -Werror=format-security -fPIC
-I/usr/include/python2.7 -c src/kerberos.c -o
build/temp.linux-x86_64-2.7/src/kerberos.o
stderr:
In file included from src/kerberos.c:19:0:
src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
directory
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
02:38:42 00:02 [complete]
FAILURE
Exception caught: ()
Exception message: Package
SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
SourceTranslator)
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 9, 2017, 4:32 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 4:32 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
>
> Diffs
> -
>
> .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde
> 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555
> api/src/main/thrift/org/apache/thermos/BUILD
> b58338e76bdee3481071d8f27235a9dbb6bf07b5
> build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/python/checkstyle-check
> 0c8800232e20347b2be9a538ffed1d47a7815241
> build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20
> build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78
> build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae
> build-support/release/make-python-sdists
> 51e11dbc1929609374031c9b23a96f035eba902b
> build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> 77c966caa3d1f644241bcc2b1968bc9306c56689
>
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
> 42300b43a8f72e45c96b975e5d3a6a7bd0283529
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch
> 11c7b13341e156f3686511cb40ab13c1256203a6
> build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
> build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
> build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy
> fc2bc9082dae2c63aa578c05dc89feb346260a67
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
> src/main/python/apache/aurora/client/cli/BUILD
> 80a6dec9acf5b64cff64143929916676b79be686
> src/main/python/apache/thermos/observer/BUILD
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193341 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193334 --- - Stephan Erb On Dec. 9, 2017, 5:32 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 5:32 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193332
---
Master (47c6899) is red with this patch.
./build-support/jenkins/build.sh
SUCCESS
16:58:37 00:00 [main]
(To run a reporting server: ./pants server)
16:58:37 00:00 [setup]
16:58:37 00:00 [parse]
Executing tasks in goals: gen -> pyprep -> setup-py
16:58:37 00:00 [gen]
16:58:37 00:00 [thrift-py]
16:58:37 00:00 [pyprep]
16:58:37 00:00 [interpreter]
16:58:37 00:00 [requirements]
16:58:37 00:00 [cache]
No cached artifacts for 1 target.
Invalidated 1 target. Failed to install
pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during
execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel',
'--dist-dir=/tmp/tmptj37lK']` while trying to execute `[u'/usr/bin/python2.7',
'-', 'bdist_wheel', '--dist-dir=/tmp/tmptj37lK']`",)
):
stdout:
running bdist_wheel
running build
running build_ext
building 'kerberos' extension
creating build
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes
-fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g
-fstack-protector-strong -Wformat -Werror=format-security -fPIC
-I/usr/include/python2.7 -c src/kerberos.c -o
build/temp.linux-x86_64-2.7/src/kerberos.o
stderr:
In file included from src/kerberos.c:19:0:
src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or
directory
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
16:58:39 00:02 [complete]
FAILURE
Exception caught: ()
Exception message: Package
SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz')
is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
SourceTranslator)
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 9, 2017, 4:32 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 4:32 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to get ./pants gen
> working.
> * The Java hashcode option has been removed as it is now the default.
>
>
> Diffs
> -
>
> .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde
> 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f
> api/src/main/thrift/org/apache/aurora/gen/BUILD
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555
> api/src/main/thrift/org/apache/thermos/BUILD
> b58338e76bdee3481071d8f27235a9dbb6bf07b5
> build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/python/checkstyle-check
> 0c8800232e20347b2be9a538ffed1d47a7815241
> build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20
> build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78
> build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae
> build-support/release/make-python-sdists
> 51e11dbc1929609374031c9b23a96f035eba902b
> build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
> 77c966caa3d1f644241bcc2b1968bc9306c56689
>
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
> 42300b43a8f72e45c96b975e5d3a6a7bd0283529
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch
> 11c7b13341e156f3686511cb40ab13c1256203a6
> build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
> build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
> build-support/thrift/prepare_binary.sh
> 4ad997bf039294f7940b93a76ebf014689f8f618
> build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
> build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy
> fc2bc9082dae2c63aa578c05dc89feb346260a67
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
> src/main/python/apache/aurora/client/cli/BUILD
> 80a6dec9acf5b64cff64143929916676b79be686
> src/main/python/apache/thermos/observer/BUILD
Re: Review Request 64290: Update to Thrift 0.10.0
> On Dec. 9, 2017, 6:08 a.m., Stephan Erb wrote: > > Looks good, thanks! > > > > This patch will not apply cleanly after the merge of > > https://reviews.apache.org/r/64382/. The merge conflict is trivial to > > resolve though. I have re-run the end-to-end tests with both patches > > applied and all looks good. Thanks Stephan, I've merged and re-posted the diff. We'll see how things go on this flaky test. I may need to detour to fix it up. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193328 --- On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/ --- (Updated Dec. 9, 2017, 9:32 a.m.) Review request for Aurora, Stephan Erb and Bill Farner. Changes --- Upgrade to Pants 1.4.0.dev23 with thrift fix. pants.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Repository: aurora Description --- Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) Included changes: * Update to the latest pants version. This was necesary to get ./pants gen working. * The Java hashcode option has been removed as it is now the default. Diffs (updated) - .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f api/src/main/thrift/org/apache/aurora/gen/BUILD 835b0cc6f51a592f7d5b6129dbe9519455eb6555 api/src/main/thrift/org/apache/thermos/BUILD b58338e76bdee3481071d8f27235a9dbb6bf07b5 build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac build-support/python/checkstyle-check 0c8800232e20347b2be9a538ffed1d47a7815241 build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae build-support/release/make-python-sdists 51e11dbc1929609374031c9b23a96f035eba902b build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 77c966caa3d1f644241bcc2b1968bc9306c56689 build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529 build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6 build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618 build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc src/main/python/apache/aurora/client/cli/BUILD 80a6dec9acf5b64cff64143929916676b79be686 src/main/python/apache/thermos/observer/BUILD 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 src/test/python/apache/aurora/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/admin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/api/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/binding_helpers/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/cli/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/docker/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/common/health_check/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/executor/common/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 Diff: https://reviews.apache.org/r/64290/diff/4/ Changes: https://reviews.apache.org/r/64290/diff/3-4/ Testing --- ``` $ ./build-support/jenkins/build.sh $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193330 --- - John Sirois On Dec. 8, 2017, 10:16 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 8, 2017, 10:16 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/3/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193328 --- Ship it! Looks good, thanks! This patch will not apply cleanly after the merge of https://reviews.apache.org/r/64382/. The merge conflict is trivial to resolve though. I have re-run the end-to-end tests with both patches applied and all looks good. - Stephan Erb On Dec. 9, 2017, 6:16 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 9, 2017, 6:16 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/3/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193326 --- - John Sirois On Dec. 8, 2017, 10:16 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > --- > > (Updated Dec. 8, 2017, 10:16 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen > working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > - > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a > api/src/main/thrift/org/apache/aurora/gen/BUILD > 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD > b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check > 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists > 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch > 77c966caa3d1f644241bcc2b1968bc9306c56689 > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch > 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch > 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh > 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD > 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD > 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py > 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py > 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/3/ > > > Testing > --- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 64290: Update to Thrift 0.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/ --- (Updated Dec. 8, 2017, 10:16 p.m.) Review request for Aurora, Stephan Erb and Bill Farner. Summary (updated) - Update to Thrift 0.10.0 Repository: aurora Description (updated) --- Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) Included changes: * Update to the latest pants version. This was necesary to get ./pants gen working. * The Java hashcode option has been removed as it is now the default. Diffs - .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a api/src/main/thrift/org/apache/aurora/gen/BUILD 835b0cc6f51a592f7d5b6129dbe9519455eb6555 api/src/main/thrift/org/apache/thermos/BUILD b58338e76bdee3481071d8f27235a9dbb6bf07b5 build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac build-support/python/checkstyle-check 0c8800232e20347b2be9a538ffed1d47a7815241 build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae build-support/release/make-python-sdists 51e11dbc1929609374031c9b23a96f035eba902b build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 77c966caa3d1f644241bcc2b1968bc9306c56689 build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529 build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6 build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618 build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc src/main/python/apache/aurora/client/cli/BUILD 80a6dec9acf5b64cff64143929916676b79be686 src/main/python/apache/thermos/observer/BUILD 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 src/test/python/apache/aurora/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/admin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/api/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/binding_helpers/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/cli/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/client/docker/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/common/health_check/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/aurora/executor/common/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 Diff: https://reviews.apache.org/r/64290/diff/3/ Testing (updated) --- ``` $ ./build-support/jenkins/build.sh $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois
