Re: Review Request 65433: Update Javascript Thrift to 0.10
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65433/#review197328 --- Running into some issues after this patch. I attempted to do a deploy from HEAD and the UI did not load. Inspecting the request shows that the `/api` endpoint is returning a 415 with the message: `Unsupported Content-Type: application/vnd.apache.thrift.json; charset=UTF-8`. Validated this behavior on the Vagrant cluster as well. Initially, the UI worked correctly but inspecting the `thrift.js` file being return showed that the version was still `0.91`. I had to do a `git clean -fdx` and destroy/bring up the vagrant cluster again in order to reproduce the error above. - Jordan Ly On Jan. 31, 2018, 10:11 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65433/ > --- > > (Updated Jan. 31, 2018, 10:11 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Repository: aurora > > > Description > --- > > We missed this change when bumping the Thrift version used by Python and > Java. https://reviews.apache.org/r/64290/ > > List of changes: > https://github.com/apache/thrift/commits/master/lib/js/src/thrift.js > > > Diffs > - > > 3rdparty/javascript/scheduler/assets/js/thrift.js > 111518739a7d353433ad59b7e48c84c2dbb546db > > > Diff: https://reviews.apache.org/r/65433/diff/1/ > > > Testing > --- > > Manually verified that the UI is still working > > > Thanks, > > Stephan Erb > >
Re: Review Request 65433: Update Javascript Thrift to 0.10
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65433/#review197018 --- Ship it! Applied the patch locally and brought up a task. Works fine. Good catch Stephan! - Renan DelValle On Jan. 31, 2018, 2:11 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65433/ > --- > > (Updated Jan. 31, 2018, 2:11 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Repository: aurora > > > Description > --- > > We missed this change when bumping the Thrift version used by Python and > Java. https://reviews.apache.org/r/64290/ > > List of changes: > https://github.com/apache/thrift/commits/master/lib/js/src/thrift.js > > > Diffs > - > > 3rdparty/javascript/scheduler/assets/js/thrift.js > 111518739a7d353433ad59b7e48c84c2dbb546db > > > Diff: https://reviews.apache.org/r/65433/diff/1/ > > > Testing > --- > > Manually verified that the UI is still working > > > Thanks, > > Stephan Erb > >
Re: Review Request 65433: Update Javascript Thrift to 0.10
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65433/#review196560 --- Ship it! Master (787ccfe) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 31, 2018, 10:11 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65433/ > --- > > (Updated Jan. 31, 2018, 10:11 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Repository: aurora > > > Description > --- > > We missed this change when bumping the Thrift version used by Python and > Java. https://reviews.apache.org/r/64290/ > > List of changes: > https://github.com/apache/thrift/commits/master/lib/js/src/thrift.js > > > Diffs > - > > 3rdparty/javascript/scheduler/assets/js/thrift.js > 111518739a7d353433ad59b7e48c84c2dbb546db > > > Diff: https://reviews.apache.org/r/65433/diff/1/ > > > Testing > --- > > Manually verified that the UI is still working > > > Thanks, > > Stephan Erb > >
Review Request 65433: Update Javascript Thrift to 0.10
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65433/ --- Review request for Aurora, David McLaughlin and Bill Farner. Repository: aurora Description --- We missed this change when bumping the Thrift version used by Python and Java. https://reviews.apache.org/r/64290/ List of changes: https://github.com/apache/thrift/commits/master/lib/js/src/thrift.js Diffs - 3rdparty/javascript/scheduler/assets/js/thrift.js 111518739a7d353433ad59b7e48c84c2dbb546db Diff: https://reviews.apache.org/r/65433/diff/1/ Testing --- Manually verified that the UI is still working Thanks, Stephan Erb