Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

2018-02-15 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197629
---


Ship it!




Ship It!

- Renan DelValle


On Feb. 12, 2018, 12:36 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65598/
> ---
> 
> (Updated Feb. 12, 2018, 12:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Renan DelValle.
> 
> 
> Bugs: AURORA-1972
> https://issues.apache.org/jira/browse/AURORA-1972
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable pytest-fast mode as a workaround for failing health checker tests
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 4c25a3fa315ab965df8908fe7c28be48ceb002bc 
> 
> 
> Diff: https://reviews.apache.org/r/65598/diff/1/
> 
> 
> Testing
> ---
> 
> repeated git clean -xfd && ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

2018-02-15 Thread Stephan Erb 


> On Feb. 14, 2018, 7:28 p.m., Renan DelValle wrote:
> > build-support/jenkins/build.sh
> > Lines 30 (patched)
> > 
> >
> > Do we still need --junit-xml-dir="$PWD/dist/test-results" to make the 
> > logs go to the right place?

Pleae see my comment above (probably auto-collapsed by now): For unknown 
reasons, disabling the fast mode breaks the junit-xml generation and I 
therefore removed it. As far as I know we don't read the files anywhere, not 
even on Jenkins.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197571
---


On Feb. 12, 2018, 9:36 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65598/
> ---
> 
> (Updated Feb. 12, 2018, 9:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Renan DelValle.
> 
> 
> Bugs: AURORA-1972
> https://issues.apache.org/jira/browse/AURORA-1972
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable pytest-fast mode as a workaround for failing health checker tests
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 4c25a3fa315ab965df8908fe7c28be48ceb002bc 
> 
> 
> Diff: https://reviews.apache.org/r/65598/diff/1/
> 
> 
> Testing
> ---
> 
> repeated git clean -xfd && ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

2018-02-14 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197571
---




build-support/jenkins/build.sh
Lines 30 (patched)


Do we still need --junit-xml-dir="$PWD/dist/test-results" to make the logs 
go to the right place?


- Renan DelValle


On Feb. 12, 2018, 12:36 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65598/
> ---
> 
> (Updated Feb. 12, 2018, 12:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Renan DelValle.
> 
> 
> Bugs: AURORA-1972
> https://issues.apache.org/jira/browse/AURORA-1972
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable pytest-fast mode as a workaround for failing health checker tests
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 4c25a3fa315ab965df8908fe7c28be48ceb002bc 
> 
> 
> Diff: https://reviews.apache.org/r/65598/diff/1/
> 
> 
> Testing
> ---
> 
> repeated git clean -xfd && ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

2018-02-14 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197488
---


Ship it!




Ship It!

- Jordan Ly


On Feb. 12, 2018, 8:36 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65598/
> ---
> 
> (Updated Feb. 12, 2018, 8:36 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Renan DelValle.
> 
> 
> Bugs: AURORA-1972
> https://issues.apache.org/jira/browse/AURORA-1972
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable pytest-fast mode as a workaround for failing health checker tests
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 4c25a3fa315ab965df8908fe7c28be48ceb002bc 
> 
> 
> Diff: https://reviews.apache.org/r/65598/diff/1/
> 
> 
> Testing
> ---
> 
> repeated git clean -xfd && ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

2018-02-11 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197239
---


Ship it!




Master (cb0faf8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 12, 2018, 12:44 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65598/
> ---
> 
> (Updated Feb. 12, 2018, 12:44 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1972
> https://issues.apache.org/jira/browse/AURORA-1972
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable pytest-fast mode as a workaround for failing health checker tests
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 4c25a3fa315ab965df8908fe7c28be48ceb002bc 
> 
> 
> Diff: https://reviews.apache.org/r/65598/diff/1/
> 
> 
> Testing
> ---
> 
> repeated git clean -xfd && ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

2018-02-11 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197238
---




build-support/jenkins/build.sh
Line 28 (original), 28-30 (patched)


Note to reviewers: This is not a real fix but mostly meant to stop the 
bleeding right now.

For unknown reasons, disabling the fast mode breaks the junit-xml 
generation and I therefore removed it. As far as I know we don't read the files 
anywhere, not even on Jenkins.


- Stephan Erb


On Feb. 11, 2018, 11:44 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65598/
> ---
> 
> (Updated Feb. 11, 2018, 11:44 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1972
> https://issues.apache.org/jira/browse/AURORA-1972
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable pytest-fast mode as a workaround for failing health checker tests
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 4c25a3fa315ab965df8908fe7c28be48ceb002bc 
> 
> 
> Diff: https://reviews.apache.org/r/65598/diff/1/
> 
> 
> Testing
> ---
> 
> repeated git clean -xfd && ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 65598: Disable pytest-fast mode as a workaround for failing health checker tests

2018-02-11 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/
---

Review request for Aurora.


Bugs: AURORA-1972
https://issues.apache.org/jira/browse/AURORA-1972


Repository: aurora


Description
---

Disable pytest-fast mode as a workaround for failing health checker tests


Diffs
-

  build-support/jenkins/build.sh 4c25a3fa315ab965df8908fe7c28be48ceb002bc 


Diff: https://reviews.apache.org/r/65598/diff/1/


Testing
---

repeated git clean -xfd && ./build-support/jenkins/build.sh


Thanks,

Stephan Erb