Re: Review Request 66074: Refactor ClusterState to more appropriate package, move binding to StateModule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66074/#review199334 --- Ship it! Ship It! - Stephan Erb On March 14, 2018, 11:07 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66074/ > --- > > (Updated March 14, 2018, 11:07 p.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Santhosh > Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > Browsing through the code and I noticed that if preemption is turned off, the > `/state` endpoint will not work since `ClusterState` is not bound. > > I moved `ClusterState` and `ClusterStateImpl` to a more suitable package, and > bind `ClusterState` in `StateModule` no matter what. > > > Diffs > - > > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 54b6ed9d474065bab1da7512a42fc38264b892bc > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > 37374dcf3471d5eadf543d93e5a6a3e07a389dc1 > src/main/java/org/apache/aurora/scheduler/http/State.java > 6d1b400c286a63dffba85fd5c14cb76f6f3a45a4 > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterState.java > ce3bc7e6da3f86625c690e26c28ccef67ed9021a > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterStateImpl.java > 5574e9ba916513e8f5dc3ef78ddeb084330c > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java > 056e4668490accab9b70e0634393580e40514f86 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > 4de5ef8be76ead1970b27d91eee90198858e53c8 > src/main/java/org/apache/aurora/scheduler/state/StateModule.java > 76c327758f88ad23942ea3b388830cb4a31728dd > src/test/java/org/apache/aurora/scheduler/http/StateTest.java > 0685d6ee6148d0a22c07e18a808f2816299b10d3 > > src/test/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java > 881bb20feaa83797831828a3cdd7a2f507621387 > > src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java > 35e9348e6ab0c14e6ae20af4076358d7e12681c7 > > > Diff: https://reviews.apache.org/r/66074/diff/1/ > > > Testing > --- > > Manually tested state endpoint returns jobs when preemptor is both on and off. > > > Thanks, > > Jordan Ly > >
Re: Review Request 66074: Refactor ClusterState to more appropriate package, move binding to StateModule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66074/#review199221 --- Ship it! Master (a12b844) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 14, 2018, 3:07 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66074/ > --- > > (Updated March 14, 2018, 3:07 p.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Santhosh > Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > Browsing through the code and I noticed that if preemption is turned off, the > `/state` endpoint will not work since `ClusterState` is not bound. > > I moved `ClusterState` and `ClusterStateImpl` to a more suitable package, and > bind `ClusterState` in `StateModule` no matter what. > > > Diffs > - > > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 54b6ed9d474065bab1da7512a42fc38264b892bc > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > 37374dcf3471d5eadf543d93e5a6a3e07a389dc1 > src/main/java/org/apache/aurora/scheduler/http/State.java > 6d1b400c286a63dffba85fd5c14cb76f6f3a45a4 > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterState.java > ce3bc7e6da3f86625c690e26c28ccef67ed9021a > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterStateImpl.java > 5574e9ba916513e8f5dc3ef78ddeb084330c > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java > 056e4668490accab9b70e0634393580e40514f86 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > 4de5ef8be76ead1970b27d91eee90198858e53c8 > src/main/java/org/apache/aurora/scheduler/state/StateModule.java > 76c327758f88ad23942ea3b388830cb4a31728dd > src/test/java/org/apache/aurora/scheduler/http/StateTest.java > 0685d6ee6148d0a22c07e18a808f2816299b10d3 > > src/test/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java > 881bb20feaa83797831828a3cdd7a2f507621387 > > src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java > 35e9348e6ab0c14e6ae20af4076358d7e12681c7 > > > Diff: https://reviews.apache.org/r/66074/diff/1/ > > > Testing > --- > > Manually tested state endpoint returns jobs when preemptor is both on and off. > > > Thanks, > > Jordan Ly > >
Review Request 66074: Refactor ClusterState to more appropriate package, move binding to StateModule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66074/ --- Review request for Aurora, David McLaughlin, Renan DelValle, and Santhosh Kumar Shanmugham. Repository: aurora Description --- Browsing through the code and I noticed that if preemption is turned off, the `/state` endpoint will not work since `ClusterState` is not bound. I moved `ClusterState` and `ClusterStateImpl` to a more suitable package, and bind `ClusterState` in `StateModule` no matter what. Diffs - src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 54b6ed9d474065bab1da7512a42fc38264b892bc src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 37374dcf3471d5eadf543d93e5a6a3e07a389dc1 src/main/java/org/apache/aurora/scheduler/http/State.java 6d1b400c286a63dffba85fd5c14cb76f6f3a45a4 src/main/java/org/apache/aurora/scheduler/preemptor/ClusterState.java ce3bc7e6da3f86625c690e26c28ccef67ed9021a src/main/java/org/apache/aurora/scheduler/preemptor/ClusterStateImpl.java 5574e9ba916513e8f5dc3ef78ddeb084330c src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java 056e4668490accab9b70e0634393580e40514f86 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 4de5ef8be76ead1970b27d91eee90198858e53c8 src/main/java/org/apache/aurora/scheduler/state/StateModule.java 76c327758f88ad23942ea3b388830cb4a31728dd src/test/java/org/apache/aurora/scheduler/http/StateTest.java 0685d6ee6148d0a22c07e18a808f2816299b10d3 src/test/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java 881bb20feaa83797831828a3cdd7a2f507621387 src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java 35e9348e6ab0c14e6ae20af4076358d7e12681c7 Diff: https://reviews.apache.org/r/66074/diff/1/ Testing --- Manually tested state endpoint returns jobs when preemptor is both on and off. Thanks, Jordan Ly
