Re: Review Request 66199: Remove unused LOST_LOCK_MESSAGE variable in JobUpdateControllerImpl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66199/#review199771 --- Ship it! Ship It! - Stephan Erb On March 21, 2018, 10:38 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66199/ > --- > > (Updated March 21, 2018, 10:38 p.m.) > > > Review request for Aurora, Renan DelValle and Stephan Erb. > > > Repository: aurora > > > Description > --- > > We no longer use locks for updates (context: > https://reviews.apache.org/r/63130/). This was a legacy variable. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > f8be8058f3a80a18b999d2666e2adb33e1e55fef > > > Diff: https://reviews.apache.org/r/66199/diff/1/ > > > Testing > --- > > `./gradlew test` > > > Thanks, > > Jordan Ly > >
Re: Review Request 66199: Remove unused LOST_LOCK_MESSAGE variable in JobUpdateControllerImpl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66199/#review199721 --- Master (f32086d) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 21, 2018, 2:38 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66199/ > --- > > (Updated March 21, 2018, 2:38 p.m.) > > > Review request for Aurora, Renan DelValle and Stephan Erb. > > > Repository: aurora > > > Description > --- > > We no longer use locks for updates (context: > https://reviews.apache.org/r/63130/). This was a legacy variable. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > f8be8058f3a80a18b999d2666e2adb33e1e55fef > > > Diff: https://reviews.apache.org/r/66199/diff/1/ > > > Testing > --- > > `./gradlew test` > > > Thanks, > > Jordan Ly > >
Re: Review Request 66199: Remove unused LOST_LOCK_MESSAGE variable in JobUpdateControllerImpl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66199/#review199712 --- Ship it! Ship It! - Renan DelValle On March 21, 2018, 2:38 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66199/ > --- > > (Updated March 21, 2018, 2:38 p.m.) > > > Review request for Aurora, Renan DelValle and Stephan Erb. > > > Repository: aurora > > > Description > --- > > We no longer use locks for updates (context: > https://reviews.apache.org/r/63130/). This was a legacy variable. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > f8be8058f3a80a18b999d2666e2adb33e1e55fef > > > Diff: https://reviews.apache.org/r/66199/diff/1/ > > > Testing > --- > > `./gradlew test` > > > Thanks, > > Jordan Ly > >
Re: Review Request 66199: Remove unused LOST_LOCK_MESSAGE variable in JobUpdateControllerImpl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66199/#review199710 --- Ship it! Ship It! - David McLaughlin On March 21, 2018, 9:38 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66199/ > --- > > (Updated March 21, 2018, 9:38 p.m.) > > > Review request for Aurora, Renan DelValle and Stephan Erb. > > > Repository: aurora > > > Description > --- > > We no longer use locks for updates (context: > https://reviews.apache.org/r/63130/). This was a legacy variable. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > f8be8058f3a80a18b999d2666e2adb33e1e55fef > > > Diff: https://reviews.apache.org/r/66199/diff/1/ > > > Testing > --- > > `./gradlew test` > > > Thanks, > > Jordan Ly > >
Review Request 66199: Remove unused LOST_LOCK_MESSAGE variable in JobUpdateControllerImpl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66199/ --- Review request for Aurora, Renan DelValle and Stephan Erb. Repository: aurora Description --- We no longer use locks for updates (context: https://reviews.apache.org/r/63130/). This was a legacy variable. Diffs - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java f8be8058f3a80a18b999d2666e2adb33e1e55fef Diff: https://reviews.apache.org/r/66199/diff/1/ Testing --- `./gradlew test` Thanks, Jordan Ly
