Re: Review Request 67638: Export number of tasks lost per dedicated role.

2018-06-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67638/#review204966
---


Ship it!




Master (4719fa7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 18, 2018, 11:20 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67638/
> ---
> 
> (Updated June 18, 2018, 11:20 p.m.)
> 
> 
> Review request for Aurora, Franck Cuny and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Export number of tasks lost per dedicated role.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> ee20ed3ad7c17bd4ca11239a467113fc8a9e8f00 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 6321ec068bd16737f96b39d5fdd8db25f3dea15c 
> 
> 
> Diff: https://reviews.apache.org/r/67638/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew test
> 
> **Tested on Vagrant**
> tasks_lost_dedicatedweb.multi 0
> tasks_lost_dedicated_vagrant 2
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>



Re: Review Request 67638: Export number of tasks lost per dedicated role.

2018-06-18 Thread Jordan Ly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67638/#review204965
---


Ship it!




Ship It!

- Jordan Ly


On June 18, 2018, 11:20 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67638/
> ---
> 
> (Updated June 18, 2018, 11:20 p.m.)
> 
> 
> Review request for Aurora, Franck Cuny and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Export number of tasks lost per dedicated role.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> ee20ed3ad7c17bd4ca11239a467113fc8a9e8f00 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 6321ec068bd16737f96b39d5fdd8db25f3dea15c 
> 
> 
> Diff: https://reviews.apache.org/r/67638/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew test
> 
> **Tested on Vagrant**
> tasks_lost_dedicatedweb.multi 0
> tasks_lost_dedicated_vagrant 2
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>



Re: Review Request 67638: Export number of tasks lost per dedicated role.

2018-06-18 Thread Franck Cuny via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67638/#review204964
---


Ship it!




Ship It!

- Franck Cuny


On June 18, 2018, 11:20 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67638/
> ---
> 
> (Updated June 18, 2018, 11:20 p.m.)
> 
> 
> Review request for Aurora, Franck Cuny and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Export number of tasks lost per dedicated role.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> ee20ed3ad7c17bd4ca11239a467113fc8a9e8f00 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 6321ec068bd16737f96b39d5fdd8db25f3dea15c 
> 
> 
> Diff: https://reviews.apache.org/r/67638/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew test
> 
> **Tested on Vagrant**
> tasks_lost_dedicatedweb.multi 0
> tasks_lost_dedicated_vagrant 2
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>



Review Request 67638: Export number of tasks lost per dedicated role.

2018-06-18 Thread Santhosh Kumar Shanmugham

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67638/
---

Review request for Aurora, Franck Cuny and Jordan Ly.


Repository: aurora


Description
---

Export number of tasks lost per dedicated role.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
ee20ed3ad7c17bd4ca11239a467113fc8a9e8f00 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
6321ec068bd16737f96b39d5fdd8db25f3dea15c 


Diff: https://reviews.apache.org/r/67638/diff/1/


Testing
---

./gradlew test

**Tested on Vagrant**
tasks_lost_dedicatedweb.multi 0
tasks_lost_dedicated_vagrant 2


Thanks,

Santhosh Kumar Shanmugham