Re: Review Request 68071: Prune updates that have no surviving job keys in the TaskStore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68071/#review206528 --- Ship it! Master (3738c3e) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 26, 2018, 11:29 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68071/ > --- > > (Updated July 26, 2018, 11:29 p.m.) > > > Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > We are running into a situation where we have a lot of short-lived ad-hoc > services launched and their updates are sticking around for 30 days, even > though the tasks are garbage collected much sooner. This change picks up > those updates and prunes them as soon as the tasks are gone. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java > 05ada3ccba8facc63d86736199b741bfcaca9697 > > src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java > a1bf04ab8206fc0ca301d4b1b1cbe854df209bbe > > > Diff: https://reviews.apache.org/r/68071/diff/2/ > > > Testing > --- > > ./gradlew test > > > Thanks, > > David McLaughlin > >
Re: Review Request 68071: Prune updates that have no surviving job keys in the TaskStore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68071/ --- (Updated July 26, 2018, 11:29 p.m.) Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. Changes --- Style fix. Repository: aurora Description --- We are running into a situation where we have a lot of short-lived ad-hoc services launched and their updates are sticking around for 30 days, even though the tasks are garbage collected much sooner. This change picks up those updates and prunes them as soon as the tasks are gone. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java 05ada3ccba8facc63d86736199b741bfcaca9697 src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java a1bf04ab8206fc0ca301d4b1b1cbe854df209bbe Diff: https://reviews.apache.org/r/68071/diff/2/ Changes: https://reviews.apache.org/r/68071/diff/1-2/ Testing --- ./gradlew test Thanks, David McLaughlin
Re: Review Request 68071: Prune updates that have no surviving job keys in the TaskStore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68071/#review206523 --- Master (4e28e73) is red with this patch. ./build-support/jenkins/build.sh :distZip :assemble :compileTestJavaNote: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. :processTestResources :testClasses :compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processJmhResources NO-SOURCE :jmhClasses :checkstyleJmh :checkstyleMain :checkstyleTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdJmh :pmdMain :pmdTest /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java:81: Avoid unused local variables such as 'update8'. :pmdTest FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':pmdTest'. > 1 PMD rule violations were found. See the report at: > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/test.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. * Get more help at https://help.gradle.org BUILD FAILED in 7m 53s 39 actionable tasks: 30 executed, 9 up-to-date I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 26, 2018, 10:04 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68071/ > --- > > (Updated July 26, 2018, 10:04 p.m.) > > > Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > We are running into a situation where we have a lot of short-lived ad-hoc > services launched and their updates are sticking around for 30 days, even > though the tasks are garbage collected much sooner. This change picks up > those updates and prunes them as soon as the tasks are gone. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java > 05ada3ccba8facc63d86736199b741bfcaca9697 > > src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java > a1bf04ab8206fc0ca301d4b1b1cbe854df209bbe > > > Diff: https://reviews.apache.org/r/68071/diff/1/ > > > Testing > --- > > ./gradlew test > > > Thanks, > > David McLaughlin > >
Re: Review Request 68071: Prune updates that have no surviving job keys in the TaskStore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68071/#review206521 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On July 26, 2018, 3:04 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68071/ > --- > > (Updated July 26, 2018, 3:04 p.m.) > > > Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > We are running into a situation where we have a lot of short-lived ad-hoc > services launched and their updates are sticking around for 30 days, even > though the tasks are garbage collected much sooner. This change picks up > those updates and prunes them as soon as the tasks are gone. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java > 05ada3ccba8facc63d86736199b741bfcaca9697 > > src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java > a1bf04ab8206fc0ca301d4b1b1cbe854df209bbe > > > Diff: https://reviews.apache.org/r/68071/diff/1/ > > > Testing > --- > > ./gradlew test > > > Thanks, > > David McLaughlin > >
Re: Review Request 68071: Prune updates that have no surviving job keys in the TaskStore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68071/ --- (Updated July 26, 2018, 10:04 p.m.) Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. Repository: aurora Description (updated) --- We are running into a situation where we have a lot of short-lived ad-hoc services launched and their updates are sticking around for 30 days, even though the tasks are garbage collected much sooner. This change picks up those updates and prunes them as soon as the tasks are gone. Diffs - src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java 05ada3ccba8facc63d86736199b741bfcaca9697 src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java a1bf04ab8206fc0ca301d4b1b1cbe854df209bbe Diff: https://reviews.apache.org/r/68071/diff/1/ Testing --- ./gradlew test Thanks, David McLaughlin
Re: Review Request 68071: Prune updates that have no surviving job keys in the TaskStore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68071/#review206520 --- Ship it! Ship It! - Jordan Ly On July 26, 2018, 10:02 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68071/ > --- > > (Updated July 26, 2018, 10:02 p.m.) > > > Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > Prune updates that have no surviving job keys in the TaskStore > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java > 05ada3ccba8facc63d86736199b741bfcaca9697 > > src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java > a1bf04ab8206fc0ca301d4b1b1cbe854df209bbe > > > Diff: https://reviews.apache.org/r/68071/diff/1/ > > > Testing > --- > > ./gradlew test > > > Thanks, > > David McLaughlin > >
Review Request 68071: Prune updates that have no surviving job keys in the TaskStore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68071/ --- Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. Repository: aurora Description --- Prune updates that have no surviving job keys in the TaskStore Diffs - src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java 05ada3ccba8facc63d86736199b741bfcaca9697 src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java a1bf04ab8206fc0ca301d4b1b1cbe854df209bbe Diff: https://reviews.apache.org/r/68071/diff/1/ Testing --- ./gradlew test Thanks, David McLaughlin