Re: Review Request 17645: added rollback_on_failure to UpdateConfig
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/ --- (Updated Feb. 3, 2014, 3:18 a.m.) Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-148 https://issues.apache.org/jira/browse/AURORA-148 Repository: aurora Description --- added rollback_on_failure to UpdateConfig Diffs - src/main/python/apache/aurora/client/api/updater.py 61e5737cc3cb4d457348cbc1df1f0fc93143de51 src/main/python/apache/aurora/client/api/updater_util.py 623b0c0ae53d32f0af20c98aa4c9c1ff73720ecb src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/config/schema/base.py 1d9f3019d2379e25ab311b45f2851de3b60e263a src/test/python/apache/aurora/client/api/test_restarter.py c53824236895d60a61935a0706ad397900aa1148 src/test/python/apache/aurora/client/api/test_updater.py eabb938ead5b3bab067339ae085dbe2fd262d6a7 Diff: https://reviews.apache.org/r/17645/diff/ Testing --- [drobinson@x1 incubator-aurora (drobinson/rollback_on_failure)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. 2 passed in 0.23 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. 6 passed in 0.29 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. 6 passed in 0.12 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . 1 passed in 0.09 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. 6 passed in 0.11 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... == 47 passed, 1 skipped in 0.44 seconds === === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py 20 passed in 0.13 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_updater.py ... 27 passed in 0.32 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_quota_check.py .. 6 passed in 0.05 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/p
Re: Review Request 17645: added rollback_on_failure to UpdateConfig
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33410 --- Ship it! i suggest another ack from at least maxim or mark on this one tho. - Brian Wickman On Feb. 2, 2014, 10:07 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17645/ > --- > > (Updated Feb. 2, 2014, 10:07 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Bugs: AURORA-148 > https://issues.apache.org/jira/browse/AURORA-148 > > > Repository: aurora > > > Description > --- > > added rollback_on_failure to UpdateConfig > > > Diffs > - > > src/main/python/apache/aurora/client/api/updater.py > 61e5737cc3cb4d457348cbc1df1f0fc93143de51 > src/main/python/apache/aurora/client/api/updater_util.py > 623b0c0ae53d32f0af20c98aa4c9c1ff73720ecb > src/main/python/apache/aurora/client/cli/jobs.py > caff6d824d9f43cc9eb0c738ea6bb489321d4669 > src/main/python/apache/aurora/client/commands/core.py > 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 > src/main/python/apache/aurora/config/schema/base.py > 1d9f3019d2379e25ab311b45f2851de3b60e263a > src/test/python/apache/aurora/client/api/test_restarter.py > c53824236895d60a61935a0706ad397900aa1148 > src/test/python/apache/aurora/client/api/test_updater.py > eabb938ead5b3bab067339ae085dbe2fd262d6a7 > > Diff: https://reviews.apache.org/r/17645/diff/ > > > Testing > --- > > [drobinson@x1 incubator-aurora (drobinson/rollback_on_failure)]$ ./pants > src/test/python/apache/aurora/client:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) > === test session starts > === > platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/test_binding_helper.py .. > > 2 passed in 0.23 seconds > = > === test session starts > === > platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/test_config.py .. > > 6 passed in 0.29 seconds > = > === test session starts > === > platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_disambiguator.py .. > > 6 passed in 0.12 seconds > = > === test session starts > === > platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/api/test_job_monitor.py . > > 1 passed in 0.09 seconds > = > === test session starts > === > platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 6 items > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > 6 passed in 0.11 seconds > = > === test session starts > === > platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 47 items / 1 skipped > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > ... > > == 47 passed, 1 skipped in 0.44 seconds > === > === test session starts > === > platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 20 items > > src/test/python/apache/aurora/client/api/test_instance_watcher.py > src/test/python/apache/aurora/client/api/test_health_check.py > > 20 passed in 0.13 seconds > > === test session starts > === > platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 27 items > > src/test/python/apache/aurora/client/api/test_updater.py > ... > > 27 passed in 0.
Review Request 17645: added rollback_on_failure to UpdateConfig
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-148 https://issues.apache.org/jira/browse/AURORA-148 Repository: aurora Description --- added rollback_on_failure to UpdateConfig Diffs - src/main/python/apache/aurora/client/api/updater.py 61e5737cc3cb4d457348cbc1df1f0fc93143de51 src/main/python/apache/aurora/client/api/updater_util.py 623b0c0ae53d32f0af20c98aa4c9c1ff73720ecb src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/config/schema/base.py 1d9f3019d2379e25ab311b45f2851de3b60e263a src/test/python/apache/aurora/client/api/test_restarter.py c53824236895d60a61935a0706ad397900aa1148 src/test/python/apache/aurora/client/api/test_updater.py eabb938ead5b3bab067339ae085dbe2fd262d6a7 Diff: https://reviews.apache.org/r/17645/diff/ Testing --- [drobinson@x1 incubator-aurora (drobinson/rollback_on_failure)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. 2 passed in 0.23 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. 6 passed in 0.29 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. 6 passed in 0.12 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . 1 passed in 0.09 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. 6 passed in 0.11 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... == 47 passed, 1 skipped in 0.44 seconds === === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py 20 passed in 0.13 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_updater.py ... 27 passed in 0.32 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_quota_check.py .. 6 passed in 0.05 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apa
Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/ --- (Updated Feb. 2, 2014, 2:07 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: aurora-88 https://issues.apache.org/jira/browse/aurora-88 Repository: aurora Description --- AURORA-88: get_quota -h lists --cluster as deprecated Replaces CLUSTER_INVOKE_OPTION with a new CLUSTER_NAME_OPTION so that get_quota -h shows the correct help dialog. Diffs - src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/client/options.py 4e53b0765375989bb80ffd02e0ef2b08af1eea50 Diff: https://reviews.apache.org/r/17637/diff/ Testing --- Tests pass locally and running aurora_client.pex get_quota -h shows the updated text for the --cluster option. Thanks, Dan Norris
