date:20140425

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Bill Farner



> On April 25, 2014, 11:34 p.m., Bill Farner wrote:
> > Overall LGTM, but i suggest we think hard before introducing the count.
> 
> Maxim Khutornenko wrote:
> Not sure I understand. What's your concern about returning the count here?

It's really only usable for display (not programmatic use), and it isn't always 
accurate.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41542
---


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Maxim Khutornenko



> On April 25, 2014, 11:34 p.m., Bill Farner wrote:
> > Overall LGTM, but i suggest we think hard before introducing the count.

Not sure I understand. What's your concern about returning the count here? 


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41542
---


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41542
---

Ship it!


Overall LGTM, but i suggest we think hard before introducing the count.


src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java


The synthetic '1' is pretty ugly, perhaps enough to warrant punting on 
returning a count until we separate cron descheduling?


- Bill Farner


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20707: Fix a plugins glitch.

2014-04-25 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20707/#review41541
---

Ship it!


Ship It!

- Suman Karumuri


On April 25, 2014, 6:33 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20707/
> ---
> 
> (Updated April 25, 2014, 6:33 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-362
> https://issues.apache.org/jira/browse/aurora-362
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix a plugins glitch.
> 
> The before_dispatch method in configuration plugins is allowed to alter
> command line arguments, to add or remove arguments needed to support
> specific environments. The default implementation of plugins doesn't
> provide any return value for the plugin methods. For before_dispatch,
> this meant that the default plugin method effectively removed all command
> line parameters!
> 
> This change just turns the default before_dispatch plugin method into an
> effective no-op. If the user doesn't provide a before_dispatch method,
> the default implementation will leave the arguments correctly unchanged.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> 64bde45b203d9b5db0c032bd964a38bd563283de 
> 
> Diff: https://reviews.apache.org/r/20707/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (fix_plugins)]$ ./pants 
> src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> === 2 passed in 0.46 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> === 6 passed in 0.54 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
> 
> === 6 passed in 0.48 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> === 1 passed in 0.45 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ..
> 
> === 6 passed in 0.41 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
> 
> = 47 passed, 1 skipped in 4.48 seconds 
> =
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
> 
> == 20 passed in 0.32 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
> 
> == 27 passed in 0.73 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_quota_check.py ...

Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

2014-04-25 Thread Jake Farrell



> On April 25, 2014, 9:08 p.m., Kevin Sweeney wrote:
> > Is there a changelog? What's coming in here?

Is there a ticket open for this?


- Jake


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20735/#review41527
---


On April 25, 2014, 9:06 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20735/
> ---
> 
> (Updated April 25, 2014, 9:06 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade aurora repo to twitter.common.python 0.5.4
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD de7d93fc7d5e94db0f4bafbef3269e5df30fce6c 
> 
> Diff: https://reviews.apache.org/r/20735/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all -v
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

2014-04-25 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20735/#review41533
---

Ship it!


Ship It!

- Kevin Sweeney


On April 25, 2014, 2:06 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20735/
> ---
> 
> (Updated April 25, 2014, 2:06 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade aurora repo to twitter.common.python 0.5.4
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD de7d93fc7d5e94db0f4bafbef3269e5df30fce6c 
> 
> Diff: https://reviews.apache.org/r/20735/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all -v
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

2014-04-25 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20735/#review41531
---

This is a no-op for the APIs we use in aurora.  It is consumed by client v1 and 
v2 for 'getVersion' and by executor_vars to extract executor versions from 
PEX-INFO.  The change from 0.2.0 to 0.3.1 was the only API backwards 
incompatibility for what we used, and that usage was fixed in 
ddd2329eaefa780a680ed34e1aecb9c5240f03dd.  0.3.1 and 0.5.4 brings structural 
changes to twitter.common.python (different APIs, wheel support) but those are 
going unused in the aurora repo.  (They are however being consumed by pants but 
pants can rely upon a different version than the repo.)

- Brian Wickman

On April 25, 2014, 9:06 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20735/
> ---
> 
> (Updated April 25, 2014, 9:06 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade aurora repo to twitter.common.python 0.5.4
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD de7d93fc7d5e94db0f4bafbef3269e5df30fce6c 
> 
> Diff: https://reviews.apache.org/r/20735/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all -v
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

2014-04-25 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20735/#review41527
---


Is there a changelog? What's coming in here?

- Kevin Sweeney


On April 25, 2014, 2:06 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20735/
> ---
> 
> (Updated April 25, 2014, 2:06 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade aurora repo to twitter.common.python 0.5.4
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD de7d93fc7d5e94db0f4bafbef3269e5df30fce6c 
> 
> Diff: https://reviews.apache.org/r/20735/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all -v
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

2014-04-25 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20735/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

Upgrade aurora repo to twitter.common.python 0.5.4


Diffs
-

  3rdparty/python/BUILD de7d93fc7d5e94db0f4bafbef3269e5df30fce6c 

Diff: https://reviews.apache.org/r/20735/diff/


Testing
---

./pants src/test/python:all -v


Thanks,

Brian Wickman

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Maxim Khutornenko



> On April 25, 2014, 8:54 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java, line 81
> > 
> >
> > How would you feel about nuking this method and moving the 
> > implementation to SchedulerThriftInterface?  It's the only consumer, making 
> > this a proxy method to StateManager.

Well, this is true about all methods in SchedulerCore. I'd rather minimize the 
diff here and address the refactoring in AURORA-94.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41522
---


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41522
---



src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java


How would you feel about nuking this method and moving the implementation 
to SchedulerThriftInterface?  It's the only consumer, making this a proxy 
method to StateManager.


- Bill Farner


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-345
https://issues.apache.org/jira/browse/AURORA-345


Repository: aurora


Description
---

Converted INVALID_REQUEST to OK and modified returned message.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
e62f6c62452a1e1ac93baec7419580de2f40f0de 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
536927949c915363cccf074449d089314ecf6996 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7c557931b2ce05c7d14499954fe3b89bb5853faa 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
d7dbfaa76b277b028e56ed633ea2a032935e26db 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 c23c94807b97bcf77c2c155ee2039deebfaa090c 

Diff: https://reviews.apache.org/r/20732/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko

Re: Review Request 20726: Removing client HTTP health checks.

2014-04-25 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20726/#review41515
---

Ship it!


Ship It!

- Mark Chu-Carroll


On April 25, 2014, 3:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20726/
> ---
> 
> (Updated April 25, 2014, 3:41 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-361
> https://issues.apache.org/jira/browse/AURORA-361
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping client http health checks in favor of status checks only.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/health_check.py 
> e3bbf71a37c3137d580378ac185eaf65f4b056af 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> 530868348142c73708fa7f0d7296a3fb5b6ebb5d 
>   src/test/python/apache/aurora/client/api/test_health_check.py 
> f59fe42cc4808aeece34f55978ca34e62404ac58 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 43412c44edba19e8c7d753118d7ad0be78a4fd39 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> e3e433262f354ed0573273bd0c28746c3cef902b 
>   src/test/python/apache/aurora/client/commands/test_restart.py 
> 526c501869b7ae22550e5d84613ca38f8071b9b7 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> f90783779805313f529487509f7d457ba8ee138c 
> 
> Diff: https://reviews.apache.org/r/20726/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 20726: Removing client HTTP health checks.

2014-04-25 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20726/
---

Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Bugs: AURORA-361
https://issues.apache.org/jira/browse/AURORA-361


Repository: aurora


Description
---

Dropping client http health checks in favor of status checks only.


Diffs
-

  src/main/python/apache/aurora/client/api/health_check.py 
e3bbf71a37c3137d580378ac185eaf65f4b056af 
  src/main/python/apache/aurora/client/api/instance_watcher.py 
530868348142c73708fa7f0d7296a3fb5b6ebb5d 
  src/test/python/apache/aurora/client/api/test_health_check.py 
f59fe42cc4808aeece34f55978ca34e62404ac58 
  src/test/python/apache/aurora/client/cli/test_restart.py 
43412c44edba19e8c7d753118d7ad0be78a4fd39 
  src/test/python/apache/aurora/client/cli/test_update.py 
e3e433262f354ed0573273bd0c28746c3cef902b 
  src/test/python/apache/aurora/client/commands/test_restart.py 
526c501869b7ae22550e5d84613ca38f8071b9b7 
  src/test/python/apache/aurora/client/commands/test_update.py 
f90783779805313f529487509f7d457ba8ee138c 

Diff: https://reviews.apache.org/r/20726/diff/


Testing
---

./pants src/test/python:all
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 


Thanks,

Maxim Khutornenko

Re: Review Request 20707: Fix a plugins glitch.

2014-04-25 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20707/#review41512
---

Ship it!


lgtm

- David McLaughlin


On April 25, 2014, 6:33 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20707/
> ---
> 
> (Updated April 25, 2014, 6:33 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-362
> https://issues.apache.org/jira/browse/aurora-362
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix a plugins glitch.
> 
> The before_dispatch method in configuration plugins is allowed to alter
> command line arguments, to add or remove arguments needed to support
> specific environments. The default implementation of plugins doesn't
> provide any return value for the plugin methods. For before_dispatch,
> this meant that the default plugin method effectively removed all command
> line parameters!
> 
> This change just turns the default before_dispatch plugin method into an
> effective no-op. If the user doesn't provide a before_dispatch method,
> the default implementation will leave the arguments correctly unchanged.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> 64bde45b203d9b5db0c032bd964a38bd563283de 
> 
> Diff: https://reviews.apache.org/r/20707/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (fix_plugins)]$ ./pants 
> src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> === 2 passed in 0.46 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> === 6 passed in 0.54 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
> 
> === 6 passed in 0.48 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> === 1 passed in 0.45 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ..
> 
> === 6 passed in 0.41 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
> 
> = 47 passed, 1 skipped in 4.48 seconds 
> =
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
> 
> == 20 passed in 0.32 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
> 
> == 27 passed in 0.73 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_quota_check.py .

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread Mark Chu-Carroll

Thanks for doing this so quickly!


On Fri, Apr 25, 2014 at 3:31 PM, David McLaughlin wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
>
> Ship it!
>
> Ship It!
>
>
> - David McLaughlin
>
> On April 25th, 2014, 12:17 a.m. UTC, Mark Chu-Carroll wrote:
>   Review request for Aurora, David McLaughlin and Suman Karumuri.
> By Mark Chu-Carroll.
>
> *Updated April 25, 2014, 12:17 a.m.*
>  *Bugs: * aurora-270 
>  *Repository: * aurora
> Description
>
> Stage 1 of implementing command hooks for aurora v2.
>
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
>
> The dynamically loaded plugins are *not* currently active outside of tests.
>
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
>
>   Testing
>
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py 
>
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
>
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .
>
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/cli/test_logging.py .
>
> === 1 passed in 0.62 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> === 2 passed in 0.53 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py 
>
> === 4 passed in 0.55 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .
>
> === 5 passed in 0.56 seconds 
> ===
> = te

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41510
---

Ship it!


Ship It!

- David McLaughlin


On April 25, 2014, 12:17 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 25, 2014, 12:17 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> === 1 passed in 0.62 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
> 
> ==

Re: Review Request 20723: Add batch options to kill and killall.

2014-04-25 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/#review41509
---

Ship it!


lgtm

- David McLaughlin


On April 25, 2014, 7:15 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20723/
> ---
> 
> (Updated April 25, 2014, 7:15 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-356
> https://issues.apache.org/jira/browse/aurora-356
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add batch options to kill and killall. (This brings the kill commands in 
> client v1 into parity with client v2.
> At the moment, in order to avoid disrupting current users, v1 still defaults 
> to non-batched operation.)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/core.py 
> 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
>   src/main/python/apache/aurora/client/options.py 
> 0d85c360dc4c62ab0baf58315a68a32c304fcffc 
>   src/test/python/apache/aurora/client/commands/test_kill.py 
> 825f5f13da1c8bee843581a34f3357c0fa2dbb00 
> 
> Diff: https://reviews.apache.org/r/20723/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (batch_v1)]$ ./pants 
> src/test/python/apache/aurora/client/commands:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
> 
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .
> 
> == 13 passed in 0.57 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
> 
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ..
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ..
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
> 
> == 28 passed in 1.47 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
> 
> src/test/python/apache/aurora/client/commands/test_hooks.py ...
> 
> === 3 passed in 1.21 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/commands/test_maintenance.py 
> 
> === 4 passed in 0.48 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_run.py .
> 
> === 1 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_ssh.py .
> 
> === 1 passed in 0.47 seconds 
> ===
> src.test.python.apache.aurora.client.commands.admin   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.core
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.hooks   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.run 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh 
>   .   SUCCESS
> [sun-wukong incubator-aurora (batch_v1)]$
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 20723: Add batch options to kill and killall.

2014-04-25 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/
---

(Updated April 25, 2014, 3:15 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Fix typo in option name.


Bugs: aurora-356
https://issues.apache.org/jira/browse/aurora-356


Repository: aurora


Description
---

Add batch options to kill and killall. (This brings the kill commands in client 
v1 into parity with client v2.
At the moment, in order to avoid disrupting current users, v1 still defaults to 
non-batched operation.)


Diffs (updated)
-

  src/main/python/apache/aurora/client/commands/core.py 
67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
  src/main/python/apache/aurora/client/options.py 
0d85c360dc4c62ab0baf58315a68a32c304fcffc 
  src/test/python/apache/aurora/client/commands/test_kill.py 
825f5f13da1c8bee843581a34f3357c0fa2dbb00 

Diff: https://reviews.apache.org/r/20723/diff/


Testing
---

[sun-wukong incubator-aurora (batch_v1)]$ ./pants 
src/test/python/apache/aurora/client/commands:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .

== 13 passed in 0.57 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ..
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ..
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...

== 28 passed in 1.47 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items

src/test/python/apache/aurora/client/commands/test_hooks.py ...

=== 3 passed in 1.21 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py 

=== 4 passed in 0.48 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

=== 1 passed in 0.58 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

=== 1 passed in 0.47 seconds ===
src.test.python.apache.aurora.client.commands.admin 
.   SUCCESS
src.test.python.apache.aurora.client.commands.core  
.   SUCCESS
src.test.python.apache.aurora.client.commands.hooks 
.   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance   
.   SUCCESS
src.test.python.apache.aurora.client.commands.run   
.   SUCCESS
src.test.python.apache.aurora.client.commands.ssh   
.   SUCCESS
[sun-wukong incubator-aurora (batch_v1)]$


Thanks,

Mark Chu-Carroll

Re: Review Request 20723: Add batch options to kill and killall.

2014-04-25 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/#review41505
---



src/main/python/apache/aurora/client/options.py


Shouldn't this be batch_size for consistency with the other commands?


- David McLaughlin


On April 25, 2014, 6:23 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20723/
> ---
> 
> (Updated April 25, 2014, 6:23 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-356
> https://issues.apache.org/jira/browse/aurora-356
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add batch options to kill and killall. (This brings the kill commands in 
> client v1 into parity with client v2.
> At the moment, in order to avoid disrupting current users, v1 still defaults 
> to non-batched operation.)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/core.py 
> 67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
>   src/main/python/apache/aurora/client/options.py 
> 0d85c360dc4c62ab0baf58315a68a32c304fcffc 
>   src/test/python/apache/aurora/client/commands/test_kill.py 
> 825f5f13da1c8bee843581a34f3357c0fa2dbb00 
> 
> Diff: https://reviews.apache.org/r/20723/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (batch_v1)]$ ./pants 
> src/test/python/apache/aurora/client/commands:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
> 
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .
> 
> == 13 passed in 0.57 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
> 
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ..
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ..
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
> 
> == 28 passed in 1.47 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
> 
> src/test/python/apache/aurora/client/commands/test_hooks.py ...
> 
> === 3 passed in 1.21 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/commands/test_maintenance.py 
> 
> === 4 passed in 0.48 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_run.py .
> 
> === 1 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_ssh.py .
> 
> === 1 passed in 0.47 seconds 
> ===
> src.test.python.apache.aurora.client.commands.admin   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.core
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.hooks   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.run 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh 
>   .   SUCCESS
> [sun-wukong incubator-aurora (batch_v1)]$
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread Mark Chu-Carroll



> On April 24, 2014, 8:15 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 344
> > 
> >
> > Different cases.
> > 
> > A command hook can signal that a command shouldn't be executed, and 
> > return the exit code that should be returned to the shell. It's intended to 
> > signal that there wasn't an error executing the hook, but that the hook 
> > requested that the command be aborted. 
> > 
> > The hook can also signal an exception, which means that there was an 
> > error in the hook.
> >
> 
> David McLaughlin wrote:
> I think exceptions are designed for exactly this... the hook authors can 
> also give their own error messages.
> 
> David McLaughlin wrote:
> I'm not sure I understand why the distinction between an error in the 
> hook and a request to stop the command is important. Why not just ask the 
> hook to throw a special exception type? If you're adamant about error codes, 
> how would they give a reason for preventing the command running?

I still think that there's an important difference between an error, and a 
normal return.

Hook writers can opt to just use exceptions, and the code will handle it 
correctly if they do. But the plugin code is supposed to look as much as 
possible like it's running as part of a verb implementation. Verbs return 
status codes to the shell when they finish; this is following the same model.

The design doc that we ran by the team and the dev mailing list specified this 
behavior, and I'm still not seeing why it should be removed.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41420
---


On April 24, 2014, 8:17 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 24, 2014, 8:17 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> ===

Re: Review Request 20707: Fix a plugins glitch.

2014-04-25 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20707/
---

(Updated April 25, 2014, 2:33 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Added a test of empty plugins, to make sure 362 didn't recur.

This revealed another case of essentially the same error, which is now fixed. 
(Thanks, Suman!)


Bugs: aurora-362
https://issues.apache.org/jira/browse/aurora-362


Repository: aurora


Description
---

Fix a plugins glitch.

The before_dispatch method in configuration plugins is allowed to alter
command line arguments, to add or remove arguments needed to support
specific environments. The default implementation of plugins doesn't
provide any return value for the plugin methods. For before_dispatch,
this meant that the default plugin method effectively removed all command
line parameters!

This change just turns the default before_dispatch plugin method into an
effective no-op. If the user doesn't provide a before_dispatch method,
the default implementation will leave the arguments correctly unchanged.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
64bde45b203d9b5db0c032bd964a38bd563283de 

Diff: https://reviews.apache.org/r/20707/diff/


Testing
---

[sun-wukong incubator-aurora (fix_plugins)]$ ./pants 
src/test/python/apache/aurora/client:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

=== 2 passed in 0.46 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/test_config.py ..

=== 6 passed in 0.54 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ..

=== 6 passed in 0.48 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/api/test_job_monitor.py .

=== 1 passed in 0.45 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ..

=== 6 passed in 0.41 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py 
...

= 47 passed, 1 skipped in 4.48 seconds =
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py 
src/test/python/apache/aurora/client/api/test_health_check.py 

== 20 passed in 0.32 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_updater.py 
...

== 27 passed in 0.73 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ..

=== 6 passed in 0.15 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 31 items

src/test/python/apache/aurora/client/api/test_sla.py 
...

== 31 passed in 0.27 seconds ===
===

Review Request 20723: Add batch options to kill and killall.

2014-04-25 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723/
---

Review request for Aurora, David McLaughlin and Suman Karumuri.


Bugs: aurora-356
https://issues.apache.org/jira/browse/aurora-356


Repository: aurora


Description
---

Add batch options to kill and killall. (This brings the kill commands in client 
v1 into parity with client v2.
At the moment, in order to avoid disrupting current users, v1 still defaults to 
non-batched operation.)


Diffs
-

  src/main/python/apache/aurora/client/commands/core.py 
67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
  src/main/python/apache/aurora/client/options.py 
0d85c360dc4c62ab0baf58315a68a32c304fcffc 
  src/test/python/apache/aurora/client/commands/test_kill.py 
825f5f13da1c8bee843581a34f3357c0fa2dbb00 

Diff: https://reviews.apache.org/r/20723/diff/


Testing
---

[sun-wukong incubator-aurora (batch_v1)]$ ./pants 
src/test/python/apache/aurora/client/commands:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .

== 13 passed in 0.57 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ..
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ..
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...

== 28 passed in 1.47 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items

src/test/python/apache/aurora/client/commands/test_hooks.py ...

=== 3 passed in 1.21 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py 

=== 4 passed in 0.48 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

=== 1 passed in 0.58 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

=== 1 passed in 0.47 seconds ===
src.test.python.apache.aurora.client.commands.admin 
.   SUCCESS
src.test.python.apache.aurora.client.commands.core  
.   SUCCESS
src.test.python.apache.aurora.client.commands.hooks 
.   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance   
.   SUCCESS
src.test.python.apache.aurora.client.commands.run   
.   SUCCESS
src.test.python.apache.aurora.client.commands.ssh   
.   SUCCESS
[sun-wukong incubator-aurora (batch_v1)]$


Thanks,

Mark Chu-Carroll

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin



> On April 25, 2014, 12:15 a.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 344
> > 
> >
> > Different cases.
> > 
> > A command hook can signal that a command shouldn't be executed, and 
> > return the exit code that should be returned to the shell. It's intended to 
> > signal that there wasn't an error executing the hook, but that the hook 
> > requested that the command be aborted. 
> > 
> > The hook can also signal an exception, which means that there was an 
> > error in the hook.
> >
> 
> David McLaughlin wrote:
> I think exceptions are designed for exactly this... the hook authors can 
> also give their own error messages.

I'm not sure I understand why the distinction between an error in the hook and 
a request to stop the command is important. Why not just ask the hook to throw 
a special exception type? If you're adamant about error codes, how would they 
give a reason for preventing the command running?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41420
---


On April 25, 2014, 12:17 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 25, 2014, 12:17 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/a

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin



> On April 25, 2014, 12:15 a.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 344
> > 
> >
> > Different cases.
> > 
> > A command hook can signal that a command shouldn't be executed, and 
> > return the exit code that should be returned to the shell. It's intended to 
> > signal that there wasn't an error executing the hook, but that the hook 
> > requested that the command be aborted. 
> > 
> > The hook can also signal an exception, which means that there was an 
> > error in the hook.
> >

I think exceptions are designed for exactly this... the hook authors can also 
give their own error messages. 


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687/#review41420
---


On April 25, 2014, 12:17 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20687/
> ---
> 
> (Updated April 25, 2014, 12:17 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
> https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stage 1 of implementing command hooks for aurora v2.
> 
> This change includes:
> (1) The ability to add hard-wired hooks, by registering them in 
> ConfigurationPlugins
>   compiled into a pex;
> (2) Dynamically loaded plugins, loaded from plugin files.
> 
> The dynamically loaded plugins are *not* currently active outside of tests.
> 
> The second stage of this change will activate dynamically loaded plugins, and
> provide a mechanism to allow privileged users to override hooks.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 17cdc287875b5f0832064a6441f33fc9837fc79b 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
>   src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0534bdf72a332caa606dd3a7ca743a59e03738ef 
>   src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 34fdb47baa647b9c3bd149ff2710b175c7435dae 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20687/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (command_hooks)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py 
> 
> === 4 passed in 0.03 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 
> === 4 passed in 0.58 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .
> 
> === 5 passed in 0.52 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 36 passed in 1.87 seconds 
> =

Re: Review Request 20469: AURORA-178 - Log snapshot operations

2014-04-25 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/
---

(Updated April 25, 2014, 6:02 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-178
https://issues.apache.org/jira/browse/AURORA-178


Repository: aurora


Description
---

AURORA-178 - Log snapshot operations


Testing Done:
./gradlew build


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
a1a0b428ba42d1abefed18bb40ca54c351154e11 

Diff: https://reviews.apache.org/r/20469/diff/


Testing
---


Thanks,

David McLaughlin

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-25 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41492
---

Ship it!


Ship It!

- Kevin Sweeney


On April 23, 2014, 10:05 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 23, 2014, 10:05 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20707: Fix a plugins glitch.

2014-04-25 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20707/#review41489
---


since this is a nasty bug that can be hard to trace, can we add a couple of 
simple unit tests to test this class?


- Suman Karumuri


On April 25, 2014, 3:53 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20707/
> ---
> 
> (Updated April 25, 2014, 3:53 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-362
> https://issues.apache.org/jira/browse/aurora-362
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix a plugins glitch.
> 
> The before_dispatch method in configuration plugins is allowed to alter
> command line arguments, to add or remove arguments needed to support
> specific environments. The default implementation of plugins doesn't
> provide any return value for the plugin methods. For before_dispatch,
> this meant that the default plugin method effectively removed all command
> line parameters!
> 
> This change just turns the default before_dispatch plugin method into an
> effective no-op. If the user doesn't provide a before_dispatch method,
> the default implementation will leave the arguments correctly unchanged.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 5a10328e49f0128965aed73b9c167324dfcfde0f 
> 
> Diff: https://reviews.apache.org/r/20707/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (fix_plugins)]$ ./pants 
> src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> === 2 passed in 0.46 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> === 6 passed in 0.54 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
> 
> === 6 passed in 0.48 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> === 1 passed in 0.45 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ..
> 
> === 6 passed in 0.41 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
> 
> = 47 passed, 1 skipped in 4.48 seconds 
> =
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
> 
> == 20 passed in 0.32 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
> 
> == 27 passed in 0.73 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_quota_check.py ..
> 
>

Re: Review Request 20629: End to end test should not look at the number of html lines.

2014-04-25 Thread Joe Smith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20629/#review41478
---

Ship it!


Works for me

- Joe Smith


On April 23, 2014, 12:59 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20629/
> ---
> 
> (Updated April 23, 2014, 12:59 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> End to end test should not look at the number of html lines.
> 
> 
> Diffs
> -
> 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> f0f2ab53c1f484a480eb2ea8766c5d299e3b8c99 
> 
> Diff: https://reviews.apache.org/r/20629/diff/
> 
> 
> Testing
> ---
> 
> end-to-end test
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 20707: Fix a plugins glitch.

2014-04-25 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20707/
---

(Updated April 25, 2014, 11:53 a.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
---

Add a jira ticket.


Bugs: aurora-362
https://issues.apache.org/jira/browse/aurora-362


Repository: aurora


Description
---

Fix a plugins glitch.

The before_dispatch method in configuration plugins is allowed to alter
command line arguments, to add or remove arguments needed to support
specific environments. The default implementation of plugins doesn't
provide any return value for the plugin methods. For before_dispatch,
this meant that the default plugin method effectively removed all command
line parameters!

This change just turns the default before_dispatch plugin method into an
effective no-op. If the user doesn't provide a before_dispatch method,
the default implementation will leave the arguments correctly unchanged.


Diffs
-

  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 

Diff: https://reviews.apache.org/r/20707/diff/


Testing
---

[sun-wukong incubator-aurora (fix_plugins)]$ ./pants 
src/test/python/apache/aurora/client:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

=== 2 passed in 0.46 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/test_config.py ..

=== 6 passed in 0.54 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ..

=== 6 passed in 0.48 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/api/test_job_monitor.py .

=== 1 passed in 0.45 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ..

=== 6 passed in 0.41 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py 
...

= 47 passed, 1 skipped in 4.48 seconds =
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py 
src/test/python/apache/aurora/client/api/test_health_check.py 

== 20 passed in 0.32 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_updater.py 
...

== 27 passed in 0.73 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ..

=== 6 passed in 0.15 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 31 items

src/test/python/apache/aurora/client/api/test_sla.py 
...

== 31 passed in 0.27 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passe

Review Request 20707: Fix a plugins glitch.

2014-04-25 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20707/
---

Review request for Aurora, David McLaughlin and Suman Karumuri.


Repository: aurora


Description
---

Fix a plugins glitch.

The before_dispatch method in configuration plugins is allowed to alter
command line arguments, to add or remove arguments needed to support
specific environments. The default implementation of plugins doesn't
provide any return value for the plugin methods. For before_dispatch,
this meant that the default plugin method effectively removed all command
line parameters!

This change just turns the default before_dispatch plugin method into an
effective no-op. If the user doesn't provide a before_dispatch method,
the default implementation will leave the arguments correctly unchanged.


Diffs
-

  src/main/python/apache/aurora/client/cli/__init__.py 
5a10328e49f0128965aed73b9c167324dfcfde0f 

Diff: https://reviews.apache.org/r/20707/diff/


Testing
---

[sun-wukong incubator-aurora (fix_plugins)]$ ./pants 
src/test/python/apache/aurora/client:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

=== 2 passed in 0.46 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/test_config.py ..

=== 6 passed in 0.54 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ..

=== 6 passed in 0.48 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/api/test_job_monitor.py .

=== 1 passed in 0.45 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ..

=== 6 passed in 0.41 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py 
...

= 47 passed, 1 skipped in 4.48 seconds =
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py 
src/test/python/apache/aurora/client/api/test_health_check.py 

== 20 passed in 0.32 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_updater.py 
...

== 27 passed in 0.73 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ..

=== 6 passed in 0.15 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 31 items

src/test/python/apache/aurora/client/api/test_sla.py 
...

== 31 passed in 0.27 seconds ===
= test session starts ==
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py 

=== 4 passed in 0.02 seconds ===
= test session starts ==
platform darwin -- Pyt

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

Re: Review Request 20707: Fix a plugins glitch.

Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

Review Request 20732: Dropping "No jobs to kill" error from killTasks.

Re: Review Request 20726: Removing client HTTP health checks.

Review Request 20726: Removing client HTTP health checks.

Re: Review Request 20707: Fix a plugins glitch.

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

Re: Review Request 20723: Add batch options to kill and killall.

Re: Review Request 20723: Add batch options to kill and killall.

Re: Review Request 20723: Add batch options to kill and killall.

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

Re: Review Request 20707: Fix a plugins glitch.

Review Request 20723: Add batch options to kill and killall.

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

Re: Review Request 20469: AURORA-178 - Log snapshot operations

Re: Review Request 20650: Exclude reports directory from idea project.

Re: Review Request 20707: Fix a plugins glitch.

Re: Review Request 20629: End to end test should not look at the number of html lines.

Re: Review Request 20707: Fix a plugins glitch.

Review Request 20707: Fix a plugins glitch.

31 matches

Site Navigation

Mail list logo

Footer information