Re: Review Request 23779: Fix filter spec for leader redirect.

2014-07-21 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23779/#review48323
---

Ship it!


Ship It!

- Maxim Khutornenko


On July 22, 2014, 12:09 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23779/
> ---
> 
> (Updated July 22, 2014, 12:09 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-584
> https://issues.apache.org/jira/browse/AURORA-584
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix filter spec for leader redirect.
> 
> 
> Diffs
> -
> 
>   build.gradle bd34f1039f93186bb95787d84cc0be190305a08e 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> 0656b9bc0a4ca2935e716f655bbbad9fda4ede0f 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> a37232aef7037f83c846a39cab70e2de0362111b 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> 27599f75603542069084631baf9195b8ad75e902 
>   src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23779/diff/
> 
> 
> Testing
> ---
> 
> Added test coverage, which brings HttpModule line (but not functional) 
> coverage to ~100%.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 23666: REST service for aurora client commands, built with Tornado Web framework

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23666/#review48322
---


Do you think this should be obviated by https://reviews.apache.org/r/23741/ ?

- Bill Farner


On July 21, 2014, 10:58 p.m., Misho Krastev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23666/
> ---
> 
> (Updated July 21, 2014, 10:58 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> REST service for aurora client commands, built using Tornado Web framework
> 
> This is a draft implementation of a REST server exposing APIs to call Aurora 
> client commands. It is a wrapper around the aurora command-line client and 
> aurora client code. It implements some but not all of the commands available 
> with the aurora command-line client. Comments on the code as well suggestions 
> for improvements and enhancements are requested.
> 
> This work is a eBay project that we would like to contribute to the Aurora 
> project.
> 
> Note: development is still ongoing to add unittests and to resolve the issues 
> discovered with the stress tests.
> Note(2): GitHub repo -- https://github.com/misho-kr/incubator-aurora
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 641d610deb58fd102ec584e3deaa388b51a6f221 
>   docs/client-rest-api.md PRE-CREATION 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 43d747956df0611b0880f64df9955d5f5806901c 
>   src/main/python/apache/aurora/client/bin/aurora_rest.py PRE-CREATION 
>   src/main/python/apache/aurora/client/rest/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/client/rest/application.py PRE-CREATION 
>   src/main/python/apache/aurora/client/rest/application_async.py PRE-CREATION 
>   src/main/python/apache/aurora/client/rest/coroutine_executor.py 
> PRE-CREATION 
>   src/main/python/apache/aurora/client/rest/external_executor.py PRE-CREATION 
>   src/main/python/apache/aurora/client/rest/internal_executor.py PRE-CREATION 
>   src/main/python/apache/aurora/client/rest/mp_executor.py PRE-CREATION 
>   src/main/python/apache/aurora/client/rest/mt_executor.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23666/diff/
> 
> 
> Testing
> ---
> 
> Stress testing with Locust to verify the REST service can handle multiple 
> requests simultaneously. Not all of them passed, particularly the ones with 
> the internal executor that calls Aurora client api.
> 
> 
> Thanks,
> 
> Misho Krastev
> 
>

Review Request 23782: Revert "Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin."

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23782/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

This wound up breaking coverage reports in a way such that they were generated, 
but did not accurately report coverage.

Going to TBR commit to make progress.


Diffs
-

  build.gradle bd34f1039f93186bb95787d84cc0be190305a08e 

Diff: https://reviews.apache.org/r/23782/diff/


Testing
---


Thanks,

Bill Farner

Review Request 23779: Fix filter spec for leader redirect.

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23779/
---

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-584
https://issues.apache.org/jira/browse/AURORA-584


Repository: aurora


Description
---

Fix filter spec for leader redirect.


Diffs
-

  build.gradle bd34f1039f93186bb95787d84cc0be190305a08e 
  src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
0656b9bc0a4ca2935e716f655bbbad9fda4ede0f 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
a37232aef7037f83c846a39cab70e2de0362111b 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
27599f75603542069084631baf9195b8ad75e902 
  src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/23779/diff/


Testing
---

Added test coverage, which brings HttpModule line (but not functional) coverage 
to ~100%.


Thanks,

Bill Farner

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23254/#review48316
---

Ship it!


Ship It!

- Bill Farner


On July 21, 2014, 11:23 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23254/
> ---
> 
> (Updated July 21, 2014, 11:23 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-94
> https://issues.apache.org/jira/browse/AURORA-94
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Splitting the earlier RB for easier reviewing. 
> 
> Addressing killTasks refactoring. Also moving some useful tests out of 
> BaseSchedulerCoreImplTest.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> 27599f75603542069084631baf9195b8ad75e902 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 628464de0032db4eb5884e3b74346b2390408993 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> b6d06f39ac39570eac4495d97d3adaabe8357bf7 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  95ee7b784889d66cae9b714bd88c27a136a54b3a 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 4ebb608d28b667bf47573524aa8878ac3b21ecfe 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> 8692051fae08a59e4b70b330eb6723f72ff04d43 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2298971ffac45a284f9130e2122aeea8b39dc852 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d2bd65eef5a8ceea92dd62044e5e2c621c4a4f3e 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 94eb0a22037187625636b24707d4ac6741b55f22 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  b28761d5bbfdd2fea4714c79b47be5f5eb3a5280 
> 
> Diff: https://reviews.apache.org/r/23254/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23254/
---

(Updated July 21, 2014, 11:23 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-94
https://issues.apache.org/jira/browse/AURORA-94


Repository: aurora


Description
---

Splitting the earlier RB for easier reviewing. 

Addressing killTasks refactoring. Also moving some useful tests out of 
BaseSchedulerCoreImplTest.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
27599f75603542069084631baf9195b8ad75e902 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
628464de0032db4eb5884e3b74346b2390408993 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
b6d06f39ac39570eac4495d97d3adaabe8357bf7 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
95ee7b784889d66cae9b714bd88c27a136a54b3a 
  src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
4ebb608d28b667bf47573524aa8878ac3b21ecfe 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
8692051fae08a59e4b70b330eb6723f72ff04d43 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 2298971ffac45a284f9130e2122aeea8b39dc852 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
d2bd65eef5a8ceea92dd62044e5e2c621c4a4f3e 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
94eb0a22037187625636b24707d4ac6741b55f22 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 b28761d5bbfdd2fea4714c79b47be5f5eb3a5280 

Diff: https://reviews.apache.org/r/23254/diff/


Testing
---

gradle -Pq clean build


Thanks,

Maxim Khutornenko

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Maxim Khutornenko 


> On July 21, 2014, 10:16 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 721
> > 
> >
> > We should avoid taking advantage of passing nulls where possible, and 
> > in fact i suggest changing addMessage to MorePreconditions.checkNotBlank on 
> > that.  However, you'll need to take care in cases like addMessage(x, x, 
> > exception.getMessage()).  For those, it makes sense to add an overload that 
> > accepts an Exception instead of String.

Makes sense. Done.


> On July 21, 2014, 10:16 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java, 
> > line 1
> > 
> >
> > Is this file relevant to the change?

This is related to the "Also moving some useful tests out of 
BaseSchedulerCoreImplTest." part of the changelist. Trying to balance the diff 
size.


> On July 21, 2014, 10:16 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
> >  line 431
> > 
> >
> > There's a subtle detail in this test case, that active() is 
> > automatically added to the task query.  Can you break that out into an 
> > independent test case?

Sure, done.


> On July 21, 2014, 10:16 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
> >  line 509
> > 
> >
> > Use a constant for string that is otherwise magic.

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23254/#review48302
---


On July 3, 2014, 1:48 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23254/
> ---
> 
> (Updated July 3, 2014, 1:48 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-94
> https://issues.apache.org/jira/browse/AURORA-94
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Splitting the earlier RB for easier reviewing. 
> 
> Addressing killTasks refactoring. Also moving some useful tests out of 
> BaseSchedulerCoreImplTest.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> 27599f75603542069084631baf9195b8ad75e902 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 628464de0032db4eb5884e3b74346b2390408993 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> b6d06f39ac39570eac4495d97d3adaabe8357bf7 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  2549dd33d08dfc6058d985127a3f0c1f3984eaa7 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2298971ffac45a284f9130e2122aeea8b39dc852 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d2bd65eef5a8ceea92dd62044e5e2c621c4a4f3e 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 94eb0a22037187625636b24707d4ac6741b55f22 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cffa74ba36e2afda3340658d6b1afd6cb50cf2c 
> 
> Diff: https://reviews.apache.org/r/23254/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 23666: REST service for aurora client commands, built with Tornado Web framework

2014-07-21 Thread Misho Krastev 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23666/
---

(Updated July 21, 2014, 10:58 p.m.)


Review request for Aurora.


Changes
---

Added link to Github repo -- https://github.com/misho-kr/incubator-aurora


Repository: aurora


Description (updated)
---

REST service for aurora client commands, built using Tornado Web framework

This is a draft implementation of a REST server exposing APIs to call Aurora 
client commands. It is a wrapper around the aurora command-line client and 
aurora client code. It implements some but not all of the commands available 
with the aurora command-line client. Comments on the code as well suggestions 
for improvements and enhancements are requested.

This work is a eBay project that we would like to contribute to the Aurora 
project.

Note: development is still ongoing to add unittests and to resolve the issues 
discovered with the stress tests.
Note(2): GitHub repo -- https://github.com/misho-kr/incubator-aurora


Diffs
-

  3rdparty/python/BUILD 641d610deb58fd102ec584e3deaa388b51a6f221 
  docs/client-rest-api.md PRE-CREATION 
  src/main/python/apache/aurora/client/bin/BUILD 
43d747956df0611b0880f64df9955d5f5806901c 
  src/main/python/apache/aurora/client/bin/aurora_rest.py PRE-CREATION 
  src/main/python/apache/aurora/client/rest/BUILD PRE-CREATION 
  src/main/python/apache/aurora/client/rest/application.py PRE-CREATION 
  src/main/python/apache/aurora/client/rest/application_async.py PRE-CREATION 
  src/main/python/apache/aurora/client/rest/coroutine_executor.py PRE-CREATION 
  src/main/python/apache/aurora/client/rest/external_executor.py PRE-CREATION 
  src/main/python/apache/aurora/client/rest/internal_executor.py PRE-CREATION 
  src/main/python/apache/aurora/client/rest/mp_executor.py PRE-CREATION 
  src/main/python/apache/aurora/client/rest/mt_executor.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23666/diff/


Testing
---

Stress testing with Locust to verify the REST service can handle multiple 
requests simultaneously. Not all of them passed, particularly the ones with the 
internal executor that calls Aurora client api.


Thanks,

Misho Krastev

Re: Review Request 23776: Add --stacktrace to gradle build command.

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23776/
---

(Updated July 21, 2014, 10:27 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description (updated)
---

I'm hoping this gives more insight into some recent build flakiness, 
specifically this error:

net.rubygrapefruit.platform.internal.jni.PosixFileFunctions.symlink(Ljava/lang/String;Ljava/lang/String;Lnet/rubygrapefruit/platform/internal/FunctionResult;)V


This appears to be related to GRADLE-3076 [1], but --stacktrace may give us 
more information.

[1] http://issues.gradle.org/browse/GRADLE-3076


Diffs
-

  build-support/jenkins/build.sh 466aae208659cb08d633c12b674a0c9ec2819bba 

Diff: https://reviews.apache.org/r/23776/diff/


Testing
---


Thanks,

Bill Farner

Review Request 23776: Add --stacktrace to gradle build command.

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23776/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

I'm hoping this gives more insight into some recent build flakiness, 
specifically this error:

This appears to be related to GRADLE-3076 [1], but --stacktrace may give us 
more information.

[1] http://issues.gradle.org/browse/GRADLE-3076


Diffs
-

  build-support/jenkins/build.sh 466aae208659cb08d633c12b674a0c9ec2819bba 

Diff: https://reviews.apache.org/r/23776/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23254/#review48302
---



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java


We should avoid taking advantage of passing nulls where possible, and in 
fact i suggest changing addMessage to MorePreconditions.checkNotBlank on that.  
However, you'll need to take care in cases like addMessage(x, x, 
exception.getMessage()).  For those, it makes sense to add an overload that 
accepts an Exception instead of String.



src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java


Is this file relevant to the change?



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java


There's a subtle detail in this test case, that active() is automatically 
added to the task query.  Can you break that out into an independent test case?



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java


Use a constant for string that is otherwise magic.


- Bill Farner


On July 3, 2014, 1:48 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23254/
> ---
> 
> (Updated July 3, 2014, 1:48 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-94
> https://issues.apache.org/jira/browse/AURORA-94
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Splitting the earlier RB for easier reviewing. 
> 
> Addressing killTasks refactoring. Also moving some useful tests out of 
> BaseSchedulerCoreImplTest.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> 27599f75603542069084631baf9195b8ad75e902 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 628464de0032db4eb5884e3b74346b2390408993 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> b6d06f39ac39570eac4495d97d3adaabe8357bf7 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  2549dd33d08dfc6058d985127a3f0c1f3984eaa7 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2298971ffac45a284f9130e2122aeea8b39dc852 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d2bd65eef5a8ceea92dd62044e5e2c621c4a4f3e 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 94eb0a22037187625636b24707d4ac6741b55f22 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cffa74ba36e2afda3340658d6b1afd6cb50cf2c 
> 
> Diff: https://reviews.apache.org/r/23254/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-07-21 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/#review48304
---

Ship it!


Ship It!

- Kevin Sweeney


On July 17, 2014, 3:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20648/
> ---
> 
> (Updated July 17, 2014, 3:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-340
> https://issues.apache.org/jira/browse/AURORA-340
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove IsolatedSchedulerModule and surrounding code.
> 
> 
> Diffs
> -
> 
>   build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d 
>   src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 
> 92cf4423ee34f11bbfaca6261e3e85802ad46de9 
>   
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 
> 2c06e2463f1d9f51968ff7bba956515f807d8d9c 
>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 
> c6672fbfbf6e07b7fd3029a73334b52c4074c3a7 
>   
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java
>  781414c5660558fa1628758e50dc82178717a723 
>   src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
> ef8c08cf2d33fb119a271151dc34245c1c30d11f 
> 
> Diff: https://reviews.apache.org/r/20648/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> sh examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23188/#review48303
---

Ship it!


Ship It!

- Kevin Sweeney


On July 21, 2014, 2:58 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23188/
> ---
> 
> (Updated July 21, 2014, 2:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-377
> https://issues.apache.org/jira/browse/AURORA-377
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding getPendingReason RPC to expose scheduling vetos in the UI/client.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  2549dd33d08dfc6058d985127a3f0c1f3984eaa7 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8ee43fa1f0e2e699b0f1a321e673e49221b528ad 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cffa74ba36e2afda3340658d6b1afd6cb50cf2c 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> ed24ca058c013dfdec8366522893bd4f83e30a9c 
> 
> Diff: https://reviews.apache.org/r/23188/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-07-21 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/#review48300
---

Ship it!


Still think it's worth keeping but don't want to block it.

- Maxim Khutornenko


On July 17, 2014, 10:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20648/
> ---
> 
> (Updated July 17, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-340
> https://issues.apache.org/jira/browse/AURORA-340
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove IsolatedSchedulerModule and surrounding code.
> 
> 
> Diffs
> -
> 
>   build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d 
>   src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 
> 92cf4423ee34f11bbfaca6261e3e85802ad46de9 
>   
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 
> 2c06e2463f1d9f51968ff7bba956515f807d8d9c 
>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 
> c6672fbfbf6e07b7fd3029a73334b52c4074c3a7 
>   
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java
>  781414c5660558fa1628758e50dc82178717a723 
>   src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
> ef8c08cf2d33fb119a271151dc34245c1c30d11f 
> 
> Diff: https://reviews.apache.org/r/20648/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> sh examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23188/#review48299
---

Ship it!


Ship It!

- Bill Farner


On July 21, 2014, 9:58 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23188/
> ---
> 
> (Updated July 21, 2014, 9:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-377
> https://issues.apache.org/jira/browse/AURORA-377
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding getPendingReason RPC to expose scheduling vetos in the UI/client.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  2549dd33d08dfc6058d985127a3f0c1f3984eaa7 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8ee43fa1f0e2e699b0f1a321e673e49221b528ad 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cffa74ba36e2afda3340658d6b1afd6cb50cf2c 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> ed24ca058c013dfdec8366522893bd4f83e30a9c 
> 
> Diff: https://reviews.apache.org/r/23188/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23254/#review48298
---


Ping.

- Maxim Khutornenko


On July 3, 2014, 1:48 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23254/
> ---
> 
> (Updated July 3, 2014, 1:48 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-94
> https://issues.apache.org/jira/browse/AURORA-94
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Splitting the earlier RB for easier reviewing. 
> 
> Addressing killTasks refactoring. Also moving some useful tests out of 
> BaseSchedulerCoreImplTest.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> 27599f75603542069084631baf9195b8ad75e902 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> 628464de0032db4eb5884e3b74346b2390408993 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> b6d06f39ac39570eac4495d97d3adaabe8357bf7 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  2549dd33d08dfc6058d985127a3f0c1f3984eaa7 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  2298971ffac45a284f9130e2122aeea8b39dc852 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d2bd65eef5a8ceea92dd62044e5e2c621c4a4f3e 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 94eb0a22037187625636b24707d4ac6741b55f22 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cffa74ba36e2afda3340658d6b1afd6cb50cf2c 
> 
> Diff: https://reviews.apache.org/r/23254/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23188/
---

(Updated July 21, 2014, 9:58 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-377
https://issues.apache.org/jira/browse/AURORA-377


Repository: aurora


Description
---

Adding getPendingReason RPC to expose scheduling vetos in the UI/client.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
2549dd33d08dfc6058d985127a3f0c1f3984eaa7 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
8ee43fa1f0e2e699b0f1a321e673e49221b528ad 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 2cffa74ba36e2afda3340658d6b1afd6cb50cf2c 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
ed24ca058c013dfdec8366522893bd4f83e30a9c 

Diff: https://reviews.apache.org/r/23188/diff/


Testing
---

gradle -Pq clean build


Thanks,

Maxim Khutornenko

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Maxim Khutornenko 


> On July 2, 2014, 11:11 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 414
> > 
> >
> > What's the motivation for including the job key?  I would assume that 
> > the caller either already knows this, and if not, they can turn back around 
> > and query for the task IDs.
> 
> Maxim Khutornenko wrote:
> TaskQuery allows pulling tasks from multiple jobs. Without specifying 
> some kind of reference towards the parent job, pending reasons would be 
> useless when pulled by anything other than the JobKey. Either we have to 
> further restrict TaskQuery to require role/env/name fields or provide a 
> reference back in the result. Feels like making this RPC effectively 
> job-scoped is an unnecessary restriction at this point.
>
> 
> Bill Farner wrote:
> > Without specifying some kind of reference towards the parent job, 
> pending reasons would be useless when pulled by anything other than the JobKey
> 
> I disagree that they would be useless.  Like i mentioned above, the 
> caller will either have context, or they can turn around and query for the 
> tasks to gain context.  Including the job key seems arbitrary (i.e. why that 
> and not the instance id?).

Dropped.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23188/#review47247
---


On July 2, 2014, 11:07 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23188/
> ---
> 
> (Updated July 2, 2014, 11:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-377
> https://issues.apache.org/jira/browse/AURORA-377
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding getPendingReason RPC to expose scheduling vetos in the UI/client.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  2549dd33d08dfc6058d985127a3f0c1f3984eaa7 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8ee43fa1f0e2e699b0f1a321e673e49221b528ad 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cffa74ba36e2afda3340658d6b1afd6cb50cf2c 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> ed24ca058c013dfdec8366522893bd4f83e30a9c 
> 
> Diff: https://reviews.apache.org/r/23188/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 23244: Fixing return value in _check_sla.

2014-07-21 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23244/
---

(Updated July 21, 2014, 9:39 p.m.)


Review request for Aurora, Joe Smith and Mark Chu-Carroll.


Changes
---

+ Mark.


Bugs: AURORA-571
https://issues.apache.org/jira/browse/AURORA-571


Repository: aurora


Description
---

Fixing return value in _check_sla. Also, adding logging in drainHosts RPC to 
help troubleshooting occasional LOST tasks when draining.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
bf48db97cf882105c0b2e6b70f9a4612ce60dbe8 
  src/main/python/apache/aurora/admin/host_maintenance.py 
b5b1375b1bbaed833acf2d17ec432b3d99145fab 
  src/test/python/apache/aurora/client/commands/test_maintenance.py 
c4677fc2cf4cfa792823cd0660c13371ec28301f 

Diff: https://reviews.apache.org/r/23244/diff/


Testing
---

gradle -Pq build
./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 21440: Implementing parallel updater

2014-07-21 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---

(Updated July 21, 2014, 9:09 p.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Changes
---

Rebased. Brian, is this fully addressing your latest comments?


Bugs: AURORA-350
https://issues.apache.org/jira/browse/AURORA-350


Repository: aurora


Description
---

The updater now spawns upto batch_size threads to process one instance per 
thread. 

All mutating calls are multiplexed by the SchedulerMux to do batch 
kill/add/restart calls. This is the first step towards a fully multiplexed 
SchedulerProxy and is intended to mitigate LDAP/scheduler load.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/BUILD 
c205a7d5f281c2b9e52d778c3d84647f25dafc15 
  src/main/python/apache/aurora/client/api/error_handling_thread.py 
PRE-CREATION 
  src/main/python/apache/aurora/client/api/instance_watcher.py 
e09aa9a6c32c17f13c9b8ff3a589919587bd839b 
  src/main/python/apache/aurora/client/api/job_monitor.py 
d176995fca68d42fcc2d3989483eaf520d0d737f 
  src/main/python/apache/aurora/client/api/scheduler_client.py 
10a956c50de893c8380ef1f763ed7d6686b5c00c 
  src/main/python/apache/aurora/client/api/scheduler_mux.py PRE-CREATION 
  src/main/python/apache/aurora/client/api/sla.py 
8fc9af329a726087c0f93fae975298e042c25d8b 
  src/main/python/apache/aurora/client/api/task_util.py PRE-CREATION 
  src/main/python/apache/aurora/client/api/updater.py 
c592651770f9426fd42b7f92fe2185e1e3065c43 
  src/main/python/apache/aurora/client/api/updater_util.py 
6b689c11b86c99ef5538c0b7bf4dbb81e0df2d13 
  src/main/python/apache/aurora/client/base.py 
663a2471ccb53efc80e9918a26c324475ee50938 
  src/test/python/apache/aurora/client/api/BUILD 
804195b719cad7652b3ccb15f03c7c80fc2a13f3 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
723a5b6f429f85202ee4ad3a004f019cec632a98 
  src/test/python/apache/aurora/client/api/test_job_monitor.py 
3aa96075e085ac7c2607a8c303ee5daf6e3e43b0 
  src/test/python/apache/aurora/client/api/test_scheduler_mux.py PRE-CREATION 
  src/test/python/apache/aurora/client/api/test_task_util.py PRE-CREATION 
  src/test/python/apache/aurora/client/api/test_updater.py 
48f82c8d9606b7e3bae77eaabbbca8edc92ab045 
  src/test/python/apache/aurora/client/cli/test_create.py 
cda95ceca4803cb39ad1c2b2bebddc5fba61d145 
  src/test/python/apache/aurora/client/cli/test_kill.py 
e9e167991cd06e556dbbc839eb9a808eb7d88fe9 
  src/test/python/apache/aurora/client/cli/test_restart.py 
407eb41eb6e78721ef29baefdee5699e605193f9 
  src/test/python/apache/aurora/client/cli/test_update.py 
44a180e88893fea1d7acf1862d5aaa95d98598f5 
  src/test/python/apache/aurora/client/cli/util.py 
65e679fbfad421ce3373e07d01e8619b5f10af5b 
  src/test/python/apache/aurora/client/commands/test_create.py 
4cd1343b19e9d13abe20d3b88dc7460ec512d57b 
  src/test/python/apache/aurora/client/commands/test_kill.py 
94bbe1bfff1c8d333837aa6bb14700714f46288b 
  src/test/python/apache/aurora/client/commands/test_restart.py 
0c6d5a069c43d96098c126aa340a734cb37c667a 
  src/test/python/apache/aurora/client/commands/test_update.py 
ea8e092267fd65ccd24ca1be3c04f50ba89f5236 
  src/test/python/apache/aurora/client/commands/util.py 
e24f130234a431969d6f52233e9b7fa9297bbaa4 
  src/test/python/apache/aurora/client/fake_scheduler_proxy.py 
2a4773c81efb390385f675854e9631500b263a45 
  src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
664c3e3c27a58d64d73ac8c9066bf4dc721415ad 
  src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
dcf61033743317a51dd2f77e8d254c4781cb6a93 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
9c5652829ac306dda5f7e95e164c85713e18988f 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
2af256d65850bd86279dff4b5c53f234cf7a 

Diff: https://reviews.apache.org/r/21440/diff/


Testing
---

./pants src/test/python:all
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Maxim Khutornenko

Re: Review Request 22944: Use tasksWithoutConfig on job page

2014-07-21 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/#review48295
---

Ship it!


Ship It!

- Kevin Sweeney


On June 24, 2014, 2:30 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22944/
> ---
> 
> (Updated June 24, 2014, 2:30 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-551
> https://issues.apache.org/jira/browse/AURORA-551
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use tasksWithoutConfig on job page to reduce page load time for jobs with 
> large amount of active instances.
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 
> 129235f33494f9a97117409374268cf441b976ca 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> fc8b40b775ab9a47d5b397cdf153e2facbac0e5e 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 8aef24237e6b6e90a31d90adfc5673e5d431dac7 
> 
> Diff: https://reviews.apache.org/r/22944/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> File Attachments
> 
> 
> Mocked data for groups.
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 23753: Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.

2014-07-21 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23753/#review48294
---

Ship it!


Ship It!

- Kevin Sweeney


On July 21, 2014, 1:58 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23753/
> ---
> 
> (Updated July 21, 2014, 1:58 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-593
> https://issues.apache.org/jira/browse/AURORA-593
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instruct jacoco gradle plugin to save coverage details needed by jacoco 
> jenkins plugin.
> 
> 
> Diffs
> -
> 
>   build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 
> 
> Diff: https://reviews.apache.org/r/23753/diff/
> 
> 
> Testing
> ---
> 
> Ran jenkins locally, verified that jacoco output files are consumed and 
> coverage graph works.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 23753: Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23753/
---

Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-593
https://issues.apache.org/jira/browse/AURORA-593


Repository: aurora


Description
---

Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins 
plugin.


Diffs
-

  build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 

Diff: https://reviews.apache.org/r/23753/diff/


Testing
---

Ran jenkins locally, verified that jacoco output files are consumed and 
coverage graph works.


Thanks,

Bill Farner

Re: Review Request 22944: Use tasksWithoutConfig on job page

2014-07-21 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/#review48292
---


Ping?

- David McLaughlin


On June 24, 2014, 9:30 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22944/
> ---
> 
> (Updated June 24, 2014, 9:30 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-551
> https://issues.apache.org/jira/browse/AURORA-551
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use tasksWithoutConfig on job page to reduce page load time for jobs with 
> large amount of active instances.
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 
> 129235f33494f9a97117409374268cf441b976ca 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> fc8b40b775ab9a47d5b397cdf153e2facbac0e5e 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 8aef24237e6b6e90a31d90adfc5673e5d431dac7 
> 
> Diff: https://reviews.apache.org/r/22944/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> File Attachments
> 
> 
> Mocked data for groups.
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.

2014-07-21 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23455/#review48068
---

Ship it!


Ship It!


src/main/python/apache/aurora/client/commands/core.py


Can safely omit this


- Kevin Sweeney


On July 14, 2014, 10:50 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23455/
> ---
> 
> (Updated July 14, 2014, 10:50 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: aurora-581
> https://issues.apache.org/jira/browse/aurora-581
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a lightweight version of command hooks for clientv1 commands.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/core.py 
> 0939f0570572375ba9b4d054ddb9849995c9048d 
>   src/test/python/apache/aurora/client/commands/test_kill.py 
> 94bbe1bfff1c8d333837aa6bb14700714f46288b 
> 
> Diff: https://reviews.apache.org/r/23455/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests, and ran full unit test suite.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23741/
---

(Updated July 21, 2014, 4:59 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Repository: aurora


Description
---

In this change, i've added two outputs from thrift_wrapper_codegen.py:
- A service metadata file (java) that maps RPC method names to parameter and 
type information
- A series of html documents that describes methods and types used in the API 
(drawing from javadoc-style comments in api.thrift)

ApiBeta.java consumes the metadata file, and uses it to instruct gson how to 
deserialize incoming requests.  It in turn uses reflection to invoke the 
appropriate method on the thrift interface implementation.


Diffs (updated)
-

  build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
27599f75603542069084631baf9195b8ad75e902 
  src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java PRE-CREATION 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
9d500baf82914733c0f92752d9570da009870aa9 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
8ee43fa1f0e2e699b0f1a321e673e49221b528ad 

Diff: https://reviews.apache.org/r/23741/diff/


Testing (updated)
---

Manually walked through /apibeta in a web browser, all links seem working and 
useful.

Started scheduler in vagrant, did some curling:

View the summary of all roles:

$ curl -s -X POST http://192.168.33.7:8081/apibeta/getRoleSummary | python 
-mjson.tool
{
"DEPRECATEDversion": {
"major": 3
},
"details": [
{
"message": "Welcome, beta API user!  Please help us find and fix 
the bugs that likely lurk in this API!"
}
],
"responseCode": "OK",
"result": {
"summaries": [
{
"cronJobCount": 0,
"jobCount": 1,
"role": "www-data"
}
]
},
"serverInfo": {
"clusterName": "example",
"statsUrlPrefix": "",
"thriftAPIVersion": 3
}
}

View the job summary for a role:

$ curl -s -X POST http://192.168.33.7:8081/apibeta/getJobSummary -d '{"role": 
"www-data"}' | python -mjson.tool
{
"DEPRECATEDversion": {
"major": 3
},
"details": [
{
"message": "Welcome, beta API user!  Please help us find and fix 
the bugs that likely lurk in this API!"
}
],
"responseCode": "OK",
"result": {
"summaries": [
{
"job": {
"instanceCount": 3,
"key": {
"environment": "devel",
"name": "hello_world",
"role": "www-data"
},
"owner": {
"role": "www-data",
"user": "vagrant"
},
"taskConfig": {
"constraints": [
{
"constraint": {
"limit": 1
},
"name": "host"
}
],
"diskMb": 8,
"environment": "devel",
"executorConfig": {
"data": "{\"priority\": 0, \"health_check_config\": 
{\"initial_interval_secs\": 15.0, \"interval_secs\": 10.0, \"timeout_secs\": 
1.0, \"max_consecutive_failures\": 0}, \"name\": \"hello_world\", 
\"environment\": \"devel\", \"max_task_failures\": 1, \"task\": {\"processes\": 
[{\"daemon\": false, \"name\": \"fetch_package\", \"ephemeral\": false, 
\"max_failures\": 1, \"min_duration\": 5, \"cmdline\": \"cp 
/vagrant/hello_world.py . && echo f182ae9a09cc7cea07dac9d595d5494a && chmod +x 
hello_world.py\", \"final\": false}, {\"daemon\": false, \"name\": 
\"hello_world\", \"ephemeral\": false, \"max_failures\": 1, \"min_duration\": 
5, \"cmdline\": \"python hello_world.py\", \"final\": false}], \"name\": 
\"fetch_package\", \"finalization_wait\": 30, \"max_failures\": 1, 
\"max_concurrency\": 0, \"resources\": {\"disk\": 8388608, \"ram\": 1048576, 
\"cpu\": 1.0}, \"constraints\": [{\"order\": [\"fetch_package\", 
\"hello_world\"]}]}, \"enable_hooks\": false, \"cluster\"
 : \"devcluster\", \"production\": false, \"role\": \"www-data\"}",
"name": "AuroraExecutor"
},
"isService": true,
"jobName": "hello_world",
"maxTaskFailures": 1,
"metadata": [],
"numCpus": 1.0,
"owner": {
"role": "www-

Re: Review Request 23718: AURORA-594: RC1 files missing Apache license headers

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23718/#review48248
---

Ship it!



src/main/python/apache/aurora/BUILD


I believe this file can be deleted, i don't know of any reason for empty 
BUILD files to exist.


- Bill Farner


On July 20, 2014, 8:07 p.m., Jake Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23718/
> ---
> 
> (Updated July 20, 2014, 8:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-594
> https://issues.apache.org/jira/browse/AURORA-594
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-594: RC1 files missing Apache license headers
> 
> Adds missing license headers to empty and newly added files.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/BUILD 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/test/python/apache/aurora/client/cli/AuroraHooks 
> c25bcfba2a3f58523769b966576f95809d7ebb26 
>   
> src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks
>  6333986e9afe5b0068bfdcc9a2b3f4cb5dd03578 
>   
> src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks
>  768c124aeb8bb47986312ec70641ad9d09f0913b 
> 
> Diff: https://reviews.apache.org/r/23718/diff/
> 
> 
> Testing
> ---
> 
> ran: build-support/jenkins/build.sh
> 
> All test passed except test_cluster_option as outlined in AURORA-595
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>

Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-21 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23741/
---

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Repository: aurora


Description
---

In this change, i've added two outputs from thrift_wrapper_codegen.py:
- A service metadata file (java) that maps RPC method names to parameter and 
type information
- A series of html documents that describes methods and types used in the API 
(drawing from javadoc-style comments in api.thrift)

ApiBeta.java consumes the metadata file, and uses it to instruct gson how to 
deserialize incoming requests.  It in turn uses reflection to invoke the 
appropriate method on the thrift interface implementation.


Diffs
-

  build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
27599f75603542069084631baf9195b8ad75e902 
  src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java PRE-CREATION 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
9d500baf82914733c0f92752d9570da009870aa9 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
8ee43fa1f0e2e699b0f1a321e673e49221b528ad 

Diff: https://reviews.apache.org/r/23741/diff/


Testing
---

Manual only, will post some snippets shortly.


Thanks,

Bill Farner