Re: Review Request 24995: Adding support for a pre-update quota check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51781 --- Ping, Kevin. - Maxim Khutornenko On Aug. 22, 2014, 8:55 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/ --- (Updated Aug. 22, 2014, 8:55 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- First step towards checking quota in startJobUpdate RPC. The final thrift wiring is to follow. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 7a1a09b94cfe6d4b58ef4e6ab958b71c4be1e9bd src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 24145f52a17ec9b7458aa5578a5b99ef5b1cddab src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java f679f38f0fcff8abf2442cfcd885cd202ac55528 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java a0ef57ec8af2fd6993eda338da14d1f4346ed3a4 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java fa611a913bad40a8c0515c578b394c460340e574 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 997ade0be58723d1d91725061bb128ccf45e25b4 Diff: https://reviews.apache.org/r/24995/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24752: combine finalization_wait when combining tasks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24752/ --- (Updated Aug. 28, 2014, 3:27 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- use an initial value with max to obviate the use of reduce. Repository: aurora Description --- Problem: combine_task and concat_task helpers lose the finalization_wait information from all but the first task Resolution: use sum/max of finialization_wait values in concat_task/combine_task Diffs (updated) - src/main/python/apache/thermos/config/schema_helpers.py 3feef02 src/test/python/apache/thermos/config/test_schema.py 85b04c0 Diff: https://reviews.apache.org/r/24752/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Matthew Jeffryes
Review Request 25159: Adding pause/resume/abort client APIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25159/ --- Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-615 https://issues.apache.org/jira/browse/AURORA-615 Repository: aurora Description --- Adding pause/resume/abort client APIs. Diffs - src/main/python/apache/aurora/client/api/__init__.py 4968738068876b6796ee0ddc0e70192894482ccf src/test/python/apache/aurora/client/api/test_api.py 237d4abacae78ff9d024f43d777ff6d3328b1dd9 Diff: https://reviews.apache.org/r/25159/diff/ Testing --- ./pants src/test/python/apache/aurora/client/api:api Thanks, Maxim Khutornenko
Re: Review Request 25159: Adding pause/resume/abort client APIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25159/#review51807 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 28, 2014, 2:16 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25159/ --- (Updated Aug. 28, 2014, 2:16 p.m.) Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-615 https://issues.apache.org/jira/browse/AURORA-615 Repository: aurora Description --- Adding pause/resume/abort client APIs. Diffs - src/main/python/apache/aurora/client/api/__init__.py 4968738068876b6796ee0ddc0e70192894482ccf src/test/python/apache/aurora/client/api/test_api.py 237d4abacae78ff9d024f43d777ff6d3328b1dd9 Diff: https://reviews.apache.org/r/25159/diff/ Testing --- ./pants src/test/python/apache/aurora/client/api:api Thanks, Maxim Khutornenko
Re: Review Request 25158: Aurora Update UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25158/#review51808 --- This looks nice! I'm assuming the grid is changes in real time as instances are updated? I think I prefer the big preview (the one with the grid as opposed to the progress bar). What are your thoughts on including the update summary from the finished view on the in progress view? I think that'd be useful information on an in-flight deploy, especially who kicked it off, when it started, and an elapsed timer...) File Attachment: Update with skipped instances - update-page-skipped.png https://reviews.apache.org//r/25158/#fcomment24 This brighter green for skipped feels off to me. It looks *more* successful than the actual successful updates. File Attachment: Update page - HUGE job, smaller viz - update-page-huge-job.png https://reviews.apache.org//r/25158/#fcomment25 Beyond a certain point, instead of making the boxes smaller and smaller (or having this section take up more and more real estate), does it make sense to set a lower bound for size (and an upper bound for overall vertical hiehgt) and simply let each box represent multiple instances? - Joshua Cohen On Aug. 28, 2014, 6:13 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25158/ --- (Updated Aug. 28, 2014, 6:13 p.m.) Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-614 None Description --- Still working on trying to make the event timeline work, but going to show what I've got so far to get feedback. Will tidy up the code and post a review for it once I get a ship it for this. The main thing here is the instance status visualisation. I've mocked out data to show some use cases. Note: I have two job page versions here with a preview of an update in progress. Would be interested in getting feedback on which one people prefer. Diffs - Diff: https://reviews.apache.org/r/25158/diff/ Testing --- File Attachments Job Page with in progress update, using same template as update page https://reviews.apache.org/media/uploaded/files/2014/08/28/332fd237-eba5-4204-93e5-4e271f8b4f8c__job-page-in-progress-big-preview.png Job Update with smaller in progress update, and more conventional progress bar. https://reviews.apache.org/media/uploaded/files/2014/08/28/39f78052-348c-458c-956b-c3ba8ab1f642__job-progress-small-preview.png Update Page - medium sized job in progress https://reviews.apache.org/media/uploaded/files/2014/08/28/e6e7e5db-c5ff-4e68-a817-552243a706f5__update-page-in-progress-medium-job.png Update Page - Update completed view https://reviews.apache.org/media/uploaded/files/2014/08/28/fb8ed1c1-c90c-4c13-8464-6876ca811ad1__update-page-finished.png Update Page - partial update / canary view https://reviews.apache.org/media/uploaded/files/2014/08/28/ada5349c-84be-4838-9c20-cc99d5db3779__update-page-partial-canary.png Update Page - Update that has failed instances https://reviews.apache.org/media/uploaded/files/2014/08/28/7a8983f5-cc36-4219-ab9e-237680566c11__update-page-failures.png Update with skipped instances https://reviews.apache.org/media/uploaded/files/2014/08/28/d4283788-45b6-4564-9e9d-81327b8d3e06__update-page-skipped.png Update that had to be rolled back https://reviews.apache.org/media/uploaded/files/2014/08/28/0a968616-4199-4e34-bc37-3b66fff03eef__update-page-rolled-back.png Update where instances were removed https://reviews.apache.org/media/uploaded/files/2014/08/28/ca132beb-fcd4-4fe1-b682-6e229f632f45__update-page-instances-removed.png Update page - HUGE job, smaller viz https://reviews.apache.org/media/uploaded/files/2014/08/28/8e4d59f9-4644-46b7-a4b1-1a5de9538a80__update-page-huge-job.png Update Page - very small job https://reviews.apache.org/media/uploaded/files/2014/08/28/356db8be-e3d1-430a-ac35-3ff7f5855467__update-page-small-job.png Thanks, David McLaughlin
Re: Review Request 25158: Aurora Update UI
On Aug. 28, 2014, 6:51 p.m., Joshua Cohen wrote: This looks nice! I'm assuming the grid is changes in real time as instances are updated? I think I prefer the big preview (the one with the grid as opposed to the progress bar). What are your thoughts on including the update summary from the finished view on the in progress view? I think that'd be useful information on an in-flight deploy, especially who kicked it off, when it started, and an elapsed timer...) I actually like the small preview with progress bar more. Having instance break-down could be overwhelming for larger jobs. Owner, progress and elapsed time should be enough here saving the instance details wow factor for the update details page. Also, is there a sample page for an update with added instances? - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25158/#review51808 --- On Aug. 28, 2014, 6:13 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25158/ --- (Updated Aug. 28, 2014, 6:13 p.m.) Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-614 None Description --- Still working on trying to make the event timeline work, but going to show what I've got so far to get feedback. Will tidy up the code and post a review for it once I get a ship it for this. The main thing here is the instance status visualisation. I've mocked out data to show some use cases. Note: I have two job page versions here with a preview of an update in progress. Would be interested in getting feedback on which one people prefer. Diffs - Diff: https://reviews.apache.org/r/25158/diff/ Testing --- File Attachments Job Page with in progress update, using same template as update page https://reviews.apache.org/media/uploaded/files/2014/08/28/332fd237-eba5-4204-93e5-4e271f8b4f8c__job-page-in-progress-big-preview.png Job Update with smaller in progress update, and more conventional progress bar. https://reviews.apache.org/media/uploaded/files/2014/08/28/39f78052-348c-458c-956b-c3ba8ab1f642__job-progress-small-preview.png Update Page - medium sized job in progress https://reviews.apache.org/media/uploaded/files/2014/08/28/e6e7e5db-c5ff-4e68-a817-552243a706f5__update-page-in-progress-medium-job.png Update Page - Update completed view https://reviews.apache.org/media/uploaded/files/2014/08/28/fb8ed1c1-c90c-4c13-8464-6876ca811ad1__update-page-finished.png Update Page - partial update / canary view https://reviews.apache.org/media/uploaded/files/2014/08/28/ada5349c-84be-4838-9c20-cc99d5db3779__update-page-partial-canary.png Update Page - Update that has failed instances https://reviews.apache.org/media/uploaded/files/2014/08/28/7a8983f5-cc36-4219-ab9e-237680566c11__update-page-failures.png Update with skipped instances https://reviews.apache.org/media/uploaded/files/2014/08/28/d4283788-45b6-4564-9e9d-81327b8d3e06__update-page-skipped.png Update that had to be rolled back https://reviews.apache.org/media/uploaded/files/2014/08/28/0a968616-4199-4e34-bc37-3b66fff03eef__update-page-rolled-back.png Update where instances were removed https://reviews.apache.org/media/uploaded/files/2014/08/28/ca132beb-fcd4-4fe1-b682-6e229f632f45__update-page-instances-removed.png Update page - HUGE job, smaller viz https://reviews.apache.org/media/uploaded/files/2014/08/28/8e4d59f9-4644-46b7-a4b1-1a5de9538a80__update-page-huge-job.png Update Page - very small job https://reviews.apache.org/media/uploaded/files/2014/08/28/356db8be-e3d1-430a-ac35-3ff7f5855467__update-page-small-job.png Thanks, David McLaughlin
Re: Review Request 25133: Fixing race in task secondary index.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25133/#review51823 --- Ship it! Ship It! - Kevin Sweeney On Aug. 27, 2014, 6:19 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25133/ --- (Updated Aug. 27, 2014, 6:19 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-667 https://issues.apache.org/jira/browse/AURORA-667 Repository: aurora Description --- Synchronizing around index value retrieval. Unit test is mostly verifying general functionality under multhithreaded access. I was not able to repro this locally as doing so reliably would require refactoring that would not make sense otherwise. Diffs - src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java f2656de4d723c35a2d3fbe75d9aeb99a353423a2 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 6882c25399fb8c2e499f440ba205e5b0ba71d27a Diff: https://reviews.apache.org/r/25133/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24995: Adding support for a pre-update quota check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51824 --- src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java https://reviews.apache.org/r/24995/#comment90441 What's going on here? A comment explaining this formula would be helpful. - Kevin Sweeney On Aug. 22, 2014, 1:55 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/ --- (Updated Aug. 22, 2014, 1:55 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- First step towards checking quota in startJobUpdate RPC. The final thrift wiring is to follow. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 7a1a09b94cfe6d4b58ef4e6ab958b71c4be1e9bd src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 24145f52a17ec9b7458aa5578a5b99ef5b1cddab src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java f679f38f0fcff8abf2442cfcd885cd202ac55528 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java a0ef57ec8af2fd6993eda338da14d1f4346ed3a4 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java fa611a913bad40a8c0515c578b394c460340e574 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 997ade0be58723d1d91725061bb128ccf45e25b4 Diff: https://reviews.apache.org/r/24995/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24995: Adding support for a pre-update quota check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/ --- (Updated Aug. 28, 2014, 8:58 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Changes --- CR comments. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- First step towards checking quota in startJobUpdate RPC. The final thrift wiring is to follow. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 7a1a09b94cfe6d4b58ef4e6ab958b71c4be1e9bd src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 24145f52a17ec9b7458aa5578a5b99ef5b1cddab src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java f679f38f0fcff8abf2442cfcd885cd202ac55528 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java a0ef57ec8af2fd6993eda338da14d1f4346ed3a4 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java fa611a913bad40a8c0515c578b394c460340e574 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 997ade0be58723d1d91725061bb128ccf45e25b4 Diff: https://reviews.apache.org/r/24995/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24995: Adding support for a pre-update quota check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51837 --- src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java https://reviews.apache.org/r/24995/#comment90463 Rather than the deduped map would it make sense to take toKill: List[TaskConfig] - tasks to be killed toCreate: List[TaskConfig] - tasks to be created and return sum(toKill.resources if toKill.production) + freeResources sum(toCreate.resources if toCreate.production) Also, is the caller required to be in a write transaction for this to make sense? How does this function if there's a partial update in progress? - Kevin Sweeney On Aug. 28, 2014, 1:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/ --- (Updated Aug. 28, 2014, 1:58 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- First step towards checking quota in startJobUpdate RPC. The final thrift wiring is to follow. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 7a1a09b94cfe6d4b58ef4e6ab958b71c4be1e9bd src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 24145f52a17ec9b7458aa5578a5b99ef5b1cddab src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java f679f38f0fcff8abf2442cfcd885cd202ac55528 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java a0ef57ec8af2fd6993eda338da14d1f4346ed3a4 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java fa611a913bad40a8c0515c578b394c460340e574 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 997ade0be58723d1d91725061bb128ccf45e25b4 Diff: https://reviews.apache.org/r/24995/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24995: Adding support for a pre-update quota check.
On Aug. 28, 2014, 10:07 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 60 https://reviews.apache.org/r/24995/diff/2/?file=671531#file671531line60 Rather than the deduped map would it make sense to take toKill: List[TaskConfig] - tasks to be killed toCreate: List[TaskConfig] - tasks to be created and return sum(toKill.resources if toKill.production) + freeResources sum(toCreate.resources if toCreate.production) Also, is the caller required to be in a write transaction for this to make sense? How does this function if there's a partial update in progress? I thought about that but decided in favor of the current approach as the least involved from the quota validation standpoint. There will be some task diffing on the caller anyway where deduping would be a logical process of accumulating unique task configs. Besides, passing a list of new TaskConfigs seems rather unnatural. *Also, is the caller required to be in a write transaction for this to make sense?* Correct. See SchedulerCoreImpl.validateTaskLimits() description for example. *How does this function if there's a partial update in progress?* This method will serve both use cases: 1. Umbrella quota check before the update starts with both release and add parts provided. 2. Single instance add (from StateManager.insertPendingTasks) with only add part provided. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51837 --- On Aug. 28, 2014, 8:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/ --- (Updated Aug. 28, 2014, 8:58 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- First step towards checking quota in startJobUpdate RPC. The final thrift wiring is to follow. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 7a1a09b94cfe6d4b58ef4e6ab958b71c4be1e9bd src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 24145f52a17ec9b7458aa5578a5b99ef5b1cddab src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java f679f38f0fcff8abf2442cfcd885cd202ac55528 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java a0ef57ec8af2fd6993eda338da14d1f4346ed3a4 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java fa611a913bad40a8c0515c578b394c460340e574 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 997ade0be58723d1d91725061bb128ccf45e25b4 Diff: https://reviews.apache.org/r/24995/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24995: Adding support for a pre-update quota check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51845 --- Ship it! Ship It! - Kevin Sweeney On Aug. 28, 2014, 1:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/ --- (Updated Aug. 28, 2014, 1:58 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- First step towards checking quota in startJobUpdate RPC. The final thrift wiring is to follow. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 7a1a09b94cfe6d4b58ef4e6ab958b71c4be1e9bd src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 24145f52a17ec9b7458aa5578a5b99ef5b1cddab src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java f679f38f0fcff8abf2442cfcd885cd202ac55528 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java a0ef57ec8af2fd6993eda338da14d1f4346ed3a4 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java fa611a913bad40a8c0515c578b394c460340e574 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 997ade0be58723d1d91725061bb128ccf45e25b4 Diff: https://reviews.apache.org/r/24995/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/ --- Review request for Aurora. Bugs: AURORA-669 https://issues.apache.org/jira/browse/AURORA-669 Repository: aurora Description --- Fix possible deadlock in TaskRunner.collect_updates. Diffs - src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198 Diff: https://reviews.apache.org/r/25175/diff/ Testing --- Regression test y/n ? Thanks, Brian Wickman
