date:20150310

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/#review76037
---

Ship it!


Master (eb392b3) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 11, 2015, 2:53 a.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31913/
> ---
> 
> (Updated March 11, 2015, 2:53 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1181
> https://issues.apache.org/jira/browse/AURORA-1181
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added 'none' host maintenance grouping function.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/base.py 
> d550c8eeed91f0967e281957b71fcefb0b4cf3b8 
>   src/test/python/apache/aurora/client/test_base.py 
> 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 
> 
> Diff: https://reviews.apache.org/r/31913/diff/
> 
> 
> Testing
> ---
> 
> [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test 
> src/test/python/apache/aurora/client:base
> 
> 15:43:40 00:00 [main]
>(To run a reporting server: ./pants server)
> 15:43:40 00:00   [bootstrap]
> 15:43:40 00:00   [setup]
> 15:43:40 00:00 [parse]
>Executing tasks in goals: bootstrap -> imports -> unpack-jars 
> -> deferred-sources -> gen -> resolve -> compile -> resources -> test
> 15:43:40 00:00   [bootstrap]
> 15:43:40 00:00 [bootstrap-jvm-tools]
> 15:43:40 00:00   [imports]
> 15:43:40 00:00 [ivy-imports]
> 15:43:40 00:00   [unpack-jars]
> 15:43:40 00:00 [unpack-jars]
> 15:43:40 00:00   [deferred-sources]
> 15:43:40 00:00 [deferred-sources]
> 15:43:40 00:00   [gen]
> 15:43:40 00:00 [thrift]
> 15:43:40 00:00 [scrooge]
> 15:43:40 00:00 [protoc]
> 15:43:40 00:00 [antlr]
> 15:43:40 00:00 [ragel]
> 15:43:40 00:00 [jaxb]
> 15:43:40 00:00 [wire]
> 15:43:40 00:00 [aapt]
> 15:43:40 00:00   [resolve]
> 15:43:40 00:00 [ivy]
> 15:43:40 00:00   [compile]
> 15:43:40 00:00 [compile]
> 15:43:40 00:00 [jvm]
> 15:43:40 00:00   [jvm-compilers]
> 15:43:40 00:00   [resources]
> 15:43:40 00:00 [prepare]
> 15:43:40 00:00   [test]
> 15:43:40 00:00 [run_prep_command]
> 15:43:40 00:00 [test]
> 15:43:40 00:00 [pytest]
> 15:43:40 00:00   [run]
>  == test session starts ===
>  platform linux2 -- Python 2.7.8 -- py-1.4.26 -- 
> pytest-2.6.4
>  plugins: cov, timeout
>  collected 7 items 
>  
>  src/test/python/apache/aurora/client/test_base.py ...
>  
>   7 passed in 0.10 seconds 
>  
> 15:43:41 00:01 [junit]
> 15:43:41 00:01 [specs]
>SUCCESS
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread David Robinson


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/
---

(Updated March 11, 2015, 2:53 a.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
---

Maxim's feedback.


Bugs: AURORA-1181
https://issues.apache.org/jira/browse/AURORA-1181


Repository: aurora


Description
---

Added 'none' host maintenance grouping function.


Diffs (updated)
-

  src/main/python/apache/aurora/client/base.py 
d550c8eeed91f0967e281957b71fcefb0b4cf3b8 
  src/test/python/apache/aurora/client/test_base.py 
06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 

Diff: https://reviews.apache.org/r/31913/diff/


Testing
---

[drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test 
src/test/python/apache/aurora/client:base

15:43:40 00:00 [main]
   (To run a reporting server: ./pants server)
15:43:40 00:00   [bootstrap]
15:43:40 00:00   [setup]
15:43:40 00:00 [parse]
   Executing tasks in goals: bootstrap -> imports -> unpack-jars -> 
deferred-sources -> gen -> resolve -> compile -> resources -> test
15:43:40 00:00   [bootstrap]
15:43:40 00:00 [bootstrap-jvm-tools]
15:43:40 00:00   [imports]
15:43:40 00:00 [ivy-imports]
15:43:40 00:00   [unpack-jars]
15:43:40 00:00 [unpack-jars]
15:43:40 00:00   [deferred-sources]
15:43:40 00:00 [deferred-sources]
15:43:40 00:00   [gen]
15:43:40 00:00 [thrift]
15:43:40 00:00 [scrooge]
15:43:40 00:00 [protoc]
15:43:40 00:00 [antlr]
15:43:40 00:00 [ragel]
15:43:40 00:00 [jaxb]
15:43:40 00:00 [wire]
15:43:40 00:00 [aapt]
15:43:40 00:00   [resolve]
15:43:40 00:00 [ivy]
15:43:40 00:00   [compile]
15:43:40 00:00 [compile]
15:43:40 00:00 [jvm]
15:43:40 00:00   [jvm-compilers]
15:43:40 00:00   [resources]
15:43:40 00:00 [prepare]
15:43:40 00:00   [test]
15:43:40 00:00 [run_prep_command]
15:43:40 00:00 [test]
15:43:40 00:00 [pytest]
15:43:40 00:00   [run]
 == test session starts ===
 platform linux2 -- Python 2.7.8 -- py-1.4.26 -- 
pytest-2.6.4
 plugins: cov, timeout
 collected 7 items 
 
 src/test/python/apache/aurora/client/test_base.py ...
 
  7 passed in 0.10 seconds 
 
15:43:41 00:01 [junit]
15:43:41 00:01 [specs]
   SUCCESS


Thanks,

David Robinson

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Maxim Khutornenko



> On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, 
> > line 48
> > 
> >
> > Do we really want to fail an operation when a message gets too long? 
> > Since it's optional anyway, I'd expect truncation could be a more resilient 
> > way to handle this.
> 
> David McLaughlin wrote:
> I think it's better to just give a clear message telling them there is a 
> limit. Truncation could happen in the client if needed.
> 
> Maxim Khutornenko wrote:
> I was considering a case when some automated external service would 
> attempt to act on an update and append some arbitrary metadata with 
> pause/resume/abort. While not desirable, does not necessarily warrant a 
> failure. Stopping a misbehaving update should clearly be a higher priority 
> than enforcing a strict audit mode.
> 
> Bill Farner wrote:
> Maybe it does warrant a failure, though.  IMHO truncation would be a 
> policy decision that the scheduler is making on behalf of the client.  If the 
> most important part of the message is after the truncation, we've made a poor 
> choice.

IDK, this whole length enforcment seems quite arbitrary to me. We don't 
restrict string size anywhere in thrift API or SQL schema. The only exception 
is TaskIdGenerator where the ID length is critical for external reasons 
(MESOS-691). Perhaps we should start doing it everywhere then?


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76008
---


On March 11, 2015, 12:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31916/
> ---
> 
> (Updated March 11, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add scheduler API support for audit messages when changing job updates.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> badb8eec51d9034fdfee79061c777927b2ba1314 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  c0d48034ad6b6a91f1f58aca54544a5eddea4742 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  58824888a4839b71f4efa832a6d62ff6dd946e40 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  7f5e5c2091458192d9310a81314f3c2c42b11f49 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> eebe01b161fbebdc43e62df4836136a02c3d5fb7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e119c494de8e81d7e2dd1f78337f08dcba3cd518 
> 
> Diff: https://reviews.apache.org/r/31916/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Bill Farner



> On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, 
> > line 48
> > 
> >
> > Do we really want to fail an operation when a message gets too long? 
> > Since it's optional anyway, I'd expect truncation could be a more resilient 
> > way to handle this.
> 
> David McLaughlin wrote:
> I think it's better to just give a clear message telling them there is a 
> limit. Truncation could happen in the client if needed.
> 
> Maxim Khutornenko wrote:
> I was considering a case when some automated external service would 
> attempt to act on an update and append some arbitrary metadata with 
> pause/resume/abort. While not desirable, does not necessarily warrant a 
> failure. Stopping a misbehaving update should clearly be a higher priority 
> than enforcing a strict audit mode.

Maybe it does warrant a failure, though.  IMHO truncation would be a policy 
decision that the scheduler is making on behalf of the client.  If the most 
important part of the message is after the truncation, we've made a poor choice.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76008
---


On March 11, 2015, 12:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31916/
> ---
> 
> (Updated March 11, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add scheduler API support for audit messages when changing job updates.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> badb8eec51d9034fdfee79061c777927b2ba1314 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  c0d48034ad6b6a91f1f58aca54544a5eddea4742 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  58824888a4839b71f4efa832a6d62ff6dd946e40 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  7f5e5c2091458192d9310a81314f3c2c42b11f49 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> eebe01b161fbebdc43e62df4836136a02c3d5fb7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e119c494de8e81d7e2dd1f78337f08dcba3cd518 
> 
> Diff: https://reviews.apache.org/r/31916/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31570: Suppressing duplicate update instance events.

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/#review76025
---


Master (b53e023) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.cli.plugins   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.quota 
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.sla   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.supdate   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.task  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.update
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.version   
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.factory   
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 src.test.python.apache.aurora.config.test_base 
 .   SUCCESS
 
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
 src.test.python.apache.aurora.config.test_loader   
 .   SUCCESS
 src.test.python.apache.aurora.config.test_thrift   
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   FAILURE
 src.test.python.apache.thermos.cli.commands.commands   
 .   SUCCESS
 src.test.python.apache.thermos.cli.common  
 .   SUCCESS
 src.test.python.apache.thermos.cli.main
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE

[31m
   FAILURE[0m


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31570/
> ---
> 
> (Updated March 11, 2015, 12:19 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76022
---

Ship it!


Master (b53e023) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 11, 2015, 12:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31916/
> ---
> 
> (Updated March 11, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add scheduler API support for audit messages when changing job updates.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> badb8eec51d9034fdfee79061c777927b2ba1314 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  c0d48034ad6b6a91f1f58aca54544a5eddea4742 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  58824888a4839b71f4efa832a6d62ff6dd946e40 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  7f5e5c2091458192d9310a81314f3c2c42b11f49 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> eebe01b161fbebdc43e62df4836136a02c3d5fb7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e119c494de8e81d7e2dd1f78337f08dcba3cd518 
> 
> Diff: https://reviews.apache.org/r/31916/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review76019
---

Ship it!


Master (b53e023) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 11, 2015, 12:26 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31869/
> ---
> 
> (Updated March 11, 2015, 12:26 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1176
> https://issues.apache.org/jira/browse/AURORA-1176
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> As indicated by some changes in tests - there were legitimate issues hiding 
> behind this catch.  After this change, the client will allow unhandled 
> exceptions to surface in their full glory.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 194629f61192c1d7d5e7064e9226adf26d03e890 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 286b2182d5fe25703882f0b367739ad03d6c8fe8 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 459d157155f74b6a3d140b85d3b7f0364367 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 7aad34a2fe5591937c5bca890751073439e3a1a6 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 1806769426a196793481f948892f5474df8dd665 
>   src/test/python/apache/aurora/client/cli/util.py 
> b65970a2717a1f36767c61e5e09c980b04895f01 
> 
> Diff: https://reviews.apache.org/r/31869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Maxim Khutornenko



> On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, 
> > line 48
> > 
> >
> > Do we really want to fail an operation when a message gets too long? 
> > Since it's optional anyway, I'd expect truncation could be a more resilient 
> > way to handle this.
> 
> David McLaughlin wrote:
> I think it's better to just give a clear message telling them there is a 
> limit. Truncation could happen in the client if needed.

I was considering a case when some automated external service would attempt to 
act on an update and append some arbitrary metadata with pause/resume/abort. 
While not desirable, does not necessarily warrant a failure. Stopping a 
misbehaving update should clearly be a higher priority than enforcing a strict 
audit mode.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76008
---


On March 11, 2015, 12:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31916/
> ---
> 
> (Updated March 11, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add scheduler API support for audit messages when changing job updates.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> badb8eec51d9034fdfee79061c777927b2ba1314 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  c0d48034ad6b6a91f1f58aca54544a5eddea4742 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  58824888a4839b71f4efa832a6d62ff6dd946e40 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  7f5e5c2091458192d9310a81314f3c2c42b11f49 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> eebe01b161fbebdc43e62df4836136a02c3d5fb7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e119c494de8e81d7e2dd1f78337f08dcba3cd518 
> 
> Diff: https://reviews.apache.org/r/31916/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---

(Updated March 11, 2015, 12:26 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-1176
https://issues.apache.org/jira/browse/AURORA-1176


Repository: aurora


Description
---

As indicated by some changes in tests - there were legitimate issues hiding 
behind this catch.  After this change, the client will allow unhandled 
exceptions to surface in their full glory.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
194629f61192c1d7d5e7064e9226adf26d03e890 
  src/main/python/apache/aurora/client/cli/__init__.py 
4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
  src/main/python/apache/aurora/client/cli/jobs.py 
286b2182d5fe25703882f0b367739ad03d6c8fe8 
  src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
  src/test/python/apache/aurora/client/cli/test_create.py 
459d157155f74b6a3d140b85d3b7f0364367 
  src/test/python/apache/aurora/client/cli/test_kill.py 
7aad34a2fe5591937c5bca890751073439e3a1a6 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
1806769426a196793481f948892f5474df8dd665 
  src/test/python/apache/aurora/client/cli/util.py 
b65970a2717a1f36767c61e5e09c980b04895f01 

Diff: https://reviews.apache.org/r/31869/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread David McLaughlin



> On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, 
> > line 48
> > 
> >
> > Do we really want to fail an operation when a message gets too long? 
> > Since it's optional anyway, I'd expect truncation could be a more resilient 
> > way to handle this.

I think it's better to just give a clear message telling them there is a limit. 
Truncation could happen in the client if needed.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76008
---


On March 11, 2015, 12:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31916/
> ---
> 
> (Updated March 11, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add scheduler API support for audit messages when changing job updates.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> badb8eec51d9034fdfee79061c777927b2ba1314 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  c0d48034ad6b6a91f1f58aca54544a5eddea4742 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  58824888a4839b71f4efa832a6d62ff6dd946e40 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  7f5e5c2091458192d9310a81314f3c2c42b11f49 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> eebe01b161fbebdc43e62df4836136a02c3d5fb7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e119c494de8e81d7e2dd1f78337f08dcba3cd518 
> 
> Diff: https://reviews.apache.org/r/31916/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31918: Improve response logging in TRequestsTransport

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31918/#review76013
---

Ship it!


Master (b53e023) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 11, 2015, 12:05 a.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31918/
> ---
> 
> (Updated March 11, 2015, 12:05 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve response logging in TRequestsTransport
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/BUILD 
> 1fe703ffdadd3edd6787f5ac74249f4c87b95a64 
>   src/main/python/apache/aurora/common/transport.py 
> a5fd7c0eb02212a1e810d7101c2765b59d0f3de4 
>   src/test/python/apache/aurora/common/test_transport.py 
> 49a4d6975161d49df90257326825ae7774aeb3ab 
> 
> Diff: https://reviews.apache.org/r/31918/diff/
> 
> 
> Testing
> ---
> 
> ```
>  == test session starts ===
>  platform darwin -- Python 2.7.6 -- py-1.4.26 -- 
> pytest-2.6.4
>  plugins: cov, timeout
>  collected 7 items 
>  
>  src/test/python/apache/aurora/common/test_transport.py 
> ...
>  
>   7 passed in 0.74 seconds 
>  
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76008
---



src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java


Do we really want to fail an operation when a message gets too long? Since 
it's optional anyway, I'd expect truncation could be a more resilient way to 
handle this.


- Maxim Khutornenko


On March 11, 2015, 12:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31916/
> ---
> 
> (Updated March 11, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add scheduler API support for audit messages when changing job updates.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> badb8eec51d9034fdfee79061c777927b2ba1314 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  c0d48034ad6b6a91f1f58aca54544a5eddea4742 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  58824888a4839b71f4efa832a6d62ff6dd946e40 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  7f5e5c2091458192d9310a81314f3c2c42b11f49 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> eebe01b161fbebdc43e62df4836136a02c3d5fb7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e119c494de8e81d7e2dd1f78337f08dcba3cd518 
> 
> Diff: https://reviews.apache.org/r/31916/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31570: Suppressing duplicate update instance events.

2015-03-10 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/
---

(Updated March 11, 2015, 12:19 a.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Changes
---

Rebased.


Bugs: AURORA-1097
https://issues.apache.org/jira/browse/AURORA-1097


Repository: aurora


Description
---

All instance update actions are supposed to be unique. Suppressing duplicats 
due to pause/resume cycle.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
58824888a4839b71f4efa832a6d62ff6dd946e40 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
e119c494de8e81d7e2dd1f78337f08dcba3cd518 

Diff: https://reviews.apache.org/r/31570/diff/


Testing
---

./gradlew -Pq build
Manual testing in vagrant.


Thanks,

Maxim Khutornenko

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review76007
---

Ship it!


LGTM once `self` or `cls` are used in place of class names.

- Kevin Sweeney


On March 10, 2015, 5:17 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31869/
> ---
> 
> (Updated March 10, 2015, 5:17 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1176
> https://issues.apache.org/jira/browse/AURORA-1176
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> As indicated by some changes in tests - there were legitimate issues hiding 
> behind this catch.  After this change, the client will allow unhandled 
> exceptions to surface in their full glory.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 194629f61192c1d7d5e7064e9226adf26d03e890 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 286b2182d5fe25703882f0b367739ad03d6c8fe8 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 459d157155f74b6a3d140b85d3b7f0364367 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 7aad34a2fe5591937c5bca890751073439e3a1a6 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 1806769426a196793481f948892f5474df8dd665 
>   src/test/python/apache/aurora/client/cli/util.py 
> b65970a2717a1f36767c61e5e09c980b04895f01 
> 
> Diff: https://reviews.apache.org/r/31869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Kevin Sweeney



> On March 10, 2015, 5:08 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 282
> > 
> >
> > My understanding was that zmanji was attempting to remove 
> > AuroraCommandContext and patch print instead. Perhaps you and him should 
> > come to a consensus.
> 
> Bill Farner wrote:
> Did he not express agreement by giving a ship-it on this diff?
> 
> Zameer Manji wrote:
> We can address that problem another time. Consistent use of context and 
> print_error will help solve that problem later.

Aha didn't see that. Carry on then.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75980
---


On March 10, 2015, 5:17 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31869/
> ---
> 
> (Updated March 10, 2015, 5:17 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1176
> https://issues.apache.org/jira/browse/AURORA-1176
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> As indicated by some changes in tests - there were legitimate issues hiding 
> behind this catch.  After this change, the client will allow unhandled 
> exceptions to surface in their full glory.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 194629f61192c1d7d5e7064e9226adf26d03e890 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 286b2182d5fe25703882f0b367739ad03d6c8fe8 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 459d157155f74b6a3d140b85d3b7f0364367 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 7aad34a2fe5591937c5bca890751073439e3a1a6 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 1806769426a196793481f948892f5474df8dd665 
>   src/test/python/apache/aurora/client/cli/util.py 
> b65970a2717a1f36767c61e5e09c980b04895f01 
> 
> Diff: https://reviews.apache.org/r/31869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---

(Updated March 11, 2015, 12:17 a.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-1176
https://issues.apache.org/jira/browse/AURORA-1176


Repository: aurora


Description
---

As indicated by some changes in tests - there were legitimate issues hiding 
behind this catch.  After this change, the client will allow unhandled 
exceptions to surface in their full glory.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
194629f61192c1d7d5e7064e9226adf26d03e890 
  src/main/python/apache/aurora/client/cli/__init__.py 
4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
  src/main/python/apache/aurora/client/cli/jobs.py 
286b2182d5fe25703882f0b367739ad03d6c8fe8 
  src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
  src/test/python/apache/aurora/client/cli/test_create.py 
459d157155f74b6a3d140b85d3b7f0364367 
  src/test/python/apache/aurora/client/cli/test_kill.py 
7aad34a2fe5591937c5bca890751073439e3a1a6 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
1806769426a196793481f948892f5474df8dd665 
  src/test/python/apache/aurora/client/cli/util.py 
b65970a2717a1f36767c61e5e09c980b04895f01 

Diff: https://reviews.apache.org/r/31869/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Zameer Manji



> On March 10, 2015, 5:08 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 282
> > 
> >
> > My understanding was that zmanji was attempting to remove 
> > AuroraCommandContext and patch print instead. Perhaps you and him should 
> > come to a consensus.
> 
> Bill Farner wrote:
> Did he not express agreement by giving a ship-it on this diff?

We can address that problem another time. Consistent use of context and 
print_error will help solve that problem later.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75980
---


On March 10, 2015, 10:44 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31869/
> ---
> 
> (Updated March 10, 2015, 10:44 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1176
> https://issues.apache.org/jira/browse/AURORA-1176
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> As indicated by some changes in tests - there were legitimate issues hiding 
> behind this catch.  After this change, the client will allow unhandled 
> exceptions to surface in their full glory.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 194629f61192c1d7d5e7064e9226adf26d03e890 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 286b2182d5fe25703882f0b367739ad03d6c8fe8 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 459d157155f74b6a3d140b85d3b7f0364367 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 7aad34a2fe5591937c5bca890751073439e3a1a6 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 1806769426a196793481f948892f5474df8dd665 
>   src/test/python/apache/aurora/client/cli/util.py 
> b65970a2717a1f36767c61e5e09c980b04895f01 
> 
> Diff: https://reviews.apache.org/r/31869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76004
---

Ship it!


Ship It!

- David McLaughlin


On March 11, 2015, 12:04 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31916/
> ---
> 
> (Updated March 11, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add scheduler API support for audit messages when changing job updates.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> badb8eec51d9034fdfee79061c777927b2ba1314 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  c0d48034ad6b6a91f1f58aca54544a5eddea4742 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  58824888a4839b71f4efa832a6d62ff6dd946e40 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  7f5e5c2091458192d9310a81314f3c2c42b11f49 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> eebe01b161fbebdc43e62df4836136a02c3d5fb7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e119c494de8e81d7e2dd1f78337f08dcba3cd518 
> 
> Diff: https://reviews.apache.org/r/31916/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Bill Farner



> On March 11, 2015, 12:08 a.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 282
> > 
> >
> > My understanding was that zmanji was attempting to remove 
> > AuroraCommandContext and patch print instead. Perhaps you and him should 
> > come to a consensus.

Did he not express agreement by giving a ship-it on this diff?


> On March 11, 2015, 12:08 a.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/api/__init__.py, line 134
> > 
> >
> > Revert this - self will correctly find the class field.

Done.


> On March 11, 2015, 12:08 a.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 681
> > 
> >
> > revert to use self so that subclass delegation will work.

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75980
---


On March 10, 2015, 5:44 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31869/
> ---
> 
> (Updated March 10, 2015, 5:44 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1176
> https://issues.apache.org/jira/browse/AURORA-1176
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> As indicated by some changes in tests - there were legitimate issues hiding 
> behind this catch.  After this change, the client will allow unhandled 
> exceptions to surface in their full glory.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 194629f61192c1d7d5e7064e9226adf26d03e890 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 286b2182d5fe25703882f0b367739ad03d6c8fe8 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 459d157155f74b6a3d140b85d3b7f0364367 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 7aad34a2fe5591937c5bca890751073439e3a1a6 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 1806769426a196793481f948892f5474df8dd665 
>   src/test/python/apache/aurora/client/cli/util.py 
> b65970a2717a1f36767c61e5e09c980b04895f01 
> 
> Diff: https://reviews.apache.org/r/31869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31918: Improve response logging in TRequestsTransport

2015-03-10 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31918/#review76002
---

Ship it!


Ship It!

- Zameer Manji


On March 10, 2015, 5:05 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31918/
> ---
> 
> (Updated March 10, 2015, 5:05 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Improve response logging in TRequestsTransport
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/BUILD 
> 1fe703ffdadd3edd6787f5ac74249f4c87b95a64 
>   src/main/python/apache/aurora/common/transport.py 
> a5fd7c0eb02212a1e810d7101c2765b59d0f3de4 
>   src/test/python/apache/aurora/common/test_transport.py 
> 49a4d6975161d49df90257326825ae7774aeb3ab 
> 
> Diff: https://reviews.apache.org/r/31918/diff/
> 
> 
> Testing
> ---
> 
> ```
>  == test session starts ===
>  platform darwin -- Python 2.7.6 -- py-1.4.26 -- 
> pytest-2.6.4
>  plugins: cov, timeout
>  collected 7 items 
>  
>  src/test/python/apache/aurora/common/test_transport.py 
> ...
>  
>   7 passed in 0.74 seconds 
>  
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75980
---



src/main/python/apache/aurora/client/api/__init__.py


Revert this - self will correctly find the class field.



src/main/python/apache/aurora/client/cli/__init__.py


My understanding was that zmanji was attempting to remove 
AuroraCommandContext and patch print instead. Perhaps you and him should come 
to a consensus.



src/main/python/apache/aurora/client/cli/jobs.py


revert to use self so that subclass delegation will work.


- Kevin Sweeney


On March 10, 2015, 10:44 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31869/
> ---
> 
> (Updated March 10, 2015, 10:44 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1176
> https://issues.apache.org/jira/browse/AURORA-1176
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> As indicated by some changes in tests - there were legitimate issues hiding 
> behind this catch.  After this change, the client will allow unhandled 
> exceptions to surface in their full glory.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 194629f61192c1d7d5e7064e9226adf26d03e890 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 286b2182d5fe25703882f0b367739ad03d6c8fe8 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 459d157155f74b6a3d140b85d3b7f0364367 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 7aad34a2fe5591937c5bca890751073439e3a1a6 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 1806769426a196793481f948892f5474df8dd665 
>   src/test/python/apache/aurora/client/cli/util.py 
> b65970a2717a1f36767c61e5e09c980b04895f01 
> 
> Diff: https://reviews.apache.org/r/31869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/#review75997
---



src/main/python/apache/aurora/client/base.py


This will actually fail upstream in host_maintenance.py when it tries to 
sort by group:
```
>>> d = defaultdict(set)
>>> d[None].add(1)
>>> d[None].add(2)
>>> s = sorted(d, key=lambda v: v[0])
Traceback (most recent call last):
  File "", line 1, in 
  File "", line 1, in 
TypeError: 'NoneType' object has no attribute '__getitem__'
```

Please, add a typed default grouping (e.g. "ALL") and a correspondent test 
in test_host_maintenance.py.


- Maxim Khutornenko


On March 10, 2015, 10:44 p.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31913/
> ---
> 
> (Updated March 10, 2015, 10:44 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1181
> https://issues.apache.org/jira/browse/AURORA-1181
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added 'none' host maintenance grouping function.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/base.py 
> d550c8eeed91f0967e281957b71fcefb0b4cf3b8 
>   src/test/python/apache/aurora/client/test_base.py 
> 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 
> 
> Diff: https://reviews.apache.org/r/31913/diff/
> 
> 
> Testing
> ---
> 
> [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test 
> src/test/python/apache/aurora/client:base
> 
> 15:43:40 00:00 [main]
>(To run a reporting server: ./pants server)
> 15:43:40 00:00   [bootstrap]
> 15:43:40 00:00   [setup]
> 15:43:40 00:00 [parse]
>Executing tasks in goals: bootstrap -> imports -> unpack-jars 
> -> deferred-sources -> gen -> resolve -> compile -> resources -> test
> 15:43:40 00:00   [bootstrap]
> 15:43:40 00:00 [bootstrap-jvm-tools]
> 15:43:40 00:00   [imports]
> 15:43:40 00:00 [ivy-imports]
> 15:43:40 00:00   [unpack-jars]
> 15:43:40 00:00 [unpack-jars]
> 15:43:40 00:00   [deferred-sources]
> 15:43:40 00:00 [deferred-sources]
> 15:43:40 00:00   [gen]
> 15:43:40 00:00 [thrift]
> 15:43:40 00:00 [scrooge]
> 15:43:40 00:00 [protoc]
> 15:43:40 00:00 [antlr]
> 15:43:40 00:00 [ragel]
> 15:43:40 00:00 [jaxb]
> 15:43:40 00:00 [wire]
> 15:43:40 00:00 [aapt]
> 15:43:40 00:00   [resolve]
> 15:43:40 00:00 [ivy]
> 15:43:40 00:00   [compile]
> 15:43:40 00:00 [compile]
> 15:43:40 00:00 [jvm]
> 15:43:40 00:00   [jvm-compilers]
> 15:43:40 00:00   [resources]
> 15:43:40 00:00 [prepare]
> 15:43:40 00:00   [test]
> 15:43:40 00:00 [run_prep_command]
> 15:43:40 00:00 [test]
> 15:43:40 00:00 [pytest]
> 15:43:40 00:00   [run]
>  == test session starts ===
>  platform linux2 -- Python 2.7.8 -- py-1.4.26 -- 
> pytest-2.6.4
>  plugins: cov, timeout
>  collected 7 items 
>  
>  src/test/python/apache/aurora/client/test_base.py ...
>  
>   7 passed in 0.10 seconds 
>  
> 15:43:41 00:01 [junit]
> 15:43:41 00:01 [specs]
>SUCCESS
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Review Request 31918: Improve response logging in TRequestsTransport

2015-03-10 Thread Joe Smith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31918/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

Improve response logging in TRequestsTransport


Diffs
-

  src/main/python/apache/aurora/common/BUILD 
1fe703ffdadd3edd6787f5ac74249f4c87b95a64 
  src/main/python/apache/aurora/common/transport.py 
a5fd7c0eb02212a1e810d7101c2765b59d0f3de4 
  src/test/python/apache/aurora/common/test_transport.py 
49a4d6975161d49df90257326825ae7774aeb3ab 

Diff: https://reviews.apache.org/r/31918/diff/


Testing
---

```
 == test session starts ===
 platform darwin -- Python 2.7.6 -- py-1.4.26 -- 
pytest-2.6.4
 plugins: cov, timeout
 collected 7 items 
 
 src/test/python/apache/aurora/common/test_transport.py 
...
 
  7 passed in 0.74 seconds 
 
```


Thanks,

Joe Smith

Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-10 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/
---

Review request for Aurora, David McLaughlin and Joshua Cohen.


Bugs: AURORA-1077
https://issues.apache.org/jira/browse/AURORA-1077


Repository: aurora


Description
---

Add scheduler API support for audit messages when changing job updates.


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
badb8eec51d9034fdfee79061c777927b2ba1314 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
c0d48034ad6b6a91f1f58aca54544a5eddea4742 
  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
58824888a4839b71f4efa832a6d62ff6dd946e40 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 7f5e5c2091458192d9310a81314f3c2c42b11f49 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
eebe01b161fbebdc43e62df4836136a02c3d5fb7 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
e119c494de8e81d7e2dd1f78337f08dcba3cd518 

Diff: https://reviews.apache.org/r/31916/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 31901: Export task status reason counters whenever they are present.

2015-03-10 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31901/#review75994
---

Ship it!


Ship It!

- Maxim Khutornenko


On March 10, 2015, 6 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31901/
> ---
> 
> (Updated March 10, 2015, 6 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I realized that the reason values apply to more than just TASK_LOST, so the 
> previous code would hide reasons like when a task has exceeded its memory 
> limit.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java 
> 68214f20dd7f46adec2d8f6d84e9840dc88dc0fb 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java 
> 4bbeff957050fb9d8ee81d9fc79520a6a0ac38a1 
> 
> Diff: https://reviews.apache.org/r/31901/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/#review75989
---

Ship it!


Master (48dc4c7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2015, 10:44 p.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31913/
> ---
> 
> (Updated March 10, 2015, 10:44 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1181
> https://issues.apache.org/jira/browse/AURORA-1181
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added 'none' host maintenance grouping function.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/base.py 
> d550c8eeed91f0967e281957b71fcefb0b4cf3b8 
>   src/test/python/apache/aurora/client/test_base.py 
> 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 
> 
> Diff: https://reviews.apache.org/r/31913/diff/
> 
> 
> Testing
> ---
> 
> [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test 
> src/test/python/apache/aurora/client:base
> 
> 15:43:40 00:00 [main]
>(To run a reporting server: ./pants server)
> 15:43:40 00:00   [bootstrap]
> 15:43:40 00:00   [setup]
> 15:43:40 00:00 [parse]
>Executing tasks in goals: bootstrap -> imports -> unpack-jars 
> -> deferred-sources -> gen -> resolve -> compile -> resources -> test
> 15:43:40 00:00   [bootstrap]
> 15:43:40 00:00 [bootstrap-jvm-tools]
> 15:43:40 00:00   [imports]
> 15:43:40 00:00 [ivy-imports]
> 15:43:40 00:00   [unpack-jars]
> 15:43:40 00:00 [unpack-jars]
> 15:43:40 00:00   [deferred-sources]
> 15:43:40 00:00 [deferred-sources]
> 15:43:40 00:00   [gen]
> 15:43:40 00:00 [thrift]
> 15:43:40 00:00 [scrooge]
> 15:43:40 00:00 [protoc]
> 15:43:40 00:00 [antlr]
> 15:43:40 00:00 [ragel]
> 15:43:40 00:00 [jaxb]
> 15:43:40 00:00 [wire]
> 15:43:40 00:00 [aapt]
> 15:43:40 00:00   [resolve]
> 15:43:40 00:00 [ivy]
> 15:43:40 00:00   [compile]
> 15:43:40 00:00 [compile]
> 15:43:40 00:00 [jvm]
> 15:43:40 00:00   [jvm-compilers]
> 15:43:40 00:00   [resources]
> 15:43:40 00:00 [prepare]
> 15:43:40 00:00   [test]
> 15:43:40 00:00 [run_prep_command]
> 15:43:40 00:00 [test]
> 15:43:40 00:00 [pytest]
> 15:43:40 00:00   [run]
>  == test session starts ===
>  platform linux2 -- Python 2.7.8 -- py-1.4.26 -- 
> pytest-2.6.4
>  plugins: cov, timeout
>  collected 7 items 
>  
>  src/test/python/apache/aurora/client/test_base.py ...
>  
>   7 passed in 0.10 seconds 
>  
> 15:43:41 00:01 [junit]
> 15:43:41 00:01 [specs]
>SUCCESS
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread David Robinson


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/
---

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-1181
https://issues.apache.org/jira/browse/AURORA-1181


Repository: aurora


Description
---

Added 'none' host maintenance grouping function.


Diffs
-

  src/main/python/apache/aurora/client/base.py 
d550c8eeed91f0967e281957b71fcefb0b4cf3b8 
  src/test/python/apache/aurora/client/test_base.py 
06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 

Diff: https://reviews.apache.org/r/31913/diff/


Testing
---

[drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test 
src/test/python/apache/aurora/client:base

15:43:40 00:00 [main]
   (To run a reporting server: ./pants server)
15:43:40 00:00   [bootstrap]
15:43:40 00:00   [setup]
15:43:40 00:00 [parse]
   Executing tasks in goals: bootstrap -> imports -> unpack-jars -> 
deferred-sources -> gen -> resolve -> compile -> resources -> test
15:43:40 00:00   [bootstrap]
15:43:40 00:00 [bootstrap-jvm-tools]
15:43:40 00:00   [imports]
15:43:40 00:00 [ivy-imports]
15:43:40 00:00   [unpack-jars]
15:43:40 00:00 [unpack-jars]
15:43:40 00:00   [deferred-sources]
15:43:40 00:00 [deferred-sources]
15:43:40 00:00   [gen]
15:43:40 00:00 [thrift]
15:43:40 00:00 [scrooge]
15:43:40 00:00 [protoc]
15:43:40 00:00 [antlr]
15:43:40 00:00 [ragel]
15:43:40 00:00 [jaxb]
15:43:40 00:00 [wire]
15:43:40 00:00 [aapt]
15:43:40 00:00   [resolve]
15:43:40 00:00 [ivy]
15:43:40 00:00   [compile]
15:43:40 00:00 [compile]
15:43:40 00:00 [jvm]
15:43:40 00:00   [jvm-compilers]
15:43:40 00:00   [resources]
15:43:40 00:00 [prepare]
15:43:40 00:00   [test]
15:43:40 00:00 [run_prep_command]
15:43:40 00:00 [test]
15:43:40 00:00 [pytest]
15:43:40 00:00   [run]
 == test session starts ===
 platform linux2 -- Python 2.7.8 -- py-1.4.26 -- 
pytest-2.6.4
 plugins: cov, timeout
 collected 7 items 
 
 src/test/python/apache/aurora/client/test_base.py ...
 
  7 passed in 0.10 seconds 
 
15:43:41 00:01 [junit]
15:43:41 00:01 [specs]
   SUCCESS


Thanks,

David Robinson

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75959
---

Ship it!


Master (48dc4c7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2015, 7:45 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31820/
> ---
> 
> (Updated March 10, 2015, 7:45 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-809 and AURORA-811
> https://issues.apache.org/jira/browse/AURORA-809
> https://issues.apache.org/jira/browse/AURORA-811
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> * Add dependency on Apache Shiro.
> * HTTP Basic Authentication.
> * Authorization based on shiro.ini.
> * Sample shiro.ini for local mode.
> 
> 
> Diffs
> -
> 
>   build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 24b61c1e4f615295acf28d904588e1512972d3f4 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 8a59d89c07b406ce98076ca7ee51b958599a39ec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 
> 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> 1e4ba014804b56a2ea02770d09beb63faaabf684 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 640acdf4e73f99418473ca97bcdc4f5f4c190f10 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 
> 52fe0ea063dbc7a71a20926630bf449dbd936306 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31820/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> Local testing in the UI and with cURL.
> 
> Updates to e2e test and Vagrant environment to follow.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75954
---

Ship it!


Ship It!

- Bill Farner


On March 10, 2015, 7:45 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31820/
> ---
> 
> (Updated March 10, 2015, 7:45 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-809 and AURORA-811
> https://issues.apache.org/jira/browse/AURORA-809
> https://issues.apache.org/jira/browse/AURORA-811
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> * Add dependency on Apache Shiro.
> * HTTP Basic Authentication.
> * Authorization based on shiro.ini.
> * Sample shiro.ini for local mode.
> 
> 
> Diffs
> -
> 
>   build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 24b61c1e4f615295acf28d904588e1512972d3f4 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 8a59d89c07b406ce98076ca7ee51b958599a39ec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 
> 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> 1e4ba014804b56a2ea02770d09beb63faaabf684 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 640acdf4e73f99418473ca97bcdc4f5f4c190f10 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 
> 52fe0ea063dbc7a71a20926630bf449dbd936306 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31820/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> Local testing in the UI and with cURL.
> 
> Updates to e2e test and Vagrant environment to follow.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/
---

(Updated March 10, 2015, 12:45 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Josh's feedback.


Bugs: AURORA-809 and AURORA-811
https://issues.apache.org/jira/browse/AURORA-809
https://issues.apache.org/jira/browse/AURORA-811


Repository: aurora


Description
---

* Add dependency on Apache Shiro.
* HTTP Basic Authentication.
* Authorization based on shiro.ini.
* Sample shiro.ini for local mode.


Diffs (updated)
-

  build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
24b61c1e4f615295acf28d904588e1512972d3f4 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
8a59d89c07b406ce98076ca7ee51b958599a39ec 
  src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
 PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 
3e7483b1e4e674397fd093f1e301d9cb2d3ca166 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
1e4ba014804b56a2ea02770d09beb63faaabf684 
  src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
640acdf4e73f99418473ca97bcdc4f5f4c190f10 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java
 PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java
 PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 
52fe0ea063dbc7a71a20926630bf449dbd936306 
  
src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini
 PRE-CREATION 
  
src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini
 PRE-CREATION 
  
src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini
 PRE-CREATION 

Diff: https://reviews.apache.org/r/31820/diff/


Testing
---

./gradlew -Pq build

Local testing in the UI and with cURL.

Updates to e2e test and Vagrant environment to follow.


Thanks,

Kevin Sweeney

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Kevin Sweeney



> On March 10, 2015, 11:48 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java,
> >  lines 59-62
> > 
> >
> > Maybe move this to the ticket and kill the commented out code here?

Done.


> On March 10, 2015, 11:48 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java,
> >  lines 38-39
> > 
> >
> > nit: probably preferable to move ImmutableSortedSet.of down to the next 
> > line.

Fixed.


> On March 10, 2015, 11:48 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/common/clusters.py, line 92
> > 
> >
> > Is this change related?

Not sure what happened, rebased.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75926
---


On March 10, 2015, 12:45 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31820/
> ---
> 
> (Updated March 10, 2015, 12:45 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-809 and AURORA-811
> https://issues.apache.org/jira/browse/AURORA-809
> https://issues.apache.org/jira/browse/AURORA-811
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> * Add dependency on Apache Shiro.
> * HTTP Basic Authentication.
> * Authorization based on shiro.ini.
> * Sample shiro.ini for local mode.
> 
> 
> Diffs
> -
> 
>   build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 24b61c1e4f615295acf28d904588e1512972d3f4 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 8a59d89c07b406ce98076ca7ee51b958599a39ec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 
> 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> 1e4ba014804b56a2ea02770d09beb63faaabf684 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 640acdf4e73f99418473ca97bcdc4f5f4c190f10 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 
> 52fe0ea063dbc7a71a20926630bf449dbd936306 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31820/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> Local testing in the UI and with cURL.
> 
> Updates to e2e test and Vagrant environment to follow.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75929
---

Ship it!


Master (48dc4c7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2015, 5:44 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31869/
> ---
> 
> (Updated March 10, 2015, 5:44 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1176
> https://issues.apache.org/jira/browse/AURORA-1176
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> As indicated by some changes in tests - there were legitimate issues hiding 
> behind this catch.  After this change, the client will allow unhandled 
> exceptions to surface in their full glory.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 194629f61192c1d7d5e7064e9226adf26d03e890 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 286b2182d5fe25703882f0b367739ad03d6c8fe8 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 459d157155f74b6a3d140b85d3b7f0364367 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 7aad34a2fe5591937c5bca890751073439e3a1a6 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 1806769426a196793481f948892f5474df8dd665 
>   src/test/python/apache/aurora/client/cli/util.py 
> b65970a2717a1f36767c61e5e09c980b04895f01 
> 
> Diff: https://reviews.apache.org/r/31869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31901: Export task status reason counters whenever they are present.

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31901/#review75923
---

Ship it!


Master (48dc4c7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2015, 6 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31901/
> ---
> 
> (Updated March 10, 2015, 6 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I realized that the reason values apply to more than just TASK_LOST, so the 
> previous code would hide reasons like when a task has exceeded its memory 
> limit.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java 
> 68214f20dd7f46adec2d8f6d84e9840dc88dc0fb 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java 
> 4bbeff957050fb9d8ee81d9fc79520a6a0ac38a1 
> 
> Diff: https://reviews.apache.org/r/31901/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31901: Export task status reason counters whenever they are present.

2015-03-10 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31901/
---

(Updated March 10, 2015, 6 p.m.)


Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

I realized that the reason values apply to more than just TASK_LOST, so the 
previous code would hide reasons like when a task has exceeded its memory limit.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java 
68214f20dd7f46adec2d8f6d84e9840dc88dc0fb 
  src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java 
4bbeff957050fb9d8ee81d9fc79520a6a0ac38a1 

Diff: https://reviews.apache.org/r/31901/diff/


Testing
---


Thanks,

Bill Farner

Review Request 31901: Export task status reason counters whenever they are present.

2015-03-10 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31901/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

I realized that the reason values apply to more than just TASK_LOST, so the 
previous code would hide reasons like when a task has exceeded its memory limit.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java 
68214f20dd7f46adec2d8f6d84e9840dc88dc0fb 
  src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java 
4bbeff957050fb9d8ee81d9fc79520a6a0ac38a1 

Diff: https://reviews.apache.org/r/31901/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---

(Updated March 10, 2015, 5:44 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-1176
https://issues.apache.org/jira/browse/AURORA-1176


Repository: aurora


Description
---

As indicated by some changes in tests - there were legitimate issues hiding 
behind this catch.  After this change, the client will allow unhandled 
exceptions to surface in their full glory.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
194629f61192c1d7d5e7064e9226adf26d03e890 
  src/main/python/apache/aurora/client/cli/__init__.py 
4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee 
  src/main/python/apache/aurora/client/cli/jobs.py 
286b2182d5fe25703882f0b367739ad03d6c8fe8 
  src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
b855c3c2d74125738d2106e18a9e9b0ebed6ac4b 
  src/test/python/apache/aurora/client/cli/test_create.py 
459d157155f74b6a3d140b85d3b7f0364367 
  src/test/python/apache/aurora/client/cli/test_kill.py 
7aad34a2fe5591937c5bca890751073439e3a1a6 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
1806769426a196793481f948892f5474df8dd665 
  src/test/python/apache/aurora/client/cli/util.py 
b65970a2717a1f36767c61e5e09c980b04895f01 

Diff: https://reviews.apache.org/r/31869/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

2015-03-10 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75901
---

Ship it!


Master (1b1931c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2015, 5:26 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31821/
> ---
> 
> (Updated March 10, 2015, 5:26 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1158
> https://issues.apache.org/jira/browse/AURORA-1158
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Extracting PreemptorSlotFinder to be reused for slot validation in later 
> stages. The changes are very minimal and mostly around metric handling and 
> test code.
> 
> Also added missing test coverage.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 701b9052696337766cb233c865cb9fbb4907071e 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> e093ca54521ffb9399bb97ce60f510331af70853 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictim.java
>  80c2023f46b63753dcec6a555dba626720a1925a 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
> bddb9647493b3e7a58c40d4b477a06161c1388a2 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> ae56d1e09322869eedd7a27586cd6f96edd64e0a 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorMetrics.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
>  85b3874a36ed07c684f26da172952c932cff707a 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 58733bdc4dd6de29ccead5cb0a267286e8dc0656 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 891cc098cca99e84ba014b7131106ceb0b429b5f 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImplTest.java
>  7207867813b0d096772dbc7f92fc1c76937e9831 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimTest.java
>  b0380b3fabb45be8ace55cfcf38ce15ef8040188 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  83680769611878886da04e1794b321aa1986e678 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java
>  020b67187a18bba64d9b562c3a6c0969fc85d469 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorSlotFinderTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31821/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

2015-03-10 Thread Maxim Khutornenko



> On March 7, 2015, 5:30 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java,
> >  line 326
> > 
> >
> > Not yours, but it seems odd that we would call a function and 
> > internally suppress its behavior based on configuration.  Seems like the 
> > caller should avoid the call if the behavior is not desired.  If you agree, 
> > please TODO.
> 
> Maxim Khutornenko wrote:
> Not sure I share your concern. This is a predicate intended to answer a 
> simple question, which it does quite well. I doubt the alternative would gain 
> us anything here.
> 
> Bill Farner wrote:
> Perhaps i highlighted a line that created confusion.  I'm suggesting that 
> this predicate does not belong in this class, as it is used to determine 
> whether to execute the 'body' of the preemptor.  I suggest this predicate 
> live in the caller.

Thanks for explaining, makes sense now. Added a TODO to refactor 
PreemptionSlotFinder interface to accept an idle pending task instead.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75637
---


On March 9, 2015, 11:34 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31821/
> ---
> 
> (Updated March 9, 2015, 11:34 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1158
> https://issues.apache.org/jira/browse/AURORA-1158
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Extracting PreemptorSlotFinder to be reused for slot validation in later 
> stages. The changes are very minimal and mostly around metric handling and 
> test code.
> 
> Also added missing test coverage.
> 
> 
> Diffs
> -
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 701b9052696337766cb233c865cb9fbb4907071e 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> e093ca54521ffb9399bb97ce60f510331af70853 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictim.java
>  80c2023f46b63753dcec6a555dba626720a1925a 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
> bddb9647493b3e7a58c40d4b477a06161c1388a2 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> ae56d1e09322869eedd7a27586cd6f96edd64e0a 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorMetrics.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
>  85b3874a36ed07c684f26da172952c932cff707a 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 58733bdc4dd6de29ccead5cb0a267286e8dc0656 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 891cc098cca99e84ba014b7131106ceb0b429b5f 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImplTest.java
>  7207867813b0d096772dbc7f92fc1c76937e9831 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimTest.java
>  b0380b3fabb45be8ace55cfcf38ce15ef8040188 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  83680769611878886da04e1794b321aa1986e678 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java
>  020b67187a18bba64d9b562c3a6c0969fc85d469 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorSlotFinderTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31821/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

38 matches

Mail list logo